[pve-devel] [PATCH storage 0/1] pass scfg to parse_volname

2024-02-23 Thread Roland Kammerer via pve-devel
--- Begin Message --- Dear PVE devs, I'm currently trying to implement "Disk Action" -> "Reassign Owner" for the LINSTOR plugin. This traditionally means implementing "rename_volume", which moves a disk from something like vm-100-disk-1 to vm-101-disk-1, which can then be parsed back by a regex to

[pve-devel] [PATCH storage 1/1] storage/plugins: pass scfg to parse_volname

2024-02-23 Thread Roland Kammerer via pve-devel
--- Begin Message --- This passes the well known $scfg to parse_volname and bumps the API versions accordingly. This allows plugins to access their configuration if necessary. Signed-off-by: Roland Kammerer --- ApiChangeLog | 7 +++ src/PVE/Storage.pm | 18 +- 2 files

Re: [pve-devel] [PATCH v2 00/22] add automated/unattended installation

2024-02-23 Thread Friedrich Weber
On 21/02/2024 12:07, Aaron Lauterer wrote: > This patch series adds the possibility to do an automated / unattended > installation of Proxmox VE. Gave this a quick spin installing some virtual PVE hosts with a simple static IP + ext4 setup. Generated an ISO from my `answer.toml` with: $ mkisofs -

Re: [pve-devel] fix #5254: add separate Sys.AccessNetwork privilege

2024-02-23 Thread Fabian Grünbichler
On February 19, 2024 6:14 pm, Thomas Lamprecht wrote: > Adds a new Sys.AccessNetwork privilege that can be used to guard API > endpoints that can do outgoing network requests with (some) user control > over said requests, like e.g. the "download URL to storage" one. > > ## Backstory: > > This ste

[pve-devel] [PATCH v2 container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-02-23 Thread Filip Schauer
Do not use the 'noacl' mount option when mounting a container disk with an ext4 file system. The option was removed from the kernel in commit 2d544ec923db The ext4 detection is based on $do_format in alloc_disk. Signed-off-by: Filip Schauer --- src/PVE/LXC.pm | 22 -- 1 file

Re: [pve-devel] [PATCH container] fix #4846: Avoid the outdated noacl mount option on ext4

2024-02-23 Thread Filip Schauer
A v2 of this patch is available: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061932.html On 16/02/2024 14:59, Fiona Ebner wrote: Am 01.09.23 um 11:05 schrieb Filip Schauer: Do not use the 'noacl' mount option when mounting a container disk with an ext4 file system. The option w

Re: [pve-devel] [PATCH v2 00/22] add automated/unattended installation

2024-02-23 Thread Aaron Lauterer
On 2/23/24 11:19, Friedrich Weber wrote: On 21/02/2024 12:07, Aaron Lauterer wrote: This patch series adds the possibility to do an automated / unattended installation of Proxmox VE. Gave this a quick spin installing some virtual PVE hosts with a simple static IP + ext4 setup. Generated an

[pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- came up in enterprise support, and I don't think there is a reason to not have it in the UI, while having it in the API www/manager6/storage/DirEdit.js | 12 1 file changed, 12 insertions(+) diff --git a/www/manager6/storage/DirEdit.js b/www/manage

Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Aaron Lauterer
Overall good idea :) On 2/23/24 12:45, Hannes Laimer wrote: Signed-off-by: Hannes Laimer --- came up in enterprise support, and I don't think there is a reason to not have it in the UI, while having it in the API www/manager6/storage/DirEdit.js | 12 1 file changed, 12 inserti

Re: [pve-devel] [PATCH qemu-server 4/5] Unify the default value for 'kvm'

2024-02-23 Thread Filip Schauer
This is missing a descriptive commit message. It must have accidentally gone lost during a rebase. Use this as the commit message: cpu config: Unify the default value for 'kvm' Make the default value for 'kvm' consistent, taking into account whether the VM will run on the same CPU architecture

Re: [pve-devel] [PATCH qemu-server 4/4] cpu config: Unify the default value for 'kvm'

2024-02-23 Thread Filip Schauer
On 22/02/2024 10:35, Fiona Ebner wrote: Yes, I also think the change is fine. But breaking ARM64 guests on a x86_64 host would not be fine. The point is CPU hotplug already doesn't work here, so the commit message should be adapted to mention that. I saw you completely removed the commit message

Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Hannes Laimer
On Fri Feb 23, 2024 at 12:51 PM CET, Aaron Lauterer wrote: > Overall good idea :) > > On 2/23/24 12:45, Hannes Laimer wrote: > > Signed-off-by: Hannes Laimer > > --- > > > > came up in enterprise support, and I don't think there is a reason to > > not have it in the UI, while having it in the API

[pve-devel] [PATCH v2 pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit

2024-02-23 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- came up in enterprise support, and I don't think there is a reason to not have it in the UI, while having it in the API v2: - use Aaron's improved help text www/manager6/storage/DirEdit.js | 12 1 file changed, 12 insertions(+) diff --git a/www/m

[pve-devel] [PATCH docs] installation: add serial console grub entry

2024-02-23 Thread Christoph Heiss
This was added with the 8.1 release ISO, so mention it in the documentation too. Signed-off-by: Christoph Heiss --- pve-installation.adoc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/pve-installation.adoc b/pve-installation.adoc index 6b44fc0..dff1a70 100644 --- a/pve-installation.

Re: [pve-devel] [PATCH manager] ui: node: system: avoid using 'Syslog'

2024-02-23 Thread Esi Y via pve-devel
--- Begin Message --- Just a small random addition to the rabbithole of the term syslog and that it has been source of confusion since long. There's yet another syslog, completely unrelated: # man 2 syslog: DESCRIPTION Note: Probably, you are looking for the C library function sy

[pve-devel] applied: [PATCH installer v2 0/7] gui: use gtk grids when possible

2024-02-23 Thread Thomas Lamprecht
Am 21/11/2023 um 16:10 schrieb Maximiliano Sandoval: > We replace the use of nested boxes with grids when possible to ensure correct > margins and alignment of widgets. > > At the end we also remove trailing spaces and colons from labels preceding an > input widget, e.g. we replace `DNS Server: `

Re: [pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

2024-02-23 Thread Thomas Lamprecht
Am 20/02/2024 um 17:26 schrieb Thomas Lamprecht: > btw. are there any dependency bumps we should consider? > I.e., between the already bumped rust parts and e.g. manager, or between > widget-toolkit and manager? Just to be sure, as I saw none of such > requirements listed in the cover letter of the

Re: [pve-devel] [PATCH v1 installer 08/18] auto-installer: add answer file definition

2024-02-23 Thread Stefan Lendl
Aaron Lauterer writes: > Signed-off-by: Aaron Lauterer > --- > proxmox-auto-installer/src/answer.rs | 147 +++ > proxmox-auto-installer/src/lib.rs| 1 + > 2 files changed, 148 insertions(+) > create mode 100644 proxmox-auto-installer/src/answer.rs > > diff --git a

[pve-devel] [PATCH v2 docs 2/6] network: update specification for bridge names

2024-02-23 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- pve-network.adoc | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/pve-network.adoc b/pve-network.adoc index d1ec64b..62edeb6 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -13,11 +13,12 @@ page contains the complete fo

[pve-devel] [PATCH v2 common/docs/widget-toolkit/manager/firewall 0/6] drop vmbr prefix for bridges

2024-02-23 Thread Stefan Hanreich
Original patch series by Jillian Morgan Changes from v1 -> v2: * limit name to 15 characters * properly validate bridge names in vlan/qinq zones * properly handle OVS bridges * handle new bridge names in firewall simulator common: Stefan Hanreich (1): interfaces: allow arbitrary bri

[pve-devel] [PATCH v2 manager 4/6] sdn: qinq: vlan: properly validate bridge name

2024-02-23 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- www/manager6/sdn/zones/QinQEdit.js | 3 +++ www/manager6/sdn/zones/VlanEdit.js | 3 +++ 2 files changed, 6 insertions(+) diff --git a/www/manager6/sdn/zones/QinQEdit.js b/www/manager6/sdn/zones/QinQEdit.js index 795ff9dfd..de177d7cb 100644 --- a/www/manager6/s

[pve-devel] [PATCH v2 common 1/6] interfaces: allow arbitrary bridge names in network config

2024-02-23 Thread Stefan Hanreich
Similar to other interface types, we can detect a bridge by the presense of it's bridge_ports attribute rather than solely relying on the "vmbr" ifname prefix heuristic. For OVS bridges we need to examine the OVS type instead. The check needs to be moved up since other prefixes could theoreticall

[pve-devel] [PATCH v2 widget-toolkit 3/6] network: allow bridges to have any valid interface name

2024-02-23 Thread Stefan Hanreich
Allow the web UI to accept bridge interfaces with any valid interface name, rather than being limited to the arbitrary "vmbr" prefix. Originally-by: Jillian Morgan Signed-off-by: Stefan Hanreich --- src/Toolkit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Toolk

[pve-devel] [PATCH v2 manager 5/6] sdn: vlan: fix indentation in vlan edit dialogue

2024-02-23 Thread Stefan Hanreich
Signed-off-by: Stefan Hanreich --- www/manager6/sdn/zones/VlanEdit.js | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/sdn/zones/VlanEdit.js b/www/manager6/sdn/zones/VlanEdit.js index 7f7ccca41..0bef5c8ec 100644 --- a/www/manager6/sdn/zones/VlanEdit.js +++

[pve-devel] [PATCH v2 firewall 6/6] simulator: use new bridge naming scheme

2024-02-23 Thread Stefan Hanreich
We now allow bridges without the vmbr prefix, so we need to allow them here in the simulator as well. Signed-off-by: Stefan Hanreich --- src/PVE/FirewallSimulator.pm| 20 ++-- src/PVE/Service/pve_firewall.pm | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff

[pve-devel] applied-esries: [PATCH installer v2 0/6] fix #4872: properly timeout `traceroute` command in country detection

2024-02-23 Thread Thomas Lamprecht
Am 13/02/2024 um 16:13 schrieb Christoph Heiss: > For all the details, see patch #6. > > TL;DR: SIGALRM does not interrupt line reading using <>, causing the > installer to hang on country detection. Fix it by using > Proxmox::Sys::Command::run_command(), which properly interacts with > SIGALRM. >

Re: [pve-devel] [PATCH installer v2 3/3] proxinstall: expose arc size setting for zfs bootdisks for all products

2024-02-23 Thread Maximiliano Sandoval
Some comments bellow. Christoph Heiss writes: > For non-PVE products, simply use the ZFS defaults (aka. 50%) and leave > unset, if the user never touches that setting. > > Signed-off-by: Christoph Heiss > --- > ... > ... > + > +# GTKs SpinButton does not support a placeholder value, unfor

Re: [pve-devel] [PATCH installer 2/5] common: fqdn: implement case-insensitive comparison as per RFC 952

2024-02-23 Thread Thomas Lamprecht
Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > +impl PartialEq for Fqdn { > +fn eq(&self, other: &Self) -> bool { > +// Case-insensitive comparison, as per RFC 952 "ASSUMPTIONS", > +// RFC 1035 sec. 2.3.3. "Character Case" and RFC 4343 as a whole > +let a = self > +

Re: [pve-devel] [PATCH v3 ceph master, ceph quincy-stable 8, pve-storage, pve-manager 00/13] Fix #4759: Configure Permissions for ceph-crash.service

2024-02-23 Thread Friedrich Weber
On 21/02/2024 14:15, Max Carrara wrote: > On 2/21/24 12:55, Friedrich Weber wrote: >> [...] >> >> - the `ceph-crash` service does not restart after installing the patched >> ceph-base package, so the reordering done by patches 02+04 does not take >> effect immediately: ceph-crash posts crash logs j

Re: [pve-devel] [PATCH installer 5/5] fix #5230: sys: net: properly escape FQDN regex

2024-02-23 Thread Thomas Lamprecht
Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > Due to interpolation, the \. sequence must be double-escaped. > Previously, this would result in a non-escaped dot, thus matching much > more liberally than it should. > OK, but... > diff --git a/proxmox-installer-common/src/utils.rs > b/proxmo

[pve-devel] applied-series: [PATCH installer 0/5] proxinstall, tui: improve hostname/FQDN validation

2024-02-23 Thread Thomas Lamprecht
Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > This series improves various aspects regarding FQDN handling and > validation across both the GUI and TUI installer. > > It (partially) addresses issue #5230 [0] in patch #5, by fixing the > regex through which we validate FQDNs in the GUI installe