[pve-devel] [PATCH docs v2] installation: reword `nomodeset` section a bit, add link to it

2024-02-26 Thread Christoph Heiss
The `nomodeset` section needs some massaging due to the text flow being broken a bit. While at it, link to it above at the 'Terminal UI' bootloader tip such that readers can find it more easily. Suggested-by: Alexander Zeidler Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * dropped supe

[pve-devel] [PATCH installer] sys: command: wait for process exit with sub-second granularity

2024-02-26 Thread Christoph Heiss
Using full seconds as a granularity for sleeping between waitpid()'s is way too much and unnecessarily slows down the installation a lot. Most processes take a few moments after closing their stdin/stdout to actually exit fully, which means that we would sleep a second in most cases. Lower it to 0

Re: [pve-devel] [PATCH v2 firewall 6/6] simulator: use new bridge naming scheme

2024-02-26 Thread Thomas Lamprecht
Am 26/02/2024 um 11:51 schrieb DERUMIER, Alexandre via pve-devel: > hi,I think you should limit to 8 characters like for sdn vnet,  > > as we need to space to  vlan tag for example (vmbrY.), or other sdn > construct. alternatively just show a hint in the UI if longer than 8 characters and, if

[pve-devel] [PATCH installer] tui: install_progress: write low-level non-JSON messages to separate file

2024-02-26 Thread Christoph Heiss
The low-level installer prints quite a few messages during the install to its stdout which are not JSON-formatted and thus parseable. Thus catch them early and write them to `/tmp/install-low-level.log`, to avoid polluting the log tty at /dev/tty2 with mostly useless parse errors. Signed-off-by:

[pve-devel] applied: [PATCH 1/2] run command: avoid using 1 as special value

2024-02-26 Thread Thomas Lamprecht
In Perl, the last expression of a block (e.g. of a method, eval) gets returned if there's no explicit return statement. Quite often that is truthy, i.e., 1. As that was chosen as the special value for the CMD_FINISHED flag it had quite a few false positives, causing weird effects and installation

[pve-devel] applied: [PATCH 2/2] run command: use explicit return undef in closures on call sites

2024-02-26 Thread Thomas Lamprecht
To avoid a misinterpretation of the auto-return value: > In the absence of an explicit return, a subroutine, eval, or do FILE > automatically returns the value of the last expression evaluated. -- https://perldoc.perl.org/functions/return Signed-off-by: Thomas Lamprecht --- Proxmox/Install.pm

[pve-devel] applied-series: [PATCH installer 0/6] switch low-level installer protocol to json

2024-02-26 Thread Thomas Lamprecht
Am 06/12/2023 um 12:34 schrieb Christoph Heiss: > This switches the stdio-protocol for the low-level installer from > simple, line-based messages to JSON. > > This solves a number of problems, most prominently that messages can now > contain multiline text (or for that matter, any kind of data), a

Re: [pve-devel] [PATCH docs] installation: reword `nomodeset` section a bit, add link to it

2024-02-26 Thread Christoph Heiss
Thanks for the review! On Mon, Feb 26, 2024 at 12:27:13PM +0100, Stefan Sterz wrote: > On Mon Feb 26, 2024 at 12:20 PM CET, Christoph Heiss wrote: [..] > > +[[nomodeset_kernel_param]] > > Adding the `nomodeset` Kernel Parameter > > ~ > > > > Problems may

Re: [pve-devel] [PATCH docs] installation: reword `nomodeset` section a bit, add link to it

2024-02-26 Thread Stefan Sterz
On Mon Feb 26, 2024 at 12:20 PM CET, Christoph Heiss wrote: > The `nomodeset` section needs some massaging due to the text flow being > broken a bit. While at it, link to it above at the 'Terminal UI' > bootloader tip such that readers can find it more easily. > > Suggested-by: Alexander Zeidler >

[pve-devel] [PATCH docs] installation: reword `nomodeset` section a bit, add link to it

2024-02-26 Thread Christoph Heiss
The `nomodeset` section needs some massaging due to the text flow being broken a bit. While at it, link to it above at the 'Terminal UI' bootloader tip such that readers can find it more easily. Suggested-by: Alexander Zeidler Signed-off-by: Christoph Heiss --- pve-installation.adoc | 11 ++

Re: [pve-devel] [PATCH v2 firewall 6/6] simulator: use new bridge naming scheme

2024-02-26 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- hi,I think you should limit to 8 characters like for sdn vnet,  as we need to space to  vlan tag for example (vmbrY.), or other sdn construct. Message initial De: Stefan Hanreich Répondre à: Proxmox VE development discussion À: pve-devel@lists.proxmo

Re: [pve-devel] [PATCH manager] ui: node: system: avoid using 'Syslog'

2024-02-26 Thread Esi Y via pve-devel
--- Begin Message --- Another random find today in man 8 rasdaemon [1], a post Syslogd-only era tool: > These trace events are logged in /sys/kernel/debug/tracing, reporting them > via syslog/journald. [1] https://manpages.debian.org/testing/rasdaemon/rasdaemon.8 On Fri, Feb 16, 2024 at 10:25:2

Re: [pve-devel] [PATCH v3 ceph master, ceph quincy-stable 8, pve-storage, pve-manager 00/13] Fix #4759: Configure Permissions for ceph-crash.service

2024-02-26 Thread Max Carrara
On 2/23/24 17:19, Friedrich Weber wrote: > On 21/02/2024 14:15, Max Carrara wrote: >> On 2/21/24 12:55, Friedrich Weber wrote: >>> [...] >>> >>> - the `ceph-crash` service does not restart after installing the patched >>> ceph-base package, so the reordering done by patches 02+04 does not take >>>

Re: [pve-devel] [PATCH installer 5/5] fix #5230: sys: net: properly escape FQDN regex

2024-02-26 Thread Christoph Heiss
On Fri, Feb 23, 2024 at 05:27:52PM +0100, Thomas Lamprecht wrote: > Am 15/02/2024 um 13:39 schrieb Christoph Heiss: > > Due to interpolation, the \. sequence must be double-escaped. > > Previously, this would result in a non-escaped dot, thus matching much > > more liberally than it should. > > > >