Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large number processing

2024-02-28 Thread Thomas Lamprecht
Hi, Am 28/02/2024 um 23:47 schrieb Roland: > any reason why this did not get a response ?  (i do not see rejection of > this  ,nor did it appear in > https://git.proxmox.com/?p=ksm-control-daemon.git;a=summary ) No reason, but even if this looks pretty straight forward, positive feedback would st

Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large number processing

2024-02-28 Thread Roland via pve-devel
--- Begin Message --- hi, any reason why this did not get a response ?  (i do not see rejection of this  ,nor did it appear in https://git.proxmox.com/?p=ksm-control-daemon.git;a=summary ) and, while we are at ksmtuned, i think it's is broken, especially when run on ZFS based installations, as i

[pve-devel] applied: [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section

2024-02-28 Thread Stoiko Ivanov
Thanks for the catch and fix! applied it! (nit: pmg-de...@list.proxmox.com is preferred for pmg-docs patches) On Wed, 28 Feb 2024 19:08:21 +0100 Christoph Heiss wrote: > That slipped through, asciidoc uses 4 not 3 dashes for that. > > Fixes: c8be3f0 ("installation: align zfs performance tip wi

Re: [pve-devel] [PATCH v2 access-control] fix #5136: ldap: Decode non-ASCII characters in attributes

2024-02-28 Thread Stoiko Ivanov
On Wed, 28 Feb 2024 16:00:48 +0100 Fiona Ebner wrote: > Am 28.02.24 um 15:41 schrieb Thomas Lamprecht: > > Am 09/01/2024 um 14:35 schrieb Filip Schauer: > >> UTF8 decode non-ASCII characters when syncing user attributes, since > >> those will be encoded later on. Without this fix the attributes

[pve-devel] [PATCH pmg-docs] installation: fix codeblock rendering in zfs performance tips section

2024-02-28 Thread Christoph Heiss
That slipped through, asciidoc uses 4 not 3 dashes for that. Fixes: c8be3f0 ("installation: align zfs performance tip with PVE documentation") Signed-off-by: Christoph Heiss --- pmg-installation.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pmg-installation.adoc b

Re: [pve-devel] [PATCH v2 access-control] fix #5136: ldap: Decode non-ASCII characters in attributes

2024-02-28 Thread Fiona Ebner
Am 28.02.24 um 15:41 schrieb Thomas Lamprecht: > Am 09/01/2024 um 14:35 schrieb Filip Schauer: >> UTF8 decode non-ASCII characters when syncing user attributes, since >> those will be encoded later on. Without this fix the attributes were >> encoded twice, resulting in cases such as 'ü' turning int

[pve-devel] applied-series: fix #5254: add separate Sys.AccessNetwork privilege

2024-02-28 Thread Thomas Lamprecht
Am 19/02/2024 um 18:14 schrieb Thomas Lamprecht: > Adds a new Sys.AccessNetwork privilege that can be used to guard API > endpoints that can do outgoing network requests with (some) user control > over said requests, like e.g. the "download URL to storage" one. > > ## Backstory: > > This stems fr

Re: [pve-devel] [PATCH v2 access-control] fix #5136: ldap: Decode non-ASCII characters in attributes

2024-02-28 Thread Thomas Lamprecht
Am 09/01/2024 um 14:35 schrieb Filip Schauer: > UTF8 decode non-ASCII characters when syncing user attributes, since > those will be encoded later on. Without this fix the attributes were > encoded twice, resulting in cases such as 'ü' turning into 'ü'. > > Signed-off-by: Filip Schauer > --- > C

[pve-devel] applied: [PATCH manager] appliance index: fix precedence in size check for log rotation

2024-02-28 Thread Thomas Lamprecht
Am 28/02/2024 um 13:07 schrieb Fiona Ebner: > In Perl, > takes precedence over ||, see perldoc perlop, so currently > the check will trigger with any size. > > Fixes: 805cae93 ("appliance index: rotate update log if bigger than 256 KiB") > Signed-off-by: Fiona Ebner > --- > PVE/APLInfo.pm | 2 +-

[pve-devel] [PATCH manager] appliance index: fix precedence in size check for log rotation

2024-02-28 Thread Fiona Ebner
In Perl, > takes precedence over ||, see perldoc perlop, so currently the check will trigger with any size. Fixes: 805cae93 ("appliance index: rotate update log if bigger than 256 KiB") Signed-off-by: Fiona Ebner --- PVE/APLInfo.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[pve-devel] [PATCH pve-cluster] docs: update http_proxy option description

2024-02-28 Thread Hannes Laimer
Signed-off-by: Hannes Laimer --- src/PVE/DataCenterConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm index c80872c..1f1291c 100644 --- a/src/PVE/DataCenterConfig.pm +++ b/src/PVE/DataCenterConfig.pm @@ -343,7 +3

[pve-devel] [PATCH proxmox-acme/pve-cluster 0/2] Add support to use a http proxy for acme dns challenges

2024-02-28 Thread Hannes Laimer
Use the http_proxy configured in the datacenter also for dns challenges, I don't think there is a use-case to configure different proxies for downloads and dns challenges. This is based on the reverted patch [1] of Stoiko a while ago. [1] https://git.proxmox.com/?p=proxmox-acme.git;a=commitdiff;

[pve-devel] [PATCH proxmox-acme 1/1] dns-challenge: use configured datacenter http_proxy for acme dns challenges

2024-02-28 Thread Hannes Laimer
the proxy is added to the plugin config so the `proxmox-acme` script exports it and it'll be used by curl when requests are made. Based on e1088f616ffc73a96ee3433f0ea07639ef7513e7 (reverted). Signed-off-by: Hannes Laimer --- src/PVE/ACME/DNSChallenge.pm | 4 1 file changed, 4 insertions(+)

[pve-devel] applied: [PATCH widget-toolkit v4 11/18] utils: add extendable, translatable notifiction event descriptions

2024-02-28 Thread Thomas Lamprecht
Am 28/02/2024 um 11:00 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > src/Utils.js | 31 +++ > 1 file changed, 31 insertions(+) > > applied, with adding to the commit message that this is oriented on the existing task description add/override mechanism,

[pve-devel] applied: [PATCH widget-toolkit v4 10/18] combogrid: add 'showClearTrigger' config

2024-02-28 Thread Thomas Lamprecht
Am 28/02/2024 um 11:00 schrieb Lukas Wagner: > This allows one configure the clear trigger to be shown, even if > 'allowBlank' is set false. This can be useful if one has a > non-editable combogrid where the value is set to something not > present in the store. Example: Match rule editing, one sele

[pve-devel] [PATCH widget-toolkit v4 13/18] notification: matcher: move match-field formulas to local viewModel

2024-02-28 Thread Lukas Wagner
This should make the code more cohesive and easier to follow. No functional changes. Signed-off-by: Lukas Wagner Tested-by: Maximiliano Sandoval --- src/window/NotificationMatcherEdit.js | 186 +- 1 file changed, 92 insertions(+), 94 deletions(-) diff --git a/src/windo

[pve-devel] [PATCH docs v4 18/18] notifications: match-field 'exact'-mode can now match multiple values

2024-02-28 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- notifications.adoc | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index 0eeed6a..912b048 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -221,11 +221,16 @@ configurable sch

[pve-devel] [PATCH docs v4 17/18] notifications: describe new notification metadata fields

2024-02-28 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- notifications.adoc | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index 57053c8..0eeed6a 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -289,19 +289,22 @@ Notification

[pve-devel] [PATCH docs v4 16/18] notification: clarify that 'hostname' does not include the domain

2024-02-28 Thread Lukas Wagner
This was a bit inconsistent between the different notification types: - APT/VZDump included the domain part - fence notifications did not A decision has been made to unify this by removing the domain part from APT/VZDump notifications. Signed-off-by: Lukas Wagner --- notifications.adoc | 2

[pve-devel] [PATCH widget-toolkit v4 10/18] combogrid: add 'showClearTrigger' config

2024-02-28 Thread Lukas Wagner
This allows one configure the clear trigger to be shown, even if 'allowBlank' is set false. This can be useful if one has a non-editable combogrid where the value is set to something not present in the store. Example: Match rule editing, one selects a backup job to be match. If the backup job is re

[pve-devel] [PATCH manager v4 07/18] api: replication: include 'hostname' field for notifications

2024-02-28 Thread Lukas Wagner
The field contains the hostname of the host (without any domain part) which sends the notification. This field can be used in match-field match rules. Signed-off-by: Lukas Wagner --- PVE/API2/Replication.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Replication.pm b/PVE/API2/

[pve-devel] [PATCH manager v4 05/18] api: replication: add 'replication-job' to notification metadata

2024-02-28 Thread Lukas Wagner
This allows users to create notification match rules for specific replication jobs, if they so desire. Signed-off-by: Lukas Wagner --- PVE/API2/Replication.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index 0dc944c9..703

[pve-devel] [PATCH manager v4 04/18] ui: dc: backup: allow to set custom job id in advanced settings

2024-02-28 Thread Lukas Wagner
This might be useful if somebody wants to match on the new 'backup-job' field in a notification match rule. Signed-off-by: Lukas Wagner --- www/manager6/Utils.js | 4 www/manager6/dc/Backup.js | 11 +++ 2 files changed, 15 insertions(+) diff --git a/www/manager6/Utils.js b/www

[pve-devel] [PATCH manager v4 06/18] vzdump: apt: notification: do not include domain in 'hostname' field

2024-02-28 Thread Lukas Wagner
- The man page warns about the usage of `hostname -f`, since a host may have multiple domains (or none at all) - The fallback PVE::INotify::nodename() already only returned the hostname without the domain part - Fencing notifications didn't include the domain part anyway This may result i

[pve-devel] [PATCH manager v4 03/18] ui: dc: backup: send 'id' property when starting a backup job manually

2024-02-28 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- www/manager6/dc/Backup.js | 1 - 1 file changed, 1 deletion(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 70903bdc..4beb84c0 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -569,7 +569,6 @@ Ext.define('PVE.dc

[pve-devel] [PATCH widget-toolkit v4 12/18] notification: matcher: match-field: show known fields/values

2024-02-28 Thread Lukas Wagner
These changes introduce combogrid pickers for the 'field' and 'value' form elements for 'match-field' match rules. The 'field' picker shows a list of all known metadata fields, while the 'value' picker shows a list of all known values, filtered depending on the current value of 'field'. The list o

[pve-devel] [PATCH widget-toolkit v4 15/18] notification: matcher: move match-severity fields to panel

2024-02-28 Thread Lukas Wagner
Also introduce a local viewModel that is linked to a parent viewModel, allowing us to move the formulas to the panel. This should make the code more cohesive and easier to follow. No functional changes. Signed-off-by: Lukas Wagner Tested-by: Maximiliano Sandoval --- src/window/NotificationMatc

[pve-devel] [PATCH widget-toolkit v4 14/18] notification: matcher: move match-calendar fields to panel

2024-02-28 Thread Lukas Wagner
Also introduce a local viewModel that is linked to a parent viewModel, allowing us to move the formulas to the panel. This should make the code more cohesive and easier to follow. No functional changes. Signed-off-by: Lukas Wagner Tested-by: Maximiliano Sandoval --- src/window/NotificationMatc

[pve-devel] [PATCH manager v4 08/18] api: notification: add API for getting known metadata fields/values

2024-02-28 Thread Lukas Wagner
This new API route returns known notification metadata fields and a list of known possible values. This will be used by the UI to provide suggestions when adding/modifying match rules. Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 152 ++ 1 file

[pve-devel] [PATCH widget-toolkit v4 11/18] utils: add extendable, translatable notifiction event descriptions

2024-02-28 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- src/Utils.js | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index 009e222..ff7c1a7 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -647,6 +647,37 @@ utilities: { Proxmox.Utils.unknownText

[pve-devel] [PATCH manager v4 09/18] ui: utils: add overrides for translatable notification fields/values

2024-02-28 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- www/manager6/Utils.js | 12 1 file changed, 12 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 4c8bf9d3..80c8f0f6 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -2042,6 +2042,18 @@ Ext.define('PVE.Util

[pve-devel] [PATCH manager v4 02/18] api: jobs: vzdump: pass job 'id' parameter

2024-02-28 Thread Lukas Wagner
This allows us to access us the backup job id in the send_notification function, where we can set it as metadata for the notification. Signed-off-by: Lukas Wagner --- PVE/API2/VZDump.pm | 8 PVE/Jobs/VZDump.pm | 4 +++- PVE/VZDump.pm | 6 +++--- 3 files changed, 14 insertions(+), 4

[pve-devel] [PATCH manager v4 01/18] api: notifications: add 'smtp' to target index

2024-02-28 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Cluster/Notifications.pm b/PVE/API2/Cluster/Notifications.pm index 7047f0b1..68fdda2a 100644 --- a/PVE/API2/Cluster/Notifications.pm +++ b/PVE/API2/Clu

[pve-devel] [PATCH manager/widget-toolkit/docs v4 00/18] notifications: notification metadata matching improvements

2024-02-28 Thread Lukas Wagner
This patch series attempts to improve the user experience when creating notification matchers. Some of the noteworthy changes: - Fixup inconsistent 'hostname' field. Some notification events sent the hostname including a domain, while other did not. This series unifies the behavior, now the

[pve-devel] applied: [PATCH proxmox-i18n] update Italian translations

2024-02-28 Thread Thomas Lamprecht
Am 27/02/2024 um 18:12 schrieb Christian Ebner: > Signed-off-by: Christian Ebner > --- > it.po | 1028 - > 1 file changed, 351 insertions(+), 677 deletions(-) > > applied, thanks! ___ pve-devel

Re: [pve-devel] [PATCH v2 firewall 6/6] simulator: use new bridge naming scheme

2024-02-28 Thread Thomas Lamprecht
Am 27/02/2024 um 13:35 schrieb Stefan Hanreich: > On Mon, Feb 26, 2024 at 04:36:59PM +0100, Thomas Lamprecht wrote: >> Am 26/02/2024 um 11:51 schrieb DERUMIER, Alexandre via pve-devel: >>> hi,I think you should limit to 8 characters like for sdn vnet,  >>> >>> as we need to space to  vlan tag for e

[pve-devel] applied: [PATCH proxmox-i18n] ja: Improve translation

2024-02-28 Thread Thomas Lamprecht
Am 24/01/2024 um 10:36 schrieb ribbon: > On Wed, Jan 24, 2024 at 04:13:47PM +0900, ribbon wrote: >> I have reviewed the whole Japanese translation. > > Attachment file deleted? Yes, the list never allowed attachements to avoid bloating up the mailing list ize and for security reasons. I adapted