Re: [pve-devel] [PATCH pve-network 1/2] gitignore: build artifacts from sbuild

ping, still applies! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-network 4/4] tests: run tests in sbuild

rebased and sent v2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-network 3/5] tests: mocking more functions to avoid system access

previously extracted functions are now mocked in the zone tests Signed-off-by: Stefan Lendl --- src/test/run_test_zones.pl | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/src/test/run_test_zones.pl b/src/test/run_test_zones.pl index

[pve-devel] [PATCH v2 pve-network 5/5] tests: run tests in sbuild

Signed-off-by: Stefan Lendl --- src/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile b/src/Makefile index c9dee4c..c4056b4 100644 --- a/src/Makefile +++ b/src/Makefile @@ -10,7 +10,7 @@ clean: .PHONY: test test: - [ -e /run/lock/sbuild ] ||

[pve-devel] [PATCH v2 pve-network 0/5] SDN tests in sbuild

Extract and mock functions that otherwise access system files which is not possible in a clean sbuild environment. Namely /etc/network/interfaces as well as /etc/frr/frr.config.local Disabling DNS tests Changes v1 -> v2: * Disabled DNS tests because they fail Stefan Lendl (5):

[pve-devel] [PATCH v2 pve-network 4/5] tests: disable failing DNS tests

Signed-off-by: Stefan Lendl --- src/test/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/Makefile b/src/test/Makefile index eb59d5f..db70c89 100644 --- a/src/test/Makefile +++ b/src/test/Makefile @@ -1,6 +1,6 @@ all: test -test: test_zones test_ipams

[pve-devel] [PATCH v2 pve-network 1/5] refactor(controllers): extract read_etc_network_interfaces

to allow mocking local fs access Signed-off-by: Stefan Lendl --- src/PVE/Network/SDN/Controllers.pm | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/PVE/Network/SDN/Controllers.pm b/src/PVE/Network/SDN/Controllers.pm index 167d3ea..fd7ad54 100644 ---

[pve-devel] [PATCH v2 pve-network 2/5] refactor(evpn): extract read_local_frr_config

to allow mocking local fs access Signed-off-by: Stefan Lendl --- src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm index

[pve-devel] applied: [PATCH widget-toolkit] certificates: don't display name if there is no name

Am 18/01/2024 um 15:14 schrieb Maximiliano Sandoval: > The default certificate does not have a name. > > Reported-by: Dietmar Maurer > Signed-off-by: Maximiliano Sandoval > --- > src/panel/Certificates.js | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git

Re: [pve-devel] [PATCH qemu-server] mediated devices: fix race condition in vm reboot

On 3/7/24 10:33, Dominik Csapak wrote: > when triggering a vm reboot from the host (via cli/api), the reboot code > is called under a guest lock, which creates a reboot request, shuts down > the vm and calls the regular cleanup code (which includes the mdev > cleanup). > > in parallel the

[pve-devel] applied: [PATCH proxmox] proxmox-acme: add api-types feature

applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH proxmox] proxmox-acme: derive PartialEq for API types

applied, thanks ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH proxmox] proxmox-acme: derive PartialEq for API types

Signed-off-by: Dietmar Maurer --- proxmox-acme/src/account.rs | 2 +- proxmox-acme/src/eab.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-acme/src/account.rs b/proxmox-acme/src/account.rs index e244c09..7f00143 100644 --- a/proxmox-acme/src/account.rs +++

[pve-devel] [PATCH proxmox] proxmox-acme: add api-types feature

Because AccountData is exposed via our API (currently as type Object). Signed-off-by: Dietmar Maurer --- proxmox-acme/Cargo.toml | 3 +++ proxmox-acme/src/account.rs | 7 +++ proxmox-acme/src/eab.rs | 5 + 3 files changed, 15 insertions(+) diff --git a/proxmox-acme/Cargo.toml

[pve-devel] [PATCH qemu-server] mediated devices: fix race condition in vm reboot

when triggering a vm reboot from the host (via cli/api), the reboot code is called under a guest lock, which creates a reboot request, shuts down the vm and calls the regular cleanup code (which includes the mdev cleanup). in parallel the qmeventd sees the vanished vm, and starts 'qm cleanup'

[pve-devel] [PATCH proxmox-ve] apt hook: disable on remove

and (re-)enable on install. adapted from apt-listbugs/apt-listchanges, which solve the issue of removing (instead of purging) the package keeping the conffile while removing the hook binary in the same fashion. Signed-off-by: Fabian Grünbichler --- tested with: - touch /please-remove-proxmox-ve