Implement a new "guest stop" confirmation message box which first
checks if there is an active shutdown task for the same guest that is
visible to the logged-in user. If there is at least one, the dialog
displays an additional default-on checkbox for overruling active
shutdown tasks. If the user
As reported in #4474 [0], a user may attempt to shutdown a VM/CT,
realize that it is unresponsive, and decide to stop it instead. If the
shutdown task has not timed out yet, the stop task will fail. The user
needs to manually abort the shutdown task before stopping the VM,
which is inconvenient.
This way, it can be used to retrieve the current list of tasks.
Signed-off-by: Friedrich Weber
---
Notes:
changes v2 -> v3:
* no changes
new in v2:
* moved fix for pve-cluster-tasks store into its own patch
www/manager6/dc/Tasks.js | 2 +-
1 file changed, 1 insertion(+),
Given a `(type, user, vmid)` tuple, the helper aborts all tasks of the
given `type` for guest `vmid` that `user` is allowed to abort:
- If `user` has `Sys.Modify` on the node, they can abort any task
- If `user` is an API token, it can abort any task it started itself
- If `user` is a user, they
The new `overrule-shutdown` parameter is boolean and defaults to 0. If
it is 1, all active `vzshutdown` tasks for the same CT (which are
visible to the user/token) are aborted before attempting to stop the
CT.
Passing `overrule-shutdown=1` is forbidden for HA resources.
Signed-off-by: Friedrich
The new `overrule-shutdown` parameter is boolean and defaults to 0. If
it is 1, all active `qmshutdown` tasks for the same VM (which are
visible to the user/token) are aborted before attempting to stop the
VM.
Passing `overrule-shutdown=1` is forbidden for HA resources.
Signed-off-by: Friedrich
Signed-off-by: Fabian Grünbichler
---
test-built 6.8, but I assume 6.5 works as well since the patch applies cleanly
there (build hasn't finished yet ;))
I also assume this will be picked up fairly fast by stable point releases, but
not sure how fast those will be folded atm on the Ubuntu side
--- Begin Message ---
for ipv4, we use the iface ipv4 router-id as router-id need to 32bit.
That's doesn't work for pure ipv6 underlay network.
since https://www.rfc-editor.org/rfc/rfc6286, we can use any 32bit id,
it's just need to be unique in the ASN.
Simply use the last 4 bytes of iface mac
--- Begin Message ---
for ipv4, we use the iface ipv4 router-id as router-id need to 32bit.
That's doesn't work for pure ipv6 underlay network.
since https://www.rfc-editor.org/rfc/rfc6286, we can use any 32bit id,
it's just need to be unique in the ASN.
Simply use the last 4 bytes of iface mac
>From man dpkg-buildpackage:
> -j, --jobs[=jobs|auto]
> Specifies the number of jobs allowed to be run simultaneously (since
> dpkg 1.14.7, long option since dpkg 1.18.8). The number of jobs
> matching the number of online processors if auto is specified (since
> dpkg 1.17.10), or unlimited
with T-B/R-B as provided, thanks!
On January 16, 2024 3:30 pm, Stefan Hanreich wrote:
> fall back to using v.ref as value when we do not have an alias or ipset
> since scope and name are not set for ips / cidrs
>
> Signed-off-by: Stefan Hanreich
> ---
>
> Changes from v1:
> * Added fix for an
thanks!
On April 12, 2024 1:08 pm, Fiona Ebner wrote:
> Changes in v2:
> * specify snapname when activating volume for hotplug
> * add missing activation call for fsck too
>
> Otherwise those operations would be problematic with certain storages
> like LVM after shutting down a container
Am 11.04.24 um 15:35 schrieb Fabian Grünbichler:
> On March 25, 2024 12:00 pm, Fiona Ebner wrote:
>> +PVE::Storage::activate_volumes($storage_cfg, [$volid]);
>
> shouldn't this atually pass $snapname as well? for some storages this
> does make quite the difference ;)
>
> there is also one
Otherwise, running pct fsck for e.g. an LVM volume after shutting down
a container would fail.
The container is not running, so the volume should be deactivated
afterwards.
Suggested-by: Fabian Grünbichler
Signed-off-by: Fiona Ebner
---
New in v2.
src/PVE/CLI/pct.pm | 9 +++--
1 file
Otherwise it was not possible to hotplug a volume that was previously
deactivated and requires activation, e.g. an LVM LV that was detached
after shutting down the container couldn't be hotplugged anymore
later.
Signed-off-by: Fiona Ebner
---
Changes in v2:
* specify snapname when
Signed-off-by: Fiona Ebner
---
New in v2.
src/PVE/CLI/pct.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 513bcba..13aa4c1 100755
--- a/src/PVE/CLI/pct.pm
+++ b/src/PVE/CLI/pct.pm
@@ -299,9 +299,13 @@
Changes in v2:
* specify snapname when activating volume for hotplug
* add missing activation call for fsck too
Otherwise those operations would be problematic with certain storages
like LVM after shutting down a container (which deactivates the
volumes).
Fiona Ebner (3):
mountpoint
Thanks for the review!
On Fri, Feb 23, 2024 at 04:37:16PM +0100, Maximiliano Sandoval wrote:
>
> Some comments bellow.
>
> Christoph Heiss writes:
>
> > For non-PVE products, simply use the ZFS defaults (aka. 50%) and leave
> > unset, if the user never touches that setting.
> >
> >
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 2 +-
src/test/zones/evpn/exitnode/expected_controller_config | 2 +-
.../evpn/exitnode_local_routing/expected_controller_config| 2 +-
with the re-worded commit message for qemu-server (although I dropped
the still redundant first line of the commit message ;))
On February 19, 2024 12:11 pm, Filip Schauer wrote:
> Allow moving unused/detached disks to another storage.
>
> qemu-server:
>
> Filip Schauer (1):
> fix #1905:
On March 19, 2024 4:08 pm, Hannes Duerr wrote:
> When a snapshot is created with RAM, qemu attempts to save not only the
> RAM content, but also the internal state of the PCI devices.
>
> However, as not all drivers support this, this can lead to the device
> drivers in the VM not being able to
Makes it consistent with the user selector and token selector.
Requested in the community forum:
https://forum.proxmox.com/threads/144978/
Signed-off-by: Fiona Ebner
---
www/manager6/form/GroupSelector.js | 4
1 file changed, 4 insertions(+)
diff --git
Am 11.04.24 um 20:07 schrieb Thomas Lamprecht:
> On 11/04/2024 11:29, Fiona Ebner wrote:
>> It's a property string, because that avoids having an implicit
>> "enabled" as part of a 'fleecing-storage' property. And there likely
>> will be more options in the future, e.g. threshold/limit for the
>>
ping!
would be nice to have this included, since currently editing FW rules is
a bit painful.
On 1/16/24 15:30, Stefan Hanreich wrote:
> fall back to using v.ref as value when we do not have an alias or ipset
> since scope and name are not set for ips / cidrs
>
> Signed-off-by: Stefan Hanreich
Reviewed-by: Fabian Grünbichler
Signed-off-by: Stefan Hanreich
---
pve-network.adoc | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/pve-network.adoc b/pve-network.adoc
index d1ec64b..ef586ec 100644
--- a/pve-network.adoc
+++ b/pve-network.adoc
@@ -13,11 +13,11
Original patch series by Jillian Morgan
I've refrained from adding arbitrary bond names in this patch series, since
that would require a bigger amount of changes in the firewall simulator. I'll
look into adding that in a future patch series.
Dependencies:
* pve-manager requires
Reviewed-by: Fabian Grünbichler
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/zones/VlanEdit.js | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/sdn/zones/VlanEdit.js
b/www/manager6/sdn/zones/VlanEdit.js
index 7f7ccca41..0bef5c8ec 100644
---
Reviewed-by: Fabian Grünbichler
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/zones/QinQEdit.js | 3 +++
www/manager6/sdn/zones/VlanEdit.js | 3 +++
2 files changed, 6 insertions(+)
diff --git a/www/manager6/sdn/zones/QinQEdit.js
b/www/manager6/sdn/zones/QinQEdit.js
index
Allow the web UI to accept bridge interfaces with any valid interface
name, rather than being limited to the arbitrary "vmbr" prefix.
Limiting to at most 10 characters, since SDN possibly adds a .
prefix for Vlans. Since the hard limit for network interface names is
15 characters, limiting it
We now allow bridges without the vmbr prefix, so we need to allow them
here in the simulator as well.
Reviewed-by: Fabian Grünbichler
Signed-off-by: Stefan Hanreich
---
src/PVE/FirewallSimulator.pm| 29 +++--
src/PVE/Service/pve_firewall.pm | 5 +++--
2 files
Similar to other interface types, we can detect a bridge by the
presence of its bridge_ports attribute, rather than solely relying on
the "vmbr" ifname prefix heuristic. For OVS bridges we need to examine
the OVS type instead.
The check needs to be moved up since other prefixes could
since cards now have a very rounded corner, one can see the non clipped
shape of the contained ExpansionTile.
To fix that, make the shape a RoundedRectangleBorder (which also removes
the added top/bottom border on expansion) and set the clipBehavior of
the surrounding card to antiAlias.
otherwise we have a grey icon but black template indicator, which looks
a bit out of place.
Signed-off-by: Dominik Csapak
---
lib/widgets/pve_guest_icon_widget.dart | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/widgets/pve_guest_icon_widget.dart
it's recommended to use fromSeed with what was the primary color
beforehand. With this, all colors are correctly deduced from it (e.g.
outline colors etc.).
But since we then set primaryContainer, we also have to set
onPrimaryContainer, otherwise it's deduced from the original primaryContainer
a series of smaller improvements, noticed by rechecking the app
after updating to new dart/flutter version.
not all of them have to be applied, most are rather independent.
e.g. use of the NavigationBar, and the icon of the warning task logs are
just my preferences.
Dominik Csapak (9):
replace
since material 3, the colors are different, and there is no 'muted'
color for the unselected labels anymore. instead use secondary for the
selected, and onPrimary for the unselected ones.
Signed-off-by: Dominik Csapak
---
lib/pages/main_layout_slim.dart | 5 -
1 file changed, 4
it has proper material 3 styling. For the animations to work correctly,
we have to put the bar outside of the part that we replace when we
navigate though
Signed-off-by: Dominik Csapak
---
lib/pages/main_layout_slim.dart | 57 +
1 file changed, 30 insertions(+),
orange instead of red, so one can differentiate between error and
warnings better.
Signed-off-by: Dominik Csapak
---
.../pve_task_log_expansiontile_widget.dart| 15 +++
lib/widgets/pve_task_log_widget.dart | 5 -
2 files changed, 15 insertions(+), 5
by making it rounded (which appears as 'less dangerous').
Sadly the 'error' icon is not really usable for us, since it looks
almost the same as the 'info' icon (just 180 degree rotated).
We could use an 'outline' variant for either, but making the 'less
dangerous' one rounded feels alright.
only put that when we show the last task, which is only when we show the
'more tasks' button. Make the title otherwise just 'Task: '
Signed-off-by: Dominik Csapak
---
lib/widgets/pve_task_log_expansiontile_widget.dart | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
getting the apt update status requires Sys.Modify, but the user does not
necessarily has that. So instead of showing a pop up every 10 seconds,
simply ignore permission errors and only show other exceptions here.
Signed-off-by: Dominik Csapak
---
lib/bloc/pve_node_overview_bloc.dart | 11
On 4/11/24 16:21, Fabian Grünbichler wrote:
> Reviewed-by: Fabian Grünbichler
Thanks a lot!
> with some small nits for the docs patch, see comment there.
>
> the pve-common patch should probably get the bug number (545) in the
> subject as well.
I'll get a v4 ready ASAP, shouldn't take long..
Am 11.04.24 um 21:04 schrieb Thomas Lamprecht:
> On 12/09/2023 14:29, Fiona Ebner wrote:
>> The one with the backup flag was reported in the community forum:
>> https://forum.proxmox.com/threads/77254/
>>
>> Signed-off-by: Fiona Ebner
>> ---
>>
>> Changes in v2:
>> * Further improve message
43 matches
Mail list logo
