[pve-devel] applied: [PATCH qemu] more stable fixes for QEMU 9.0

2024-05-29 Thread Fiona Ebner
Most importantly the first one "Revert "monitor: use aio_co_reschedule_self()"", fixing a crash when doing hotplug+resize with a disk using io_uring. Other fixes (likely not too important) for TCG emulation of x86(_64) and ARM. Signed-off-by: Fiona Ebner ---

[pve-devel] [PATCH proxmox-firewall 1/1] service: flush firewall rules on force disable

2024-05-29 Thread Stefan Hanreich
When disabling the nftables firewall again, there is a race condition where the nftables ruleset never gets flushed and persists after disabling. In practice this almost never happens due to pve-firewall running every 10 seconds, and proxmox-firewall running every 5 seconds, so the

Re: [pve-devel] [PATCH many v3 0/8] notifications: move template strings to template files

2024-05-29 Thread Maximiliano Sandoval
ping. Its not possible to build proxmox-perl-rs at the moment without this patch series. Lukas Wagner writes: > These changes adapts the PVE notification stack to the changes introduced > in proxmox-notify 0.4. > > The notification system uses handlebar templates to render the subject > and

[pve-devel] [PATCH docs v11 4/5] add AMD SEV documentation

2024-05-29 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- qm.adoc | 103 1 file changed, 103 insertions(+) diff --git a/qm.adoc b/qm.adoc index 42c26db..2001bd4 100644 ---

[pve-devel] [PATCH qemu-server/docs/manager v11 0/5] AMD SEV

2024-05-29 Thread Markus Frank
Patch series to enable AMD Secure Encrypted Virtualization (SEV) https://www.amd.com/en/developer/sev.html changes v11: * removed systemd service and added run_command in qemu-server instead * moved SEV related code to CPUConfig * instead of the no-debug and no-key-sharing checkboxes there are no

[pve-devel] [PATCH qemu-server v11 2/5] config: add AMD SEV support

2024-05-29 Thread Markus Frank
This patch is for enabling AMD SEV (Secure Encrypted Virtualization) support in QEMU. VM-Config-Examples: amd_sev: type=std,no-debug=1,no-key-sharing=1 amd_sev: es,no-debug=1,kernel-hashes=1 kernel-hashes, reduced-phys-bits & cbitpos correspond to the variables with the same name in QEMU.

[pve-devel] [PATCH manager v11 5/5] ui: add AMD SEV configuration to Options

2024-05-29 Thread Markus Frank
By adding a new input panel with an AMD SEV technology selection combo box and checkboxes for the optional parameters in an advanced section, the user can configure the amd_sev option via the WebUI's Options tab. Signed-off-by: Markus Frank --- changes v11: * instead of the no-debug and

[pve-devel] [PATCH qemu-server v11 3/5] migration: add check_non_migratable_resources function

2024-05-29 Thread Markus Frank
The function checks for resources that cannot be migrated, snapshoted, or suspended. Signed-off-by: Markus Frank --- changes v11: * this patch is new to v11 PVE/API2/Qemu.pm | 5 - PVE/QemuMigrate.pm | 2 +- PVE/QemuServer.pm | 23 ++- 3 files changed, 27

[pve-devel] [PATCH qemu-server v11 1/5] add C program to get hardware capabilities from CPUID

2024-05-29 Thread Markus Frank
Implement a C program that extracts AMD SEV hardware information such as reduced-phys-bios and cbitpos from CPUID at boot time, looks if SEV, SEV-ES & SEV-SNP are enabled, and outputs these details as JSON to /run/qemu-server/host-hw-capabilities.json This programm can also be used to read and

Re: [pve-devel] [PATCH pve-guest-common 0/4] change-detection-mode for PBS

2024-05-29 Thread Christian Ebner
Superseded by version 2, which correctly prefixes the repositories the patches must be applied to: https://lists.proxmox.com/pipermail/pve-devel/2024-May/064024.html ___ pve-devel mailing list pve-devel@lists.proxmox.com

[pve-devel] [PATCH v2 pve-guest-common pve-container pve-manager 0/4] change-detection-mode for PBS

2024-05-29 Thread Christian Ebner
This patch series defines the vzdump configuration description as well as backup job configuration option in the WebUI to set the experimental `change-detection-mode` parameter to the proxmox-backup-client invocation for container backups having a Proxmox Backup Server storage target. This allows

[pve-devel] [PATCH v2 pve-container 2/4] vzdump: conditionally set PBS change detection mode option

2024-05-29 Thread Christian Ebner
Allows to switch the backup clients change detection mode based on the option set in the backup jobs configuration for backup jobs with Proxmox Backup Server target. Signed-off-by: Christian Ebner --- changes since version 1: - no changes src/PVE/VZDump/LXC.pm | 2 ++ 1 file changed, 2

[pve-devel] [PATCH v2 pve-manager 3/4] www: advanced backup: add pbs change detection mode selector

2024-05-29 Thread Christian Ebner
The proxmox backup client allows to switch the method used to encode data based on a change-detection-mode parameter. Expose this setting as experimental feature in the advanced panel for a backup job. Signed-off-by: Christian Ebner --- changes since version 1: - prefix subject with correct

[pve-devel] [PATCH v2 pve-manager 4/4] vzdump: add pbs-change-detection-mode to config template

2024-05-29 Thread Christian Ebner
Include the additional parameter to set the `change-detection-mode` for backup jobs with Proxmox Backup Server target as node wide configuration, including possible variants to be set. Signed-off-by: Christian Ebner --- changes since version 1: - prefix subject with correct repo

[pve-devel] [PATCH v2 pve-guest-common 1/4] vzdump: add PBS change detection mode configuration

2024-05-29 Thread Christian Ebner
Define the possible modes to be configured in a PBS file change detection mode to the vzdump confdesc. Signed-off-by: Christian Ebner --- changes since version 1: - no changes src/PVE/VZDump/Common.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/VZDump/Common.pm

[pve-devel] [PATCH guest-common] abstract config: snapshot create/rollback/remove: print more log statements

2024-05-29 Thread Dominik Csapak
this increases verbosity of the actions, especially when including the snapshot name, since that will appear in the task logs wereas before there was no mention of any action, just the storage specific output for creating/rollback/removal. Logs are printed at all main actions that can fail or

[pve-devel] [PATCH pve-container 3/4] www: advanced backup: add pbs change detection mode selector

2024-05-29 Thread Christian Ebner
The proxmox backup client allows to switch the method used to encode data based on a change-detection-mode parameter. Expose this setting as experimental feature in the advanced panel for a backup job. Signed-off-by: Christian Ebner --- www/manager6/panel/BackupAdvancedOptions.js | 20

[pve-devel] [PATCH pve-guest-common 1/4] vzdump: add PBS change detection mode configuration

2024-05-29 Thread Christian Ebner
Define the possible modes to be configured in a PBS file change detection mode to the vzdump confdesc. Signed-off-by: Christian Ebner --- src/PVE/VZDump/Common.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index

[pve-devel] [PATCH pve-container 2/4] vzdump: conditionally set PBS change detection mode option

2024-05-29 Thread Christian Ebner
Allows to switch the backup clients change detection mode based on the option set in the backup jobs configuration for backup jobs with Proxmox Backup Server target. Signed-off-by: Christian Ebner --- src/PVE/VZDump/LXC.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git

[pve-devel] [PATCH pve-container 4/4] vzdump: add pbs-change-detection-mode to config template

2024-05-29 Thread Christian Ebner
Include the additional parameter to set the `change-detection-mode` for backup jobs with Proxmox Backup Server target as node wide configuration, including possible variants to be set. Signed-off-by: Christian Ebner --- configs/vzdump.conf | 1 + 1 file changed, 1 insertion(+) diff --git

[pve-devel] [PATCH pve-guest-common 0/4] change-detection-mode for PBS

2024-05-29 Thread Christian Ebner
This patch series defines the vzdump configuration description as well as backup job configuration option in the WebUI to set the experimental `change-detection-mode` parameter to the proxmox-backup-client invocation for container backups having a Proxmox Backup Server storage target. This allows

Re: [pve-devel] [PATCH qemu-server] api: snapshot create/delete/rollback: print log line that mentions snapshot name

2024-05-29 Thread Fabian Grünbichler
On May 29, 2024 1:07 pm, Dominik Csapak wrote: > On 5/29/24 12:09, Fabian Grünbichler wrote: >> On May 29, 2024 11:20 am, Dominik Csapak wrote: >>> so that an admin can see from the task logs which snapshot was rolled >>> back/created/removed without the need to look into the journal (to which >>>

Re: [pve-devel] [PATCH qemu-server] api: snapshot create/delete/rollback: print log line that mentions snapshot name

2024-05-29 Thread Dominik Csapak
On 5/29/24 12:09, Fabian Grünbichler wrote: On May 29, 2024 11:20 am, Dominik Csapak wrote: so that an admin can see from the task logs which snapshot was rolled back/created/removed without the need to look into the journal (to which the admin might not have access to). good idea in general,

Re: [pve-devel] [PATCH qemu-server] api: snapshot create/delete/rollback: print log line that mentions snapshot name

2024-05-29 Thread Fabian Grünbichler
On May 29, 2024 11:20 am, Dominik Csapak wrote: > so that an admin can see from the task logs which snapshot was rolled > back/created/removed without the need to look into the journal (to which > the admin might not have access to). good idea in general, but wouldn't it be better to log it

[pve-devel] [PATCH qemu-server] api: snapshot create/delete/rollback: print log line that mentions snapshot name

2024-05-29 Thread Dominik Csapak
so that an admin can see from the task logs which snapshot was rolled back/created/removed without the need to look into the journal (to which the admin might not have access to). Signed-off-by: Dominik Csapak --- noticed while trying to find out, to which snapshot a vm was rolled back to on a