[pve-devel] [PATCH qemu-server 1/2] schema: vga: mention that type 'cirrus' should not be used

2024-05-31 Thread Fiona Ebner
[0]: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ [1]: https://lore.kernel.org/qemu-devel/usd6hvncbao47zklcb5qlpvjcuk7odryu57f45imxienyltlec@2ujm6g2gr2od/ Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[pve-devel] [PATCH qemu-server 2/2] cfg2cmd: split out helper for vga properties

2024-05-31 Thread Fiona Ebner
To remove some line bloat from the config_to_command() function. Signed-off-by: Fiona Ebner --- Original motivation was to prepare for a deprectation warning for display type 'cirrus'. However, it might not get deprecated after all: https://lore.kernel.org/qemu-devel/usd6hvncbao47zklcb5qlpvjcuk7

Re: [pve-devel] [PATCH guest-common/qemu-server/manager/docs v3 0/4] implement experimental vgpu live migration

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > > qemu-server: > > Dominik Csapak (10): > usb: mapping: move implementation of find_on_current_node here > pci: mapping: move implementation of find_on_current_node here > pci: mapping: check mdev config against hardware > stop cleanup: remov

Re: [pve-devel] [PATCH qemu-server v3 10/10] api: include not mapped resources for running vms in migrate preconditions

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > so that we can show a proper warning in the migrate dialog and check it > in the bulk migrate precondition check > > the unavailable_storages and should be the same as before, but > we now always return allowed_nodes too. > > also add a note that we

Re: [pve-devel] [PATCH qemu-server v3 09/10] api: enable live migration for marked mapped pci devices

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > They have to be marked as 'live-migration-capable' in the mapping > config, and the driver and qemu must support it. > > For the gui checks, we now return the whole object of the mapped > resources, which includes info like the name and if it's marked

Re: [pve-devel] [PATCH qemu-server v3 08/10] check_local_resources: add more info per mapped device and return as hash

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > such as the mapping name and if it's marked for live-migration (pci only) > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 2 +- > PVE/QemuMigrate.pm | 7 --- > PVE/QemuServer.pm | 17 ++--- > 3 files changed, 15 ins

Re: [pve-devel] [PATCH qemu-server v3 07/10] pci: set 'enable-migration' to on for live-migration marked mapped devices

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > the default is 'auto', but for those which are marked as capable for > live migration, we want to explicitly enable that, so we get an early > error on start if the driver does not support that. > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServ

Re: [pve-devel] [PATCH qemu-server v3 06/10] migrate: call vm_stop_cleanup after stopping in phase3_cleanup

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > we currently only call deactivate_volumes, but we actually want to call > the whole vm_stop_cleanup, since that is not invoked by the vm_stop > above (we cannot parse the config anymore) and might do other cleanups > we also want to do (like mdev clean

Re: [pve-devel] [PATCH qemu-server v3 04/10] stop cleanup: remove unnecessary tpmstate cleanup

2024-05-31 Thread Fiona Ebner
Adding the rationale for third-party plugins from last time: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062354.html Am 19.04.24 um 14:45 schrieb Dominik Csapak: > tpmstate0 is already included in `get_vm_volumes`, and our only storage > plugin that has unmap_volume implemented is the

Re: [pve-devel] [PATCH guest-common v3 4/4] mapping: remove find_on_current_node

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > they only have one user each (where we can inline the implementation). > It's easy enough to recreate should we need to. > > Signed-off-by: Dominik Csapak > --- > src/PVE/Mapping/PCI.pm | 10 -- > src/PVE/Mapping/USB.pm | 9 - > 2 f

Re: [pve-devel] [PATCH guest-common v3 2/4] mapping: pci: check the mdev configuration on the device too

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > but that lives int he 'global' part of the mapping config, not in a > specific mapping. To check that, add it to the $configured_props from > there. > > this requires all call sites to be adapted otherwise the check will > always fail for devices that

Re: [pve-devel] [PATCH guest-common v3 1/4] mapping: pci: rework properties check

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > rename '$cfg' to '$mapping', 'correct' to 'expected' > reword the error messages > also check keys from the configured props not only the expected ones > Would've been nicer as multiple commits. > previously we only checked the keys from the 'correc

Re: [pve-devel] [PATCH guest-common/qemu-server/manager/docs v3 0/4] implement experimental vgpu live migration

2024-05-31 Thread Fiona Ebner
Am 19.04.24 um 14:45 schrieb Dominik Csapak: > and some useful cleanups > > Resending even there was not much feedback, because i worked in some > minor fixes/changes in the meantime. > > A user tested the previous patch series and only found one issue with > the ui, see the comments on bug #5175

[pve-devel] [PATCH docs] backup: warn that tar does not honor exclusion pattern with a trailing slash

2024-05-31 Thread Fiona Ebner
As reported in the community forum [0], for tar, an exclusion pattern with a trailing slash will not match a folder with that name. For rsync and proxmox-backup-client however, such a pattern will exclude a directory with that name, but not a file. rsync is used for 'suspend' mode backup and tar i

[pve-devel] [PATCH container] backup: warn that tar does not honor exclusion pattern with a trailing slash

2024-05-31 Thread Fiona Ebner
As reported in the community forum [0], for tar, an exclusion pattern with a trailing slash will not match a folder with that name. For rsync and proxmox-backup-client however, such a pattern will exclude a directory with that name, but not a file. rsync is used for 'suspend' mode backup and tar i

Re: [pve-devel] [RFC PATCH manager] api/ui: include the node ha status in resources call and show as icon

2024-05-31 Thread Dominik Csapak
sorry there is a word missing in the subject: 'include the node ha status in resources call and show maintenance as icon' ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH guest-common/qemu-server/manager/docs v3 0/4] implement experimental vgpu live migration

2024-05-31 Thread Dominik Csapak
On 5/31/24 10:11, Eneko Lacunza wrote: Hi Dominik, Hi, El 28/5/24 a las 9:25, Dominik Csapak escribió: ping? i know we cannot really test this atm but there are a few users/customers that would like to use/test this since i marked it experimental i think it should be ok to include this i

Re: [pve-devel] [PATCH guest-common/qemu-server/manager/docs v3 0/4] implement experimental vgpu live migration

2024-05-31 Thread Eneko Lacunza via pve-devel
--- Begin Message --- Hi Dominik, El 28/5/24 a las 9:25, Dominik Csapak escribió: ping? i know we cannot really test this atm but there are a few users/customers that would like to use/test this since i marked it experimental i think it should be ok to include this if its ok code wise Wou

[pve-devel] [RFC PATCH manager] api/ui: include the node ha status in resources call and show as icon

2024-05-31 Thread Dominik Csapak
we already have the information parsed, so it's cheap, and we already have a mechanism in place that adds 'ha-' as a css class, so let's reuse that. I chose a yellow wrench, as wrenches are associated with 'maintenance', and because the state warrants more notice than 'online' but less than 'offli