On 2024-04-30 17:28, Max Carrara wrote:
> Make the regex more maintainable declaring it as a variable, breaking it
> up and commenting it by using the x flag.
>
> Also remove the part that parses our Debian revision (e.g. -pve1) from
> the version, as we do not actually include that in our Cep
On 2024-04-30 17:28, Max Carrara wrote:
> The logic of the `render_version` function is split up in order to
> handle how the version is displayed depending on the type of the row.
>
> If the parsed version is `undefined` or the row marks the beginning of
> the tree, an empty string is now ret
On 2024-04-30 17:28, Max Carrara wrote:
> This commit adds `PVE.Utils.parse_ceph_buildcommit`, which can be used
> to get the full hash "eccf199d..." in parentheses from a string like
> the following:
>
> ceph version 17.2.7 (eccf199d63457659c09677399928203b7903c888) quincy
> (stable)
>
>
On 2024-04-30 17:28, Max Carrara wrote:
> Ceph Build Commit in UI - Version 1
> ===
>
> This series adds Ceph's build commit to the UI and lets the user know if
> a service is running an outdated build and therefore ought to be
> restarted.
>
> The build commit
Am 05.06.24 um 11:21 schrieb Dominik Csapak:
> On 5/31/24 15:37, Fiona Ebner wrote:
>> Am 19.04.24 um 14:45 schrieb Dominik Csapak:
>>> @@ -4518,28 +4520,31 @@ __PACKAGE__->register_method({
>>> # if vm is not running, return target nodes where local
>>> storage/mapped devices are available
Am 05.06.24 um 10:51 schrieb Dominik Csapak:
> On 5/31/24 14:56, Fiona Ebner wrote:
>> Am 19.04.24 um 14:45 schrieb Dominik Csapak:
>>> the default is 'auto', but for those which are marked as capable for
>>> live migration, we want to explicitly enable that, so we get an early
>>> error on start i
On 5/31/24 15:37, Fiona Ebner wrote:
Am 19.04.24 um 14:45 schrieb Dominik Csapak:
so that we can show a proper warning in the migrate dialog and check it
in the bulk migrate precondition check
the unavailable_storages and should be the same as before, but
we now always return allowed_nodes too.
On Tue Apr 30, 2024 at 5:28 PM CEST, Max Carrara wrote:
> Ceph Build Commit in UI - Version 1
> ===
>
> This series adds Ceph's build commit to the UI and lets the user know if
> a service is running an outdated build and therefore ought to be
> restarted.
Bump ;)
On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote:
> Signed-off-by: Daniel Krambrock
> ---
> src/PVE/Cluster.pm | 1 +
> src/PVE/DataCenterConfig.pm | 9 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
> index f899dbe..059c
This is a fairly large patch. It could easily be split into a backend
and front-end portion. That would make it easier to review, in my
opinion.
On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote:
> VMID suggestion strategy is set in datacenter config
>
> Signed-off-by: Daniel Krambrock
On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote:
> This series of patches let the user choose a VMID suggestion strategy
> to avoid the recycled VMID problem.
Hi Daniel!
Thanks for your contribution! First of some top-level feedback:
- Please familiarize yourself with the Developer D
On 5/31/24 14:56, Fiona Ebner wrote:
Am 19.04.24 um 14:45 schrieb Dominik Csapak:
the default is 'auto', but for those which are marked as capable for
live migration, we want to explicitly enable that, so we get an early
error on start if the driver does not support that.
Signed-off-by: Dominik
On 5/31/24 14:56, Fiona Ebner wrote:
Am 19.04.24 um 14:45 schrieb Dominik Csapak:
we currently only call deactivate_volumes, but we actually want to call
the whole vm_stop_cleanup, since that is not invoked by the vm_stop
above (we cannot parse the config anymore) and might do other cleanups
we
Some users might want to switch to using only the newer .sources files
already, which Debian is going to switch to in the long run.
Signed-off-by: Fiona Ebner
---
proxmox-apt/src/repositories/mod.rs | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/proxmo
On 5/31/24 13:14, Fiona Ebner wrote:
Am 19.04.24 um 14:45 schrieb Dominik Csapak:
and some useful cleanups
Resending even there was not much feedback, because i worked in some
minor fixes/changes in the meantime.
A user tested the previous patch series and only found one issue with
the ui, see
15 matches
Mail list logo