Re: [pve-devel] [PATCH v1 pve-manager 2/8] ceph: tools: update Ceph version regex

2024-06-05 Thread Lukas Wagner
On 2024-04-30 17:28, Max Carrara wrote: > Make the regex more maintainable declaring it as a variable, breaking it > up and commenting it by using the x flag. > > Also remove the part that parses our Debian revision (e.g. -pve1) from > the version, as we do not actually include that in our Cep

Re: [pve-devel] [PATCH v1 pve-manager 8/8] ui: ceph: osd: rework rendering of version field & show build commit

2024-06-05 Thread Lukas Wagner
On 2024-04-30 17:28, Max Carrara wrote: > The logic of the `render_version` function is split up in order to > handle how the version is displayed depending on the type of the row. > > If the parsed version is `undefined` or the row marks the beginning of > the tree, an empty string is now ret

Re: [pve-devel] [PATCH v1 pve-manager 6/8] ui: ceph: services: parse and display build commit

2024-06-05 Thread Lukas Wagner
On 2024-04-30 17:28, Max Carrara wrote: > This commit adds `PVE.Utils.parse_ceph_buildcommit`, which can be used > to get the full hash "eccf199d..." in parentheses from a string like > the following: > > ceph version 17.2.7 (eccf199d63457659c09677399928203b7903c888) quincy > (stable) > >

Re: [pve-devel] [PATCH v1 pve-manager 0/8] Ceph Build Commit in UI

2024-06-05 Thread Lukas Wagner
On 2024-04-30 17:28, Max Carrara wrote: > Ceph Build Commit in UI - Version 1 > === > > This series adds Ceph's build commit to the UI and lets the user know if > a service is running an outdated build and therefore ought to be > restarted. > > The build commit

Re: [pve-devel] [PATCH qemu-server v3 10/10] api: include not mapped resources for running vms in migrate preconditions

2024-06-05 Thread Fiona Ebner
Am 05.06.24 um 11:21 schrieb Dominik Csapak: > On 5/31/24 15:37, Fiona Ebner wrote: >> Am 19.04.24 um 14:45 schrieb Dominik Csapak: >>> @@ -4518,28 +4520,31 @@ __PACKAGE__->register_method({ >>>     # if vm is not running, return target nodes where local >>> storage/mapped devices are available

Re: [pve-devel] [PATCH qemu-server v3 07/10] pci: set 'enable-migration' to on for live-migration marked mapped devices

2024-06-05 Thread Fiona Ebner
Am 05.06.24 um 10:51 schrieb Dominik Csapak: > On 5/31/24 14:56, Fiona Ebner wrote: >> Am 19.04.24 um 14:45 schrieb Dominik Csapak: >>> the default is 'auto', but for those which are marked as capable for >>> live migration, we want to explicitly enable that, so we get an early >>> error on start i

Re: [pve-devel] [PATCH qemu-server v3 10/10] api: include not mapped resources for running vms in migrate preconditions

2024-06-05 Thread Dominik Csapak
On 5/31/24 15:37, Fiona Ebner wrote: Am 19.04.24 um 14:45 schrieb Dominik Csapak: so that we can show a proper warning in the migrate dialog and check it in the bulk migrate precondition check the unavailable_storages and should be the same as before, but we now always return allowed_nodes too.

Re: [pve-devel] [PATCH v1 pve-manager 0/8] Ceph Build Commit in UI

2024-06-05 Thread Max Carrara
On Tue Apr 30, 2024 at 5:28 PM CEST, Max Carrara wrote: > Ceph Build Commit in UI - Version 1 > === > > This series adds Ceph's build commit to the UI and lets the user know if > a service is running an outdated build and therefore ought to be > restarted. Bump ;)

Re: [pve-devel] [PATCH cluster] close #4369: make VMID suggestion strategy configurable

2024-06-05 Thread Shannon Sterz
On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote: > Signed-off-by: Daniel Krambrock > --- > src/PVE/Cluster.pm | 1 + > src/PVE/DataCenterConfig.pm | 9 + > 2 files changed, 10 insertions(+) > > diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm > index f899dbe..059c

Re: [pve-devel] [PATCH manager] close #4369: make VMID suggestion strategy configurable

2024-06-05 Thread Shannon Sterz
This is a fairly large patch. It could easily be split into a backend and front-end portion. That would make it easier to review, in my opinion. On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote: > VMID suggestion strategy is set in datacenter config > > Signed-off-by: Daniel Krambrock

Re: [pve-devel] (no subject)

2024-06-05 Thread Shannon Sterz
On Wed May 22, 2024 at 2:05 PM CEST, Daniel Krambrock wrote: > This series of patches let the user choose a VMID suggestion strategy > to avoid the recycled VMID problem. Hi Daniel! Thanks for your contribution! First of some top-level feedback: - Please familiarize yourself with the Developer D

Re: [pve-devel] [PATCH qemu-server v3 07/10] pci: set 'enable-migration' to on for live-migration marked mapped devices

2024-06-05 Thread Dominik Csapak
On 5/31/24 14:56, Fiona Ebner wrote: Am 19.04.24 um 14:45 schrieb Dominik Csapak: the default is 'auto', but for those which are marked as capable for live migration, we want to explicitly enable that, so we get an early error on start if the driver does not support that. Signed-off-by: Dominik

Re: [pve-devel] [PATCH qemu-server v3 06/10] migrate: call vm_stop_cleanup after stopping in phase3_cleanup

2024-06-05 Thread Dominik Csapak
On 5/31/24 14:56, Fiona Ebner wrote: Am 19.04.24 um 14:45 schrieb Dominik Csapak: we currently only call deactivate_volumes, but we actually want to call the whole vm_stop_cleanup, since that is not invoked by the vm_stop above (we cannot parse the config anymore) and might do other cleanups we

[pve-devel] [PATCH proxmox] fix #5513: apt: do not assume that sources.list file exists

2024-06-05 Thread Fiona Ebner
Some users might want to switch to using only the newer .sources files already, which Debian is going to switch to in the long run. Signed-off-by: Fiona Ebner --- proxmox-apt/src/repositories/mod.rs | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/proxmo

Re: [pve-devel] [PATCH guest-common/qemu-server/manager/docs v3 0/4] implement experimental vgpu live migration

2024-06-05 Thread Dominik Csapak
On 5/31/24 13:14, Fiona Ebner wrote: Am 19.04.24 um 14:45 schrieb Dominik Csapak: and some useful cleanups Resending even there was not much feedback, because i worked in some minor fixes/changes in the meantime. A user tested the previous patch series and only found one issue with the ui, see