[pve-devel] applied-series: [PATCH kernel 1/2] add fix for CIFS client memory leak

On 10/07/2024 13:37, Fiona Ebner wrote: > As reported in the community forum [0], there currently is a memory > leak in the CIFS client code. Reproduced by running a backup with CIFS > target storage: > >> while true; do vzdump 101 --storage cifs --prune-backups keep-last=1; echo 3 >> >

[pve-devel] [PATCH widget-toolkit v2 05/12] notification: add UI for adding/updating webhook targets

The widgets for editing the headers/secrets were adapted from the 'Tag Edit' dialog from PVE's datacenter options. Apart from that, the new dialog is rather standard. I've decided to put the http method and url in a single row, mostly to save space and also to make it analogous to how an actual

[pve-devel] [PATCH proxmox v2 02/12] notify: add api for webhook targets

All in all pretty similar to other endpoint APIs. One thing worth noting is how secrets are handled. We never ever return the values of previously stored secrets in get_endpoint(s) calls, but only a list of the names of all secrets. This is needed to build the UI, where we display all secrets that

[pve-devel] [PATCH proxmox-mail-forward v2 12/12] bump proxmox-notify dependency

Signed-off-by: Lukas Wagner --- Cargo.toml | 2 +- debian/control | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index f39d118..49ca079 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,4 +20,4 @@ nix = "0.26" syslog = "6.0" proxmox-sys

[pve-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints

Sending as an RFC because I don't want this merged yet; that being said, the feature should be mostly finished at this point, I'd appreciate any reviews and feedback. This series adds support for webhook notification targets to PVE and PBS. A webhook is a HTTP API route provided by a third-party

[pve-devel] [PATCH proxmox v2 01/12] notify: implement webhook targets

This target type allows users to perform HTTP requests to arbitrary third party (notification) services, for instance ntfy.sh/Discord/Slack. The configuration for these endpoints allows one to freely configure the URL, HTTP Method, headers and body. The URL, header values and body support

[pve-devel] [PATCH manager v2 07/12] api: add routes for webhook notification endpoints

These just call the API implementation via the perl-rs bindings. Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 263 +- 1 file changed, 262 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Cluster/Notifications.pm

[pve-devel] [PATCH proxmox-backup v2 09/12] api: notification: add API routes for webhook targets

Copied and adapted from the Gotify ones. Signed-off-by: Lukas Wagner --- src/api2/config/notifications/mod.rs | 2 + src/api2/config/notifications/webhook.rs | 175 +++ 2 files changed, 177 insertions(+) create mode 100644 src/api2/config/notifications/webhook.rs

[pve-devel] [PATCH proxmox-backup v2 10/12] ui: utils: enable webhook edit window

This allows users to add/edit new webhook targets. Signed-off-by: Lukas Wagner --- www/Utils.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/Utils.js b/www/Utils.js index 4853be36..b715972f 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -482,6 +482,11 @@ Ext.define('PBS.Utils',

[pve-devel] [PATCH manager v2 06/12] api: notifications: use get_targets impl from proxmox-notify

The get_targets API endpoint is now implemented in Rust. Signed-off-by: Lukas Wagner --- PVE/API2/Cluster/Notifications.pm | 34 +-- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/PVE/API2/Cluster/Notifications.pm b/PVE/API2/Cluster/Notifications.pm

[pve-devel] [PATCH proxmox-perl-rs v2 04/12] common: notify: add bindings for get_targets

This allows us to drop the impl of that function on the perl side. Signed-off-by: Lukas Wagner --- common/src/notify.rs | 9 + 1 file changed, 9 insertions(+) diff --git a/common/src/notify.rs b/common/src/notify.rs index fe192d5..0f8a35d 100644 --- a/common/src/notify.rs +++

[pve-devel] [PATCH proxmox-perl-rs v2 03/12] common: notify: add bindings for webhook API routes

Signed-off-by: Lukas Wagner --- common/src/notify.rs | 63 1 file changed, 63 insertions(+) diff --git a/common/src/notify.rs b/common/src/notify.rs index e1b006b..fe192d5 100644 --- a/common/src/notify.rs +++ b/common/src/notify.rs @@ -19,6 +19,9 @@

Re: [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool

tested this series more thoroughly and checked with an existing root pool all 3 install options: * TUI * GUI * auto Worked well in 3 cases to rename. One oddity seems to be if we cancel the rename in the TUI installer. it jumps to 100% and stays there and I then need to manually abort.

Re: [pve-devel] [PATCH installer v3 4/4] low-level: install: check for already-existing `rpool` on install

only one small nit inline On 2024-07-11 13:57, Christoph Heiss wrote: .. much in the same manner as the detection for LVM works. zpools can only be renamed by importing them with a new name, so unfortunately the import-export dance is needed. Signed-off-by: Christoph Heiss --- Changes v2

Re: [pve-devel] [PATCH installer 00/14] fix #5536: implement post-(auto-)installation notification mechanism

On Thu, Jul 11, 2024 at 06:49:28PM GMT, Stefan Hanreich wrote: > Did a quick smoke test of this series by creating an ISO with an answer > file baked in and checking the response via `nc -l`. Review is inline. Thanks for the review & testing! >From a quick glance all the comments make sense,

[pve-devel] partially-applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys

Applied the first patch. The 2nd one I skipped and is now obsolete, since I instead immediately removed the functions since I was doing a major bump to the sys crate anyway. ___ pve-devel mailing list pve-devel@lists.proxmox.com