On 24/07/2024 12:20, Fiona Ebner wrote:
In the UI, it think it's enough to expose a checkbox for read-only. Use
cases that deny reads seem a bit esoteric, so I'm not even sure we
should add deny_read in the back-end before somebody complains. But no
strong opinion there.
I removed the
Add a checkbox to the device passthrough dialogue for restricting
container write access to a passed through device.
Signed-off-by: Filip Schauer
---
www/manager6/lxc/DeviceEdit.js | 8
1 file changed, 8 insertions(+)
diff --git a/www/manager6/lxc/DeviceEdit.js
Add the deny_read and deny_write options for device passthrough, to
restrict container access to devices.
Signed-off-by: Filip Schauer
---
src/PVE/LXC.pm| 13 -
src/PVE/LXC/Config.pm | 12
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git
Add the deny_read and deny_write options for device passthrough, to
restrict container access to devices.
This allows for passing through a device in read-only mode without
giving the container full access it.
Up until now a container with a device passed through to it was granted
full access to
.. in order to include Ceph's build commit. Instead of e.g.
18.2.2 (reef)
the string will now contain:
18.2.2 (build: e9fe820e7) reef
This format is used in the OSD detail view; the build commit will
therefore also be shown there.
Signed-off-by: Max Carrara
Fixes:
.. so that the Ceph build commit as well as differing build commits
are shown properly.
Signed-off-by: Max Carrara
---
Changes v2 --> v3:
* increase the width even further to account for new changes
Changes v1 --> v2:
* NEW
www/manager6/ceph/OSD.js | 1 +
1 file changed, 1 insertion(+)
.. and show the build commit next to the OSD version.
The logic of the `render_version` function is split up in order to
handle how the version is displayed depending on the type of the row.
If the parsed version is `undefined` or the row marks the beginning of
the tree, an empty string is now
This is required in order to avoid making multiple API calls in the
following commit.
Signed-off-by: Max Carrara
Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5366
Tested-by: Lukas Wagner
Reviewed-by: Lukas Wagner
---
Changes v2 --> v3:
* reword commit title
* add 'Fixes' trailer
Ceph Build Commit in UI - Version 3
===
Notable Changes Since v2
* Rebase on master branch as v2 was partially applied (thanks!)
* Factor duplicate build commit rendering code into separate helper
as suggested [1] (thanks Thomas!)
The build commit is displayed and taken into account when comparing
monitor and manager versions in the client. Specifically, the
shortened build commit is now displayed in parentheses next to the
version for both monitors and managers like so:
18.2.2 (build: abcd1234)
Should the build commit
Am 11.06.24 um 14:17 schrieb Fabian Grünbichler:
> add the information that the parameter is special like other secret ones, and
> add the resulting config to the example to make it even more obvious.
>
> Signed-off-by: Fabian Grünbichler
> ---
> pve-storage-pbs.adoc | 9 +++--
> 1 file
Am 29.05.24 um 14:23 schrieb Markus Frank:
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 2a1d4d7..8f36cf8 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -4504,7 +4504,7 @@ __PACKAGE__->register_method({
> $res->{running} = PVE::QemuServer::check_running($vmid) ?
Am 29.05.24 um 14:23 schrieb Markus Frank:
> Implement a C program that extracts AMD SEV hardware information such
> as reduced-phys-bios and cbitpos from CPUID at boot time, looks if
> SEV, SEV-ES & SEV-SNP are enabled, and outputs these details as JSON
> to
Am 29.05.24 um 14:23 schrieb Markus Frank:
> Signed-off-by: Markus Frank
Reviewed-by: Fiona Ebner
with some (style) nits that can still be addressed:
> diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm
> index 33f7524..2542aa2 100644
> --- a/PVE/QemuServer/CPUConfig.pm
>
Am 09/07/2024 um 11:10 schrieb Wolfgang Bumiller:
> Systemd reapplies its known values on reload, so we cannot simply call
> into PVE::CGroup. Call systemd's SetUnitProperties method via dbus
> instead.
>
> The hotplug and startup code also calculated different values, as one
> operated within
On July 24, 2024 1:34 pm, Fiona Ebner wrote:
> Am 04.06.24 um 11:28 schrieb Max Carrara:
>>
>> Max Carrara (3):
>> section config: document package and its methods with POD
>> section config: update code style
>> section config: clean up parser logic
>>
>> src/PVE/SectionConfig.pm | 982
Am 04.06.24 um 11:28 schrieb Max Carrara:
>
> Max Carrara (3):
> section config: document package and its methods with POD
> section config: update code style
> section config: clean up parser logic
>
> src/PVE/SectionConfig.pm | 982 +++
> 1 file
I tested the patch series with the HTTP auto install variant and logged
the POST hook request.
Overall it works as advertised.
Patch 6/17 runtime env> runs into a problem if the system isn't using secure boot.
But I think we should fix that in Proxmox/Install/RunEnv.pm to store it
in a way
Remove ureq, because it does not support unix sockets.
Signed-off-by: Dietmar Maurer
---
Changes sinve v2:
split out the command line help text change into patch:
[PATCH pve-xtermjs] termproxy: fix the command line help text
Changes since v1:
- use extra --authsocket cli option
- use
The need to be the first argument.
Signed-off-by: Dietmar Maurer
---
termproxy/src/cli.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/termproxy/src/cli.rs b/termproxy/src/cli.rs
index cc44655..adfd830 100644
--- a/termproxy/src/cli.rs
+++ b/termproxy/src/cli.rs
@@ -4,7
Am 23/07/2024 um 16:24 schrieb Stefan Hanreich:
> When detaching and attaching the network device on update, the
> link_down setting is not considered and the network device always gets
> attached to the guest - even if link_down is set.
>
> Fixes: 3f14f206 ("nic online bridge/vlan change: link
Two few small things inline
On 2024-07-18 15:49, Christoph Heiss wrote:
This utility can be called with the low-level install config after a
successful installation to send a notification via a HTTP POST request,
if the user has configured an endpoint for that in the answer file.
Am 29.04.24 um 15:15 schrieb Filip Schauer:
> Add the deny_read and deny_write options for device passthrough, to
> restrict container access to devices.
>
In the UI, it think it's enough to expose a checkbox for read-only. Use
cases that deny reads seem a bit esoteric, so I'm not even sure we
Am 29.04.24 um 15:15 schrieb Filip Schauer:
> Add the deny_read and deny_write options for device passthrough, to
> restrict container access to devices.
>
> Signed-off-by: Filip Schauer
Reviewed-by: Fiona Ebner
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index
On 7/24/24 11:59, Fiona Ebner wrote:
Am 26.04.24 um 09:58 schrieb Dominik Csapak:
this is wrong and does nothing, see previous commit:
0c54d61 (remove 'amd_iommu=on' from the passthrough docs)
and
https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=amd_iommu
Am 26.04.24 um 09:58 schrieb Dominik Csapak:
> this is wrong and does nothing, see previous commit:
> 0c54d61 (remove 'amd_iommu=on' from the passthrough docs)
> and
> https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=amd_iommu
>
> Signed-off-by: Dominik Csapak
Am 26.04.24 um 09:17 schrieb Dominik Csapak:
> when editing the pci mapping, we set the nodename of the pciselector
> to the selected node. At the same time we disable and hide the node
> selector, but it still changes it's value to the 'first' node
> (alphabetically sorted) and that triggers a
Am 23/07/2024 um 16:57 schrieb Aaron Lauterer:
> There are quite a few preparation changes in other sub-crates
> (auto-installer, installer-common).
> I've only gotten through them for now and haven't looked at the actual
> post-hook crate stuff.
>
> Wouldn't it be nicer to split the
Am 23/07/2024 um 13:37 schrieb Christoph Heiss:
> On Tue, Jul 23, 2024 at 01:04:06PM GMT, Aaron Lauterer wrote:
>> Instead of hacking or own pretty print, we could maybe think about using
>> https://crates.io/crates/pretty_assertions
>
> As discussed offline, I think that this is definitely the
Remove ureq, because it does not support unix sockets.
Signed-off-by: Dietmar Maurer
---
Changes since v1:
- use extra --authsocket cli option
- use single format!() instead of multiple push_str()
- cleanup variable names
termproxy/Cargo.toml | 2 +-
termproxy/src/cli.rs | 26
30 matches
Mail list logo
