Re: [pve-devel] [PATCH pve-firewall 10/15] api: add vnet endpoints

2024-10-04 Thread Stefan Hanreich
On 9/26/24 08:37, Thomas Lamprecht wrote: > I'd prefer a _hook suffix for such a method for slightly added clarity. > > And FWIW, if all you do now is check privileges, and there's nothing you > already > know that's gonna get added here soon, you could just name it after what it > does > and a

Re: [pve-devel] Proposal: support for atomic snapshot of all VM disks at once

2024-10-04 Thread Dietmar Maurer
> I am the maintainer of StorPool’s external storage plugin for PVE[0] > which integrates our storage solution as a backend for VM disks. Our > software has the ability to create atomic (crash-consistent) snapshots > of a group of storage volumes. We already make sure that shaphots of a group

[pve-devel] applied: [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema

2024-10-04 Thread Thomas Lamprecht
On 04/10/2024 10:34, Fabian Grünbichler wrote: > using the definition already used in the task index API schema in the same > module. > > Signed-off-by: Fabian Grünbichler > --- > starttime has a disagreeing schema atm - 'number' vs 'integer'. since this is > the return schema it doesn't really m

[pve-devel] Proposal: support for atomic snapshot of all VM disks at once

2024-10-04 Thread Ivaylo Markov via pve-devel
--- Begin Message --- Greetings, I am the maintainer of StorPool’s external storage plugin for PVE[0] which integrates our storage solution as a backend for VM disks. Our software has the ability to create atomic (crash-consistent) snapshots of a group of storage volumes. I’d like to use this

[pve-devel] [PATCH access-control 3/3] api: enforce a minimum length of 8 on new passwords

2024-10-04 Thread Shannon Sterz
when creating new users or updating existing passwords this new minimum is enforced which aligns with NIST's latest recommendations [1]. [1]: https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver Signed-off-by: Shannon Sterz --- src/PVE/API2/AccessControl.pm | 2 +- src/PVE/API2/User.pm

[pve-devel] [PATCH widget-toolkit 2/3] password edit: add a minimum length parameter

2024-10-04 Thread Shannon Sterz
so products can independently specify the minimum length of new passwords Signed-off-by: Shannon Sterz --- src/window/PasswordEdit.js | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/window/PasswordEdit.js b/src/window/PasswordEdit.js index bc54b8d..e012a0d 100644 -

[pve-devel] [PATCH manager 1/3] ui: workspace/user view: change password minimum length to 8

2024-10-04 Thread Shannon Sterz
this only impacts new passwords Signed-off-by: Shannon Sterz --- www/manager6/Workspace.js | 1 + www/manager6/dc/UserEdit.js | 2 +- www/manager6/dc/UserView.js | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 52c

[pve-devel] [PATCH manager/widget-toolkit/access-control 0/3] enforce minimum of 8 characters on new passwords

2024-10-04 Thread Shannon Sterz
this series pushes the minimum of 5 characters up to at least 8 for pve. this puts our password policy in line with NIST's latest recommendation [1]. [1]: https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver pve-manager: Shannon Sterz (1): ui: workspace/user view: change password minimum

[pve-devel] applied: [PATCH http-server v2] fix #5391: proxy request: avoid HTTP 599 Too many redirections

2024-10-04 Thread Thomas Lamprecht
On 04/10/2024 11:43, Friedrich Weber wrote: > The API server proxies HTTP requests in two cases: > > - between cluster nodes (pveproxy->pveproxy) > - between daemons on one node for protected API endpoints > (pveproxy->pvedaemon) > > The API server uses AnyEvent::HTTP for proxying, with unfortu

Re: [pve-devel] [RFC http-server] fix #5391: proxy request: avoid HTTP 599 Too many redirections

2024-10-04 Thread Friedrich Weber
On 20/06/2024 09:45, Thomas Lamprecht wrote: > Nice work and write up! > > Acked-by: Thomas Lamprecht > > But yeah, seeing some benchmarking for before/after this patch would still be > great, that's also the main reason for me not applying this now already. sent a v2 with some benchmarking: h

[pve-devel] [PATCH http-server v2] fix #5391: proxy request: avoid HTTP 599 Too many redirections

2024-10-04 Thread Friedrich Weber
The API server proxies HTTP requests in two cases: - between cluster nodes (pveproxy->pveproxy) - between daemons on one node for protected API endpoints (pveproxy->pvedaemon) The API server uses AnyEvent::HTTP for proxying, with unfortunate settings for connection reuse (details below). With t

[pve-devel] [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema

2024-10-04 Thread Fabian Grünbichler
using the definition already used in the task index API schema in the same module. Signed-off-by: Fabian Grünbichler --- starttime has a disagreeing schema atm - 'number' vs 'integer'. since this is the return schema it doesn't really matter I guess, but might be worth it to settle on one or the