[pve-devel] [PATCH-SERIES qemu/common/storage/qemu-server/container/manager v6 00/37] backup provider API

2025-04-04 Thread Fiona Ebner
v5: https://lore.proxmox.com/pve-devel/20250321134852.103871-1-f.eb...@proxmox.com/ v4: https://lore.proxmox.com/pve-devel/20241114150754.374376-1-f.eb...@proxmox.com/ v3: https://lore.proxmox.com/pve-devel/20241107165146.125935-1-f.eb...@proxmox.com/ Changes in v6: * Factor out some helpers in

[pve-devel] [PATCH qemu-server v6 19/37] backup: fleecing: use exact size when allocating non-raw fleecing images

2025-04-04 Thread Fiona Ebner
A non-1KiB aligned source image could cause issues when used with qcow2 fleecing images, e.g. for an image with size 4.5 KiB: > Size mismatch for 'drive-tpmstate0-backup-fleecing' - sector count 10 != 9 Raw images are attached to QEMU with an explicit 'size' argument, so rounding up before allocat

[pve-devel] [PATCH proxmox v2 1/2] network-types: initial commit

2025-04-04 Thread Stefan Hanreich
This commit moves some IP address and MAC address types from proxmox-ve-config to proxmox, so they can be used re-used across our code base. The code in this commit is mostly the same as in proxmox-ve-config ('bc9253d8'), but I have made a few changes: * Added additional documentation to some of

[pve-devel] [PATCH cluster/ha-manager/manager 0/6] preparation for #6143: notification template cleanup

2025-04-04 Thread Lukas Wagner
With [#6143] on the horizon, notification templates, template variables and template helpers become part of our public API and as such we should provide some stability guarantees for them. As a result, we use this opportunity to do a 'final' cleanup. This series: - adds some common template vars

[pve-devel] [PATCH proxmox 2/2] notify: gotify: use constant from http crate for 'Authorization' header

2025-04-04 Thread Lukas Wagner
Signed-off-by: Lukas Wagner --- proxmox-notify/Cargo.toml | 2 +- proxmox-notify/src/endpoints/gotify.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-notify/Cargo.toml b/proxmox-notify/Cargo.toml index ddbaacd7..5a54c4a1 100644 --- a/proxmox-notify/C

[pve-devel] [PATCH qemu-server v15 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2025-04-04 Thread Markus Frank
Reviewed-by: Fiona Ebner Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu Tested-by: Daniel Kral Signed-off-by: Markus Frank --- no changes in v15 PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuSer

[pve-devel] applied: [PATCH v2 guest-common 1/1] storage tunnel: check just-imported image files

2025-04-04 Thread Thomas Lamprecht
Am 04.11.24 um 11:42 schrieb Fabian Grünbichler: > remote migration requires elevated privileges already and can thus only be > triggered by trusted sources, but an additional safeguard of checking the > image > for external references doesn't hurt. > > Signed-off-by: Fabian Grünbichler > --- >

Re: [pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config

2025-04-04 Thread Fabian Grünbichler
On March 4, 2025 12:57 pm, Markus Frank wrote: > Adds a config file for directories by using a 'map' property string for > each node mapping. > > Next to node & path, there is the optional announce-submounts parameter > which forces virtiofsd to report a different device number for each > submount

[pve-devel] [PATCH ha-manager 07/15] manager: read and update rules config

2025-04-04 Thread Daniel Kral
Read the rules configuration in each round and update the canonicalized rules configuration if there were any changes since the last round to reduce the amount of times of verifying the rule set. Signed-off-by: Daniel Kral --- As noted inline already, there's a missing check whether the service c

[pve-devel] applied-series: [PATCH-SERIES v2 qemu-server/storage/guest-common 0/7] slightly improve image format handling

2025-04-04 Thread Thomas Lamprecht
Am 05.03.25 um 11:49 schrieb Fiona Ebner: > v1: > https://lore.proxmox.com/pve-devel/20250207125514.42668-1-f.eb...@proxmox.com/ > > Changes in v2: > * different approach, use existing format > * introduce standard option > * add patches to drop mythological 'cow' format > > Allow using 'vmdk' f

[pve-devel] [PATCH qemu-server v6 18/37] backup: keep track of block-node size for fleecing

2025-04-04 Thread Fiona Ebner
For fleecing, the size needs to match exactly what QEMU sees. In particular, EFI disks might be attached with a 'size=' option, meaning that size can be different from the volume's size. Commit 36377acf ("backup: disk info: also keep track of size") introduced size tracking and it was used for flee

[pve-devel] [PATCH manager v5 32/32] backup: implement backup for external providers

2025-04-04 Thread Fiona Ebner
Hooks from the backup provider are called during start/end/abort for both job and backup. And it is necessary to adapt some log messages and special case some things like is already done for PBS, e.g. log file handling. Signed-off-by: Fiona Ebner --- PVE/VZDump.pm | 57

[pve-devel] [PATCH proxmox-ve-rs 05/17] frr: create proxmox-frr crate

2025-04-04 Thread Gabriel Goller
This crate holds FRR-types, so rust-types that closely resemble FRR-configuration items. These types can then simply be converted to strings (and the final FRR config) by serializing. This has minimal dependencies and it's only internal dependency is proxmox-network-types, which holds common types.

[pve-devel] [PATCH 3/4] elide serde lifetimes

2025-04-04 Thread Maximiliano Sandoval
Signed-off-by: Maximiliano Sandoval --- proxmox-ve-config/src/firewall/parse.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-ve-config/src/firewall/parse.rs b/proxmox-ve-config/src/firewall/parse.rs index 7bf00c0..8cf4757 100644 --- a/proxmox-ve-config/src/fi

Re: [pve-devel] [PATCH cluster/docs/manager/network/proxmox{, -ve-rs, -firewall, -perl-rs} 00/52] Add SDN Fabrics

2025-04-04 Thread Gabriel Goller
On 03.04.2025 10:30, Friedrich Weber wrote: On 28/03/2025 18:12, Gabriel Goller wrote: This series allows the user to add fabrics such as OpenFabric and OSPF over their clusters. Overview This series allows the user to create routed networks ('fabrics') across their clusters, which ca

Re: [pve-devel] [PATCH SERIES access-control/docs/manager/perl-rs/proxmox-openid v4] Make OIDC userinfo endpoint optional

2025-04-04 Thread Mira Limbeck
On 3/24/25 04:37, Thomas Skinner wrote: > Changes since v3: > - adjust option to "query userinfo endpoint" with default enabled > > access-control: > > Thomas Skinner (1): > fix #4234: add library functions for openid optional userinfo request > > src/PVE/API2/OpenId.pm | 6 +- > src/PVE/

[pve-devel] [PATCH qemu v5 01/32] PVE backup: add target ID in backup state

2025-04-04 Thread Fiona Ebner
In preparation for allowing multiple backup providers and potentially multiple targets for a given provider. Each backup target can then have its own dirty bitmap and there can be additional checks that the current backup state is actually associated to the expected target. Signed-off-by: Fiona Eb

[pve-devel] [PATCH qemu-server v7 26/37] backup: future-proof checks for QEMU feature support

2025-04-04 Thread Fiona Ebner
The features returned by the 'query-proxmox-support' QMP command are booleans, so just checking for definedness is not enough in principle. In practice, a feature is currently always true if defined. Still, fix the checks, should the need to disable support for a feature ever arise in the future an

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-04 Thread Fiona Ebner
Am 01.04.25 um 10:07 schrieb Fiona Ebner: > Note there is a v6 of the patch series now [0]. Also available as packages now: http://download.proxmox.com/temp/backup-provider-api-v6/ SHA256SUMS: > 08064b8f20997090e31854711ff6fa99154c8c7894c39da12333c9d3d71e42c6 > libpve-common-perl_8.2.9+backup

Re: [pve-devel] [PATCH storage v4 09/27] plugin: introduce new_backup_provider() method

2025-04-04 Thread Andreas Rogge
Am 01.04.25 um 20:21 schrieb Thomas Lamprecht: For more current discussion it might be best to check out the recently posted v7 of this series, if nothing bigger comes up it should be very close to what gets applied for an initial version – i.e., one that will be supported for a long time, which

Re: [pve-devel] [PATCH v4 qemu-server 11/11] qcow2: add external snapshot support

2025-04-04 Thread Fabian Grünbichler
> DERUMIER, Alexandre hat am 04.04.2025 > 13:31 CEST geschrieben: > Hi Fabian, > > >>the first one is the renaming of a blockdev while it is used, which > >>is currently done like this: > >>-- "link" snapshot path to make it available under old and new name > >>-- handle blockdev additions/reo

Re: [pve-devel] [PATCH storage v4 09/27] plugin: introduce new_backup_provider() method

2025-04-04 Thread Andreas Rogge
Am 02.04.25 um 10:30 schrieb Wolfgang Bumiller: On Tue, Apr 01, 2025 at 08:21:30PM +0200, Thomas Lamprecht wrote: This sounds pretty inefficient - especially when comparing with qmrestore's ability to just read read from stdin. The reading from stdin is quite limited, does not support sparse f

[pve-devel] [PATCH container v6 32/37] external restore: don't use 'one-file-system' tar flag when restoring from a directory

2025-04-04 Thread Fiona Ebner
This gives backup providers more freedom, e.g. mount backed-up mount point volumes individually. Suggested-by: Fabian Grünbichler Signed-off-by: Fiona Ebner --- src/PVE/LXC/Create.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Cre

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-04 Thread Prashant Patil via pve-devel
--- Begin Message --- Ok, will give plugins a try and see if we can achieve backup/restore management from our backup solution. 1. Can we just implement backup provider plugin and not storage plugin? We can build storage plugin in subsequent releases. 2. What are the steps to configure/d

[pve-devel] [PATCH qemu-server v5 17/32] backup: allow adding fleecing images also for EFI and TPM

2025-04-04 Thread Fiona Ebner
For the external backup API, it will be necessary to add a fleecing image even for small disks like EFI and TPM, because there is no other place the old data could be copied to when a new guest write comes in. Signed-off-by: Fiona Ebner --- PVE/VZDump/QemuServer.pm | 14 -- 1 file ch

[pve-devel] [PATCH manager v6 37/37] backup: implement backup for external providers

2025-04-04 Thread Fiona Ebner
Call job_{init,cleanup}() and backup_{init,cleanup}() methods so that backup providers can prepare and clean up for the whole backup job and for individual guest backups. It is necessary to adapt some log messages and special case some things like is already done for PBS, e.g. log file handling.

[pve-devel] [PATCH 2/4] stop using captures trick

2025-04-04 Thread Maximiliano Sandoval
See https://doc.rust-lang.org/nightly/edition-guide/rust-2024/rpit-lifetime-capture.html. Signed-off-by: Maximiliano Sandoval --- proxmox-ve-config/src/firewall/bridge.rs | 2 +- proxmox-ve-config/src/sdn/config.rs | 12 ++-- proxmox-ve-config/src/sdn/ipam.rs| 2 +- 3 fil

[pve-devel] [PATCH container v5 30/32] api: add early check against restoring privileged container from external source

2025-04-04 Thread Fiona Ebner
While restore_external_archive() already has a check, that happens after an existing container is destroyed. Signed-off-by: Fiona Ebner --- src/PVE/API2/LXC.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 7cb5122..6cd771c 100

Re: [pve-devel] [PATCH qemu-server 1/1] qemu: add offline migration from dead node

2025-04-04 Thread Dominik Csapak
On 4/1/25 12:46, Thomas Lamprecht wrote: Am 01.04.25 um 12:19 schrieb Dominik Csapak: while i also agree to all said here, I have one counter point to offer: In the case that such an operation is necessary (e.g. HA is not wanted/needed/possible for what ever reason), the user will fall back to

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-04 Thread Prashant Patil via pve-devel
--- Begin Message --- Basically, the backup/restore tasks will be managed through our backup solution. So, all we needed is VM config which can be fetched through PVE REST API and a API to get access to consistent disk image which can be then transferred to backup storage that we support. But it

Re: [pve-devel] [PATCH ifupdown2 1/1] Correctly handle IPv6 addresses in vxlan

2025-04-04 Thread Stefan Hanreich
On 3/31/25 06:45, Andrew wrote: > Just noticed I didn’t reply to this before - the patch set in ifupdown2 does > not actually address IPv6 local tunnel IPs at all. 3.9 itself doesn't, but 3.10 should contain the respective patches ___ pve-devel mailin

[pve-devel] [POC storage v5 14/32] Borg example plugin

2025-04-04 Thread Fiona Ebner
Archive names start with the guest type and ID and then the same timestamp format as PBS. Container archives have the following structure: guest.config firewall.config filesystem/ # containing the whole filesystem structure VM archives have the following structure guest.config firewall.config vol

Re: [pve-devel] [PATCH installer 6/6] fix #5811: auto: add option to retrieve FQDN from DHCP configuration

2025-04-04 Thread Stefan Hanreich
On 4/1/25 15:25, Christoph Heiss wrote: > The file directly from `git format-patch` looks fine, with no extra > newlines. Sent the patches using `git send-email` as usual, so not sure > where it went wrong. > I'll see if I can reproduce it locally for me and fix it up for a v2. I think this hap

[pve-devel] [PATCH proxmox-ve-rs 11/17] frr: add serializer for all FRR types

2025-04-04 Thread Gabriel Goller
This custom serializer will serialize all the FRR types into a string, which is the FRR config. Signed-off-by: Gabriel Goller --- proxmox-frr/src/lib.rs| 2 + proxmox-frr/src/serializer.rs | 192 ++ 2 files changed, 194 insertions(+) create mode 100644

Re: [pve-devel] [RFC pve-kernel] add disable_write_zeroes quirk for Crucial T700 and T705

2025-04-04 Thread Thomas Lamprecht
Am 19.03.25 um 21:33 schrieb Stoiko Ivanov: > The patch seems to indeed improve the performance of BLKZEROOUT and > other operations that use write_zeroes for both drives. > > Tested with LVM-thick LVs on both drives, as LVM seems to pass-through the > write_zeroes_max_bytes property (going by the

[pve-devel] [PATCH qemu-server v6 22/37] test: qemu img convert: add test cases for snapshots

2025-04-04 Thread Fiona Ebner
Signed-off-by: Fiona Ebner --- New in v6. test/run_qemu_img_convert_tests.pl | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/run_qemu_img_convert_tests.pl b/test/run_qemu_img_convert_tests.pl index 20ff387a..29c188d8 100755 --- a/test/run_qemu_img_convert_tests.pl

[pve-devel] [PATCH v8 qemu-server 11/11] backup: bitmap action to human: lie about TPM state

2025-04-04 Thread Wolfgang Bumiller
From: Fiona Ebner The TPM state drive is newly attached each time, so it is fully expected that a bitmap from last time would be missing. Signed-off-by: Fiona Ebner --- No changes to v7. PVE/VZDump/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/VZDump/QemuServer.pm b/

Re: [pve-devel] [PATCH proxmox-ve-rs 01/17] add proxmox-network-types crate

2025-04-04 Thread Stefan Hanreich
On 3/31/25 16:09, Thomas Lamprecht wrote: > Am 28.03.25 um 18:12 schrieb Gabriel Goller: >> This is a common crate that is gonna be reused between >> proxmox-ve-config, proxmox-frr and proxmox-perl-rs. It holds different >> networking primitives, such as Ipv4/Ipv6-Cidr, NET and e.g. >> HelloInter

Re: [pve-devel] [PATCH qemu-server] config: add system and service credentials support

2025-04-04 Thread Thomas Lamprecht
Am 03.04.25 um 09:49 schrieb Thomas Lamprecht: > Am 02.04.25 um 16:36 schrieb Maximiliano Sandoval: >> Allows to pass system and service credentials to a VM. See [1] for a >> description of credentials. This can be potentially used to provision a >> VM as per [2]. Values can be passed either as pla

Re: [pve-devel] [PATCH manager v2 1/6] api: ceph: add rbd namespace management endpoints

2025-04-04 Thread Friedrich Weber
Hi, I have some minor comments inline: On 23/12/2024 17:00, Aaron Lauterer wrote: > RBD supports namespaces. To make the management easier and possible via > the web UI, we need to add API endpoints to: > * list > * create > * delete > namespaces. > > We only allow creatng namespaces for pools th

[pve-devel] [PATCH qemu-server v3 7/8] api: qemu machine capabilities: add custom pveX versions too

2025-04-04 Thread Dominik Csapak
Add the pveX variants (where X > 0) to the list too, so one knows they exits. Also this allows them to be shown and chosen in the UI. Signed-off-by: Dominik Csapak Reviewed-by: Fiona Ebner --- changes from v2: * changed outer variable name to 'supported_machine_list' PVE/API2/Qemu/Machine.pm |

[pve-devel] [PATCH v8 container 1/7] add LXC::Namespaces module

2025-04-04 Thread Wolfgang Bumiller
From: Fiona Ebner The module includes a run_in_userns() helper to run a Perl subroutine in a user namespace. The first use case is running the container backup subroutine for external providers inside a user namespace. That allows them to see the filesystem to back-up from the containers perspec

Re: [pve-devel] [PATCH qemu-server/docs v2] disable S3/S4 power states by default

2025-04-04 Thread Dominik Csapak
ping, I think I addressed all of Fiona's comments ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container v6 33/37] create: factor out compression option helper

2025-04-04 Thread Fiona Ebner
In preparation to re-use it for checking potentially untrusted archives. Signed-off-by: Fiona Ebner --- src/PVE/LXC/Create.pm | 51 +-- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index d0cb

[pve-devel] [PATCH qemu-server v6 24/37] image convert: allow caller to specify the format of the source path

2025-04-04 Thread Fiona Ebner
In preparation for the restore API for backup providers that doesn't want detection based on the file extension but always requires raw. Signed-off-by: Fiona Ebner --- New in v6. PVE/QemuServer.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/

Re: [pve-devel] [PATCH manager v14 12/12] ui: add options to add virtio-fs to qemu config

2025-04-04 Thread Laurențiu Leahu-Vlăducu
Some comments inline Otherwise, please consider: Reviewed-by: Laurențiu Leahu-Vlăducu Tested-by: Laurențiu Leahu-Vlăducu On 04.03.25 12:58, Markus Frank wrote: Signed-off-by: Markus Frank --- v14: * disable expose-xattr when expose-acl is set * added missing writeback cache option www/

Re: [pve-devel] [!!ACHTUNG extern!!] - Re: [PATCH pve-network v3 1/3] ipam: nautobot: base plugin

2025-04-04 Thread Hannes Duerr
On 3/19/25 10:50, lou.lecriv...@wdz.de wrote: Re, Ok so. Answering on that. By default, the status "Active" already exists for fresh installs. However, since the users are free to define whatever status they want (and delete the pre-existing ones!), I thought it'd be best if we checked it did

Re: [pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs

2025-04-04 Thread Aaron Lauterer
On 2025-03-24 17:57, Friedrich Weber wrote: On 25/02/2025 16:47, Aaron Lauterer wrote: […] + + if (me.consoleType ==="kvm") { nit: missing space after the === thanks for spotting this + Proxmox.Utils.API2Request({ + url: `/api2/extjs/nodes/${me.nodename

Re: [pve-devel] [RFC PATCH 2/2] config: add systemd credentials support

2025-04-04 Thread Maximiliano Sandoval
Fabian Grünbichler writes: > On September 24, 2024 4:35 pm, Maximiliano Sandoval wrote: >> Allows to pass systemd credentials to a VM. See [1] for a description of >> systemd credentials. This can be potentially used to provision a VM as >> per [2]. Values can be passed either as plain text (whi

[pve-devel] [PATCH qemu-server v3 2/8] config to command: get rid of globalFlags

2025-04-04 Thread Dominik Csapak
We only have one place where we use it, so add the global flag inline, instead of collecting and doing it at the end. This makes it consistent with our other places where we need '-global' flags. Adapt the tests, since that global flag changes place, the resulting qemu hardware should be identical

[pve-devel] [PATCH storage v5 11/32] plugin api: bump api version and age

2025-04-04 Thread Fiona Ebner
Changes for version 11: * Allow declaring storage features via plugin data. * Introduce new_backup_provider() plugin method. * Allow declaring sensitive properties via plugin data. See the api changelog file for details. Signed-off-by: Fiona Ebner --- New in v5. ApiChangeLog | 32 +

[pve-devel] applied-series: [PATCH cluster/ha-manager/manager v2 0/6] preparation for #6143: notification template cleanup

2025-04-04 Thread Thomas Lamprecht
Am 28.03.25 um 11:19 schrieb Lukas Wagner: > With [#6143] on the horizon, notification templates, template variables > and template helpers become part of our public API and as such > we should provide some stability guarantees for them. > As a result, we use this opportunity to do a 'final' cleanu

[pve-devel] [PATCH qemu-server v3 5/8] machine: add S3/S4 power state properties

2025-04-04 Thread Dominik Csapak
So users can disable them (they're enabled by default in QEMU) Signed-off-by: Dominik Csapak Reviewed-by: Fiona Ebner --- changes from v2: * different name for function * removed comment intended for next patch * don't put function call inside 'if ()' PVE/QemuServer.pm | 2 ++ PVE/Qem

[pve-devel] applied: [PATCH pve-ha-manager v2 1/1] notifications: overhaul fence notification

2025-04-04 Thread Thomas Lamprecht
Am 28.03.25 um 11:19 schrieb Lukas Wagner: > - try to make template variable names more clear (in preparation > for #6143) > - add common tempate variables (fqdn, hostname, cluster-name) > - Instead of dumping the status-data variable as a JSON blob we > add template variables for the most usef

[pve-devel] [PATCH proxmox-firewall v2 1/1] firewall: nftables: migrate to proxmox-network-types

2025-04-04 Thread Stefan Hanreich
The fabrics patch series moved some generic network types into its own crate, so they can be reused across crates. Migrate proxmox-firewall to use the new proxmox-network-types crate instead of proxmox_ve_config. Signed-off-by: Stefan Hanreich --- Notes: This depends on the changes in the pr

Re: [pve-devel] About PVE Backup Integration Guide

2025-04-04 Thread Prashant Patil via pve-devel
--- Begin Message --- Thanks for answering all questions. When does Proxmox VE backend calls functions from the plugin? The backup/restore tasks/jobs are configured in our Backup Solution hence this question. Thanks Prashant -Original Message- From: Fiona Ebner Sent: 01 April 2

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v15 0/12] virtiofs

2025-04-04 Thread Markus Frank
On 2025-04-04 10:27, Lukas Wagner wrote: On 2025-04-03 12:34, Markus Frank wrote: Virtio-fs is a shared file system that enables sharing a directory between host and guest VMs. It takes advantage of the locality of virtual machines and the hypervisor to get a higher throughput than the 9p re

[pve-devel] applied-series: [PATCH manager/qemu-server v4 0/9] fix #5657: allow configuring RNG device as non-root user

2025-04-04 Thread Fabian Grünbichler
with a small follow-up in pve-manager to correctly sort the ACL paths in the selector thanks! Quoting Filip Schauer (2025-02-18 12:10:53) > Allow users with the VM.Config.HWType privilege to configure VirtIO RNG > devices on VMs with either /dev/urandom or /dev/random as the entropy > source. Use

[pve-devel] applied: [PATCH installer 2/6] auto: tests: parse-answer: allow per-test runtime env

2025-04-04 Thread Thomas Lamprecht
Am 27.03.25 um 16:17 schrieb Christoph Heiss: > This allows to create custom runtime environment files for tests to use > instead of the common one, to allow testing codepaths which depend on > certain runtime-gathered values. > > Signed-off-by: Christoph Heiss > --- > proxmox-auto-installer/tes

[pve-devel] applied: [PATCH manager v3 1/4] show optional consent-banner before login

2025-04-04 Thread Thomas Lamprecht
Am 10.12.24 um 17:11 schrieb Gabriel Goller: > Add ConsentBanner variable to html template and populate it from the > `datacenter.cfg` config file. Add Datacenter option to set the text and > trigger the popup on login. The max length of the input is 63*1024, > which is a bit less than the max body

Re: [pve-devel] [PATCH storage v7 12/37] plugin: introduce new_backup_provider() method

2025-04-04 Thread Max Carrara
On Wed Apr 2, 2025 at 12:44 PM CEST, Thomas Lamprecht wrote: > Am 02.04.25 um 12:01 schrieb Max Carrara: > >> +use base qw(PVE::BackupProvider::Plugin::Base); > > You can `use parent ...` here, as that's more lightweight. `base` is > > fine too though. > > > > See: https://perldoc.perl.org/par

Re: [pve-devel] [PATCH v1 pve-storage 7/8] pluginbase: document volume operations

2025-04-04 Thread Fabian Grünbichler
On March 26, 2025 3:20 pm, Max Carrara wrote: > Add docstrings for the following methods: > - list_volumes > - get_volume_attribute > - update_volume_attribute > - volume_size_info > - volume_resize > - volume_snapshot > - volume_snapshot_info > - volume_rollback_is_possible > - volume_snapshot_rol

Re: [pve-devel] [PATCH guest-common v15 2/12] add dir mapping section config

2025-04-04 Thread Daniel Kral
Two comments inline. On 4/3/25 12:34, Markus Frank wrote: Adds a config file for directories by using a 'map' property string for each node mapping. example config: ``` some-dir-id map node=node1,path=/path/to/share/ map node=node2,path=/different/location/ ``` Signed-off-by: M

Re: [pve-devel] [PATCH pve-network 17/17] frr: fix reloading frr configuration

2025-04-04 Thread Stefan Hanreich
On 4/2/25 12:37, Fabian Grünbichler wrote: > On March 28, 2025 6:13 pm, Gabriel Goller wrote: >> From: Stefan Hanreich >> >> Reloading the FRR configuration failed, because outfunc was defined as >> an empty hash, but Tools.pm requires it to be a CODE reference, so the >> following error has bee

Re: [pve-devel] [PATCH manager/docs 0/4] fix #2413: make target for ballooning configurable

2025-04-04 Thread Stoiko Ivanov
Thanks for the patch! comments inline: On Wed, 12 Mar 2025 16:15:02 +0100 Friedrich Weber wrote: > Automatic memory allocation (ballooning) is implemented in pvestatd, which > assigns memory to or reclaims memory from eligible VMs in order to reach a > certain target memory usage on the host. Th

Re: [pve-devel] [PATCH cluster/docs/manager/network/proxmox{, -ve-rs, -firewall, -perl-rs} 00/52] Add SDN Fabrics

2025-04-04 Thread Gabriel Goller
On 04.04.2025 12:55, Hannes Duerr wrote: On 3/28/25 18:12, Gabriel Goller wrote: This series allows the user to add fabrics such as OpenFabric and OSPF over their clusters. Overview This series allows the user to create routed networks ('fabrics') across their clusters, which can be u

[pve-devel] applied: [PATCH docs v3 3/4] add consent-banner description

2025-04-04 Thread Thomas Lamprecht
Am 10.12.24 um 17:11 schrieb Gabriel Goller: > Signed-off-by: Gabriel Goller > --- > pve-gui.adoc | 9 + > 1 file changed, 9 insertions(+) > > applied, thanks! prefixed the anchor-link with the per-chapter gui_ string, i.e. like all others are in this chapter ;-)

[pve-devel] applied: [PATCH docs] pveum: document correct path for ldap/realm credentials

2025-04-04 Thread Thomas Lamprecht
Am 28.03.25 um 13:07 schrieb Christoph Heiss: > /etc/pve/priv/realm has been the default path since commit > > 782b702db ("auth ldap/ad: make password a parameter for the api") > > That commit was part of pve-access-control 6.0-7. > > Replace /etc/pve/priv/ldap with /etc/pve/priv/realm, to avo

[pve-devel] [PATCH installer 0/3] fix #6285: always set up zfs modprobe configuration

2025-04-04 Thread Christoph Heiss
Fixes #6285 [0]. This also came up quite a few times already in the forum, most recently [1] (german). Since we do expose the option in the UI for all products nowadays (on ZFS-on-root installations only tho), just always write to /etc/modprobe.d/zfs.conf. [0] https://bugzilla.proxmox.com/show_b

[pve-devel] [PATCH pve-manager v2 11/11] ui: permissions: add ACL paths for fabrics

2025-04-04 Thread Gabriel Goller
From: Stefan Hanreich Signed-off-by: Stefan Hanreich Signed-off-by: Gabriel Goller --- www/manager6/data/PermPathStore.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js index 72da2e9da4a1..4654d51654c1 100644 --- a

[pve-devel] [PATCH pve-network v2 04/19] refactor: controller: move frr methods into helper

2025-04-04 Thread Gabriel Goller
From: Stefan Hanreich Up until now the EVPN controller contained all the helper methods as well as the configuration generation logic for FRR. Since we need to write FRR configuration with the fabrics as well, move the FRR helper files into its own FRR module, so they can be used by the EVPN plug

[pve-devel] applied: [PATCH cluster v16 1/12] add mapping/dir.cfg for resource mapping

2025-04-04 Thread Thomas Lamprecht
Am 04.04.25 um 18:08 schrieb Markus Frank: > Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side > (status.c). > This dir.cfg is used to map directory IDs to paths on selected hosts. > > Signed-off-by: Markus Frank > Reviewed-by: Fiona Ebner > Reviewed-by: Laurențiu Leahu-Vlăducu Revi

[pve-devel] applied: [PATCH access-control 4/5] api: password: use singular they pronoun

2025-04-04 Thread Thomas Lamprecht
Am 04.12.24 um 12:37 schrieb Fiona Ebner: > Signed-off-by: Fiona Ebner > --- > src/PVE/API2/AccessControl.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com ht

[pve-devel] applied: [PATCH access-control 3/5] api: clarify that password changes for PAM realm only apply to local node

2025-04-04 Thread Thomas Lamprecht
Am 04.12.24 um 12:37 schrieb Fiona Ebner: > Reported in the community forum: > https://forum.proxmox.com/threads/158518/ > > Signed-off-by: Fiona Ebner > --- > src/PVE/API2/AccessControl.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! ___

Re: [pve-devel] [PATCH pve-access-control v2 1/1] permissions: add ACL paths for SDN fabrics

2025-04-04 Thread Thomas Lamprecht
Am 04.04.25 um 18:28 schrieb Gabriel Goller: > From: Stefan Hanreich Missing a commit message, ACL is something that might profit from providing the thoughts behind this, even if it's probably quite clear for you. > > Signed-off-by: Stefan Hanreich > Signed-off-by: Gabriel Goller > --- > src

[pve-devel] applied: [PATCH cluster v3 2/4] add consent-text parameter to datacenter config file

2025-04-04 Thread Thomas Lamprecht
Am 10.12.24 um 17:11 schrieb Gabriel Goller: > The consent-text parameter is the base64-encoded content of the optional > consent-banner which can be displayed before login. The limit is 128kB, > which is less than the pmxcfs file limit, but still enough to also > encode images. > > Signed-off-by:

[pve-devel] applied: [PATCH pve-cluster v2 1/1] cluster: add sdn fabrics config files

2025-04-04 Thread Thomas Lamprecht
Am 04.04.25 um 18:28 schrieb Gabriel Goller: > Add the sdn fabrics config files. These are split into two, as we > currently support two fabric types: ospf and openfabric. They hold the > whole configuration for the respective protocols. They are read and > written by pve-network. > > Signed-off-b

[pve-devel] [PATCH container v9 22/29] backup: implement backup for external providers

2025-04-04 Thread Fiona Ebner
The filesystem structure is made available as a directory in a consistent manner (with details depending on the vzdump backup mode) just like for regular backup via tar. The backup_container() method of the backup provider is executed in a user namespace with the container's ID mapping applied. Th

Re: [pve-devel] [PATCH pve-cluster 1/1] cfs: add 'sdn/.lock' file

2025-04-04 Thread Thomas Lamprecht
Am 28.02.25 um 14:05 schrieb Stefan Hanreich: > This file stores a secret if the SDN configuration gets globally > locked. stumbled uppon this when checking for open patches for pve-cluster, sorry for the wait but does this need to be observed by pmxcfs though? Simple file handled by file_{get,se

Re: [pve-devel] [PATCH qemu-server v2 6/8] machine: bump pve machine version and reverse the s3/s4 defaults

2025-04-04 Thread Fiona Ebner
Am 07.03.25 um 15:44 schrieb Dominik Csapak: > so new guests (or guests with the 'latest' machine type) have that > setting automatically disabled. > > The previous default (enabling S3/S4), does not make too much sense in a > virtual environment, and sometimes makes problems, e.g. Windows default

[pve-devel] applied-series: [PATCH SERIES access-control/docs/manager/proxmox-openid v5] fix #4411: add support for openid groups

2025-04-04 Thread Fabian Grünbichler
with some small fix- and follow-ups, thanks! Quoting Thomas Skinner (2025-03-27 02:49:58) > Changes since v4: > - remove invalid section from docs > > access-control: > > Thomas Skinner (1): > fix #4411: openid: add logic for openid groups support > > src/PVE/API2/OpenId.pm | 83 ++

[pve-devel] [PATCH pve-manager v2 01/11] api: use new generalized frr and etc network config helper functions

2025-04-04 Thread Gabriel Goller
pve-network added new generalized frr generation and etc/network/interfaces generations methods. Starting with this series, not only the zones plugin edits the /etc/network/interfaces.d/sdn file, but the fabrics as well. The new fabrics are also implemented in rust, so they are not a normal Control

[pve-devel] applied:-series [PATCH access-control 0/3] fix undef warning on login for case-insensitive realms

2025-04-04 Thread Thomas Lamprecht
Am 25.03.25 um 11:38 schrieb Christoph Heiss: > This primarily fixes a Perl warning in the syslog about a undef > variable, with no impact on the actual functionality though. > > The two other patches #2 and #3 just clean up some small things I came > across while at it. > > Christoph Heiss (3):

Re: [pve-devel] [PATCH installer] gui: always set visible-child-name on disk dialog

2025-04-04 Thread Thomas Lamprecht
Am 01.04.25 um 15:09 schrieb Maximiliano Sandoval: > The commit message should be updated, I will do that if there is a need > for v2. Can you please either send out a v2 or propose a new commit message that I can just copy+paste in full? ___ pve-devel

Re: [pve-devel] [PATCH cluster/docs/manager/network/proxmox{, -ve-rs, -firewall, -perl-rs} 00/52] Add SDN Fabrics

2025-04-04 Thread Gabriel Goller
On 04.04.2025 14:53, Hannes Duerr wrote: On 4/4/25 14:48, Gabriel Goller wrote: On 04.04.2025 12:55, Hannes Duerr wrote: On 3/28/25 18:12, Gabriel Goller wrote: This series allows the user to add fabrics such as OpenFabric and OSPF over their clusters. Overview This series allows

[pve-devel] [PATCH proxmox-ve-rs v2 04/15] frr: add openfabric types

2025-04-04 Thread Gabriel Goller
Implement OpenFabric-specific variants of common enums that encapsulate protocol properties defined in proxmox-network-types. The primary addition is OpenFabricInterface, which stores protocol-specific timing parameters: HelloInterval (neighbor discovery frequency), CsnpInterval (database synchroni

Re: [pve-devel] [PATCH] fix #6223: fit terminal after 'OK' message

2025-04-04 Thread Thomas Lamprecht
Am 26.03.25 um 11:42 schrieb Dominik Csapak: > On 3/26/25 11:19, Thomas Lamprecht wrote: >> But again, probably not required as requisting an animation frame from >> inside the callback allways gives the next one already anyway. >> >> [0]: >> https://developer.mozilla.org/en-US/docs/Web/API/Window

Re: [pve-devel] [PATCH proxmox-ve-rs] clippy: elide some lifetimes

2025-04-04 Thread Thomas Lamprecht
Am 31.03.25 um 15:40 schrieb Gabriel Goller: > Elide some lifetimes to avoid clippy warnings: > > warning: the following explicit lifetimes could be elided: 'a >--> proxmox-ve-config/src/firewall/parse.rs:319:11 > | > 319 | impl<'de, 'a, E> serde::de::Deserializer<'de> for

Re: [pve-devel] [PATCH corosync] corosync.service: add patch to reduce log spam in broken network setups

2025-04-04 Thread Maximiliano Sandoval
Friedrich Weber writes: > Since c761053 ("Check packets come from the correct interface > https://github.com/corosync/corosync/issues/750";) in kronosnet, > corosync will produce log messages in certain broken network setups. > See inner patch for details. Drawing attention to such setups is >

[pve-devel] applied: [PATCH qemu] d/rules: remove outdated workaround against historic changelog file

2025-04-04 Thread Thomas Lamprecht
Am 31.03.25 um 15:57 schrieb Fiona Ebner: > There is no top-level 'Changelog' file in the QEMU submodule > repository anymore since QEMU v5.2, to be precise commit e83029fa60 > ("CHANGELOG: remove disused file"). > > Signed-off-by: Fiona Ebner > --- > debian/rules | 3 +-- > 1 file changed, 1 in

[pve-devel] applied: [PATCH pve-manager v5 4/4] Add configuration options for AMD SEV-SNP

2025-04-04 Thread Thomas Lamprecht
Am 31.03.25 um 15:59 schrieb Philipp Giersfeld: > Expand input panel with AMD SEV-SNP selection, and relevant optional > parameters similar to existing options for AMD SEV(-ES). > > Further, upon selecting AMD SEV-SNP, issue a warning that EFI disks are > not included when using SEV-SNP. > > Sign

[pve-devel] [PATCH pve-network v2 14/19] api: openfabric: add node endpoints

2025-04-04 Thread Gabriel Goller
From: Stefan Hanreich Add CRUD endpoints for manipulating OpenFabric nodes. They are implemented in proxmox-perl-rs. Signed-off-by: Stefan Hanreich Signed-off-by: Gabriel Goller --- src/PVE/API2/Network/SDN/Fabrics/Makefile | 2 +- .../Network/SDN/Fabrics/OpenFabricNode.pm | 181 +++

[pve-devel] [PATCH pve-docs v2 1/1] fabrics: add initial documentation for sdn fabrics

2025-04-04 Thread Gabriel Goller
Add initial documentation for the openfabric and ospf options. Signed-off-by: Gabriel Goller --- pvesdn.adoc | 206 1 file changed, 206 insertions(+) diff --git a/pvesdn.adoc b/pvesdn.adoc index 5d5d27bfbc1f..414f39c5109e 100644 --- a/pvesdn.

[pve-devel] [PATCH pve-network v2 08/19] test: isis: add test for standalone configuration

2025-04-04 Thread Gabriel Goller
From: Stefan Hanreich With how the config generation worked before, it was not possible to create a standalone isis controller. Since each controller is now responsible for creating its own configuration, it is possible to create a standalone isis controller without having any evpn controller. Ad

[pve-devel] [PATCH proxmox-perl-rs v2 2/7] perl-rs: sdn: add CRUD helpers for OpenFabric fabric management

2025-04-04 Thread Gabriel Goller
Add functionality for managing OpenFabric fabrics: - Implement Rust-backed Perl module PVE::RS::SDN::Fabrics::OpenFabric - Add CRUD methods for fabric, node, and interface configuration - Support fabric-specific parameters (hello-intervals, router-id, etc.) Signed-off-by: Gabriel Goller --- pve-

[pve-devel] [PATCH pve-network v2 18/19] test: fabrics: add test cases for ospf and openfabric + evpn

2025-04-04 Thread Gabriel Goller
From: Stefan Hanreich Add two additional test cases for EVPN zones, which use fabrics as the underlay network - one for OSPF, one for OpenFabric. They cover a full-mesh fabric setup as well as a simple point-to-point setup to a route reflector as the underlay fabric. Signed-off-by: Stefan Hanre

[pve-devel] [PATCH pve-network v2 11/19] fabrics: generate ifupdown configuration

2025-04-04 Thread Gabriel Goller
From: Stefan Hanreich Currently, the ifupdown generation is handled solely by the zones plugin. Since the fabrics need to generate ifupdown configuration as well, we create a new helper in the SDN module. It then in turn calls into the zone and fabrics plugin, and merges the generated raw configu

[pve-devel] [PATCH proxmox-perl-rs v2 5/7] perl-rs: sdn: add CRUD helpers for OSPF fabric management

2025-04-04 Thread Gabriel Goller
Add CRUD functions for managing OSPF fabrics. Signed-off-by: Gabriel Goller --- pve-rs/Makefile| 1 + pve-rs/src/sdn/mod.rs | 1 + pve-rs/src/sdn/ospf.rs | 217 + 3 files changed, 219 insertions(+) create mode 100644 pve-rs/src/sdn/ospf.rs d

[pve-devel] [PATCH proxmox-perl-rs v2 6/7] perl-rs: sdn: OSPF perlmod methods

2025-04-04 Thread Gabriel Goller
CRUD methods for perlmod that call the helper functions defined earlier. Also add a method that returns the FRR daemons to be enabled and a method that generates FRR configuration after validating it. Signed-off-by: Gabriel Goller Co-authored-by: Stefan Hanreich --- pve-rs/src/sdn/ospf.rs | 173

Re: [pve-devel] [PATCH v4 qemu-server 11/11] qcow2: add external snapshot support

2025-04-04 Thread DERUMIER, Alexandre via pve-devel
--- Begin Message --- > I have reused vdisk_free for this one, as I'm seeing a comment about > $running deprecation in Storage.pm > > # FIXME PVE 8.x remove $running parameter (needs APIAGE reset) > sub volume_snapshot_delete { >     my ($cfg, $volid, $snap, $running) = @_; > > > vdisk_free have

  1   2   3   >