On Tue, 03 Jun 2025 10:52:47 +0200, Dominik Csapak wrote:
> when encountering an error (e.g. there was no curser at the wanted
> position), the program would close with exitcode 1, but would not
> properly finish the json output if in json mode.
>
> To fix that, introduce a `print_error_and_exit`
Updates the `PveResourceStatusType` enum with `prelaunch` option. Also
adds the status checks in `getStatus` and `getQemuStatus` functions.
The changes are necessary inorder to show the `prelaunch`
status in the qemu overview page and in the resources tab view.
Signed-off-by: Shan Shaji
---
lib/
When the VM starts up, if the `Freeze CPU at startup` option value is
set to `true` the VM status is shown as `unknown`. However when testing
the same on web UI, the UI shows the `prelaunch` status when
hovering over the VM.
Additionally the resume option is missing in the app UI, which should
hav
This patch series fixes an issue where the VM status was
shown as `unknown` when the QEMU state is `prelaunch`. Additionaly,
also fixes the resume option missing inside the power settings sheet
when the QEMU state is `prelaunch`.
Steps to reproduce:
- Select any VM
- Go to the options tab.
The section on running swap on ZFS was split into two parts.
The part describing setting the swappiness level was moved to a
separate file and the part about creating swap partitions on a ZFS
volume was replaced with a warning about doing so.
Signed-off-by: Alexander Abraham
---
Changes in v8:
Reduce duplicate code by merging common parts of the change detection
mode selector. Allows to control a common selector used by the
advanced options of the backup job and the window for one-shot backup
runs in one place.
No functional changes intended.
Signed-off-by: Christian Ebner
---
NOTE: A
Switch the current implied default `legacy` option with the new
default value `metadata`, as set by vzdump.
Further, allow to switch back to the previous default by adding the
`legacy` option and keep the `metadata` mode as separate, dedicated
option so pre-exiting backup job configurations still
Switch the default change detection mode used by vzdump for container backups
with PBS storage target from the current `legacy` to the `metadata` mode.
The `legacy` mode was kept to avoid a breaking change in backup behavior. With
the upcoming PVE 9, switch the default to the `metadata` mode, so a
Since commit 58839940 ("vzdump: conditionally set PBS change
detection mode option") it is possible to perform container backups
with Proxmox Backup Server as target using additional `data` and
`metadata` modes provided by the Proxmox Backup client.
While the `metadata` mode was introduced to spee
The section on running swap on ZFS was split into two parts.
The part describing setting the swappiness level was moved to a
separate file and the part about creating swap partitions on a ZFS
volume was replaced with a warning about doing so.
Signed-off-by: Alexander Abraham
Changes in v7:
* Kee
this makes a few changes necessary, but not too much:
* include the different directory for bootstrap5
* use different navbar markup
* different classes for navbar container + items
* add classes to pre tag since it's not styled anymore in newer
bootstrap versions
* add 'form-label' to labels
* u
in commit
d0f4b94 (fix regression in api/html (bootstrap) viewer)
the $unsafe parameter of uri_escape_utf8 was corrected. This
unintentionally also escapes the 'onclick' content of the logout button,
making it not valid javascript code and thus would not execute.
The commit talks about it being
the console js code was added in
63307be (add generic formatter framework
in January 2017 and marked to be removed (in the FIXME) with
6189d2e (Formatter/Bootstrap.pm; use configured cookie_name)
a day later.
This was never used, so simply remove it.
Signed-off-by: Dominik Csapak
---
src/PVE/
On 5/28/25 11:32, Stefan Hanreich wrote:
Tested the following things and they worked:
* Create a new simple zone with Nautobot IPAM
* Create a VNet with a Subnet + GW -> IP allocated
* Create a VM on that VNet -> IP allocated
* Create a CT on that VNet -> IP allocated
* Change network device to
superseeded by v3:
https://lore.proxmox.com/pve-devel/20250603122037.158232-1-s.sh...@proxmox.com/T/#t
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
When the default property was selected inside the realm
of the web UI, the app's login page was not showing the
default realm instead, it was always showing PAM.
Add `default` property and a getter boolean that internally
checks if the realm is default. This boolean is used inside
`pve_login_form.
--- Begin Message ---
use the blockdev syntax for machine_type > 10.0 only
The blockdev chain is:
-throttle-group-node (drive-(ide|scsi|virtio)x)
- format-node (fmt-drive-x)
- file-node (file-drive -x)
Volumes activation is done earlier now, at config_to_command,
as we need it for fi
When the `default` property was selected inside the realm of the web
UI, the app's login page was not showing the default realm instead,
it was always showing PAM.
Add `isDefaultRealm` boolean check to find the default realm.
Also the user's selection will have priority if a realm is
already saved
When the `default` property was selected inside the realm of the web UI,
the app's login page was not showing the default realm instead,
it was always showing PAM.
To reproduce, follow the following steps:
on the web UI go to Datacenter -> Realms and edit another realm than
PAM, like PVE. There
Gave this a spin on my test cluster, and it worked as advertised. As
already mentioned and talked off-list we should imo add documentation
for this setting and mention the current restrictions (no migration of
NAT entries). We might also want to mention that only CT entries created
*after* the fire
Thank you for catching that. Will create another patch.
On Tue Jun 3, 2025 at 11:48 AM CEST, Michael Köppl wrote:
> On 5/26/25 17:41, Shan Shaji wrote:
> > When the `default` property was selected inside the realm of the web
> > UI, the app's login page was not showing the default realm instead,
On 5/26/25 17:41, Shan Shaji wrote:
> When the `default` property was selected inside the realm of the web
> UI, the app's login page was not showing the default realm instead,
> it was always showing PAM.
>
> This commit adds the `isDefaultRealm` boolean check to find the
> default realm.
nit: c
On 4/24/25 13:19, Christoph Heiss wrote:
> Adds a new checkbox to the migration dialog, if it is a
> live/online-migration and both the source and target nodes have support
> for our dbus-vmstate helper.
>
> If the checkbox is active, it passes along the `with-conntrack-state`
> parameter to th
On 4/24/25 13:19, Christoph Heiss wrote:
> First part to fixing #5180 [0].
>
> Adds a simple D-Bus server which implements the `org.qemu.VMState1`
> interface as specified in the QEMU documentation [1].
>
> Using the built-in QEMU VMState machinery saves us from having to worry
> about transfe
A field for OIDC audiences was added, logic to handle these audiences,
and the audiences supplied by an OIDC IDP are validated against
the audiences a user saves in their realm domains
configuration.
Signed-off-by: Alexander Abraham
---
proxmox-openid/src/lib.rs | 20 ++--
1 file
An optional "audiences" field was added to the schema
to accept an array of strings for any audiences communicated
by using an Open ID realm in PVE.
Signed-off-by: Alexander Abraham
---
src/PVE/API2/OpenId.pm | 463 +++--
src/PVE/Auth/OpenId.pm | 141 +++--
A field for audiences for OpenId was added for users to supply
Open ID audiences as a space-separated array of strings in their
realm configuration. This array of audiences is then saved in the
realm domains config file.
Signed-off-by: Alexander Abraham
---
www/manager6/Parser.js| 27
This series adds support for handling Open ID audiences as
described in bug #5076. PVE's API schema was updated to
accept an optional field, an array of strings and the Rust
code was also updated to accordingly handle any incoming
audiences and compare them to the realm config's audiences.
In the r
On Mon, 02 Jun 2025 11:47:50 +0200, Stoiko Ivanov wrote:
> While checking our codebase for potential uses of non-usr-merged paths
> for ZFS I noticed the file-restore uses absolute paths for most commands.
>
> As the daemon runs in an isolated environment we provide sticking to
> absolute paths,
superseeded by v3:
https://lore.proxmox.com/pve-devel/20250603085247.917673-1-d.csa...@proxmox.com/T/#u
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
when encountering an error (e.g. there was no curser at the wanted
position), the program would close with exitcode 1, but would not
properly finish the json output if in json mode.
To fix that, introduce a `print_error_and_exit` helper that tries to
finish the json output. We set `success` to 0 t
On Mon Jun 2, 2025 at 4:14 PM CEST, Alexander Abraham wrote:
> A field for OIDC audiences was added, logic to handle these audiences,
> and the audiences supplied by an OIDC IDP are validated against
> the audiences a user saves in their realm domains
> configuration.
>
> Signed-off-by: Alexander A
Useful to detect whether a system is running version 0.6.0 or 0.6.1 of
the package which changed to the `ntfs3` driver from the `ntfs` driver.
Signed-off-by: Maximiliano Sandoval
---
PVE/API2/APT.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 99c2e
--- Begin Message ---
This add a $running param to volume_snapshot,
it can be used if some extra actions need to be done at the storage
layer when the snapshot has already be done at qemu level.
Note: zfs && rbd plugins already used this param in create_base,
but it was not implemented in volume_s
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
src/PVE/Storage/Common.pm | 40 +++
1 file changed, 40 insertions(+)
diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm
index 25f5d28..11b5b94 100644
--- a/src/PVE/Storage/Common.pm
++
Thanks for tackling this! Definitely improves the UX. I tested this in
my Android emulator. Paused guests were displayed with the correct
status instead of "Unknown" and I was able to filter for the "Paused"
status. Did not notice anything off. Well done!
I left some minor comments on the individu
I think it's a good change. The MainLayoutSlim class is already more
than big enough.
On 6/2/25 15:37, Shan Shaji wrote:
> This patch splits the `_MobileResourceFilterSheet` into multiple widgets
> and since the `main_layout_slim.dart` file is large, the widget has been
> moved to it's own file un
--- Begin Message ---
We need to define name-nodes for all backing chain images,
to be able to live rename them with blockdev-reopen
For linked clone, we don't need to definebase image(s) chain.
They are auto added with #block nodename.
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer/Block
Am 02.06.25 um 18:24 schrieb DERUMIER, Alexandre via pve-devel:
>>>
>>> * Drop $snapshot parameter, currently there is no need to attach
>>> snapshots via -blockdev. They would need to be attached read-only
>>> too to not fail and this can always be added later.
>
>
>>> I need it in different
On 6/2/25 15:37, Shan Shaji wrote:
> When the guest status is set to `paused` the guest was not showing in
> the resources tab. Also there were no option in the resources
> filter to select the `paused` status under the status section.
The first sentence confused me a bit. The resource tab seems t
on second though, we only ever print unknown strings from strerror here, which
should be ascii only?
so using our already existing escaping of quotes and control characters should
be enough...
will send a v3 that combines these things and drops the dependency on json-c...
__
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
src/PVE/Storage/Common.pm | 35 +++
src/PVE/Storage/Plugin.pm | 19 +--
2 files changed, 36 insertions(+), 18 deletions(-)
diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.p
--- Begin Message ---
we format lvm logical volume with qcow2 to handle snapshot chain.
like for qcow2 file, when a snapshot is taken, the current lvm volume
is renamed to snap volname, and a new current lvm volume is created
with the snap volname as backing file
Signed-off-by: Alexandre Derumier
--- Begin Message ---
for raw format, use offset=0 && size=$ovmf_size
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 63 +--
PVE/QemuServer/Blockdev.pm| 22 +--
test/cfg2cmd/efi-raw-template.conf.cmd| 7 ++-
--- Begin Message ---
add a snapext option to enable the feature
When a snapshot is taken, the current volume is renamed to snap volname
and a current image is created with the snap volume as backing file
Signed-off-by: Alexandre Derumier
---
src/PVE/Storage.pm | 1 -
src/PVE/Storag
--- Begin Message ---
Returns if the volume is supporting qemu snapshot:
'internal' : do the snapshot with qemu internal snapshot
'external' : do the snapshot with qemu external snapshot
undef : does not support qemu snapshot
Signed-off-by: Alexandre Derumier
---
src/PVE/Storage.pm
--- Begin Message ---
FIXME:
port qemu bitmap drive-mirror patch to blockdev-mirror
Signed-off-by: Alexandre Derumier
---
PVE/QemuMigrate.pm| 2 +-
PVE/QemuServer.pm | 115 ++
test/MigrationTest/QemuMigrateMock.pm | 10 ++-
3
--- Begin Message ---
for external snapshot, we simply use snap volname as src.
don't use internal snapshot option in the command line.
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 4 ++-
test/run_qemu_img_convert_tests.pl | 44 ++
2 fil
--- Begin Message ---
This was a limitation of drive-mirror, blockdev mirror is able
to reopen image with a different aio.
Do the change when generating the blockdev_format
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 9 ++---
PVE/QemuServer/Blockdev.pm | 3 +++
2 file
--- Begin Message ---
simply use the "drive-$id" top node
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 04e71fb6..8e48f52b 100644
--- a/PVE/QemuServer.pm
+++
--- Begin Message ---
allow to rename from|to external snapshot volname
Signed-off-by: Alexandre Derumier
---
src/PVE/Storage.pm | 4 ++--
src/PVE/Storage/LVMPlugin.pm | 8 ++--
src/PVE/Storage/Plugin.pm| 5 -
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/
--- Begin Message ---
fixme:
- backup seem to use a tpmstate0-backup drive. Not sure how it's works, but
I think it could be converted to blockdev too
- verify drivedel with fleecing temp image
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 93 ++
--- Begin Message ---
Look at qdev value, as cdrom drives can be empty
without any inserted media
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a27dcabb..b
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
debian/changelog | 6 +
.../extra/0001-bump-version-to-10.0.0.patch | 19 ++
...438a42f7a178504347456b9e50e3d2c50478.patch | 247 ++
...b0606879ddeddf04bcf8440aabcfe1393b9c.patch | 120 ++
--- Begin Message ---
fixme:
- add test for internal (was missing) && external qemu snapshots
- is it possible to use blockjob transactions for commit && steam
for atomatic disk commit ?
Signed-off-by: Alexandre Derumier
---
PVE/QemuConfig.pm | 4 +-
PVE/QemuServer.pm |
--- Begin Message ---
This patch series implement qcow2 external snapshot support for files && lvm
volumes
The current internal qcow2 snapshots have bad write performance because no
metadatas can be preallocated.
This is particulary visible on a shared filesystem like ocfs2 or gfs2.
Also other
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
src/PVE/Storage/Common.pm | 72 ++
src/PVE/Storage/GlusterfsPlugin.pm | 2 +-
src/PVE/Storage/Plugin.pm | 47 +--
3 files changed, 74 insertions(+), 47 deletions(-)
diff --g
--- Begin Message ---
We need to use the top blocknode (throttle) as name-node
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 8e1369fc..04e71fb6 100
--- Begin Message ---
reuse the code for cloud-init too
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 79 ++-
1 file changed, 43 insertions(+), 36 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 0af091aa..8e1369fc 100
--- Begin Message ---
Signed-off-by: Alexandre Derumier
---
PVE/QemuServer.pm | 71 +--
1 file changed, 50 insertions(+), 21 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index fa072fca..0af091aa 100644
--- a/PVE/QemuServer.pm
+++ b/P
--- Begin Message ---
and use it for plugin linked clone
This also enable extended_l2=on, as it's mandatory for backing file
preallocation.
Preallocation was missing previously, so it should increase performance
for linked clone now (around x5 in randwrite 4k)
cluster_size is set to 128k, as it
61 matches
Mail list logo
