Printing anyhow errors with "{:#}" would be nice, so that the whole
context is visible as well.
Otherwise LGTM!
Consider:
Reviewed-by: Gabriel Goller
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/lis
Tested as follow:
Created 5 Proxmox VE nodes
joined them as cluster
added a two interfaces per node, all interfaces are on the same host bridge.
Assigned the interfaces VLAN tags so that the nodes form a circle:
1---
/ \
5 2
\ /
4---3
== OSPF ==
Cre
The minimum supported binary version for Proxmox VE 9 is QEMU 10.0, so
there still is more than enough room for eventual regression testing
with older binaries.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 15 ++-
test/cfg2cmd/old-qemu.conf | 4 ++--
2 files changed,
There will be no block node for 'none' after switching to '-blockdev'.
Co-developed-by: Alexandre Derumier
[FE: split out from larger patch
do it also for non-SCSI cases]
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 22 +++---
1 file changed, 19 insertions(+), 3 delet
Co-developed-by: Alexandre Derumier
Signed-off-by: Fiona Ebner
---
RFC, because I didn't test it yet.
PVE/QemuServer/Blockdev.pm | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/Blockdev.pm b/PVE/QemuServer/Blockdev.pm
index 2d3760f0..839e
It was not possible to start a QEMU instance with these options set
since QEMU version 3.1, QEMU commit b24ec3c462 ("block: Remove
deprecated -drive geometry options") and thus also not to take a
backup. It is still possible to restore an ancient backup with these
options set and they will be autom
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 10 +-
PVE/QemuServer/Drive.pm | 16
2 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a2e51849..b9705367 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer
In preparation to add a new one.
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu.pm| 12 +++-
PVE/QemuServer/Drive.pm | 6 --
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 626cce45..003934ef 100644
--- a/PVE/API2/Qemu.
This is a preparatory series for the switch to -blockdev with Proxmox
VE 9, QEMU machine version 10.0, based in part on Alexandre's series
here [0].
While the last patch actually does the switch, many operations are not
yet supported. It is included to show what changes I made there. It
should not
This will be useful for backwards-compat for restore to allow dropping
some drive properties that are long gone from QEMU.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer/Drive.pm | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive
The drive device and node structure is:
front-end device {ide-hd,scsi-hd,virtio-blk-pci} (id=$drive_id)
- throttle node (node-name=$drive_id)
- format node (node-name=f$encoded-info)
- file node (node-name=e$encoded-info)
The node-name can only be 31 characters long and needs to start wit
With '-blockdev', it is necessary to activate the volumes to generate
the command line, because it can be necessary to check whether the
volume is a block device or a regular file.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm| 61 +++-
test/run_con
Co-developed-by: Alexandre Derumier
Signed-off-by: Fiona Ebner
---
RFC, because it should be applied together with properly supporting
all operations.
PVE/QemuServer.pm | 119 --
1 file changed, 72 insertions(+), 47 deletions(-)
diff --git a/PVE/Qem
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 17 +++--
PVE/QemuServer/Drive.pm | 18 ++
test/cfg2cmd/aio.conf.cmd | 16
3 files changed, 29 insertions(+), 22 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 24b791e
The throttle group will be referenced via the 'blockdev' schema.
Co-developed-by: Alexandre Derumier
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 51 ++
PVE/QemuServer/Blockdev.pm | 44
PVE/QemuServer/Makefile
With the 'blockdev' command line option, the cache options are split
up. While cache.direct and cache.no-flush can be set in the -blockdev
options, cache.writeback is a front-end property and was intentionally
removed from the 'blockdev' options by QEMU commit aaa436f998 ("block:
Remove cache.write
Suggested-by: Alexandre Derumier
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 46 +++--
PVE/QemuServer/Drive.pm | 33 +
2 files changed, 45 insertions(+), 34 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.
The following commit will also move the state file handling which uses
the migration IP to the module.
Since QemuServer.pm does not use QemuMigrate.pm and since state file
handling can be both network migration or regular state file, it seems
best to add a new module. The goal is to make vm_start_
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 56 +++--
PVE/QemuServer/StateFile.pm | 56 +
2 files changed, 66 insertions(+), 46 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 91b55cf9..25b
The config_to_command() function already calls into
print_hostpci_devices() which makes reservations.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 56 +++
1 file changed, 32 insertions(+), 24 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/Qem
For command line generation of '-blockdev', it will be necessary to
activate the VM's volumes before calling config_to_command() and thus
also deactivate in an error scenario. Avoid the need to put more code
than necessary into the resulting eval.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm
These properties cannot be specified via '-blockdev' like they could
with '-drive', because they are properties of the front-end drive
device.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index f9e1b
The $scfg parameter for drive_uses_cache_direct() is only relevant for
BTRFS and the io_uring default does not depend on the cache setting
for BTRFS, so it currently doesn't matter if the parameter is passed
along or not here. Still, fix it for the future.
Fixes: 8fbae1dc ("fix #4525: clone disk:
For backwards-compat, to allow dropping some drive properties that are
long gone from QEMU.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 58a5cfa8..5408ba8a 100644
--- a/PVE/QemuSer
The parameter is unused since commit f97b3da1 ("drive: code cleanup:
remove unused $vmid argument from get_iso_path() helper").
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 6 +++---
PVE/QemuServer/Drive.pm | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/PVE/Qe
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Replication.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
index 1c2eac5..fb79e4b 100644
--- a/src/PVE/Replication.pm
+++ b/src/PVE/Replication.pm
@@ -370,7 +370,7 @@ sub replic
Adds replication settings similar to the migration settings. This allows
specifying different networks and it is ultimately more straightforward
than using the migration settings for replication jobs.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/DataCenterConfig.pm | 32 ++
Similar to the migration settings. Replication jobs will fallback to the
migration settings if the replication settings are not set.
test-repo-1:
Maximiliano Sandoval (1):
datacenter config: add replication settings
src/PVE/DataCenterConfig.pm | 32 +++-
1 file ch
If set, otherwise we fall back to migration settings which was the
previous behavior.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/Replication.pm | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
index 20c3485..1c2eac5 1006
The proxmox-notify crate now uses tracing for logging, hence we have to
set up some tracing logging infrastructure if we want to see any
messages in the journal. Therefore we switch from the syslog crate to
proxmox-log, which configures the appropriate layers/subscribers for
tracing.
Signed-off-by
These were only used in the 'old' revamped notification stack which was
briefly available on pvetest. With PVE 9 we can finally get completely
rid of these.
Signed-off-by: Lukas Wagner
---
Only intended for PVE 9.
www/manager6/dc/Backup.js | 16
1 file changed, 16 deletions(-)
--- Begin Message ---
> > Later on, I'd like to contribute to a version which
> > enables thin provisioned snapshots.
>>For thin provision, I have done prelimary work in september 2024
>>(check
>>the pve-devel mailing),
>>but I was waiting to have first the snapshot finished.
here the patch serie
Those were only used in the first iteration of the new notification
stack, which unfortunately hit pvetest too soon. These two keys have no
effect and were proactively removed by the GUI when changing
backup job settings.
The pve8to9 script will gain a check to check for any left-over keys.
Signe
When the pending chip appears after enabling an option from the options
page, Flutter throws an overflow error, causing the chip to render
on top of the Switch widget due to insufficient space between
the title and the switch toggle.
To resolve this, modify the layout so that the pending chip widg
The backup job details view was never updated after the overhaul of the
notification system. In this commit we remove the left-over
notification-policy/target handling and change the view so that we
display the current configuration based on notification-mode, mailto and
mailnotification.
Signed-o
Superseeded by v2:
https://lore.proxmox.com/pve-devel/20250612085746.18066-1-s.sh...@proxmox.com/T/#u
On Tue Jun 10, 2025 at 5:49 PM CEST, Shan Shaji wrote:
> Thank you for the review. Will send another updated patch.
>
> On Tue Jun 10, 2025 at 5:31 PM CEST, Michael Köppl wrote:
> > Due to the c
In iOS, there was a blue background color visible beneath the bottom
bar, which caused the app to not utilize the full screen height.
Additionally, the colors of the app bar and the status bar
differed when the user began scrolling.
This issue was due to the container color used in the `ColoredSaf
Superseded by
https://lore.proxmox.com/pve-devel/20250612082318.118153-1-m.sando...@proxmox.com/T/#u.
Fiona Ebner writes:
> Am 30.04.25 um 12:45 schrieb Maximiliano Sandoval:
>> Signed-off-by: Maximiliano Sandoval
>> ---
>> www/manager6/window/Restore.js | 10 ++
>> 1 file changed,
The pool selector is only visible when restoring from the
Datacenter->{node}->{storage}->Backups panel.
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- Hide the pool selector when restoring a VM in-place.
www/manager6/window/Restore.js | 11 +++
1 file changed, 11 inser
Am 11.06.25 um 23:28 schrieb joao.sousa:
> This is the output of git am when applying the qemu-server patches:
>
> Applying: blockdev: cmdline: add blockdev syntax support
> .git/rebase-apply/patch:972: trailing whitespace.
> boot:
> error: patch failed: test/cfg2cmd/simple-btrfs.conf.cmd:32
> err
--- Begin Message ---
>> Later on, I'd like to contribute to a version which
>>enables thin provisioned snapshots.
For thin provision, I have done prelimary work in september 2024 (check
the pve-devel mailing),
but I was waiting to have first the snapshot finished.
I can help you if you want abou
41 matches
Mail list logo
