On 7/7/25 21:49, Adam Kalisz wrote:
Hi Dominik,
seems like a more elegant solution. In my testing on the Ryzen system:
Thanks for testing!
progress 100% (read 53624176640 bytes, zeroes = 5% (2776629248 bytes), duration
52 sec)
progress 96% (read 53628370944 bytes, zeroes = 5% (2776629248 b
Hi Dennis,
Am 08.07.25 um 05:07 schrieb Dennis Klochko:
> Thank you for the extra information, that's very helpful.
> Another question is about versioning of a plugin vs new Proxmox versions -
> in what cases should the plugin be updated?
We had a short section about [api versioning] in the stora
--- Begin Message ---
Hi Thomas,
Thank you for the extra information, that's very helpful.
Another question is about versioning of a plugin vs new Proxmox versions -
in what cases should the plugin be updated?
On Wed, Jul 2, 2025 at 11:17 PM Thomas Lamprecht
wrote:
> Hello!
>
> Am 25.06.25 um 0
--- Begin Message ---
Hi Dominik,
seems like a more elegant solution. In my testing on the Ryzen system:
progress 100% (read 53624176640 bytes, zeroes = 5% (2776629248 bytes), duration
52 sec)
progress 96% (read 53628370944 bytes, zeroes = 5% (2776629248 bytes), duration
52 sec)
progress 97% (r
On Mon, 07 Jul 2025 13:01:36 +0200, Christoph Heiss wrote:
> Much in the same way as the top-level target.
>
>
Applied this one, thanks!
[1/2] buildsys: add target for auto-formatting bin/ scripts
commit: 9feebec6f26631f9fd5c34736aca226e91f5d00b
_
Am 07.07.25 um 10:03 schrieb Friedrich Weber:
> This allows to introduce other subcommands, e.g. for manual actions
> rqeuired before the upgrade.
>
> Signed-off-by: Friedrich Weber
> ---
>
> Notes:
> changes since v3:
> - rephrase commit message
>
> new in v3
>
> PVE/CLI/pve8
On Tue, 24 Jun 2025 13:33:26 +0200, Lukas Wagner wrote:
> The notification stack removes these sections automatically whenever the
> configuration is updated, so this should only affect a small number of
> people - those who used the notification system while it was only
> available in pvetest, cre
On 07.07.2025 14:19, Wolfgang Bumiller wrote:
On Wed, Jul 02, 2025 at 04:50:02PM +0200, Gabriel Goller wrote:
[snip]
+impl std::fmt::Display for NodeSectionId {
+fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
+write!(f, "{}_{}", self.fabric_id.as_ref(), self.node_id
On 07.07.2025 13:58, Wolfgang Bumiller wrote:
On Wed, Jul 02, 2025 at 04:50:00PM +0200, Gabriel Goller wrote:
+impl FrrSerializer for &FrrConfig {
^ Can drop the &, `serialize` already takes `&self` anyway.
Same for lots of other impls below - the tuple impls will still work...
Yep, removed
On 07.07.2025 13:52, Wolfgang Bumiller wrote:
On Wed, Jul 02, 2025 at 04:49:59PM +0200, Gabriel Goller wrote:
[snip]
+/// A single [`AccessList`] rule.
+///
+/// Every rule in a [`AccessList`] is its own command and gets written into a
new line (with the
+/// same name). These rules have an act
On 07.07.2025 13:28, Wolfgang Bumiller wrote:
On Wed, Jul 02, 2025 at 04:49:58PM +0200, Gabriel Goller wrote:
[snip]
+/// The NetworkType of the interface.
+///
+/// The most important options here are Broadcast (which is the default) and
PointToPoint.
+/// When PointToPoint is set, then the in
On 07.07.2025 13:25, Wolfgang Bumiller wrote:
On Wed, Jul 02, 2025 at 04:49:57PM +0200, Gabriel Goller wrote:
[snip]
+/// The OpenFabric properties.
+///
+/// This struct holds all the OpenFabric interface properties. The most
important one here is the
+/// fabric_id, which ties the interface t
On Mon, 07 Jul 2025 11:48:00 +0200, Shan Shaji wrote:
> Set `targetSdkVersion` and `compileSdkVersion` to (36).
> According to android docs [0] the `targetSdkVersion` should be
> <= `compileSdkVersion`.
>
> Also update the Gradle and AGP versions [1] to support the new
> API level.
>
> [...]
Ap
On 07.07.2025 13:18, Wolfgang Bumiller wrote:
On Wed, Jul 02, 2025 at 04:49:56PM +0200, Gabriel Goller wrote:
[snip]
+impl FromStr for FrrWord {
+type Err = FrrWordError;
+
+fn from_str(s: &str) -> Result {
+FrrWord::new(s.to_string())
^ Let's try to avoid allocating before err
On Thu Jun 26, 2025 at 5:11 PM CEST, Michael Köppl wrote:
[..]
> diff --git a/proxmox-tui-installer/src/views/mod.rs
> b/proxmox-tui-installer/src/views/mod.rs
> index 4364489..3211c93 100644
> --- a/proxmox-tui-installer/src/views/mod.rs
> +++ b/proxmox-tui-installer/src/views/mod.rs
> @@ -387,8
On 07.07.2025 13:12, Wolfgang Bumiller wrote:
On Wed, Jul 02, 2025 at 04:49:55PM +0200, Gabriel Goller wrote:
[snip]
+[dependencies]
+thiserror = { workspace = true }
+anyhow = "1"
+tracing = "0.1"
+
+serde = { workspace = true, features = [ "derive" ] }
+serde_with = { workspace = true }
+itoa
On Mon, 07 Jul 2025 12:08:12 +0200, Christoph Heiss wrote:
> Two small, mostly trivial patches simplifying the serde definitions for
> the answer file.
>
> History
> ===
>
> v1:
> https://lore.proxmox.com/pve-devel/20250429132025.1543199-1-c.he...@proxmox.com/T/
>
> [...]
Applied, thanks!
On Thu Jun 26, 2025 at 5:11 PM CEST, Michael Köppl wrote:
> Signed-off-by: Michael Köppl
> ---
> proxmox-installer-common/src/utils.rs | 17 +++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/proxmox-installer-common/src/utils.rs
> b/proxmox-installer-common/sr
On Wed, Jul 02, 2025 at 04:50:02PM +0200, Gabriel Goller wrote:
> From: Stefan Hanreich
>
> NodeSection functions identically to the FabricSection type. It
> contains all the common properties that nodes from all protocols have.
> Protocol-specific properties can be defined via the type parameter
On Thu Jun 26, 2025 at 5:11 PM CEST, Michael Köppl wrote:
[..]
> diff --git a/proxinstall b/proxinstall
> index 904668e..84f1a91 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -1488,7 +1488,7 @@ sub create_hdoption_view {
>
> my $tmp;
>
> -if (($tmp = &$get_float($spinbutton_hdsize))
On Wed, Jul 02, 2025 at 04:50:00PM +0200, Gabriel Goller wrote:
> Add generic FRR types that contain openfabric and ospf variants. Also
> add the FrrConfig, which holds the whole FRR configuration in a single
> struct, which will then be serialized to the FRR configuration file.
>
> Signed-off-by:
On Wed, Jul 02, 2025 at 04:49:59PM +0200, Gabriel Goller wrote:
> Only a very limited subset of the FRR route-maps is implemented here
> intially, only what is currently needed for the fabrics feature. Once
> standalone route-maps will make it into PVE, we will build on the
> structs defined here a
Ping
On Thu May 22, 2025 at 11:50 AM CEST, Shan Shaji wrote:
> When running the app in iOS the app icon was the default flutter
> icon and this commit fixes it by replacing all
> flutter icons with the proxmox app icon.
___
pve-devel mailing list
pve-d
On Thu Jun 26, 2025 at 5:11 PM CEST, Michael Köppl wrote:
[..]
> diff --git a/proxmox-installer-common/src/disk_checks.rs
> b/proxmox-installer-common/src/disk_checks.rs
> index ecc43bd..d535837 100644
> --- a/proxmox-installer-common/src/disk_checks.rs
> +++ b/proxmox-installer-common/src/disk_ch
On Mon Jul 7, 2025 at 1:23 PM CEST, Thomas Lamprecht wrote:
> Am 07.07.25 um 13:01 schrieb Christoph Heiss:
>> Reformats all Perl scripts in bin/ with perltidy using Proxmox style
>> guides, as was done in commit 138cae897 for all other Perl code.
>>
>> As these files do not use `.pl` or `.pm` as f
On Wed, Jul 02, 2025 at 04:49:58PM +0200, Gabriel Goller wrote:
> Add OSPF-specific FRR types. This also reuses the types from
> proxmox-network-types.
>
> The NetworkType FRR option is implemented here, but not exposed to the
> interface, as we want to keep it simple for the users. If they do not
On Wed, Jul 02, 2025 at 04:49:57PM +0200, Gabriel Goller wrote:
> Implement OpenFabric-specific variants of common enums that
> encapsulate protocol properties defined in proxmox-network-types. The
> primary addition is OpenFabricInterface, which stores
> protocol-specific timing parameters: HelloI
Am 07.07.25 um 13:01 schrieb Christoph Heiss:
> Reformats all Perl scripts in bin/ with perltidy using Proxmox style
> guides, as was done in commit 138cae897 for all other Perl code.
>
> As these files do not use `.pl` or `.pm` as file extensions, they were
> missed during the initial reformattin
On Wed, Jul 02, 2025 at 04:49:56PM +0200, Gabriel Goller wrote:
> Add common FRR configuration types such as FrrWord,
> CommonInterfaceName, etc. These are some common types that are used by
> both openfabric and ospf and the generic types that span the two
> protocols. The FrrWord is a simple prim
On Wed, Jul 02, 2025 at 04:49:55PM +0200, Gabriel Goller wrote:
> This crate holds FRR-types, so rust-types that closely resemble
> FRR-configuration items. These types can then simply be converted to
> strings (and the final FRR config) by serializing. This has minimal
> dependencies and it's only
Done using `make -C bin tidy`.
Signed-off-by: Christoph Heiss
---
bin/pve-init-ceph-crash | 127 +-
bin/pvebanner | 2 +-
bin/pvedaemon | 2 +-
bin/pveperf | 198
bin/pveproxy| 10 +-
Reformats all Perl scripts in bin/ with perltidy using Proxmox style
guides, as was done in commit 138cae897 for all other Perl code.
As these files do not use `.pl` or `.pm` as file extensions, they were
missed during the initial reformatting.
Patch #1 just adds the appropriate make target, patc
Much in the same way as the top-level target.
Signed-off-by: Christoph Heiss
---
Makefile | 1 +
bin/Makefile | 4
2 files changed, 5 insertions(+)
diff --git a/Makefile b/Makefile
index b05d5e129..eb1425222 100644
--- a/Makefile
+++ b/Makefile
@@ -18,6 +18,7 @@ all: $(SUBDIRS)
.PHONY
> DERUMIER, Alexandre hat am 07.07.2025
> 12:18 CEST geschrieben:
> >>for the DirPlugin we need to add another level for the snapshots
> >>on-disk, else we cannot differentiate between weirdly-named image
> >>files and snapshot files..
> >>
> >>so we could add a directory "snapshots" and put a
Reviewed-by: Fabian Grünbichler
although the comment in the postinst (that got moved over)
could be shortened to just say that the entry is unconditionally
rewritten, IMHO ;)
> Lukas Wagner hat am 25.06.2025 14:20 CEST geschrieben:
>
>
> proxmox-mail-forward is not intended to be called by r
--- Begin Message ---
>>we could consider adding a new API method `rename_snapshot` instead:
>>
>>my ($class, $scfg, $storeid, $volname, $source_snap, $target_snap) =
>>@_;
>>
>>for the two plugins here it could easily share most of the
>>implementation
>>with rename_volume, without blowing up the
--- Begin Message ---
>
> or maybe use something else than volume_snapshot_info here, simply
> glob
> all the vm disk && snap files and delete them in random order, as we
> want to delete it anyway.
yes, this is exactly what I meant with tricky ;)
>>if we start deleting snapshots from the "first
For `Option<>`s, serde automatically defaults to `None` for
deserialization in case the key is missing in the source.
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
proxmox-auto-installer/src/answer.rs | 2 --
1 file changed, 2 deletions(-)
diff --g
Two small, mostly trivial patches simplifying the serde definitions for
the answer file.
History
===
v1:
https://lore.proxmox.com/pve-devel/20250429132025.1543199-1-c.he...@proxmox.com/T/
Changes v1 -> v2:
* rebased on latest master
Diffstat
Christoph Heiss (2):
auto: answer:
Instead of using an `Option>`, we can use a `BTreeMap`
directly and let serde default to an empty map.
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* rebased on latest master
proxmox-auto-installer/src/answer.rs | 18 ++
1 file changed, 10 inser
Created a new patch [0] by updating the compileSdkVersion to 36. Now
both the `compileSdkVersion` and `targetSdkVersion` are 36.
- [0]
https://lore.proxmox.com/pve-devel/20250707094800.68832-1-s.sh...@proxmox.com/T/#u
On Fri Jul 4, 2025 at 1:15 PM CEST, Shan Shaji wrote:
> There is no new vers
Set `targetSdkVersion` and `compileSdkVersion` to (36).
According to android docs [0] the `targetSdkVersion` should be
<= `compileSdkVersion`.
Also update the Gradle and AGP versions [1] to support the new
API level.
[0] - https://developer.android.com/build#android_sdk_settings
[1] -
https://d
v2:
https://lore.proxmox.com/pve-devel/20250707091412.314631-1-c.he...@proxmox.com/
On Wed May 28, 2025 at 11:29 AM CEST, Christoph Heiss wrote:
> Came across these commented-out `onlineHelp` and looked into it - all
> referenced sections across the repo have been (very) long available in
> pve-d
Came across these commented-out `onlineHelp` and looked into it - all
referenced sections across the repo have been (very) long available in
pve-docs and can thus be enabled.
Additionally, after looking at #3, thought to link to this "new" section
in some other tags-related panels, instead of the
This section is available since pve-docs 7.1-1, which was released in
November 2021.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* rebased on latest master
www/manager6/qemu/HDTPM.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/HDTPM.js b/www/
This section is available since pve-docs 8.2.4, released November 2024.
Includes the necessary bump to accommodate that.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* rebased on latest master
debian/control | 2 +-
www/manager6/panel/TagConfig.js | 3 +--
2 files cha
Now that there is a dedicated section for configuring tags, link to that
instead of to the documentation of the datacenter configuration file.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* rebased on latest master
www/manager6/dc/OptionView.js | 2 +-
www/manager6/dc/Register
This section has been available since pve-docs 6.0-5, which was released
in October 2019.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* rebased on latest master
www/manager6/qemu/AudioEdit.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/www/manager6/qemu/Audi
> DERUMIER, Alexandre hat am 04.07.2025
> 15:22 CEST geschrieben:
> > + #delete external snapshots
> > + if ($scfg->{snapext}) {
> > + my $snapshots = $class->volume_snapshot_info($scfg,
> > $storeid, $volname);
> > + for my $snapid (
> > + sor
by using async futures to load chunks and stream::buffer_unordered to
buffer up to 16 of them, depending on write/load speed.
With this, we don't need to increase the number of threads in the
runtime to trigger parallel reads and network traffic to us. This way
it's only limited by CPU if decoding
Superseded by:
https://lore.proxmox.com/pve-devel/20250707080352.58713-1-f.we...@proxmox.com/T/
On 29/04/2025 13:36, Friedrich Weber wrote:
> # Summary
>
> With default settings, LVM autoactivates LVs when it sees a new VG, e.g. after
> boot or iSCSI login. In a cluster with guest disks on a shar
When discovering a new volume group (VG), for example on boot, LVM
triggers autoactivation. With the default settings, this activates all
logical volumes (LVs) in the VG. Activating an LV creates a
device-mapper device and a block device under /dev/mapper.
Autoactivation is problematic for shared
When discovering a new volume group (VG), for example on boot, LVM
triggers autoactivation. With the default settings, this activates all
logical volumes (LVs) in the VG. Activating an LV creates a
device-mapper device and a block device under /dev/mapper.
This is not necessarily problematic for l
Starting with PVE 9, the LVM and LVM-thin plugins create new LVs with
the `--setautoactivation n` flag to fix #4997 [1]. However, this does
not affect already existing LVs of setups upgrading from PVE 8.
Hence, add a new `updatelvm` subcommand to `pve8to9` that finds guest
volume LVs with autoacti
# Summary
With default settings, LVM autoactivates LVs when it sees a new VG, e.g. after
boot or iSCSI login. In a cluster with guest disks on a shared LVM VG (e.g. on
top of iSCSI/Fibre Channel (FC)/direct-attached SAS), this can indirectly cause
guest creation or migration to fail. See bug #4997
Signed-off-by: Friedrich Weber
---
PVE/CLI/pve8to9.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index f4cdf1c7..45692748 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1061,8 +1061,7 @@ sub check_storage_content_dir
This allows to introduce other subcommands, e.g. for manual actions
rqeuired before the upgrade.
Signed-off-by: Friedrich Weber
---
Notes:
changes since v3:
- rephrase commit message
new in v3
PVE/CLI/pve8to9.pm | 4 +++-
bin/Makefile | 2 +-
2 files changed, 4 insertion
On Fri, Jul 04, 2025 at 05:56:46PM +0200, Gabriel Goller wrote:
> On 04.07.2025 14:57, Wolfgang Bumiller wrote:
> > On Wed, Jul 02, 2025 at 04:50:15PM +0200, Gabriel Goller wrote:
> > > From: Stefan Hanreich
> > >
> > > The FabricConfig from proxmox-ve-config implements CRUD functionality
> > > f
> DERUMIER, Alexandre hat am 04.07.2025
> 14:33 CEST geschrieben:
>
>
> >>these should probably stay in Plugin.pm
>
> Ok, will do, no problem (Fiona asked me to move it out of Plugin)
I'd prefer if the helpers there remain low-level helpers
for now, and not config-handling things including
On Fri, Jul 04, 2025 at 04:40:47PM +0200, Gabriel Goller wrote:
> > > [snip]
> > > diff --git a/proxmox-sdn-types/src/net.rs b/proxmox-sdn-types/src/net.rs
> > > new file mode 100644
> > > index ..78a47983f0c7
> > > --- /dev/null
> > > +++ b/proxmox-sdn-types/src/net.rs
> > > @@ -0,0 +1
> DERUMIER, Alexandre hat am 04.07.2025
> 14:10 CEST geschrieben:
> >>it would also be great if you could add a patch bumping API version
> >>and age
> I was not sure it was needed, as Fiona has just bumped it in last
> patches and no .deb has been released ?
we could maybe skip bumping twice,
--- Begin Message ---
Ah, sorry, I just notice than I have rebase the wrong patch serie
version (I had already done some fix for last fiona review)
Fiona wanted a dedicated sub to create backed images like
our $QCOW2_CLUSTERS = {
backed => ['extended_l2=on','cluster_size=128k']
};
=pod
=hea
Thank you Dominik, Will keep that in mind. I have created a new patch
by including the changes that you mentioned.
superseeded by v2:
https://lore.proxmox.com/pve-devel/20250704152654.21221-1-s.sh...@proxmox.com/T/#t
On Mon Jul 7, 2025 at 8:28 AM CEST, Dominik Csapak wrote:
> On 7/4/25 16:40,
63 matches
Mail list logo
