On Fri, 01 Aug 2025 18:22:15 +0200, Daniel Kral wrote:
> Here's a follow up on the HA rules and especially the HA resource
> affinity rules.
>
> The first three patches haven't changed as they were lower priority for
> me than the last part about loosening restrictions on mixed resource
> referenc
On each add, edit, remove of a rule, refresh both affinity rule stores
to immediately display any conflicts between the rules. Before this
change, users would have to refresh the page to see conflicts on
resource affinity rules after adding node affinity rules and vice-versa.
Signed-off-by: Michae
Signed-off-by: Michael Köppl
---
www/manager6/ha/Rules.js | 175 +++
1 file changed, 86 insertions(+), 89 deletions(-)
diff --git a/www/manager6/ha/Rules.js b/www/manager6/ha/Rules.js
index c8d4c1dac..5fd02b7ba 100644
--- a/www/manager6/ha/Rules.js
+++ b/www/m
The goal of this is to refresh both affinity rules stores to
immediately display any conflicts. Without this change, users have to
refresh the page to see conflicts on resource affinity rules after they
added a node affinity rule that was in conflict (and vice-versa).
The second patch is formattin
On Thu Jul 31, 2025 at 4:27 PM CEST, Daniel Kral wrote:
> Two smaller (RFC!) patches regarding the version comparison for the HA
> group migration and two test cases for slightly more realistic scenarios
> when the cluster nodes are upgraded and rebooted one-by-one (with some
> failures in-between)
Am 01.08.25 um 18:07 schrieb Max R. Carrara:
>> An implementation option might be using an node-local environment file
>> sourced by the unit file, e.g.
>>
>> Environment="VARIANT=legacy"
>> EnvironmentFile=-/var/lib/pve-firewall/tables-variant
>>
>> ExecStartPre=-/usr/bin/update-alternatives --set
In the context of the HA Manager, resources' downtime is expected to be
minimized as much as possible. Therefore, it is more reasonable to try
other possible node placements if one or more of the HA resources of a
positive affinity rule fail, instead of putting the failed HA resources
in recovery.
These test cases cover slightly more realistic upgrade paths of the
cluster nodes, where nodes are upgraded and rebooted one-by-one and some
actions might fail in-between.
The new sim_hardware_cmd 'version' is introduced to allow simulating the
runtime upgrades of each node and should be removed a
Most users will likely interact with the HA rules through the web
interface, where the HA rule ids are not shown in the rules view.
Error messages with direct references to these rule ids will seem
confusing to users, so replace them with a more generic name.
Reported-by: Fiona Ebner
Signed-off-
Make call sites to the for_each_rule more readable and while at remove
unnecessary variables in the helper body as well.
Suggested-by: Thomas Lamprecht
Signed-off-by: Daniel Kral
---
src/PVE/API2/HA/Rules.pm | 6 ++
src/PVE/HA/Rules.pm | 16 +++-
sr
Otherwise, these will be ignored by the feasibility check and allows
users to create rules or update rules, which are infeasible and will
make other HA rules invalid.
Reported-by: Fiona Ebner
Signed-off-by: Daniel Kral
---
src/PVE/API2/HA/Rules.pm | 4
1 file changed, 4 insertions(+)
diff
Add test cases for some scenarios, where node and positive/negative
resource affinity rules are applied together.
For the positive resource affinity rules, node affinity rules will
always take precedence, even if all or the majority of resources in the
resource affinity rule are already on another
Add test cases to verify that the rule checkers correctly identify and
remove HA node and resource affinity rules from the rules to make the
rule set feasible. The added test cases verify:
- the resources of a resource affinity rule are not part of any node
affinity rule, which has multiple prio
Suggested-by: Thomas Lamprecht
Signed-off-by: Daniel Kral
---
src/PVE/API2/HA/Rules.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/API2/HA/Rules.pm b/src/PVE/API2/HA/Rules.pm
index b180d2ed..d797f621 100644
--- a/src/PVE/API2/HA/Rules.pm
+++ b/src/PVE/API2/HA/Rules.pm
@@ -223,6
In preparation of the next patch, remove the overly restrictive checker,
which disallows that resources are used in node affinity rules and
resource affinity rules at the same time.
Signed-off-by: Daniel Kral
---
This could be squashed into the next, but I figured it's good measure
for documentat
Add inter-plugin checks and helpers, which allow resources to be used in
node affinity rules and resource affinity rules at the same time, if the
following conditions are met:
- the resources of a resource affinity rule are not part of any node
affinity rule, which has multiple priority groups.
Here's a follow up on the HA rules and especially the HA resource
affinity rules.
The first three patches haven't changed as they were lower priority for
me than the last part about loosening restrictions on mixed resource
references.
Patches #1 - #8 are rather independent patches but still have
These should not be accounted for as these are treated as if the HA
Manager doesn't manage them at all.
Reported-by: Michael Köppl
Signed-off-by: Daniel Kral
---
src/PVE/HA/Config.pm | 2 ++
src/PVE/HA/Manager.pm | 4
2 files changed, 6 insertions(+)
diff --git a/src/PVE/HA/Config.pm b/s
For the minimum version of 9.0.0~16 to migrate ha groups, the version
9.0.0 would fail the test as 0 < 16 would be true. If the ~revision is
not set for $version, then it is ordered after any minimum ~revision.
Signed-off-by: Daniel Kral
---
nothing changed since v1
src/PVE/HA/Manager.pm | 7 ++
Storage IDs in Proxmox VE may contain dots, which makes a simple
rename adding a '.old' extension impossible without potential
breakage. The storage RRD is grouped by nodes, so to fix it, create
a '.old' directory for each node and move migrated RRD files there.
If a previous migration with the lo
On Fri Aug 1, 2025 at 6:00 PM CEST, Thomas Lamprecht wrote:
> Am 01.08.25 um 17:45 schrieb Max R. Carrara:
> > Back in c743e671d it was necessary to update-alternative `ebtables`
> > to `ebtables-legacy` due to some bugs [0][1]. However, these bugs
> > appear to be fixed now.
>
> Oh, what a throwba
On Fri, 01 Aug 2025 10:16:05 +0200, Fiona Ebner wrote:
> Avoid that Perl auto-attaches the line number and file name.
>
>
Applied, thanks!
[1/1] deactivate volumes: terminate error message with newline
commit: 5750596f5b21a7ed001904ebfcd65f0f9a239780
Am 01.08.25 um 17:45 schrieb Max R. Carrara:
> Back in c743e671d it was necessary to update-alternative `ebtables`
> to `ebtables-legacy` due to some bugs [0][1]. However, these bugs
> appear to be fixed now.
Oh, what a throwback ^^ Yeah might be good to change this, but we're
a bit to late for th
Back in c743e671d it was necessary to update-alternative `ebtables`
to `ebtables-legacy` due to some bugs [0][1]. However, these bugs
appear to be fixed now.
In Trixie, `ebtables-legacy` seems to cause an enormous amount of audit
message spam in `dmesg` after upgrading from Bookworm--about 5 long
Silence ebtables Audit Messages in dmesg - RFC v1
=
In short, this is done by switching the `update-alternatives` calls
in pve-firewall.service from ebtables-legacy / iptables-legacy to
ebtables-nft / iptables-nft.
Switching to ebtables-nft in parti
Am 31.07.25 um 17:58 schrieb Gabriel Goller:
> The checkbox wasn't displayed and following errors were on the console:
>
> failed to query /capabilites/qemu/migration on '': [object Object]
> pvemanagerlib.js:20401:25
> Uncaught (in promise) TypeError: comigratedHAResources is not iterable
>
On Fri, 01 Aug 2025 11:26:18 +0200, Fiona Ebner wrote:
> Previously, sorting would not apply to the leaves of the tree.
>
>
Applied, thanks!
[1/1] ui: sdn: ipam/dhcp: allow sorting by guest ID
commit: 732d12184b9a8270defb87c2557e8573f0ed0d52
_
On Fri, 01 Aug 2025 15:54:27 +0200, Fiona Ebner wrote:
> Use the correct path when skipping a nonexistent node. Before this
> series, the presence of a nonexistent node would lead to a failure:
>
> > Error migrating nodes: Not a directory (os error 20)
>
> That is because the path would have a du
The old PNG was quite small and looked blurry when using >100% scaling.
Signed-off-by: Lukas Wagner
---
www/LoginView.js | 4 ++--
www/MainView.js | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/LoginView.js b/www/LoginView.js
index 9c1ac38a3..ef422200d 100644
--- a
The SVG is based on the one from PDM, but with the `width` and `height`
properties removed - apparently that is needed so that the SVG properly
resizes with the parent container.
Signed-off-by: Lukas Wagner
---
Notes:
Created a new component because I did not want to mess with the old one.
PBS uses 5px padding here as well.
Signed-off-by: Lukas Wagner
---
Notes:
Looks a tiny bit nicer with the added padding, but no hard feelings
here.
www/manager6/Workspace.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index
The old PNG was quite small and looked blurry when using >100% scaling.
Signed-off-by: Lukas Wagner
---
www/manager6/Workspace.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index c4bbfccc..03628b5a 100644
--- a/www/
proxmox-widget-toolkit:
Lukas Wagner (1):
add Proxmox logo as SVG
src/Logo.js | 22 ++
src/images/Makefile | 1 +
src/images/proxmox_logo.svg | 25 +
3 files changed, 48 insertions(+)
create mode 100644 src/images/proxmox
On Fri, 01 Aug 2025 14:10:26 +0200, Stefan Hanreich wrote:
> Check if there are any not-yet-migrated ipam / mac cache files in
> pmxcfs. Those should have been migrated over in the pve-network
> postinst, but if something went wrong during this process we can
> explicitly notify users here again to
Use the correct path when skipping a nonexistent node. Before this
series, the presence of a nonexistent node would lead to a failure:
> Error migrating nodes: Not a directory (os error 20)
That is because the path would have a duplicate node name attached,
for example:
> /var/lib/rrdcached/db/pv
Signed-off-by: Fiona Ebner
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index c426882..5634344 100644
--- a/debian/control
+++ b/debian/control
@@ -9,6 +9,7 @@ Build-Depends: cargo:native,
librust-libc-0.2+default-dev (>= 0
Use the same expression as in the OK(()) branch after the
do_rrd_migration() call. Previously, the presence of a nonexistent
node would lead to a failure:
> Error migrating nodes: Not a directory (os error 20)
That is because the path would have a duplicate node name attached,
for example:
> /var
On Fri, 01 Aug 2025 13:44:45 +0200, Fiona Ebner wrote:
> This is a breaking API change intended for PVE 9.
>
>
Applied, thanks!
[1/1] api: sdn: ipams: status: ensure that guest ID is returned as an integer
commit: 37c2156ce8b26d6fb5e6e173b660841eb64a83cd
On Fri, 01 Aug 2025 14:10:27 +0200, Stefan Hanreich wrote:
> With the upgrade to PVE 9, those files should have been successfully
> migrated on all nodes, so we do not need to fallback on the old files
> anymore.
>
>
Applied, thanks!
[1/1] ipam: remove fallback code for ipam.db and mac cache
On Fri, 01 Aug 2025 14:38:04 +0200, Stoiko Ivanov wrote:
> a few things changed in systemd-boot upstream packages we use as
> for proxmox-boot-tool systems:
> * systemd-boot was split up further into systemd-boot-tools (we need
> `bootctl`) and `systemd-boot`(the meta-package which triggers
> u
On Fri Aug 1, 2025 at 2:52 PM CEST, Thomas Lamprecht wrote:
> Applied, thanks!
>
> But can you please add a cover-letter for any actual patch series (i.e., not
> just a single patch), as that provides some value even if it's empty, as it
> makes it very clear if trailers like T-b or R-b are intende
On Fri, 01 Aug 2025 14:10:25 +0200, Stefan Hanreich wrote:
> Those files get migrated with pve-network >= 0.9.9 - so we do not need
> to observe them anymore via pmxcfs.
>
>
Applied, thanks!
[1/1] pmxcfs: remove legacy ipam db and mac cache files
commit: 8c12940a66e84ace6c428f4ddbda547d86
On Fri, 01 Aug 2025 11:54:27 +0200, Lukas Wagner wrote:
> Otherwise we leak the memory that was already allocated for `filename`.
>
>
Applied, thanks!
But can you please add a cover-letter for any actual patch series (i.e., not
just a single patch), as that provides some value even if it's empt
On Fri Aug 1, 2025 at 11:54 AM CEST, Lukas Wagner wrote:
> Otherwise we leak the memory that was already allocated for `filename`.
>
> Signed-off-by: Lukas Wagner
> ---
> src/pmxcfs/status.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
> ind
On August 1, 2025 2:38 pm, Stoiko Ivanov wrote:
> a few things changed in systemd-boot upstream packages we use as
> for proxmox-boot-tool systems:
> * systemd-boot was split up further into systemd-boot-tools (we need
> `bootctl`) and `systemd-boot`(the meta-package which triggers
> updates
>
On Fri, 01 Aug 2025 14:36:00 +0200, Fiona Ebner wrote:
> A space between the sentences was missing, as well as the dot after
> the second sentence.
>
>
Applied, thanks!
[1/1] pve8to9: fix punctuation in message for legacy notification settings
commit: e9e4d2c3ed4b5c26e36946755ad9c2b8ea9c1
a few things changed in systemd-boot upstream packages we use as
for proxmox-boot-tool systems:
* systemd-boot was split up further into systemd-boot-tools (we need
`bootctl`) and `systemd-boot`(the meta-package which triggers
updates
* the ESPs updates now also run upon updates of shim(-signed
A space between the sentences was missing, as well as the dot after
the second sentence.
Signed-off-by: Fiona Ebner
---
PVE/CLI/pve8to9.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 834432b9..81129b85 100644
--- a/PVE/C
Those files get migrated with pve-network >= 0.9.9 - so we do not need
to observe them anymore via pmxcfs.
Signed-off-by: Stefan Hanreich
---
src/PVE/Cluster.pm | 2 --
src/pmxcfs/status.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index 938024
Check if there are any not-yet-migrated ipam / mac cache files in
pmxcfs. Those should have been migrated over in the pve-network
postinst, but if something went wrong during this process we can
explicitly notify users here again to avoid any unpleasant suprises
after the upgrade.
If all nodes are
With the upgrade to PVE 9, those files should have been successfully
migrated on all nodes, so we do not need to fallback on the old files
anymore.
Signed-off-by: Stefan Hanreich
---
src/PVE/Network/SDN/Ipams.pm | 30 +-
src/PVE/Network/SDN/Ipams/PVEPlugin.pm |
The IPAM and MAC DB files have been moved in PVE 8.3. Remove the fallback code
that handles that transitional state with PVE 9. Leave the pve-network
postinstall script for now and potentially replace it in PVE 10 with a script
that removes the legacy files. Even foolhardy users can then upgrade fr
This is for the pve-network repository. Sorry, seems like I haven't
configured the prefix for this in my git config yet.
Am 01.08.25 um 1:45 PM schrieb Fiona Ebner:
> This is a breaking API change intended for PVE 9.
>
> Signed-off-by: Fiona Ebner
> ---
>
> Together with [0] this makes sorting
This is a breaking API change intended for PVE 9.
Signed-off-by: Fiona Ebner
---
Together with [0] this makes sorting numerically by guest ID work in
the SDN IPAM UI.
[0]
https://lore.proxmox.com/pve-devel/2014f691-aa28-4ab4-91c1-48c1f68d8...@proxmox.com/T/
src/PVE/API2/Network/SDN/Ipams.pm
Lukas Wagner writes:
> Otherwise we leak the memory that was already allocated for `filename`.
>
> Signed-off-by: Lukas Wagner
> ---
> src/pmxcfs/status.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
> index a00e793..886d0bd 100644
> --- a
On Fri, 01 Aug 2025 11:13:36 +0200, Shannon Sterz wrote:
> the find command previously also found the already migrated rrd files
> under `pve-{vm,node,storage}-9.0` and reported them as needing to
> migrate them. the provided command to would of course not migrate them
> so the warning persisted ev
Am 01.08.25 um 11:45 schrieb Fiona Ebner:
> Am 01.08.25 um 11:27 AM schrieb Fiona Ebner:
>> Previously, sorting would not apply to the leaves of the tree.
>>
>> Signed-off-by: Fiona Ebner
>> ---
>> www/manager6/tree/DhcpTree.js | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/www/manag
Signed-off-by: Fiona Ebner
---
The stable-8 branch needs a 'make tidy' first for this to apply
cleanly.
PVE/CLI/pve8to9.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 4d61cd83..fe3964d1 100644
--- a/PVE/CLI/pve8to9.p
Am 01.08.25 um 10:37 schrieb Fabian Grünbichler:
> remove the dh_installinit call in d/rules, the existing patch was incomplete
>
For the record, this turned out to be unnecessary, it really was already
removed but now we also got the packages for Ceph Squid, which is our
baseline for PVE 9, also
Since commit 103068a ("api: create: default to unprivileged
containers"), creation defaults to unprivileged. Use the opportunity
to also describe the behavior when restoring.
Signed-off-by: Fiona Ebner
---
src/PVE/LXC/Config.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --g
The setting screen UI was previously defined in this repo. If a new app
settings needs to be added eg: privacy policy link, app version string.
The change had to be done in the package even though the change is not
package specific.
Inorder to fix that, move settings page to `pve_flutter_frontend`
The settings page UI was previously implemented in
proxmox_login_manager. A new screen has now been created with an added
route and removed the settings page from `proxmox_login_manager`.
This screen reuses the SSL toggle form from the
`proxmox_login_manager` package.
Signed-off-by: Shan Shaji
-
Note: This is POC PATCH
Since the primary responsibility of the login manager is to handle
login-related features, having the settings screen code defined within
the package causes unnecessary coupling. Whenever a new configuration
or app-related setting
(e.g., privacy policy URL, help link, a
This should be a tiny bit more efficient.
Signed-off-by: Lukas Wagner
---
src/pmxcfs/status.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index e438d9f..c8e072f 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status
Signed-off-by: Lukas Wagner
---
src/pmxcfs/status.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index c8e072f..e9e28bb 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -1431,7 +1431,7 @@ static void update_rrd_data
`filename_pve2` is not accessed anymore after assigning the copy to
`filename`, so we can simply 'transfer' the ownership to `filename`
and set `filenname_pve2` to NULL.
The call to `g_free(filename_pve2)` later can handle a NULL arg, it will
simply do nothing in this case.
Signed-off-by: Lukas W
Signed-off-by: Lukas Wagner
---
src/pmxcfs/status.c | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index 886d0bd..e438d9f 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -1374,14 +1374,12 @@ sta
Otherwise we leak the memory that was already allocated for `filename`.
Signed-off-by: Lukas Wagner
---
src/pmxcfs/status.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index a00e793..886d0bd 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/sta
Am 01.08.25 um 11:27 AM schrieb Fiona Ebner:
> Previously, sorting would not apply to the leaves of the tree.
>
> Signed-off-by: Fiona Ebner
> ---
> www/manager6/tree/DhcpTree.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/tree/DhcpTree.js b/www/manager6/tree/DhcpTree.
Thanks, this removes the warnings after upgrading on my systems.
Tested-by: Daniel Herzig
On 8/1/25 11:13, Shannon Sterz wrote:
the find command previously also found the already migrated rrd files
under `pve-{vm,node,storage}-9.0` and reported them as needing to
migrate them. the provided com
Gave this a quick spin, since I was just encountering this while
upgrading some nodes for testing. Running the pve8to9 script before
running the migration, the script reported some rrd files had not yet
been migrated, as expected. After migrating the files, as suggested by
the warning message, the
On Fri Aug 1, 2025 at 11:13 AM CEST, Shannon Sterz wrote:
> the find command previously also found the already migrated rrd files
> under `pve-{vm,node,storage}-9.0` and reported them as needing to
> migrate them. the provided command to would of course not migrate them
> so the warning persisted e
Previously, sorting would not apply to the leaves of the tree.
Signed-off-by: Fiona Ebner
---
www/manager6/tree/DhcpTree.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/tree/DhcpTree.js b/www/manager6/tree/DhcpTree.js
index 0088d708..40eb40bf 100644
--- a/www/manager6/tree/Dh
the find command previously also found the already migrated rrd files
under `pve-{vm,node,storage}-9.0` and reported them as needing to
migrate them. the provided command to would of course not migrate them
so the warning persisted even after the command was run.
limit the find command to the old
On August 1, 2025 10:54 am, Thomas Lamprecht wrote:
> On Fri, 01 Aug 2025 10:37:31 +0200, Fabian Grünbichler wrote:
>> remove the dh_installinit call in d/rules, the existing patch was incomplete
>>
>>
>
> Argh, I saw the maintscript being called and removing it and thought that
> should have don
On Fri, 01 Aug 2025 10:37:31 +0200, Fabian Grünbichler wrote:
> remove the dh_installinit call in d/rules, the existing patch was incomplete
>
>
Argh, I saw the maintscript being called and removing it and thought that
should have done it.. btw. do we need to increase that version for the
maintsc
Am 31.07.25 um 13:45 schrieb Fabian Grünbichler:
> in Trixie, systemd-boot got split into:
>
> systemd-boot: systemd integration and automatic installation of bootloader
> systemd-boot-tools: bootctl
> systemd-boot-efi(-XXX-signed): EFI binaries
>
> when managed using p-b-t, we only want the latt
On Fri, 01 Aug 2025 10:34:15 +0200, Lukas Wagner wrote:
> Storage metrics and node metrics use a nested directory structure, e.g.:
> pve-storage-9.0
> somenode
> local
> local-lvm
>
> The second level ('somenode') was not created correctly, leading to
> errors when trying to upda
remove the dh_installinit call in d/rules, the existing patch was incomplete
Signed-off-by: Fabian Grünbichler
---
...ip-legacy-init.d-ceph-script-anymore.patch | 31 ++-
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git
a/patches/0025-debian-do-not-ship-legacy-init.d
Storage metrics and node metrics use a nested directory structure, e.g.:
pve-storage-9.0
somenode
local
local-lvm
The second level ('somenode') was not created correctly, leading to
errors when trying to update the RRD database.
Signed-off-by: Lukas Wagner
---
src/pmxcfs/statu
Avoid that Perl auto-attaches the line number and file name.
Signed-off-by: Fiona Ebner
---
src/PVE/Storage.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index 761b979..1dde2b7 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.
On Fri Aug 1, 2025 at 9:35 AM CEST, Thomas Lamprecht wrote:
> Am 01.08.25 um 09:11 schrieb Daniel Kral:
>> Another even simpler version that we use in the function already (e.g.
>> right above for blockingHAResources) is to just fallback to an empty
>> array, i.e.
>>
>> let comigratedHAResources =
Am 01.08.25 um 09:11 schrieb Daniel Kral:
> Thanks for spotting that!
>
> On Fri Aug 1, 2025 at 8:38 AM CEST, Thomas Lamprecht wrote:
>> Am 31.07.25 um 17:58 schrieb Gabriel Goller:
>>> +console.warn(`failed to query /capabilites/qemu/migration
>>> on '${target}':`);
>>> +
On Thu, 31 Jul 2025 16:39:00 +0200, Christoph Heiss wrote:
> Avoids overriding parse_port_list(), making it a bit more clear where
> altnames are translated.
>
>
Applied, thanks!
[1/2] d/patches: translate bond-slaves altnames directly on attribute read
commit: 426bedc9380da6d7e3591cce565
Thanks for spotting that!
On Fri Aug 1, 2025 at 8:38 AM CEST, Thomas Lamprecht wrote:
> Am 31.07.25 um 17:58 schrieb Gabriel Goller:
>> +console.warn(`failed to query /capabilites/qemu/migration
>> on '${target}':`);
>> +console.warn(err);
>> }
>>
>>
85 matches
Mail list logo
