This broke running the TUI installer in debug mode, does not effect
release builds in any way.
Fixes: 4b4dfa1 ("low level: testmode: take path to disk image instead of using
/dev/null")
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/src/setup.rs | 2 +-
1 file changed, 1
.
With this, the mentioned tarballs [0] work out-of-the-box.
[0]
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.containerTarball.x86_64-linux
Signed-off-by: Christoph Heiss
---
src/PVE/LXC/Setup/NixOS.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/PVE/LXC/Setup/NixOS.pm b/src/PVE/LXC/Setup
The GTK installer/UI module in the low-level installer does the same.
Messages used with this are worded for this, using yes/no instead can be
quite confusing (e.g.
Proxmox::Install::ask_existing_vg_rename_or_abort())
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs
.
Will be reworked properly later on.
Signed-off-by: Christoph Heiss
---
Proxmox/UI/StdIO.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/Proxmox/UI/StdIO.pm b/Proxmox/UI/StdIO.pm
index 0ee6311..f734c0b 100644
--- a/Proxmox/UI/StdIO.pm
+++ b/Proxmox/UI/StdIO.pm
@@ -36,6 +36,7 @@ sub finished
Thanks!
On Fri, Nov 17, 2023 at 01:20:31PM +0100, Thomas Lamprecht wrote:
>
> Am 17/11/2023 um 13:12 schrieb Christoph Heiss:
> > Happens due to a force-unwrap() under the false assumption that the
> > disk for LVM configurations always exists when switching to a
: use correct defaults in advanced
dialog")
Reported-by: Christian Ebner
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/proxmox-tui-installer/src/views/bootdisk.rs
b/p
t;foo.bar.bar" as hostname/FQDN.
Fixes: a805423 ("run env: do not store emtpy hostname")
Signed-off-by: Christoph Heiss
---
Tested this with various possible settings for the `host-name` DHCP
option, also including e.g. if `host-name` is set to "" in the lease
(which
On Fri, Nov 17, 2023 at 06:37:08AM +0100, Thomas Lamprecht wrote:
>
> Am 16/11/2023 um 20:59 schrieb Stoiko Ivanov:
> > without this patch the hostname ends up as the empty string in
> > run-env-info.json, which results in a parse-error in the TUI code
> > (an empty string is not None, but still
While at it, convert it to a proper `View`-impl, instead of a functional
component.
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* moved separation of progress task function to separate patch
proxmox-tui-installer/src/main.rs |
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* new patch, separated out from patch #1
* use static member function instead of top-level function
.../src/views/install_progress.rs | 299 +-
1 file changed, 152 insertions(+),
This at least gives _some_ feedback to the user he can potentially
report or try to address, instead of a single, hardcoded message.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
.../src/views/install_progress.rs | 33 +--
1 file changed,
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* use static member function instead of top-level function
.../src/views/install_progress.rs | 42 ++-
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/proxmox-tui-instal
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* moved spawn_low_level_installer() to common crate
proxmox-installer-common/src/setup.rs | 22 -
.../src/views/install_progress.rs | 24 ++-
2 files changed,
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* use static member function instead of top-level function
.../src/views/install_progress.rs | 54 ++-
1 file changed, 29 insertions(+), 25 deletions(-)
diff --git a/proxmox-tui-instal
The GUI installer already has the same functionality, with this the TUI
installer gains the same. It is a nice touch anyway, primarily to
indicate to the user that the installer is not frozen or similar.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
proxmox-low-le
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
proxmox-low-level-installer | 45 +++--
1 file changed, 18 insertions(+), 27 deletions(-)
diff --git a/proxmox-low-level-installer b/proxmox-low-level-installer
index 0f2bf4f..b8269d7 100
tch its GUI counterpart.
v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058510.html
Notable changes v1 -> v2:
* rebased on latest master
* added patch #2, split out from #1
Christoph Heiss (8):
tui: move install progress dialog into own view module
tui: install_progress
.. in exactly the same way GUI and TUI installer do, streamlining them.
Up until now, testing the TUI installer often involved hand-editing the
`run-env-info.json` to put some proper disk sizes > 0 in place. This
makes this process a lot easier.
Signed-off-by: Christoph Heiss
---
v1: ht
sed series on latest master
Changes v2 -> v3:
* rebased series on latest master
* dropped patch #2, which was obsoleted by other changes
Christoph Heiss (2):
tui: bootdisk: refactor Rc> type into custom type
fix #4856: tui: bootdisk: use correct defaults in advanced dialog
pr
ZFS RAID should be kept with all parameters
* etc ..
Further I also verified that the correct disk size(s) get written into
the setup structure for the low-level installer.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 162 ++--
1 file chan
Will be used/passed around quite a lot of times due to future changes,
so simplify it a bit.
No functional changes.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/proxmox-tui
On Tue, Nov 07, 2023 at 04:50:31PM +0100, Thomas Lamprecht wrote:
>
> Am 07/11/2023 um 13:20 schrieb Christoph Heiss:
> > run env: remove debug print
> > install: use correct variable names in zfs_setup_module_conf()
> > proxinstall: expose `arc_max` ZFS opti
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs| 2 +-
proxmox-tui-installer/src/options.rs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
index 2e5a194..82ae1bb 100644
Signed-off-by: Christoph Heiss
---
Makefile| 3 ++
debian/control | 1 +
test/Makefile | 10 ++
test/zfs-arc-max.pl | 81 +
4 files changed, 95 insertions(+)
create mode 100644 test/Makefile
create mode 100755 test/zfs
To set the maximum value for arc_max accordingly, simply pass down
`RuntimeInfo` directly instead of the disks array to the views.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 2 +-
proxmox-tui-installer/src/views/bootdisk.rs | 68
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/src/options.rs | 62 +++--
proxmox-installer-common/src/setup.rs | 2 +
proxmox-tui-installer/src/views/bootdisk.rs | 18 --
3 files changed, 71 insertions(+), 11 deletions(-)
diff --git a/proxmox
dropped already applied patches from series
* added new patch to drop debug print
* added new patch fixing zfs_arc_max modprobe setting
Christoph Heiss (6):
run env: remove debug print
install: use correct variable names in zfs_setup_module_conf()
proxinstall: expose `arc_max` ZFS option for P
Signed-off-by: Christoph Heiss
---
proxinstall | 15 +++
1 file changed, 15 insertions(+)
diff --git a/proxinstall b/proxinstall
index 113bf37..857281d 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1162,6 +1162,21 @@ my $create_raid_advanced_grid = sub {
$spinbutton_copies
That's what happens when you do some last-minute variable renaming and
trust that nothing broke ..
Fixes: 42aa2fa ("fix #4829: install: add new ZFS `arc_max` setup option")
Signed-off-by: Christoph Heiss
---
Proxmox/Install.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
Signed-off-by: Christoph Heiss
---
Proxmox/Install/RunEnv.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm
index 9116397..5f68d82 100644
--- a/Proxmox/Install/RunEnv.pm
+++ b/Proxmox/Install/RunEnv.pm
@@ -319,7 +319,6 @@ sub
First patch is just a mechanical rustfmt, which I apparently missed to
check during review - that's on me. Second patch fixes a longer-standing
clippy warning.
Christoph Heiss (2):
tui, common: run rustfmt
tui: fix clippy warning
proxmox-installer-common/src/setup.rs | 1
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
index 3216868..2e5a194 100644
--- a/proxmox-tui-installer/src/main.rs
+++ b/proxmox-tui
While at it, move rustfmt.toml to the repo root, to share it with the
other crate.
Signed-off-by: Christoph Heiss
---
proxmox-installer-common/src/setup.rs | 1 -
proxmox-tui-installer/src/options.rs | 12 ++--
proxmox-tui-installer/src/setup.rs
To set the maximum value for arc_max accordingly, simply pass down
`RuntimeInfo` directly instead of the disks array to the views.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* fix ZFS_ARC_MIN_SIZE to be MiB rather than bytes
Changes v2 -> v3:
* renamed `ZFS_ARC_MI
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
Changes v2 -> v3:
* no changes
proxinstall | 15 +++
1 file changed, 15 insertions(+)
diff --git a/proxinstall b/proxinstall
index 64c8bab..f1a3c02 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1162,6 +1
Most of the churn here is due to changing the inner view from an
`EditView` to a `LinearLayout`. Also prompted the introduction of two
small helpers .inner() and .inner_mut() to simplify things everywhere
else in the view.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no chan
This is mainly to explicitly document the unit of its return value.
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* new patch
Proxmox/Install/RunEnv.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* updated comment for ZfsBootdiskOptions::defaults_from() accordingly
Changes v2 -> v2:
* documented the unit of the return value of default_zfs_arc_max()
proxmox-tui-installer/src/options.rs| 57 +++--
p
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
Changes v2 -> v3:
* no changes
Makefile| 3 ++
debian/control | 1 +
test/Makefile | 10 ++
test/zfs-arc-max.pl | 81 +
4 files changed, 95 inse
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* no changes
Changes v2 -> v3:
* better documented calculation and renamed some variables to reflect
its unit (thanks Thomas!)
* moved modprobe config setup into separate sub
Proxmox/Install.pm| 14
P
No functional changes.
Signed-off-by: Christoph Heiss
---
Changes v2 -> v3:
* new patch
proxmox-tui-installer/src/views/bootdisk.rs | 50 -
1 file changed, 29 insertions(+), 21 deletions(-)
diff --git a/proxmox-tui-installer/src/views/bootdisk.rs
b/proxmox-tui-instal
sed on latest master
* new patch explaining query_total_memory, which is used extensively
in this patchset
* new patch unifying product handling a bit
* documented all calculations better w.r.t. to their units
* moved modprobe setup into separate sub
Christoph Heiss (8):
Signed-off-by: Christoph Heiss
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 111fe4b..e792e0e 100644
--- a/Makefile
+++ b/Makefile
@@ -43,6 +43,7 @@ $(BUILDDIR):
proxinstall \
proxmox-low-level-installer \
proxmox-tui
ick follow-up
patch for that, so you don't have to necessarily re-spin the whole
series just for a single, trivial line.
LGTM; thus please consider the whole series:
Reviewed-by: Christoph Heiss
Tested-by: Christoph Heiss
On Wed, Oct 25, 2023 at 05:59:59PM +0200, Aaron Lauterer wrote:
>
Simple code move/copy, so LGTM.
Reviewed-by: Christoph Heiss
On Wed, Oct 25, 2023 at 06:00:01PM +0200, Aaron Lauterer wrote:
>
> Copy code that is common to its own crate.
>
> Signed-off-by: Aaron Lauterer
> ---
> proxmox-installer-common/Cargo.toml | 2 +
&g
Could be squased into the previous patch IMO if you do send a v2, but
not a blocker either for me if not.
In any case:
Reviewed-by: Christoph Heiss
On Wed, Oct 25, 2023 at 06:00:11PM +0200, Aaron Lauterer wrote:
>
> Signed-off-by: Aaron Lauterer
> ---
> proxmox-tui-installer/
The .deb fails to build with this patch applied,
`proxmox-installer-common/` must also be copied to the build directory
(see `$(BUILDIR)` target in the Makefile).
On Wed, Oct 25, 2023 at 06:00:00PM +0200, Aaron Lauterer wrote:
>
> It will be used for code shared among the different crates in
On Wed, Oct 25, 2023 at 07:09:00PM +0200, Thomas Lamprecht wrote:
>
> Am 25/10/2023 um 10:28 schrieb Christoph Heiss:
> > On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel
> > wrote:
> >
> > Currently, this isn't planned, although -
This aligns it with the other constructors for options struct by
introducing a `::defaults_from()` function.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs| 15 +++---
proxmox-tui-installer/src/options.rs | 75 +---
proxmox-tui-installer/src
Enables the advanced and LVM dialog to determine what options (max
root/data size and Btrfs RAIDs) by itself, without needing to resort to
the global `setup_info()` function.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 74 ++---
1 file
by Aaron for pulling out non-TUI-related code into a
separate, shared crate.
No functional changes overall.
v1: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059335.html
Changes v1 -> v2:
* Rebased on latest master, no actual changes otherwise
Christoph Heiss (3):
tui: refac
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
index a342a08..81fe3ca 100644
--- a/proxmox-tui-installer/src
On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel wrote:
> Date: Tue, 24 Oct 2023 08:59:36 -0300
> From: Gilberto Ferreira
> To: Proxmox VE development discussion
> Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add
> new ZFS `arc_max` setup
Thanks for the review!
I will refactor all the points mentioned and send a v2 soon.
On Tue, Oct 24, 2023 at 05:05:15PM +0200, Thomas Lamprecht wrote:
>
> Am 24/10/2023 um 13:55 schrieb Christoph Heiss:
> > Signed-off-by: Christoph Heiss
> > ---
> > Changes v1 -
To set the maximum value for arc_max accordingly, simply pass down
`RuntimeInfo` directly instead of the disks array to the views.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* Fix ZFS_ARC_MIN_SIZE to be MiB rather than bytes
proxmox-tui-installer/src/main.rs |
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* No changes
Makefile| 3 ++
debian/control | 1 +
test/Makefile | 10 ++
test/zfs-arc-max.pl | 81 +
4 files changed, 95 insertions(+)
create mode 100644 t
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* No changes
proxinstall | 15 +++
1 file changed, 15 insertions(+)
diff --git a/proxinstall b/proxinstall
index 64c8bab..f1a3c02 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1162,6 +1162,21 @@ my $create_raid_advanced_g
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* Updated comment for ZfsBootdiskOptions::defaults_from() accordingly
proxmox-tui-installer/src/options.rs| 52 +++--
proxmox-tui-installer/src/setup.rs | 2 +
proxmox-tui-installer/src/views/bootdisk
Most of the churn here is due to changing the inner view from an
`EditView` to a `LinearLayout`. Also prompted the introduction of two
small helpers .inner() and .inner_mut() to simplify things everywhere
else in the view.
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* No chan
el/2023-August/058830.html
Notable changes v1 -> v2:
* Rebased on latest master
* Fix arc_max value set in TUI not being applied correctly
Christoph Heiss (6):
fix #4829: install: add new ZFS `arc_max` setup option
fix #4829: proxinstall: expose new `arc_max` ZFS option for PVE
in
Signed-off-by: Christoph Heiss
---
Changes v1 -> v2:
* No changes
Proxmox/Install.pm| 4
Proxmox/Install/Config.pm | 1 +
Proxmox/Install/RunEnv.pm | 38 ++
3 files changed, 43 insertions(+)
diff --git a/Proxmox/Install.pm b/Prox
On Fri, Oct 20, 2023 at 05:21:41PM +0200, Thomas Lamprecht wrote:
>
> Am 20/10/2023 um 11:46 schrieb Christoph Heiss:
> > DHCP servers can set option 12 ("host-name") for client leases [0],
> > telling them about their hostname. It's very much non-invasive and f
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/options.rs | 110 ++-
proxmox-tui-installer/src/utils.rs | 2 +-
2 files changed, 110 insertions(+), 2 deletions(-)
diff --git a/proxmox-tui-installer/src/options.rs
b/proxmox-tui-installer/src/options.rs
This now tries to use the hostname from the DHCP lease if it was set,
falling back to the product name as before.
Signed-off-by: Christoph Heiss
---
proxinstall | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/proxinstall b/proxinstall
index 88f194f..4d61fa7 100755
ery useful feature too have.
I have tested this with the "host-name" entry set and unset, as well as
any combinations of that with the domain name being set or unset.
[0] https://datatracker.ietf.org/doc/html/rfc2132#section-3.14
Christoph Heiss (5):
net: move hostname/fqdn regexes in
Signed-off-by: Christoph Heiss
---
Proxmox/Install/RunEnv.pm | 4
Proxmox/Sys/Net.pm| 25 +
2 files changed, 29 insertions(+)
diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm
index 19b5387..7589679 100644
--- a/Proxmox/Install/RunEnv.pm
This now tries to use the hostname from the DHCP lease if it was set,
falling back to the product name as before.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/options.rs | 22 +++---
proxmox-tui-installer/src/setup.rs | 3 +++
2 files changed, 18 insertions
Such that they can be re-used by other parts.
No functional changes.
Signed-off-by: Christoph Heiss
---
Proxmox/Sys/Net.pm | 3 +++
proxinstall| 9 +
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Proxmox/Sys/Net.pm b/Proxmox/Sys/Net.pm
index ba368c1..f5a9885
Ping, still applies.
On Wed, Jun 07, 2023 at 04:15:11PM +0200, Christoph Heiss wrote:
>
> This allows to use `pvesh` on endpoints like /nodes/{node}/journal,
> which return streamed (and possibly gzip'd) responses.
>
> Currently, e.g. `pvesh get /nodes/localhost/journal -
When debugging or otherwise deliberately running the `dump-env`
low-level installer command in test mode, chances are that you'd want
the run env file to be re-created as well.
No impact on the normal installation flow.
Signed-off-by: Christoph Heiss
---
Noticed over time that I have to run
`rm
See inline comments. Also, `cargo fmt` please :^)
On Thu, Oct 12, 2023 at 03:02:08PM +0200, Filip Schauer wrote:
> [..]
> diff --git a/proxinstall b/proxinstall
> index d5b2565..51170cd 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -347,7 +347,9 @@ sub create_ipconf_view {
>
> my
Ping - still applies cleanly on current master of both repositories.
On Wed, Jul 05, 2023 at 01:12:44PM +0200, Christoph Heiss wrote:
>
> This implements #2435 [0]. Show the unprivileged status in the summary
> panel, the distro logo and name in the title of the summary panel.
>
&
On Tue, Oct 10, 2023 at 01:55:43PM +0200, Thomas Lamprecht wrote:
>
> Am 10/10/2023 um 13:33 schrieb Christoph Heiss:
> > On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote:
> >> @@ -347,7 +347,7 @@ sub create_ipconf_view {
> >>
> >> my $ge
Needs to be done for the TUI installer as well. Easiest way here is to
add `state` to each interface in Proxmox::Sys::RunEnv::query_netdevs(),
then deserialize that in `setup::Interface`.
Looking at it, adding the MAC address there too would be great, if you
are already at it.
On Fri, Aug 04,
This aligns it with the other constructors for options struct by
introducing a `::defaults_from()` function.
No functional changes.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs| 15 ++--
proxmox-tui-installer/src/options.rs | 36
No functional changes.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
index ea8c8d9..49f378b 100644
by Aaron for pulling out non-TUI-related code into a
separate, shared crate.
No functional changes overall.
Christoph Heiss (3):
tui: refactor `NetworkOptions` to have a `defaults_from()` function
tui: bootdisk: pass down product info to advanced dialog
tui: remove obsolete, global `SetupInfo
Enables the advanced and LVM dialog to determine what options (max
root/data size and Btrfs RAIDs) by itself, without needing to resort to
the global `setup_info()` function.
No functional changes.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 74
Mostly internal changes without any user-visible changes; replaces all
optional return values in form with result that can hold more specific
error causes.
Signed-off-by: Christoph Heiss
---
RFC; just a thought: It could make sense to introduce the `anyhow` crate
here in the installer as well
ted.
The same can be done for the GUI installer of course, but I didn't want
to include in this series to avoid it being larger-than-necessary.
series.
Christoph Heiss (7):
tui: fix setting content when using the `DiskSizeEditView` builder
tui: improve `FormView` error handling
tui: add optio
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 35 ++
proxmox-tui-installer/src/options.rs| 2 +-
proxmox-tui-installer/src/views/mod.rs | 127 +++-
proxmox-tui-installer/src/views/timezone.rs | 109 +
4 files
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/proxmox-tui-installer/src/views/bootdisk.rs
b/proxmox-tui-installer/src/views/bootdisk.rs
index bb421a1..66d909c 100644
--- a/proxmox-tui
Previously, it would throw away all other settings (like `max_value`),
if a construct like
DiskSizeEditView::new().max_value(8.0).content(8.0)
was used, due to simply replacing the inner view.
Instead, modify the inner view.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/proxmox-tui-installer/src/views/bootdisk.rs
b/proxmox-tui-installer/src/views/bootdisk.rs
index 8b5b5d2..bb421a1 100644
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/mod.rs | 46 ++
1 file changed, 39 insertions(+), 7 deletions(-)
diff --git a/proxmox-tui-installer/src/views/mod.rs
b/proxmox-tui-installer/src/views/mod.rs
index 7efd487..0fe715e 100644
--- a/proxmox
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/views/bootdisk.rs | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/proxmox-tui-installer/src/views/bootdisk.rs
b/proxmox-tui-installer/src/views/bootdisk.rs
index 46bdd9f..8b5b5d2 100644
.. in exactly the same way `proxinstall` does, streamlining them both.
Up until now, testing the TUI installer often involved hand-editing the
`run-env-info.json` to put some proper disk sizes > 0 in place. This
makes this process just a lot easier.
Signed-off-by: Christoph Heiss
---
Makef
Ping.
While it does not apply cleanly on current master anymore, I'd like to
collect some general feedback on the approach before rebasing +
resending w/o any actual changes.
On Thu, May 11, 2023 at 11:46:18AM +0200, Christoph Heiss wrote:
>
> For nodes, VMs and CTs we can show the user
PBS backup, as well as migrating both container.
Signed-off-by: Christoph Heiss
---
v1: https://lists.proxmox.com/pipermail/pve-devel/2023-February/055949.html
Changes since v1:
* Moved detect_architecture() to PVE::LXC::Tools to avoid a cyclic
include
* Properly log/report errors from
On Thu, Sep 21, 2023 at 01:30:33PM +0200, Thomas Lamprecht wrote:
>
> Am 21/09/2023 um 13:16 schrieb Christoph Heiss:
[..]
> > Sending simple JSON-formatted logs to an HTTP endpoint or even using
> > the rsyslog protocol come to mind and would be a good solution for
&
We do actually want the block size if it is integer - currently, it is
always set to `undef` (and then `null` in the serialized JSON).
Fixes: 15b2cd7 ("sys: block: fix possible use of `undef`-value when detecting
disk sizes")
Signed-off-by: Christoph Heiss
---
Proxmox/Sys/Block.pm
Some general notes:
- The overall approach seems fine too me. Did some cursory testing too,
worked fine - although I did not really test out the
filtering/matching much.
- Probably just due to it being still a bit early, but all these
`.unwrap()/.expect()` should be replaced with proper
Even if the installer is run in release mode, the test-mode flag should
be honored on whether to start a test-installation or not.
The test mode is always forced on in debug builds, so the cfg()
conditionals can be dropped.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs
I think this can be part of the auto-installer itself, instead of
introducing another shell script somewhere. While yes, "do one thing and
do it well", its a rather small part and not unreasonable to move it
directly into the auto-installer.
Or have a separate Rust-written executable for this,
On Wed, Aug 23, 2023 at 10:31:29AM +0200, Wolfgang Bumiller wrote:
>
> On Wed, Aug 09, 2023 at 03:44:24PM +0200, Christoph Heiss wrote:
> > [..]
> > diff --git a/Proxmox/Sys/Block.pm b/Proxmox/Sys/Block.pm
> > index 26085e3..f76e0f1 100644
> > --- a/Proxmox/Sys/
Thanks for the review!
On Mon, Aug 21, 2023 at 02:50:28PM +0200, Fiona Ebner wrote:
>
> Am 28.02.23 um 11:59 schrieb Christoph Heiss:
> > diff --git a/src/PVE/LXC/Setup.pm b/src/PVE/LXC/Setup.pm
> > index 891231f..4346c5e 100644
> > --- a/src/PVE/LXC/Setup.pm
> &
Signed-off-by: Christoph Heiss
---
Makefile| 3 ++
debian/control | 1 +
test/Makefile | 10 ++
test/zfs-arc-max.pl | 81 +
4 files changed, 95 insertions(+)
create mode 100644 test/Makefile
create mode 100755 test/zfs
BS and PMG. For PVE, checked that the `zfs`
module option gets correctly written & applied, the latter by looking at
the output of `arc_summary`. For PBS and PMG, verified that no modprobe
options file is created and the ARC size is set to default.
Christoph Heiss (6):
fix #4829: instal
To set the maximum value for arc_max accordingly, simply pass down
`RuntimeInfo` directly instead of the disks array to the views - which
accounts for about half the churn here.
Signed-off-by: Christoph Heiss
---
proxmox-tui-installer/src/main.rs | 2 +-
proxmox-tui-installer/src
Signed-off-by: Christoph Heiss
---
Proxmox/Install.pm| 4
Proxmox/Install/Config.pm | 1 +
Proxmox/Install/RunEnv.pm | 38 ++
3 files changed, 43 insertions(+)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 1c4811d..d23a04b 100644
301 - 400 of 585 matches
Mail list logo
