Dots are allow in PVE VM names, so they should not be dropped during import.
Signed-off-by: Dominic Jäger
---
PVE/QemuServer/OVF.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm
index c76c199..0376cbf 100644
--- a/PVE
We assume that users want update notifications for production systems.
Those systems should also have an active subscription.
Signed-off-by: Dominic Jäger
---
v2: new
PVE/API2/APT.pm | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2
Default value like pveupdate: Assume users with subscriptions want
notifications
Signed-off-by: Dominic Jäger
---
v2: default depends on subscription status
www/manager6/dc/OptionView.js | 37 +++
1 file changed, 37 insertions(+)
diff --git a/www/manager6/dc
When opened for the first time (undefined value in datacenter.cfg) we should
allow setting both options yes and no for the package_update checkbox.
Signed-off-by: Dominic Jäger
---
v2: new
www/manager6/dc/OptionView.js | 11 +++
1 file changed, 11 insertions(+)
diff --git a/www
Users may want turn off update notifications.
Depends on pve-cluster patch.
Signed-off-by: Dominic Jäger
---
v2: Keep defaults. I hope that I understood the idea correctly.
bin/pveupdate | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/bin/pveupdate b/bin
Permits controlling email notifications about package updates.
Use property string for extensibility to more notification types.
Signed-off-by: Dominic Jäger
---
v2: Use property string
data/PVE/DataCenterConfig.pm | 24
1 file changed, 24 insertions(+)
diff --git a
Similar to notes for nodes.
datacenter.cfg normally uses key-value pairs defined in the schema.
We bypass this to allow potentially long comments at the top.
Signed-off-by: Dominic Jäger
---
data/PVE/DataCenterConfig.pm | 34 +-
1 file changed, 33 insertions
Like notes for nodes.
Signed-off-by: Dominic Jäger
---
Depends on the pve-cluster patch.
www/manager6/dc/Config.js | 6
www/manager6/panel/NotesView.js | 49 +
2 files changed, 32 insertions(+), 23 deletions(-)
diff --git a/www/manager6/dc/Config.js
Signed-off-by: Dominic Jäger
Here two inputpanels
1. diskData with volid, storage...
2. diskBasicOptions with the checkboxes
are on the first tab. This required the least changes to get a working version
so that we can quickly get on the same page about what we want it to look like.
I can also
On Fri, Jun 18, 2021 at 06:31:51PM +0200, Thomas Lamprecht wrote:
> On 21.05.21 12:44, Dominic Jäger wrote:
> > Users are repeatedly left with entries in Disks->Directory, most recently
> > https://forum.proxmox.com/threads/how-to-remove-local-directory-storage-properly.89504/
&
Enable adding multiple disks in VM create wizard.
This is a first step for future import features.
Split disk edit panel into multiple tabbed panels to make it less cluttered.
This affects the create wizard & the HD edit windows in the VM hardware view.
Signed-off-by: Dominic Jäger
---
{
> + xtype: 'proxmoxcheckbox',
> + name: 'verify-certificates',
> + fieldLabel: gettext('Verify certificates'),
> + uncheckedValue: 0,
> +
-1.iso"; modification-date="Tue, 27 Apr 2021 15:25:15 +0200";
> size=928993280;
and it gets directly into the GUI like that.
It did work for a Debian image.
https://cdimage.debian.org/debian-cd/current/amd64/iso-dvd/debian-10.9.0-amd64-DVD-1.iso
Tested-by: Dominic Jäger
___
Extend qm importdisk/importovf functionality to the API.
Co-authored-by: Fabian Grünbichler
Signed-off-by: Dominic Jäger
---
v9: unchanged
PVE/API2/Qemu.pm | 175 +++--
PVE/API2/Qemu/Makefile | 2 +-
PVE/API2/Qemu/OVF.pm | 68
Add GUI wizard to import whole VMs and a window to import single disks in
Hardware View.
Signed-off-by: Dominic Jäger
---
v9: Use Tabpanel instead of Advanced Checkbox for disk options
PVE/API2/Nodes.pm| 7 +
www/manager6/Makefile| 4 +
www
Users are repeatedly left with entries in Disks->Directory, most recently
https://forum.proxmox.com/threads/how-to-remove-local-directory-storage-properly.89504/
Signed-off-by: Dominic Jäger
---
pve-storage-dir.adoc | 13 +
1 file changed, 13 insertions(+)
diff --git a/pve-stor
Signed-off-by: Dominic Jäger
---
www/manager6/panel/ConfigPanel.js | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/www/manager6/panel/ConfigPanel.js
b/www/manager6/panel/ConfigPanel.js
index 23a6ee58..788615aa 100644
--- a/www/manager6/panel/ConfigPanel.js
Signed-off-by: Dominic Jäger
---
www/manager6/panel/IPSet.js | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index 303e518a..94117789 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
Signed-off-by: Dominic Jäger
---
www/manager6/panel/RunningChart.js | 43 +++---
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/www/manager6/panel/RunningChart.js
b/www/manager6/panel/RunningChart.js
index ab4c9039..19db8b50 100644
--- a/www/manager6
Signed-off-by: Dominic Jäger
---
www/manager6/panel/StatusPanel.js | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/www/manager6/panel/StatusPanel.js
b/www/manager6/panel/StatusPanel.js
index f7bb4a91..f9e3537b 100644
--- a/www/manager6/panel/StatusPanel.js
+++ b
Signed-off-by: Dominic Jäger
---
www/manager6/panel/NotesView.js | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/panel/NotesView.js b/www/manager6/panel/NotesView.js
index 18dd8876..a40cb7d5 100644
--- a/www/manager6/panel/NotesView.js
+++ b/www/manager6
Signed-off-by: Dominic Jäger
---
www/manager6/storage/PBSEdit.js | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
index 2479304a..773d41e8 100644
--- a/www/manager6/storage/PBSEdit.js
+++ b/www
Signed-off-by: Dominic Jäger
---
These 2 patches fix the remaining errors for manager6/qemu and manager6/storage
(manager6/lxc is already OK)
www/manager6/qemu/CmdMenu.js | 2 +-
www/manager6/qemu/PCIEdit.js | 7 +--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/www
Function syntax, raw words, string templates, no prototype builtins
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/MPResize.js | 5 -
www/manager6/qemu/HDResize.js | 4
www/manager6/qemu/OSDefaults.js | 2 +-
www/manager6/storage/Base.js | 2 +-
www/manager6/storage
Reduce eslint problems in qemu/lxc/storage to 3 Errors and 2 Warnings.
Those are a little trickier, I'll fix them tomorrow.
I clicked through a couple of wizards to test, but not yet every single
possible window.
Dominic Jäger (6):
Fix usage of 'me'
No unused or dupl
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/MPEdit.js | 6 ++---
www/manager6/qemu/AgentIPView.js | 4 +--
www/manager6/qemu/CloudInit.js | 44
www/manager6/qemu/DisplayEdit.js | 4 +--
www/manager6/qemu/SSHKey.js | 4 +--
www/manager6/qemu
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/DNS.js| 2 +-
www/manager6/qemu/CloudInit.js | 2 +-
www/manager6/qemu/USBEdit.js | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/lxc/DNS.js b/www/manager6/lxc/DNS.js
index f277370c..6c519023 100644
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/CreateWizard.js | 1 -
www/manager6/lxc/DNS.js | 5 ++---
www/manager6/lxc/Options.js | 5 ++---
www/manager6/lxc/Resources.js| 2 +-
www/manager6/qemu/AgentIPView.js | 1 -
www/manager6/qemu/HDEdit.js
Signed-off-by: Dominic Jäger
---
www/manager6/storage/GlusterFsEdit.js | 1 +
www/manager6/storage/IScsiEdit.js | 1 +
www/manager6/storage/LvmThinEdit.js | 1 +
www/manager6/storage/NFSEdit.js | 1 +
www/manager6/storage/StatusView.js| 2 +-
5 files changed, 5 insertions(+), 1
Signed-off-by: Dominic Jäger
---
www/manager6/lxc/FeaturesEdit.js | 2 +-
www/manager6/lxc/Resources.js | 2 +-
www/manager6/qemu/AgentIPView.js | 4 ++--
www/manager6/qemu/BootOrderEdit.js | 4 ++--
www/manager6/qemu/OSTypeEdit.js| 2 +-
www/manager6/qemu/RNGEdit.js | 2
alled? (500)
but the precise package name would make it even more helpful for me.
> proxmox-backup-file-restore
Today I also tried around with existing options of restoring data with the
backup client (CLI).
And even with the previous concerns, I think that in comparison to those CLI
possibilities this
new feature makes exploring & restoring really, really convenient.
Tested-by: Dominic Jäger
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
VLANs with a name like vmbr0v5 had type UNKNOWN unless vlan-raw-device was set.
This way we return type VLAN for them as we do for vmbr0.5
Signed-off-by: Dominic Jäger
---
src/PVE/INotify.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/INotify.pm b/src/PVE
Set the VLAN raw device and VLAN ID fields in the GUI correctly when
VLANs are specified with 'v' instead of a dot, vmbr0v5 for example.
Signed-off-by: Dominic Jäger
---
src/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Utils.js b/src/Utils.js
ind
Needs a rebase since the rbd patches
On Fri, Apr 02, 2021 at 12:19:19PM +0200, Aaron Lauterer wrote:
> +sub reassign_volume {
> +my ($class, $scfg, $storeid, $volname, $target_vmid) = @_;
> +
> +my $base;;
> +(undef, $volname, undef, $base) = $class->parse_volname($volname);
> +
> +
Add GUI wizard to import whole VMs and a window to import single disks in
Hardware View.
Signed-off-by: Dominic Jäger
---
v8:
- Adapt to new API
- Some small fixes
- Much renaming
PVE/API2/Nodes.pm | 7 +
www/manager6/Makefile | 2 +
www/manager6
Extend qm importdisk/importovf functionality to the API.
Co-authored-by: Fabian Grünbichler
Signed-off-by: Dominic Jäger
---
v8:
- Fabian moved the import functions into the existing create_vm / update_vm_api
- Dropped the separate API endpoints & import lock
PVE/API2/Qemu.pm |
On Wed, Apr 07, 2021 at 10:51:43AM +0200, Thomas Lamprecht wrote:
> On 07.04.21 10:30, Dominic Jäger wrote:
> > -# We assume that users with subscriptions want informations
> > -# about new packages.
> > -my $notify = ($info && $info->{status} eq 'Activ
This way all users, including subscription users, can decide if they want to
receive notifications mails from pveupdate or not. Disabling notifications is
desirable if available updates are monitored externally, for example.
Signed-off-by: Dominic Jäger
---
bin/pveupdate | 4
To store user preference for if they want to receive notifications from
pveupdate or not.
Signed-off-by: Dominic Jäger
---
data/PVE/DataCenterConfig.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/data/PVE/DataCenterConfig.pm b/data/PVE/DataCenterConfig.pm
index 24ebf3f..d20292f
connection to the migrating guest broke (OK, I guess) but after
reconnecting the old flow entries were still there? Shouldn't they vanish?
With the new option
> qm migrate 150 pveA --online --migrate-conntracks
the SSH connection to the guest sometimes
On Wed, Mar 31, 2021 at 05:12:28PM +0200, Fabian Grünbichler wrote:
> this is starting to shape up nicely. as promised, I now took a stab at
> (roughly!) integrating this into our regular flow (see diff below):
>
>
> - we could likely drop the separate import_disk API call, and let the
>
This is required to import from LVM storages, for example
Signed-off-by: Dominic Jäger
---
v6->v7: Feedback Fabian G
- Variables with _ instead of camelCase
- single if instead of if/else
PVE/Storage.pm | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/
Extend qm importdisk/importovf functionality to the API.
Signed-off-by: Dominic Jäger
---
v6->v7: Feedback by Fabian G
- Introduce a regex for the import syntax :0
- Use parameter list instead of hash for import helper
- More parsing, less string magic
- More VM config digest checking
- Cre
Add GUI wizard to import whole VMs and a window to import single disks in
Hardware View.
Signed-off-by: Dominic Jäger
---
v6->v7:
- Update to API changes
- Add helpers to Utils
- Whitespace & line breaks according to style guide
- Making conditional branches in HDEdit easier to read
P
lvm with backups of
- a Debian VM and
- a Windows VM
--Tested-by: Dominic Jäger
Possible nice-to-haves for the future:
- Notice if a storage gets full. In the good case only the restore process
freezes. When choosing local, functions like removing VMs start to fail.
- editing the VM configura
Add GUI wizard to import whole VMs and a window to import single disks in
Hardware View.
Signed-off-by: Dominic Jäger
---
v5->v6:
Rebase
Move readovf to qemu-server
PVE/API2/Nodes.pm | 7 +
www/manager6/Makefile | 2 +
www/manager6/Workspace
This is required to import from LVM storages
Signed-off-by: Dominic Jäger
---
v5->v6: unchanged
PVE/Storage.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index 8ee2c92..7c2e24e 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage
Extend qm importdisk/importovf functionality to the API.
Signed-off-by: Dominic Jäger
---
v5->v6:
More parsing
Fix regex
Improve --boot handling
Move readovf from manager to qemu-server (like CPU)
Create properties helper for readovf return values
PVE/API2/Qemu.pm |
On Wed, Feb 10, 2021 at 10:49:41AM +0100, Fabian Grünbichler wrote:
> >
> > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> > index 8172231e..9bf75ab7 100644
> > --- a/PVE/API2/Nodes.pm
> > +++ b/PVE/API2/Nodes.pm
> > @@ -27,6 +27,7 @@ use PVE::HA::Env::PVE2;
> > use PVE::HA::Config;
> > us
Extend qm importdisk/importovf functionality to the API.
Signed-off-by: Dominic Jäger
---
v4->v5: Feedback by Fabian Grünbichler
Use more existing helpers, parse more, change signature of import helper
function, more detailed errors esp. for API, ...
Remaining todo: Some error cases st
Add GUI wizard to import whole VMs and a window to import single disks in
Hardware View.
Signed-off-by: Dominic Jäger
---
v4->v5: unchanged
Remaining todo: Refactor
PVE/API2/Nodes.pm | 40 +++
www/manager6/Makefile | 2 +
www/manager6/Workspace
This is required to import from LVM storages
Signed-off-by: Dominic Jäger
---
v4->v5: New
PVE/Storage.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index 8ee2c92..7c2e24e 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage
On Fri, Feb 12, 2021 at 10:03:50AM +0100, Fabian Grünbichler wrote:
> >> > +my $store_conf = PVE::Storage::config();
> >>
> >> it probably makes sense to pass this in as parameter, all call sites
> >> probably have it already ;)
> >
> > I just noticed that I have it in importdisk, but unused
Thank you for looking so carefully!
On Wed, Feb 10, 2021 at 10:40:56AM +0100, Fabian Grünbichler wrote:
>
> On February 5, 2021 11:04 am, Dominic Jäger wrote:
> > Extend qm importdisk/importovf functionality to the API.
> >
> > @@ -4325,4 +4324,378 @@ __PA
Signed-off-by: Dominic Jäger
---
src/node/NetworkEdit.js | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index 9e56360..d1ac454 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -258,8 +258,22 @@ Ext.define
Using find_next_iface_id we get a valid VLAN name.
This way, inserting a vlan raw device is still required (but everything that is
inserted so far is valid).
Signed-off-by: Dominic Jäger
---
Wasn't sure if we want this. Feel free to squash with previous 3/5.
src/node/NetworkView.js | 1
We usually choose default values that are valid input for the field.
interfaceX.1 is rejected by the API.
Instead, use a tooltip to demonstrate possible valid inputs for the field.
Signed-off-by: Dominic Jäger
---
src/node/NetworkEdit.js | 4
src/node/NetworkView.js | 1 -
2 files changed
Users certainly have to insert a vlan raw device when the textfield is enabled.
Currently, they only see `invalid network interface name "` when submitting.
Forbidding the blank field shows the problem earlier.
Signed-off-by: Dominic Jäger
---
src/node/NetworkEdit.js | 1 +
1 file chang
fixes automatically disabling the fields vlan-raw-device and vlan-id (VLAN
tag) in the VLAN edit window.
Signed-off-by: Dominic Jäger
---
src/Utils.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/Utils.js b/src/Utils.js
index 7b78eeb..af5f1db 100644
--- a/src/Utils.js
Add GUI wizard to import whole VMs and a window to import single disks in
Hardware View.
Signed-off-by: Dominic Jäger
---
The wizard works, but there is still quite some refactoring to do
v3->v4:
* Allow only root
* Adapt to API changes
PVE/API2/Nodes.pm | 40 +++
Extend qm importdisk/importovf functionality to the API.
qm can be adapted to use this later.
Signed-off-by: Dominic Jäger
---
Biggest v3->v4 changes:
* New code instead of bloating update_vm_api
* Don't change anything in the existing schema, use new parameter "diskimages"
Signed-off-by: Dominic Jäger
---
PVE/Storage/LVMPlugin.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/LVMPlugin.pm
index 73e8e48..df49b76 100644
--- a/PVE/Storage/LVMPlugin.pm
+++ b/PVE/Storage/LVMPlugin.pm
@@ -446,7 +446,8 @@ sub
Signed-off-by: Dominic Jäger
---
test/Makefile| 5 +++-
test/OSD_test.pl | 72
2 files changed, 76 insertions(+), 1 deletion(-)
create mode 100755 test/OSD_test.pl
diff --git a/test/Makefile b/test/Makefile
index d383e89f..3c4d2f2a 100644
inserts the correct node
into the API path.
pveceph automatically insert the local node into the API call, too.
Consequently, it can now only destroy local OSDs (fix #2053).
- pveceph osd destroy 1 is allowed on node A but
- pveceph osd destroy 2 is not
Signed-off-by: Dominic Jäger
---
PVE/API2
ostype via API and
overwrite the default e1000.
Signed-off-by: Dominic Jäger
---
www/manager6/qemu/NetworkEdit.js | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index 3b093b46..f8b448ce 100644
--- a/www
The corresponding option in /etc/network/interfaces is exactly "bond-primary".
Translating this might easily make unclear what is meant.
Signed-off-by: Dominic Jäger
---
new in v2
src/node/NetworkEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Translating root@pam is not useful, especially as the empty text symbolises the
default value.
Signed-off-by: Dominic Jäger
---
new in v2
www/window/NotifyOptions.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/window/NotifyOptions.js b/www/window/NotifyOptions.js
Signed-off-by: Dominic Jäger
---
Thank you, Stoiko!
1. Make unwanted translations empty => Removed in following patches
2. Replace Abbild with Image
de.po | 443 --
1 file changed, 182 insertions(+), 261 deletions(-)
diff --git a/de.p
Translating these is not useful; e.g. API would be translated to API in German.
Signed-off-by: Dominic Jäger
---
new in v2
www/manager6/dc/ACMEClusterView.js | 2 +-
www/manager6/dc/ACMEPluginEdit.js | 2 +-
www/manager6/dc/Config.js | 2 +-
3 files changed, 3 insertions(+), 3
Signed-off-by: Dominic Jäger
---
de.po | 451 --
1 file changed, 186 insertions(+), 265 deletions(-)
diff --git a/de.po b/de.po
index ffdc6ff..06dc295 100644
--- a/de.po
+++ b/de.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
First, both buttons add a row to the grid, so they should be both "Add" (or both
"Insert").
Secondly, we add a (security group) rule to the grid, not the group itself.
Thirdly, the window title should be different to the regular rule.
Signed-off-by: Dominic Jäger
--
The regular button is titled "Add". If groups are allowed, then the group
button is titled "Add: Group rule". In this case, changing the regular button
title to "Add: Rule" makes the difference a little more clear and also both
buttons then look the same.
Signed-o
Move existing import functionality to the API so that it is available for the
GUI.
Signed-off-by: Dominic Jäger
---
I haven't checked everything (e.g. permissions, code style) yet, but
1. a large part of intermediate bloat is away (some may be left)
2. it's rebased
3. so clicking throu
Add GUI wizard to import whole VMs and a window for only single disks in
hardware view.
Signed-off-by: Dominic Jäger
---
PVE/API2/Nodes.pm | 49
www/manager6/Makefile | 2 +
www/manager6/Workspace.js | 15 ++
www/manager6/form
On Mon, Dec 14, 2020 at 01:33:25PM +0100, Fabian Grünbichler wrote:
> I think the argument is that the associated format already enforces that
> the ID is >= 100, so that the API allows less has no practical effect
> except confusing users that read the man page/help output/api dump.
This is exa
API standard_option.
Signed-off-by: Dominic Jäger
---
https://forum.proxmox.com/threads/qm-importovf-man-page.80632/
src/PVE/JSONSchema.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 29ada5b..b4596d3 100644
--- a/src/
Add replication jobs & HA. This makes the enumeration complete.
Signed-off-by: Dominic Jäger
---
PVE/API2/Qemu.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 00d98ab..693348d 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qem
This was apparently not clear enough.
For example, see #3184.
A bit long, but I think this is a better place for additional
information about ACL and firewall than the GUI tooltip or the
API parameter description.
Signed-off-by: Dominic Jäger
---
pct.adoc | 10 ++
qm.adoc | 8
This makes the enumeration complete.
Signed-off-by: Dominic Jäger
---
www/manager6/window/SafeDestroy.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/SafeDestroy.js
b/www/manager6/window/SafeDestroy.js
index cc32f6e0..4506fad3 100644
--- a/www
Please try changing the AddressOnParent values so that they are unique.
As you mentioned, the disks should then be attached with different numbers
scsi0, scsi1, scsi2...
If it still doesn't work, then you can also create a VM and add each disk
manually by using qm importdisk. For example,
qm imp
u can quickly check xtype + layout. Then
consulting this drawing solves the mistery.
Signed-off-by: Dominic Jäger
---
IMO it's not that easy/quick to see where everything goes to.
initComponent is not that short. I actually drew the layout on paper
to keep an overview while reading it.
T
-disk-1.raw --boot order=sata0
Reported-by: Dominic Jäger
Authored-by: Stefan Reiter
Signed-off-by: Dominic Jäger
---
PVE/QemuServer/Drive.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index d560937..bb3e990 100644
--- a/PVE/QemuServer
... if the user hasn't seen the prune panel yet.
The GUI has as default value a ticked keep-all checkbox => keep-all=1.
Previously we sent nothing in this case which led to the no-keeps default of
keep-last=1.
Signed-off-by: Dominic Jäger
---
v2: Move the keep-all=1 default up
@Thomas
ionary/unusable
[1] https://www.merriam-webster.com/dictionary/loose
[2] https://www.merriam-webster.com/dictionary/lose
Signed-off-by: Dominic Jäger
---
www/manager6/storage/PBSEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6
on edit" is now
clearly visible even without comment.
Signed-off-by: Dominic Jäger
---
www/manager6/storage/Base.js | 34 --
1 file changed, 24 insertions(+), 10 deletions(-)
diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index 80b
... instead of generic PVE admin guide.
Signed-off-by: Dominic Jäger
---
www/manager6/dc/Config.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index 2fdba743..92b94afc 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc
... as this is now allowed by the API (createSchema() in PVE::SectionConfig).
It is only allowed by the update API call (updateSchema()).
Signed-off-by: Dominic Jäger
---
www/manager6/storage/Base.js | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a
Fixes the issue for me.
Tested-by: Dominic Jäger
On Mon, Nov 23, 2020 at 11:12:29AM +0100, Stoiko Ivanov wrote:
> fix #3161
>
> When considering mountpoints for running 'fsfreeze' before snapshot creation,
> commit 8463099d99273561c46398bf02206b4d9d431bc5 did not o
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
v2: This patch is unchanged, but the lines are changed by some subsequent
patches. I'll rebase that soon.
www/manager6/qemu/HDEdit.js | 134 ++
and will have a VM
- that actually starts
- has all the disks automatically attached, converted etc.
- has hostname, cores, RAM like in the .ovf
so that's something, I think.
qemu-server:
Dominic Jäger (1):
Move importdisk from qm to
And fix parameters for the API
Signed-off-by: Dominic Jäger
---
v2: Added
www/manager6/qemu/HDEdit.js | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index f8e811e1..0c5603ab 100644
--- a/www/manager6/qemu
---
v2: unchanged
www/manager6/Workspace.js| 15 +++
www/manager6/node/CmdMenu.js | 12
2 files changed, 27 insertions(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 3d0f3fec..6ee7c957 100644
--- a/www/manager6/Workspace.js
+++ b/www/mana
Signed-off-by: Dominic Jäger
---
v2: This patch is unchanged, but the lines are changed by patch 6. I'll rebase
that soon.
PVE/API2/Nodes.pm | 48 +++
www/manager6/Makefile | 2 +
www/manager6/form/ControllerSelector.js | 26 +-
www/manager6
As we've dropped the idea of using a single tab for each disk
---
v2: Added
www/manager6/qemu/ImportWizard.js | 42 +--
www/manager6/qemu/MultiHDEdit.js | 27 ++--
www/manager6/window/Wizard.js | 14 ---
3 files changed, 26 insertions(+),
ned-off-by: Dominic Jäger
---
v2: unchanged
This already had some versions. Fabian G already left some feedback (e.g.
permissions) for the last one the mailing list which I haven't been able to
address yet.
PVE/API2/Qemu.pm | 209 ++-
PVE/API2
This is actually broken, sorry. I'm just fixing it. But clicking through the
wizard should work.
On Thu, Nov 19, 2020 at 10:46:18AM +0100, Dominic Jäger wrote:
> Make importing single disks easier.
> Required to import a whole VM via GUI.
>
> Signed-off-by: Dominic Jäger
>
e first half is controller and the integer is
deviceid
And for me it would make sense to minimize those differences.
Tested-by: Dominic Jäger
On Fri, Oct 30, 2020 at 11:42:23AM +0100, Aaron Lauterer wrote:
> Does anyone have time to take a look at the latest iteration of these patches?
>
Signed-off-by: Dominic Jäger
---
Somehow selecting storages is not possible anymore. It was at some point.
You can add disks that are not in the OVF in the importwizard at the moment.
PVE/API2/Nodes.pm | 48 +++
www/manager6/Makefile | 2 +
www
Make importing single disks easier.
Required to import a whole VM via GUI.
Signed-off-by: Dominic Jäger
---
www/manager6/qemu/HDEdit.js | 134 ++
www/manager6/qemu/HardwareView.js | 24 ++
2 files changed, 141 insertions(+), 17 deletions(-)
diff --git a
ned-off-by: Dominic Jäger
---
This already had some versions. Fabian G already left some feedback (e.g.
permissions)
for the last one the mailing list which I haven't been able to address yet.
PVE/API2/Qemu.pm | 209 ++-
PVE/API2/Qemu/Impor
1 - 100 of 152 matches
Mail list logo
