On 8/14/23 12:36, Wolfgang Bumiller wrote:
applied, thanks
@Dominik: does extjs have an 'enableFn' for rows in a grid?
IMO we should either disable the ones with pools when the transfer
checkbox is not checked, or hide them (but when hiding them after
already checking them... it's weird)
Or
did not look through the api/backend part, but the gui part is now ok from my
side,
so consider the manger ui patches (15-22) and the wt patches (25-29)
Reviewed-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https
in the tag view, we have a custom 'full' style in a place where we
can have another tagstyle class above. to compensate for that, we have
to add another condition to those styles, namely that there is not the
'proxmox-tags-full' in between.
Signed-off-by: Dominik Csapak
---
src/css/ext6-pmx.css
this adds a 'tagview' to the web ui, organizing guests by their tags
(for details see the pve-manager patch)
pve-docs:
Dominik Csapak (1):
gui: add anchor for tags chapter
pve-gui.adoc | 1 +
1 file changed, 1 insertion(+)
proxmox-widget-toolkit:
Dominik Csapak (1):
css: add some
-by: Dominik Csapak
---
this depends on the docs (onlineHelp ref) and widget toolkit (css)
patches
there is probably some optimization potential in how we handle the
overrides, but i tried to keep it as generic as possible so that
we can extend it easily if we want to.
www/manager6/Makefile
Signed-off-by: Dominik Csapak
---
pve-gui.adoc | 1 +
1 file changed, 1 insertion(+)
diff --git a/pve-gui.adoc b/pve-gui.adoc
index e0fc873..0dd6646 100644
--- a/pve-gui.adoc
+++ b/pve-gui.adoc
@@ -379,6 +379,7 @@ and the corresponding interfaces for each menu item on the
right
looks mostly fine, some comments inline
On 6/26/23 14:41, Noel Ullreich wrote:
A little update to the PCI(e) docs with the plan of reworking the PCI
wiki as well.
Along some minor grammar fixes added:
* how to check if kernelmodules are being loaded
* how to check which drivers to
On 7/20/23 09:46, Lukas Wagner wrote:
On 7/19/23 14:53, Dominik Csapak wrote:
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
Notes:
I'm not sure if I like this solution, but adding notification targets to
the resources API endpoint would not have make sense
more or less the same comments as for 61/66
autoShow,
single line if,
column use,
etc.
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
src/Makefile | 3 +-
src/data/model/NotificationConfig.js | 9 ++
src/panel/NotificationConfigView.js
comments inline
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
src/Makefile| 1 +
src/Schema.js | 5 +
src/panel/NotificationGroupEditPanel.js | 177
src/window/EndpointEditBase.js
some comments/nits inline:
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
src/Makefile | 4 +
src/Schema.js| 8 ++
src/data/model/NotificationConfig.js | 8 ++
src/panel/NotificationConfigView.js | 192
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
Notes:
I'm not sure if I like this solution, but adding notification targets to
the resources API endpoint would not have make sense.
Maybe we could create a new API endpoint that returns all possible ACL
some comments inline:
On 7/17/23 17:00, Lukas Wagner wrote:
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 1 +
www/manager6/dc/Config.js | 12 ++
www/manager6/dc/NotificationEvents.js | 238 ++
3 files changed, 251
looks fine, one comment inline
On 7/17/23 17:00, Lukas Wagner wrote:
This commit adds a possibility to choose between different options
for notifications for backup jobs:
- Notify via email, in the same manner as before
- Notify via an endpoint/group
If 'notify via mail' is selected,
the combogrid sets the default itself correctly
Signed-off-by: Dominik Csapak
---
depends on the widget-toolkit patch
www/manager6/form/NodeSelector.js | 5 +
www/manager6/ha/GroupSelector.js | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/www/manager6/form
if it does not
it's either invalid (and thus "dirty") or it has a selected value anyway
this should make the manual setting of
value: [],
unnecessary in the child classes. We can even remove it direcly in the
NetworkSelector.
Signed-off-by: Dominik Csapak
---
src/form/ComboGrid.js
the combogrid does that itself already
Signed-off-by: Dominik Csapak
---
can be applied independently, but fixes dirty tracking when the
widget-toolkit patch is also present
www/manager6/grid/FirewallRules.js | 2 --
www/manager6/panel/IPSet.js| 1 -
2 files changed, 3 deletions
it is in the backend, so make it required in the gui too
Signed-off-by: Dominik Csapak
---
can be applied independently
www/manager6/panel/IPSet.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index c449cdaa..d42d062d 100644
-toolkit:
Dominik Csapak (1):
combogrid: initialze value with [] by default
src/form/ComboGrid.js | 2 +-
src/form/NetworkSelector.js | 4
2 files changed, 1 insertion(+), 5 deletions(-)
pve-manager:
Dominik Csapak (3):
ui: ipset: make ip/cidr required
ui: don't set the default
On 7/18/23 15:14, Lukas Wagner wrote:
On 7/18/23 14:34, Dominik Csapak wrote:
gave the series a quick spin, review of the gui patches comes later ;)
a few high level comments from a user perspective:
* the node fencing/replication edit windows always shows the warning that it
shouldn't
gave the series a quick spin, review of the gui patches comes later ;)
a few high level comments from a user perspective:
* the node fencing/replication edit windows always shows the warning that it
shouldn't be
disabled, that should imo only be there if i select 'never' ?
(conversely, the
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that allows
to select multiple files at once
Signed-off-by: Dominik Csapak
---
changes from v2:
* added comments to indicate
On 7/13/23 12:09, Christoph Heiss wrote:
On Mon, Jul 03, 2023 at 04:51:16PM +0200, Dominik Csapak wrote:
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that allows
like we do for qemu guest, by multiplying cpu usage by 100
Signed-off-by: Dominik Csapak
---
lib/bloc/pve_lxc_overview_bloc.dart | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/lib/bloc/pve_lxc_overview_bloc.dart
b/lib/bloc/pve_lxc_overview_bloc.dart
index
abort the login when the form returns null. This happens if the user
presses 'X' in the tfa form.
Signed-off-by: Dominik Csapak
---
lib/proxmox_login_form.dart | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/proxmox_login_form.dart b/lib
if the user was logged in in the past, but that ticket expired, we still
gave the expired ticket to the login form which tried to login with
that, producing a login error the first time the user pressed login.
we already get the correct ticket in a variable, so use that.
Signed-off-by: Dominik
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
also create a 'MultiFileButton' (mostly copied from extjs) that allows
to select multiple files at once
Signed-off-by: Dominik Csapak
---
changes from v2:
* reduces lines of code
by converting the textfield into a textarea and validate the value
line wise (if there is more than one line)
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/CreateWizard.js | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/www/manager6/lxc
'libanyevent-aio-perl' and
'libperl-languageserver-perl' (the only user of it AFAICS) on a PVE or
PMG system.
Signed-off-by: Dominik Csapak
---
maybe we should leave the use statement in and only comment it out,
with a note not to use this?
src/PVE/APIServer/AnyEvent.pm | 1 -
1 file changed, 1
but fallback to 'eslint' otherwise
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
defines.mk| 2 ++
www/manager6/Makefile | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index 3a5792ad..811f3483 100644
but fallback to 'eslint' otherwise
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
src/defines.mk | 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..2fca191 100644
--- a/src/Makefile
+++ b
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/links
+++ b/debian
but fallback to 'eslint' otherwise
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
defines.mk | 1 +
www/Makefile | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index cd5b52a2..c113d4e1 100644
--- a/defines.mk
+++ b
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defines.mk| 2 ++
www/manager6/Makefile | 4 ++--
2 files
but fallback to 'eslint' otherwise
introduce the defines.mk for this
Suggested-by: Thomas Lamprecht
Signed-off-by: Dominik Csapak
---
defines.mk | 1 +
js/Makefile| 6 --
js/mobile/Makefile | 3 ++-
3 files changed, 7 insertions(+), 3 deletions(-)
create mode 100644
sorry i forgot to add,
basically all patches (feel free to fixup on commit):
Suggested-by: Thomas Lamprecht
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
but fallback to 'eslint' otherwise
introduce the defines.mk for this
Signed-off-by: Dominik Csapak
---
defines.mk | 5 +
js/Makefile| 6 --
js/mobile/Makefile | 3 ++-
3 files changed, 11 insertions(+), 3 deletions(-)
create mode 100644 defines.mk
diff --git
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
src/defines.mk | 6 ++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..2fca191 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -110,14
to check if pve-eslint exists, use eslint as
fallback
* introduce defines.mk in pmg-gui for ESLINT variable
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager
Dominik Csapak (1):
try
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
defines.mk| 7 +++
www/manager6/Makefile | 4 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index 3a5792ad..b75671f4 100644
--- a/defines.mk
+++ b/defines.mk
but fallback to 'eslint' otherwise
Signed-off-by: Dominik Csapak
---
defines.mk | 6 ++
www/Makefile | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/defines.mk b/defines.mk
index cd5b52a2..68e7741c 100644
--- a/defines.mk
+++ b/defines.mk
@@ -11,5 +11,11 @@ JSDIR
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/links
+++ b/debian
altogether)
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migrate.js | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index c310342d..5473821b 100644
--- a/www/manager6/window/Migrate.js
+++ b/www
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 2d884f4a..d19167c2 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
into issues?
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager:
Dominik Csapak (1):
use 'pve-eslint' instead of 'eslint'
www/manager6/Makefile | 4 ++--
1 file changed, 2 insertions
since we changed the binary name
Signed-off-by: Dominik Csapak
---
js/Makefile| 4 ++--
js/mobile/Makefile | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/js/Makefile b/js/Makefile
index fad2bd6..d0f02ff 100644
--- a/js/Makefile
+++ b/js/Makefile
@@ -106,7 +106,7
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/links
+++ b/debian
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/Makefile b/www/Makefile
index 476c80b6..bc1fd6f2 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -133,11 +133,11 @@ js/proxmox-backup
since we changed the binary name
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..d312308 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -110,14 +110,14 @@ all: $(SUBDIRS
except the password dialog, since the user must provide input
to do that, we have to set the focus index on all relevant views
Signed-off-by: Dominik Csapak
---
not sure if this is the correct approach, also the extra parameter feels
slightly wrong, but didn't found a nicer way to do this
any
regex copied from perl gui installer
Signed-off-by: Dominik Csapak
---
this needs librust-regex-dev as build-dependency
proxmox-tui-installer/Cargo.toml | 1 +
proxmox-tui-installer/src/main.rs | 8
2 files changed, 9 insertions(+)
diff --git a/proxmox-tui-installer/Cargo.toml b
like the gui installer
Signed-off-by: Dominik Csapak
---
proxmox-tui-installer/src/main.rs| 2 +-
proxmox-tui-installer/src/options.rs | 14 +++---
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
i have added it to the pci api call, but forgot to add it for usb
otherwise adding a mapped usb device only works on the node where the
gui is connected to
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster/Mapping/USB.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/API2/Cluster
by disallowing nodes to be selected where a mapping already exists
Signed-off-by: Dominik Csapak
---
changes from v1:
* dont' disable autoselect, the first allowed node will be selected
* for usb mappings too
www/manager6/window/PCIMapEdit.js | 9 -
www/manager6/window/USBMapEdit.js | 4
by changing into 'mapping matches host data' which indicates that the
configured values matches the host information
also for the pci and usb map selectors
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 2 +-
www/manager6/form/USBMapSelector.js | 2 +-
www/manager6
mappings are editable
we have to split the nodeselector into two fields, since the disabling
cbind does not pass through to the editconfig (and thus makes the form
invalid if we try that)
Signed-off-by: Dominik Csapak
---
changes from rfc:
* for usb mappings too, so they are consistent
* moved
they got lost in my last rebase/refactor.
the onLoadCallBack is used to check by the window if there are iommu
groups at all, and the checkIsolated function checks if the selected
ones are in a separate group (in regards to the other devices)
Signed-off-by: Dominik Csapak
---
factored out
so they can be translated
Signed-off-by: Dominik Csapak
---
new in v2
www/manager6/window/PCIMapEdit.js | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/www/manager6/window/PCIMapEdit.js
b/www/manager6/window/PCIMapEdit.js
index f243362b..2b268719 100644
--- a/www
thanks for the review!
i agree with all of the points of the answers in your other mails
some comments here:
On 6/20/23 15:25, Fiona Ebner wrote:
Am 19.06.23 um 16:13 schrieb Dominik Csapak:
by removing the confusing buttons in the toolbar and adding them as
actions in an actioncolumn
On 6/20/23 12:18, Aaron Lauterer wrote:
On 6/20/23 11:57, Dominik Csapak wrote:
On 6/20/23 11:35, Aaron Lauterer wrote:
I like the approach as it cleans up the overloaded tbar that has items that are only valid in
certain contexts.
Two small nits from a UX POV:
- double clicking any PCI
t probably it is a bit harder to gather the info from the other nodes?
we already query the pci list of each node, so we could extract that from there
but this only works if the user has Sys.Audit which may not be the case.
then the column would be empty
On 6/19/23 16:13, Dominik Csapak wrote:
b
, but only
mappings are editable
we have to split the nodeselector into two fields, since the disabling
cbind does not pass through to the editconfig (and thus makes the form
invalid if we try that)
Signed-off-by: Dominik Csapak
---
this is not intended to be applied as is, rather i'd like some
they got lost in my last rebase/refactor.
the onLoadCallBack is used to check by the window if there are iommu
groups at all, and the checkIsolated function checks if the selected
ones are in a separate group (in regards to the other devices)
Signed-off-by: Dominik Csapak
---
www/manager6/form
by changing into 'mapping matches host data' which indicates that the
configured values matches the host information
also for the pci and usb map selectors
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 2 +-
www/manager6/form/USBMapSelector.js | 2 +-
www/manager6
by disallowing nodes to be selected where a mapping already exists
and not preselecting a node
Signed-off-by: Dominik Csapak
---
www/manager6/window/PCIMapEdit.js | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/PCIMapEdit.js
b/www/manager6
and mdev change.
giving an empty array did not have the desired effect of resetting the
selection, but giving no parameter at all does.
this now also clears the selection when the mdev filter/config changed
(was just forgotten)
Signed-off-by: Dominik Csapak
---
www/manager6/form
when there is more than one function for a device, indent the individual
functions. This sets them visually apart from the 'pass all through as
one' entry
We have to use a html entity here, as extjs trims the normal whitespace.
Signed-off-by: Dominik Csapak
---
www/manager6/form
by
* moving the node to the left column and changing the label
* moving the mdev filter to the right column
* show only the create button for new node mappings (otherwise we'd have
a reset button here that cannot do anything useful)
Signed-off-by: Dominik Csapak
---
www/manager6/window
the 'errors' property changed to 'checks' so we have to adapt here too
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/www/manager6/form/PCIMapSelector.js
b/www/manager6/form
aka a 'splitter'. that way the user can determine how much of each panel
he wants to see himself
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Config.js | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware map config
Signed-off-by: Dominik Csapak
this will be the base class for trees for the individual mapping types,
e.g. pci and usb mapping.
there are a few things to configure, but the overall code sharing is
still significant, and should work out fine for future mapping types
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile
very similar to the PCIMapEdit window, but we only ever allow one
mapping per host
Signed-off-by: Dominik Csapak
---
depends on the pve-docs patch otherwise the onlineHelp ref is not there
www/manager6/Makefile | 3 +-
www/manager6/window/USBMapEdit.js | 217
Signed-off-by: Dominik Csapak
---
depends on the pve-docs patch otherwise the onlineHelp ref is not there
changes from v6:
* removed accidentally commited hunk
* show warning again for multiple devices
www/manager6/Makefile | 1 +
www/manager6/window/PCIMapEdit.js | 215
akin to the PCISelector, but uses the api for mapped devices
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/PCIMapSelector.js | 112
2 files changed, 113 insertions(+)
create mode 100644 www/manager6/form
if the migration is an offline migration and when the mapping on
the target node exists, otherwise not
this does not change the behaviour for 'raw' devices in the config
those can still be forced to be migrated, like before
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migrate.js | 52
they can only be migrated to nodes where there exists a mapping and if
the migration is done offline
Signed-off-by: Dominik Csapak
---
no changes since v6
PVE/QemuMigrate.pm | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE
for offline migration, limit the allowed nodes to the ones where the
mapped resources are available
this adds new info to the api call namely the 'mapped-resources' list,
as well as the 'unavailable-resources' info in the 'not_allowed_nodes'
object
Signed-off-by: Dominik Csapak
---
no changes
thanks to wolfgangs feedback)
* simplified the js filterPropertyStringList helper
* added onlineHelp where appropriate
qemu-server:
Dominik Csapak (7):
usb: refactor usb code and move some into USB module
enable cluster mapped USB devices for guests
enable cluster mapped PCI devices for
: Improve SR-IOV usability
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm| 49 -
PVE/QemuServer.pm | 73 ---
PVE/QemuServer/PCI.pm | 256
test/cfg2cmd/q35-linux-hostpci.conf | 2 +-
test
that it can check the validity of the mapping for that node
in the future when we e.g. broadcast the lspci output via pmxcfs
we drop the proxyto_callback and directly use the info from
pmxcfs (or we drop the parameter and always check all nodes)
Signed-off-by: Dominik Csapak
---
changes from v6
uses the new ResourceMapTree to add the CRUD interfaces for the
mappings.
We add both of them into a single panel, since the datacenter menu
already has many entries, and without a proper summary for the group, we
cannot really put them in a category
Signed-off-by: Dominik Csapak
---
depends
.
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 4 +
www/manager6/Makefile | 1 +
www/manager6/form/MultiPCISelector.js | 288 ++
3 files changed, 293 insertions(+)
create mode 100644 www/manager6/form/MultiPCISelector.js
have
to do it in multiple places (especially in places where we don't see
that this is needed)
No functional change intended
Signed-off-by: Dominik Csapak
---
new in v7
PVE/API2/Qemu.pm | 40 ++
PVE/QemuServer.pm | 72 ---
PVE/QemuServer/USB.pm
not enough permissions.
data/PermPathStore:
add '/hardware' to the list of acl paths
Signed-off-by: Dominik Csapak
---
www/manager6/data/PermPathStore.js | 1 +
www/manager6/form/PCISelector.js | 1 +
www/manager6/form/USBSelector.js | 1 +
www/manager6/qemu/HardwareView.js | 17
explain why someone would want it, how to configure and which privileges
are necessary
Signed-off-by: Dominik Csapak
---
changes from v6:
* added small note about only one usb device per node per map
qm-pci-passthrough.adoc | 8
qm.adoc | 87
to be able to select 'mapped' usb devices
Signed-off-by: Dominik Csapak
---
changes from v6:
* adapt to splitting into 'mapping' property
www/manager6/qemu/USBEdit.js | 75 ++--
1 file changed, 54 insertions(+), 21 deletions(-)
diff --git a/www/manager6/qemu
Signed-off-by: Dominik Csapak
---
no changes since v6
test/cfg2cmd/q35-linux-hostpci-mapping.conf | 17
.../q35-linux-hostpci-mapping.conf.cmd| 36
test/run_config2command_tests.pl | 82 +++
3 files changed, 135 insertions(+)
create mode
similar to the pciselector, make it accept a plain nodename,
or no node at all and provide a setNodename function
to keep backwards compatibility, also check pveSelNode for the nodename
Signed-off-by: Dominik Csapak
---
www/manager6/form/USBSelector.js | 32 +++-
1
similar to PCIMapSelector
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/USBMapSelector.js | 98 +
2 files changed, 99 insertions(+)
create mode 100644 www/manager6/form/USBMapSelector.js
diff --git a/www/manager6
Signed-off-by: Dominik Csapak
---
changes from v6:
* adapted to refactor
* deduplicated permission checks
* use seperate 'mapping' property for the mapping instead of reusing 'host'
* added a FIXME comment for the restore permission checks
PVE/API2/Qemu.pm | 12 +++---
PVE/QemuServer.pm
namely the filtering while preserving the original string,
it's just one line, but having a shorthand for it still makes it a bit
nicer
Signed-off-by: Dominik Csapak
---
www/manager6/Parser.js | 4
1 file changed, 4 insertions(+)
diff --git a/www/manager6/Parser.js b/www/manager6
by adding them to their own list, saving the nodes where
they are not allowed, and return those on 'wantarray' so we don't break
existing callers that don't expect it.
Signed-off-by: Dominik Csapak
---
changes from v6:
* adapted to split into mapping property
PVE/QemuServer.pm| 42
have some explicit checks like that it should not make a problem
Signed-off-by: Dominik Csapak
---
change from v1:
* put check inside the 'if ref' condition since that will be
'JSON::PP::Boolean' after decoding
* added more info to commit message
src/PVE/JSONSchema.pm | 4
1 file changed
Looks good from my side now, maybe someone else wants to chime in
regarding the splitting of the setting in the gui (but IMHO that's good)
consider the series:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve
On 6/15/23 11:51, Wolfgang Bumiller wrote:
On Thu, Jun 15, 2023 at 11:32:15AM +0200, Dominik Csapak wrote:
if a real json boolean is sent via the api, $value is a
JSON::PP::Boolean here instead of a string/scalar
so we should validate that too
the $value itself can be used normally
pvedaemon
Signed-off-by: Dominik Csapak
---
i tested this with a few api calls (e.g. in the user creation/edit)
and it worked, but maybe the safer option would be to convert those
values to '1'/'0' ? we could reuse the 'normalize_legacy_param_formats'
function in RESTHandler for this, but this o
forgot to write: we should apply this for stable-7 as well
On 6/15/23 10:08, Dominik Csapak wrote:
this field has a fixed height, which is too tall for the create wizard,
and one cannot see the last entry when scrolling all the way down.
to fix this, make it 20px shorter
Signed-off
this field has a fixed height, which is too tall for the create wizard,
and one cannot see the last entry when scrolling all the way down.
to fix this, make it 20px shorter
Signed-off-by: Dominik Csapak
---
alternatively we could also increase the height in the create wizard
the optimal
to get a fast overview in which groups each user is.
for that we need to add the 'full=1' parameter.
this only tokens/groups to the api call, but we have that info in the
backend after parsing the config anyway, so it should not be very
costly.
Signed-off-by: Dominik Csapak
---
www/manager6
501 - 600 of 2034 matches
Mail list logo
