t anyway, and the source does not
change, we probably could move that out of that function altogether)
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migrate.js | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 2d884f4a..d19167c2 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
o 8.x/3.x it does not run into issues?
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager:
Dominik Csapak (1):
use 'pve-eslint' instead of 'eslin
since we changed the binary name
Signed-off-by: Dominik Csapak
---
js/Makefile| 4 ++--
js/mobile/Makefile | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/js/Makefile b/js/Makefile
index fad2bd6..d0f02ff 100644
--- a/js/Makefile
+++ b/js/Makefile
@@ -106,7 +106,7
so that we don't conflict with 'eslint' package in debian, which ships
the same binary
Signed-off-by: Dominik Csapak
---
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/links b/debian/links
index 99342ed..0a1546f 100644
--- a/debian/lin
since we changed the binary name
Signed-off-by: Dominik Csapak
---
www/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/Makefile b/www/Makefile
index 476c80b6..bc1fd6f2 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -133,11 +133,11 @@ js/proxmox-backup
since we changed the binary name
Signed-off-by: Dominik Csapak
---
src/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/Makefile b/src/Makefile
index 7cff5dd..d312308 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -110,14 +110,14 @@ all: $(SUBDIRS
except the password dialog, since the user must provide input
to do that, we have to set the focus index on all relevant views
Signed-off-by: Dominik Csapak
---
not sure if this is the correct approach, also the extra parameter feels
slightly wrong, but didn't found a nicer way to do this
regex copied from perl gui installer
Signed-off-by: Dominik Csapak
---
this needs librust-regex-dev as build-dependency
proxmox-tui-installer/Cargo.toml | 1 +
proxmox-tui-installer/src/main.rs | 8
2 files changed, 9 insertions(+)
diff --git a/proxmox-tui-installer/Cargo.toml b
like the gui installer
Signed-off-by: Dominik Csapak
---
proxmox-tui-installer/src/main.rs| 2 +-
proxmox-tui-installer/src/options.rs | 14 +++---
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src/main.rs
i have added it to the pci api call, but forgot to add it for usb
otherwise adding a mapped usb device only works on the node where the
gui is connected to
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster/Mapping/USB.pm | 5 +
1 file changed, 5 insertions(+)
diff --git a/PVE/API2/Cluster
by disallowing nodes to be selected where a mapping already exists
Signed-off-by: Dominik Csapak
---
changes from v1:
* dont' disable autoselect, the first allowed node will be selected
* for usb mappings too
www/manager6/window/PCIMapEdit.js | 9 -
www/manager6/window/USBMapEdit.j
by changing into 'mapping matches host data' which indicates that the
configured values matches the host information
also for the pci and usb map selectors
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 2 +-
www/manager6/form/USBMapSelector.js | 2 +-
ww
, but only
mappings are editable
we have to split the nodeselector into two fields, since the disabling
cbind does not pass through to the editconfig (and thus makes the form
invalid if we try that)
Signed-off-by: Dominik Csapak
---
changes from rfc:
* for usb mappings too, so they are consiste
they got lost in my last rebase/refactor.
the onLoadCallBack is used to check by the window if there are iommu
groups at all, and the checkIsolated function checks if the selected
ones are in a separate group (in regards to the other devices)
Signed-off-by: Dominik Csapak
---
factored out the
so they can be translated
Signed-off-by: Dominik Csapak
---
new in v2
www/manager6/window/PCIMapEdit.js | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/www/manager6/window/PCIMapEdit.js
b/www/manager6/window/PCIMapEdit.js
index f243362b..2b268719 100644
--- a/www
thanks for the review!
i agree with all of the points of the answers in your other mails
some comments here:
On 6/20/23 15:25, Fiona Ebner wrote:
Am 19.06.23 um 16:13 schrieb Dominik Csapak:
by removing the confusing buttons in the toolbar and adding them as
actions in an actioncolumn. There
On 6/20/23 12:18, Aaron Lauterer wrote:
On 6/20/23 11:57, Dominik Csapak wrote:
On 6/20/23 11:35, Aaron Lauterer wrote:
I like the approach as it cleans up the overloaded tbar that has items that are only valid in
certain contexts.
Two small nits from a UX POV:
- double clicking any PCI
robably it is a bit harder to gather the info from the other nodes?
we already query the pci list of each node, so we could extract that from there
but this only works if the user has Sys.Audit which may not be the case.
then the column would be empty
On 6/19/23 16:13, Dominik Csapak wrote:
b
pings, but only
mappings are editable
we have to split the nodeselector into two fields, since the disabling
cbind does not pass through to the editconfig (and thus makes the form
invalid if we try that)
Signed-off-by: Dominik Csapak
---
this is not intended to be applied as is, rather i&#
they got lost in my last rebase/refactor.
the onLoadCallBack is used to check by the window if there are iommu
groups at all, and the checkIsolated function checks if the selected
ones are in a separate group (in regards to the other devices)
Signed-off-by: Dominik Csapak
---
www/manager6/form
by changing into 'mapping matches host data' which indicates that the
configured values matches the host information
also for the pci and usb map selectors
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 2 +-
www/manager6/form/USBMapSelector.js | 2 +-
ww
by disallowing nodes to be selected where a mapping already exists
and not preselecting a node
Signed-off-by: Dominik Csapak
---
www/manager6/window/PCIMapEdit.js | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/PCIMapEdit.js
b/www/manager6
and mdev change.
giving an empty array did not have the desired effect of resetting the
selection, but giving no parameter at all does.
this now also clears the selection when the mdev filter/config changed
(was just forgotten)
Signed-off-by: Dominik Csapak
---
www/manager6/form
when there is more than one function for a device, indent the individual
functions. This sets them visually apart from the 'pass all through as
one' entry
We have to use a html entity here, as extjs trims the normal whitespace.
Signed-off-by: Dominik Csapak
---
www/man
by
* moving the node to the left column and changing the label
* moving the mdev filter to the right column
* show only the create button for new node mappings (otherwise we'd have
a reset button here that cannot do anything useful)
Signed-off-by: Dominik Csapak
---
www/manager6/w
the 'errors' property changed to 'checks' so we have to adapt here too
Signed-off-by: Dominik Csapak
---
www/manager6/form/PCIMapSelector.js | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/www/manager6/form/PCIMapSelector.js
aka a 'splitter'. that way the user can determine how much of each panel
he wants to see himself
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Config.js | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware m
this will be the base class for trees for the individual mapping types,
e.g. pci and usb mapping.
there are a few things to configure, but the overall code sharing is
still significant, and should work out fine for future mapping types
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile
very similar to the PCIMapEdit window, but we only ever allow one
mapping per host
Signed-off-by: Dominik Csapak
---
depends on the pve-docs patch otherwise the onlineHelp ref is not there
www/manager6/Makefile | 3 +-
www/manager6/window/USBMapEdit.js | 217
Signed-off-by: Dominik Csapak
---
depends on the pve-docs patch otherwise the onlineHelp ref is not there
changes from v6:
* removed accidentally commited hunk
* show warning again for multiple devices
www/manager6/Makefile | 1 +
www/manager6/window/PCIMapEdit.js | 215
akin to the PCISelector, but uses the api for mapped devices
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/PCIMapSelector.js | 112
2 files changed, 113 insertions(+)
create mode 100644 www/manager6/form
if the migration is an offline migration and when the mapping on
the target node exists, otherwise not
this does not change the behaviour for 'raw' devices in the config
those can still be forced to be migrated, like before
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migra
they can only be migrated to nodes where there exists a mapping and if
the migration is done offline
Signed-off-by: Dominik Csapak
---
no changes since v6
PVE/QemuMigrate.pm | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE
for offline migration, limit the allowed nodes to the ones where the
mapped resources are available
this adds new info to the api call namely the 'mapped-resources' list,
as well as the 'unavailable-resources' info in the 'not_allowed_nodes'
object
Signed-off-by:
ables (thanks to wolfgangs feedback)
* simplified the js filterPropertyStringList helper
* added onlineHelp where appropriate
qemu-server:
Dominik Csapak (7):
usb: refactor usb code and move some into USB module
enable cluster mapped USB devices for guests
enable cluster mapped PCI de
is a breaking change.
Fixes #3574: Improve SR-IOV usability
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm| 49 -
PVE/QemuServer.pm | 73 ---
PVE/QemuServer/PCI.pm | 256
test/cfg2cmd/q35-li
to the given node
so that it can check the validity of the mapping for that node
in the future when we e.g. broadcast the lspci output via pmxcfs
we drop the proxyto_callback and directly use the info from
pmxcfs (or we drop the parameter and always check all nodes)
Signed-off-by: Dominik Csapak
uses the new ResourceMapTree to add the CRUD interfaces for the
mappings.
We add both of them into a single panel, since the datacenter menu
already has many entries, and without a proper summary for the group, we
cannot really put them in a category
Signed-off-by: Dominik Csapak
---
depends on
.
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 4 +
www/manager6/Makefile | 1 +
www/manager6/form/MultiPCISelector.js | 288 ++
3 files changed, 293 insertions(+)
create mode 100644 www/manager6/form/MultiPCISelector.js
arse the device itself, so we don't have
to do it in multiple places (especially in places where we don't see
that this is needed)
No functional change intended
Signed-off-by: Dominik Csapak
---
new in v7
PVE/API2/Qemu.pm | 40 ++
PVE/QemuServer.pm | 72 -
enough permissions.
data/PermPathStore:
add '/hardware' to the list of acl paths
Signed-off-by: Dominik Csapak
---
www/manager6/data/PermPathStore.js | 1 +
www/manager6/form/PCISelector.js | 1 +
www/manager6/form/USBSelector.js | 1 +
www/manager6/qemu/HardwareVie
explain why someone would want it, how to configure and which privileges
are necessary
Signed-off-by: Dominik Csapak
---
changes from v6:
* added small note about only one usb device per node per map
qm-pci-passthrough.adoc | 8
qm.adoc | 87
to be able to select 'mapped' usb devices
Signed-off-by: Dominik Csapak
---
changes from v6:
* adapt to splitting into 'mapping' property
www/manager6/qemu/USBEdit.js | 75 ++--
1 file changed, 54 insertions(+), 21 deletions(-)
diff --git
Signed-off-by: Dominik Csapak
---
no changes since v6
test/cfg2cmd/q35-linux-hostpci-mapping.conf | 17
.../q35-linux-hostpci-mapping.conf.cmd| 36
test/run_config2command_tests.pl | 82 +++
3 files changed, 135 insertions(+)
create mode
similar to the pciselector, make it accept a plain nodename,
or no node at all and provide a setNodename function
to keep backwards compatibility, also check pveSelNode for the nodename
Signed-off-by: Dominik Csapak
---
www/manager6/form/USBSelector.js | 32 +++-
1
similar to PCIMapSelector
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/USBMapSelector.js | 98 +
2 files changed, 99 insertions(+)
create mode 100644 www/manager6/form/USBMapSelector.js
diff --git a/www/manager6
place
where we can add such checks
Signed-off-by: Dominik Csapak
---
changes from v6:
* adapted to refactor
* deduplicated permission checks
* use seperate 'mapping' property for the mapping instead of reusing 'host'
* added a FIXME comment for the restore permission checks
P
namely the filtering while preserving the original string,
it's just one line, but having a shorthand for it still makes it a bit
nicer
Signed-off-by: Dominik Csapak
---
www/manager6/Parser.js | 4
1 file changed, 4 insertions(+)
diff --git a/www/manager6/Parser.js b/www/man
by adding them to their own list, saving the nodes where
they are not allowed, and return those on 'wantarray' so we don't break
existing callers that don't expect it.
Signed-off-by: Dominik Csapak
---
changes from v6:
* adapted to split into mapping property
PVE/QemuServe
' so even if
we have some explicit checks like that it should not make a problem
Signed-off-by: Dominik Csapak
---
change from v1:
* put check inside the 'if ref' condition since that will be
'JSON::PP::Boolean' after decoding
* added more info to commit message
src/PV
Looks good from my side now, maybe someone else wants to chime in
regarding the splitting of the setting in the gui (but IMHO that's good)
consider the series:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing lis
On 6/15/23 11:51, Wolfgang Bumiller wrote:
On Thu, Jun 15, 2023 at 11:32:15AM +0200, Dominik Csapak wrote:
if a real json boolean is sent via the api, $value is a
JSON::PP::Boolean here instead of a string/scalar
so we should validate that too
the $value itself can be used normally in
pvedaemon
Signed-off-by: Dominik Csapak
---
i tested this with a few api calls (e.g. in the user creation/edit)
and it worked, but maybe the safer option would be to convert those
values to '1'/'0' ? we could reuse the 'normalize_legacy_param_formats'
function in RE
forgot to write: we should apply this for stable-7 as well
On 6/15/23 10:08, Dominik Csapak wrote:
this field has a fixed height, which is too tall for the create wizard,
and one cannot see the last entry when scrolling all the way down.
to fix this, make it 20px shorter
Signed-off-by
this field has a fixed height, which is too tall for the create wizard,
and one cannot see the last entry when scrolling all the way down.
to fix this, make it 20px shorter
Signed-off-by: Dominik Csapak
---
alternatively we could also increase the height in the create wizard
the optimal
to get a fast overview in which groups each user is.
for that we need to add the 'full=1' parameter.
this only tokens/groups to the api call, but we have that info in the
backend after parsing the config anyway, so it should not be very
costly.
Signed-off-by: Dominik Csapak
---
ww
ist in the search grids, we only include the
ones with 'header' or 'text' property (without those, the columsn would
show up with an empty string)
Signed-off-by: Dominik Csapak
---
www/manager6/data/ResourceStore.js | 10 +-
www/manager6/form/ViewSelector.
otherwise we might run into an exception further down
Signed-off-by: Dominik Csapak
---
www/manager6/panel/ConfigPanel.js | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/www/manager6/panel/ConfigPanel.js
b/www/manager6/panel/ConfigPanel.js
index d578f944..5192d2bc
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware map config
ll to the given node
so that it can check the validity of the mapping for that node
in the future when we e.g. broadcast the lspci output via pmxcfs
we drop the proxyto_callback and directly use the info from
pmxcfs (or we drop the parameter and always check all nodes)
Signed-off-by: Dominik C
this will be the base class for trees for the individual mapping types,
e.g. pci and usb mapping.
there are a few things to configure, but the overall code sharing is
still significant, and should work out fine for future mapping types
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile
uses the new ResourceMapTree to add the CRUD interfaces for the
mappings.
We add both of them into a single panel, since the datacenter menu
already has many entries, and without a proper summary for the group, we
cannot really put them in a category
Signed-off-by: Dominik Csapak
---
changes
Signed-off-by: Dominik Csapak
---
changes from v5:
* add onlineHelp
www/manager6/Makefile | 1 +
www/manager6/form/PCISelector.js | 17 ++-
www/manager6/window/PCIMapEdit.js | 207 ++
3 files changed, 224 insertions(+), 1 deletion(-)
create mode 100644
explain why someone would want it, how to configure and which privileges
are necessary
Signed-off-by: Dominik Csapak
---
new in v6
qm-pci-passthrough.adoc | 8
qm.adoc | 86 +
2 files changed, 94 insertions(+)
diff --git a/qm-pci
if the migration is an offline migration and when the mapping on
the target node exists, otherwise not
this does not change the behaviour for 'raw' devices in the config
those can still be forced to be migrated, like before
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migra
very similar to the PCIMapEdit window, but we only ever allow one
mapping per host
Signed-off-by: Dominik Csapak
---
changes from v5:
* add onlineHelp
www/manager6/Makefile | 3 +-
www/manager6/window/USBMapEdit.js | 217 ++
2 files changed, 219
akin to the PCISelector, but uses the api for mapped devices
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/PCIMapSelector.js | 112
2 files changed, 113 insertions(+)
create mode 100644 www/manager6/form
Signed-off-by: Dominik Csapak
---
test/cfg2cmd/q35-linux-hostpci-mapping.conf | 17
.../q35-linux-hostpci-mapping.conf.cmd| 36
test/run_config2command_tests.pl | 82 +++
3 files changed, 135 insertions(+)
create mode 100644 test/cfg2cmd/q35
similar to PCIMapSelector
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/USBMapSelector.js | 98 +
2 files changed, 99 insertions(+)
create mode 100644 www/manager6/form/USBMapSelector.js
diff --git a/www/manager6
xes #3574: Improve SR-IOV usability
Signed-off-by: Dominik Csapak
---
changes from v5:
* move permission check for clone/restore to QemuServer.pm
PVE/API2/Qemu.pm| 54 +-
PVE/QemuServer.pm | 71 ---
PVE/QemuServer/PCI.pm |
r the
host, since we don't track passed through usb devices yet
also checks the permission for usb devices on clone/restore
Note that this now fails for 'raw' devices when the user is not root, so
this is a breaking change!
Signed-off-by: Dominik Csapak
---
changes from v
.
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 4 +
www/manager6/Makefile | 1 +
www/manager6/form/MultiPCISelector.js | 288 ++
3 files changed, 293 insertions(+)
create mode 100644 www/manager6/form/MultiPCISelector.js
similar to the pciselector, make it accept a plain nodename,
or no node at all and provide a setNodename function
to keep backwards compatibility, also check pveSelNode for the nodename
Signed-off-by: Dominik Csapak
---
www/manager6/form/USBSelector.js | 32 +++-
1
enough permissions.
data/PermPathStore:
add '/hardware' to the list of acl paths
Signed-off-by: Dominik Csapak
---
www/manager6/data/PermPathStore.js | 1 +
www/manager6/form/PCISelector.js | 1 +
www/manager6/form/USBSelector.js | 1 +
www/manager6/qemu/HardwareVie
namely the filtering while preserving the original string,
it's just one line, but having a shorthand for it still makes it a bit
nicer
Signed-off-by: Dominik Csapak
---
changes from v5:
* removed list parser (was unused)
* changed the filter helper to a simple 'filter' call
to be able to select 'mapped' usb devices
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/USBEdit.js | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js
index fe51d186
in pve-http-server the proxyto_callback always has a complete list of
parameters, not only the ones in the url, so adapt the implementation
here to do the same
Signed-off-by: Dominik Csapak
---
PVE/CLI/pvesh.pm | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/PVE
they can only be migrated to nodes where there exists a mapping and if
the migration is done offline
Signed-off-by: Dominik Csapak
---
chnages from v5:
* renamed to $missing_mappings_by_node and $missing_mappings
PVE/QemuMigrate.pm | 23 ---
1 file changed, 20 insertions
variables (thanks to wolfgangs feedback)
* simplified the js filterPropertyStringList helper
* added onlineHelp where appropriate
qemu-server:
Dominik Csapak (6):
enable cluster mapped USB devices for guests
enable cluster mapped PCI devices for guests
check_local_resources: extend for mapped
for offline migration, limit the allowed nodes to the ones where the
mapped resources are available
this adds new info to the api call namely the 'mapped-resources' list,
as well as the 'unavailable-resources' info in the 'not_allowed_nodes'
object
Signed-off-by: Do
by adding them to their own list, saving the nodes where
they are not allowed, and return those on 'wantarray' so we don't break
existing callers that don't expect it.
Signed-off-by: Dominik Csapak
---
changes from v5:
* renamed hash to missing_mappings_by_node
PVE/QemuServe
and make it collapsible, so that users can hide it if they're not
interested in it
Signed-off-by: Dominik Csapak
---
changes from v1:
* fix eslint warning
www/manager6/dc/AuthView.js | 2 +-
www/manager6/dc/Config.js | 28
2 files changed, 21 insertions(
to make it consistent with the repositories ui, since having a checkbox
that is not clickable is confusing
Signed-off-by: Dominik Csapak
---
www/manager6/dc/RealmSyncJob.js | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/www/manager6/dc/RealmSyncJob.js b/www
by simply passing the sync job config to the 'sync' api endpoint, like
we do for vzdump jobs
Signed-off-by: Dominik Csapak
---
new in v2
www/manager6/dc/RealmSyncJob.js | 41 +
1 file changed, 41 insertions(+)
diff --git a/www/manager6/dc/RealmSyncJo
v1:
* fix eslint warnings
* add new 'run now' button
Dominik Csapak (4):
ui: realm sync edit: improve ux when there is no ldap/ad realm
ui: realm sync: change enabled column rendering
ui: realm: move sync job panel into realm panel
ui: realm sync: add 'run now' button
by adding an empty text to the dropdown, and disabling the other
possibly invalid fields, so that it's clear why the panel is invalid
as soon as there is an ldap/ad realm, it gets autoselected anyway and
the fields get re-enabled.
Signed-off-by: Dominik Csapak
---
changes from v1:
* fix e
by adding an empty text to the dropdown, and disabling the other
possibly invalid fields, so that it's clear why the panel is invalid
as soon as there is an ldap/ad realm, it gets autoselected anyway and
the fields get re-enabled.
Signed-off-by: Dominik Csapak
---
www/manage
and make it collapsible, so that users can hide it if they're not
interested in it
Signed-off-by: Dominik Csapak
---
www/manager6/dc/AuthView.js | 2 +-
www/manager6/dc/Config.js | 28
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/www/man
to make it consistent with the repositories ui, since having a checkbox
that is not clickable is confusing
Signed-off-by: Dominik Csapak
---
www/manager6/dc/RealmSyncJob.js | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/www/manager6/dc/RealmSyncJob.js b/www
by implementing @thomas suggestions.
The only thing not done for now is a 'run now' button, but for that
we either have to create a new api call, or change the existing
'sync' call to read the job config with an extra parameter
(i'd lean to do the latter)
Dominik Csa
it).
In any case, link to the known issues section in the upgrade guide
(which we can update to contain up-to-date information).
Signed-off-by: Dominik Csapak
---
I opted to not parse more specific information about the driver (like
version, etc.) since it increases the complexity of the check
On 6/7/23 13:47, Thomas Lamprecht wrote:
Am 07/06/2023 um 13:23 schrieb Wolfgang Bumiller:
applied both & bumped dependency for pve-common
Isn't this breaking older common too?
no it just forwards the parameters to either the daemon or the other
nodes as json if the proxy received it a
mostly LGTM, a few minor comments inline (that could probably be
followed up?)
On 4/17/23 14:45, Noel Ullreich wrote:
A little update to the PCI(e) docs with the plan of reworking the PCI
wiki as well.
Along some minor grammar fixes added:
* how to check if kernelmodules are being loaded
*
applied both ui patches with slight rewording of the commit subject/message
+ a short follow up to prevent also double clicking
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
for the record (since i forgot to mention it in the commit message):
this patch breaks pve-common without the common 1/3 applied
since the gui sends arrays when the api expects a '-list'
and the api treats '-list' and '-alist' the same
with the parameter conversion in common 1/3 this is worked
.
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 4 +
www/manager6/Makefile | 1 +
www/manager6/form/MultiPCISelector.js | 288 ++
3 files changed, 293 insertions(+)
create mode 100644 www/manager6/form/MultiPCISelector.js
enough permissions.
data/PermPathStore:
add '/hardware' to the list of acl paths
Signed-off-by: Dominik Csapak
---
www/manager6/data/PermPathStore.js | 1 +
www/manager6/form/PCISelector.js | 1 +
www/manager6/form/USBSelector.js | 1 +
www/manager6/qemu/HardwareVie
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware map config
601 - 700 of 1489 matches
Mail list logo
