[pve-devel] [PATCH manager] ui: allow specifying shutdown policy during node shutdown/reboot

Signed-off-by: Fiona Ebner --- Depends on https://lists.proxmox.com/pipermail/pve-devel/2023-June/057635.html Used a new window, because it's small and couldn't find a good fit with the existing ones. Maybe SafeDestroy, but not in name and would require a few modifications too. Not

Re: [pve-devel] [PATCH v5 qemu-server 1/10] qemuserver: foreach_volid: include pending volumes

Am 19.06.23 um 11:29 schrieb Aaron Lauterer: > > @@ -4876,11 +4876,13 @@ sub foreach_volid { > $volhash->{$volid}->{shared} = 1 if $drive->{shared}; > > $volhash->{$volid}->{referenced_in_config} //= 0; > - $volhash->{$volid}->{referenced_in_config} = 1 if !defined($snapname); >

Re: [pve-devel] [PATCH v5 qemu-server 0/7] migration: don't scan all storages, fail on aliases

a new version by themselves and can be fixed upon/after applying. For the patches that don't have it yet: Reviewed-by: Fiona Ebner ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v5 container 9/10] migration: fail when aliased volume is detected

Am 19.06.23 um 11:29 schrieb Aaron Lauterer: > @@ -277,6 +280,12 @@ sub phase1 { > # finally all current volumes > PVE::LXC::Config->foreach_volume_full($conf, { include_unused => 1 }, > $test_mp); > > +for my $path (keys %$path_to_volid) { > + my @volids = keys $path_to_volid-

Re: [pve-devel] [PATCH v5 qemu-server 6/10] migration: fail when aliased volume is detected

Am 19.06.23 um 11:29 schrieb Aaron Lauterer: > @@ -427,6 +429,12 @@ sub scan_local_volumes { > } > }); > > + for my $path (keys %$path_to_volid) { > + my @volids = keys $path_to_volid->{$path}->%*; > + die "detected not supported aliased volumes: '" . join("

Re: [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models

Am 19.06.23 um 11:19 schrieb DERUMIER, Alexandre: > Le lundi 19 juin 2023 à 10:46 +0200, Fiona Ebner a écrit : > >> I also noticed that >> Denverton{-v2,-v3} >> Snowridge{-v2,-v3,-v4} > > Both are atom cpu. I don't known if we want to support them ? (they

Re: [pve-devel] [PATCH v2 pve-docs] qemu: add cpu models documentation

Am 19.06.23 um 10:38 schrieb Alexandre Derumier: > add doc for differents cpu models including > new x86-64-vX models > > changelog v2: x86-64-v2 is compatible with >= opteron_g3 > > Signed-off-by: Alexandre Derumier > --- > qm.adoc | 145 +---

Re: [pve-devel] [PATCH qemu-server] cpuconfig: add missing qemu 8.0 cpu models

Am 09.06.23 um 12:27 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer/CPUConfig.pm | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm > index fb0861b..77fc682 100644 > --- a/PVE/

Re: [pve-devel] [PATCH v4 qemu-server, container, docs 0/12] migration: don't scan all storages, fail on aliases

ced in snapshot - $snapnames)"; > } but that can also just s/referenced_in_config/is_attached/ Consider patches 7/12 until 12/12: Reviewed-by: Fiona Ebner ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v4 container 10/12] migration: only migrate volumes used by the guest

Am 16.06.23 um 11:57 schrieb Aaron Lauterer:> changes since v3: hopefully caught all style nits now ;) I'm sorry to tell you: > +if (defined $conf->{pending} && $conf->{pending}->%*) { missing parentheses around defined() :P ___ pve-devel mailing

[pve-devel] [PATCH v2 widget-toolkit] apt repositories: add production ready warnings for Ceph repositories

Could've been done for the test repository already, but now that there is a split between no-subscription and enterprise it becomes even more relevant. Reported-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- Changes in v2: * rebase on current master. src/node/APTRepositories.js

[pve-devel] applied: [PATCH v4 qemu-server 5/12] migration: add target_storage_check_available

Am 16.06.23 um 11:57 schrieb Aaron Lauterer: > We use this in a few places. By factoring it into its own function, we > can avoid running slightly different checks in various places. > > Signed-off-by: Aaron Lauterer > --- applied this one, thanks! Not too important right now, but could be impr

Re: [pve-devel] [PATCH v4 qemu-server 4/12] qemuserver: foreach_volid: test regular config last

Am 16.06.23 um 11:57 schrieb Aaron Lauterer: > after snapshots and the pending section to make sure, that volids that > are referenced here, will be marked correctly, e.g. 'is_unused'. > The flag is set as follows: > $volhash->{$volid}->{is_unused} //= 0; > $volhash->{$volid}->{i

Re: [pve-devel] [PATCH v4 qemu-server 2/12] qemuserver: foreach_volid: include pending volumes

Am 16.06.23 um 11:56 schrieb Aaron Lauterer: > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 6cbaf87..33acef6 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -2424,7 +2424,7 @@ sub destroy_vm { > > if ($purge_unreferenced) { # also remove unreferenced disk >

Re: [pve-devel] [PATCH v4 qemu-server 1/12] migration: only migrate disks used by the guest

Am 16.06.23 um 11:56 schrieb Aaron Lauterer: > When scanning all configured storages for disk images belonging to the > VM, the migration could easily fail if a storage is not available, but > enabled. That storage might not even be used by the VM at all. > > By not scanning all storages and only

[pve-devel] [PATCH-SERIES cluster/(ha-)manager] allow node HA shutdown policy override

exist and LRM honor the new param). cluster: Fiona Ebner (1): datacenter config: turn shutdown policy into a standard option src/PVE/DataCenterConfig.pm | 50 +++-- 1 file changed, 26 insertions(+), 24 deletions(-) ha-manager: Fiona Ebner (7): lrm servic

[pve-devel] [RFC ha-manager 5/7] pve2 env: validate shutdown policy from override file

for future-proofing. Signed-off-by: Fiona Ebner --- Not sure if this is worth it. (Build-)dependency bump for libpve-cluster-perl needed src/PVE/HA/Env/PVE2.pm | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm

[pve-devel] [PATCH ha-manager 1/7] lrm service: add runtime directory

in preparation to allow overriding the shutdown policy with a file there. Signed-off-by: Fiona Ebner --- debian/pve-ha-lrm.service | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/pve-ha-lrm.service b/debian/pve-ha-lrm.service index fb1b5db..9f3f73d 100644 --- a/debian/pve-ha

[pve-devel] [RFC ha-manager 2/7] lrm service: move PID file to service's runtime directory

it's arguably cleaner to put it there, now that there is one. Signed-off-by: Fiona Ebner --- debian/pve-ha-lrm.service | 2 +- src/PVE/Service/pve_ha_lrm.pm | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/debian/pve-ha-lrm.service b/debian/pve-ha-lrm.service

[pve-devel] [PATCH ha-manager 7/7] tests: add test for shutdown policy override

Signed-off-by: Fiona Ebner --- src/test/test-shutdown-policy-override/README | 3 + .../test-shutdown-policy-override/cmdlist | 4 ++ .../datacenter.cfg| 10 .../hardware_status | 5 ++ .../test-shutdown-policy-override/log.expect

[pve-devel] [PATCH ha-manager 6/7] sim env: add support for datacenter config overrides

to model the recent change in the pve2 environment. Signed-off-by: Fiona Ebner --- src/PVE/HA/Sim/Env.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/HA/Sim/Env.pm b/src/PVE/HA/Sim/Env.pm index c6ea73c..1b8399a 100644 --- a/src/PVE/HA/Sim/Env.pm +++ b/src/PVE/HA/Sim/Env.pm

[pve-devel] [PATCH ha-manager 4/7] lrm: honor shutdown policy override set by node's shutdown API endpoint

The /nodes//status API endpoint in pve-manager allows to specify the shutdown policy now. This change is required for it to have any effect of course. Being able to choose the shutdown policy on a per-node/per-shutdown is more flexible and user-friendly. Signed-off-by: Fiona Ebner --- src/PVE

[pve-devel] [PATCH manager 1/1] api: nodes: allow setting HA shutdown policy during shutdown/reboot

Increases flexibility/user-friendliness. Suggested-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- (Build-)dependency bump for libpve-cluster-perl needed. Dependency bump for ha-manager needed (to have the runtime dir exist and LRM honor the new param). PVE/API2/Nodes.pm | 11

[pve-devel] [PATCH cluster 1/1] datacenter config: turn shutdown policy into a standard option

to be re-used by the node/status API endpoint. Signed-off-by: Fiona Ebner --- src/PVE/DataCenterConfig.pm | 50 +++-- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm index 5f12450..3d24e78

[pve-devel] [PATCH ha-manager 3/7] pve2 env: get shutdown policy override set by node's shutdown API endpoint

Signed-off-by: Fiona Ebner --- src/PVE/HA/Env/PVE2.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm index f6ebfeb..6a75bd4 100644 --- a/src/PVE/HA/Env/PVE2.pm +++ b/src/PVE/HA/Env/PVE2.pm @@ -458,9 +458,17 @@ sub

Re: [pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option

Am 16.06.23 um 10:23 schrieb Thomas Lamprecht: > Am 16/06/2023 um 09:35 schrieb Fiona Ebner: >> The associated pve_verify_vmid() method already restricts the value >> to this range, but this wouldn't be visible in the API viewer for >> example [0]. >> >> Th

[pve-devel] [PATCH common] schema: explicitly set min/max for vmid option

rum.proxmox.com/threads/128845/post-564526 Signed-off-by: Fiona Ebner --- src/PVE/JSONSchema.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 60b02cb..7589bba 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSch

[pve-devel] [PATCH qemu 1/2] regenerate patches

There's still some context changes not covered by earlier series. No functional change intended. Signed-off-by: Fiona Ebner --- ...VE-add-savevm-async-for-background-state-snapshots.patch | 4 ++-- .../pve/0020-PVE-Add-dummy-id-command-line-parameter.patch | 4 ++-- ...E-Compat-4.0

[pve-devel] [PATCH qemu 2/2] fix checks for drive mirror with bitmap

-by: Fiona Ebner --- ...rive-mirror-add-support-for-sync-bitmap-mode-never.patch | 4 ++-- ...03-mirror-add-check-for-bitmap-mode-without-bitmap.patch | 2 +- .../bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch | 6 +++--- .../0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch | 2

[pve-devel] [PATCH common] syslog: interpret priority level 'warn' correctly

amprecht Signed-off-by: Fiona Ebner --- src/PVE/SafeSyslog.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/SafeSyslog.pm b/src/PVE/SafeSyslog.pm index 7d3e7a7..af105a1 100644 --- a/src/PVE/SafeSyslog.pm +++ b/src/PVE/SafeSyslog.pm @@ -18,7 +18,11 @@ my $log_ta

Re: [pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property

Am 13.06.23 um 15:42 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > src/PVE/VZDump/Common.pm | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index a6fe483..28ab0d3 100644 > --- a/src/PVE/VZDump/Common.pm

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

Am 14.06.23 um 13:44 schrieb Aaron Lauterer: > On 6/14/23 13:38, Thomas Lamprecht wrote: >> Am 14/06/2023 um 13:28 schrieb Aaron Lauterer: >>> This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. >>> >>> The bug should be fixed by now [0]. The reproducer doesn't cause any >>> issues in my

Re: [pve-devel] [PATCH qemu-server] status: fix description of qmpstatus property

Ping Am 03.03.23 um 08:35 schrieb Fiona Ebner: > Using the word 'agent' is highly confusing here as there is no QMP > agent and thus wrongly suggests that the value is related to the > guest agent[0]. > > [0]: https://forum.proxmox.com/threads/123590/post-537716 >

Re: [pve-devel] [PATCH guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property

Am 13.06.23 um 15:42 schrieb Alexander Zeidler: > Signed-off-by: Alexander Zeidler > --- > src/PVE/VZDump/Common.pm | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm > index a6fe483..28ab0d3 100644 > --- a/src/PVE/VZDump/Common.pm

Re: [pve-devel] [PATCH container 3/4] add 'pbs-entries-max' parameter

Am 13.06.23 um 15:42 schrieb Alexander Zeidler: > configuring pbs-entries-max can avoid failing backups due to a high > amount of files in folders where a folder exclusion is not possible > > Signed-off-by: Alexander Zeidler > --- > src/PVE/VZDump/LXC.pm | 5 + > 1 file changed, 5 insertions

Re: [pve-devel] [PATCH manager 1/4] api: backup: refactor backup permission check

Am 13.06.23 um 15:42 schrieb Alexander Zeidler: > Unify style before adding another parameter check > > Signed-off-by: Alexander Zeidler > --- > PVE/API2/Backup.pm | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm > index 45e

Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

Am 12.06.23 um 16:54 schrieb Thomas Lamprecht: > Am 12/06/2023 um 13:22 schrieb Fiona Ebner: >> Instead of getting rid of the "print once per line" handling, can't we >> rather adapt the invocation for backup to bubble up the other log lines too? > > would it

[pve-devel] applied-series: [PATCH-SERIES v6 qemu-server/manager] add and set x86-64-v2-AES as default model for new vms

Am 08.06.23 um 11:51 schrieb Alexandre Derumier: > > Hi, > > we used kvm64 as default cpumodel since the begin of proxmox. (basically, > it's like a pentium4 cpu flags). > > New distros like rhel9 are compiled to use more modern cpu flags. > (and windows already use new flags since year, and we

[pve-devel] [PATCH v2 ha-manager 1/2] tests: simulate stale maintainance node caused by simultaneous cluster shutdown

ommit will address the issue. Signed-off-by: Fiona Ebner --- Changes in v2: * Rebase on current master. * Split out introducing the test into a dedicated patch. src/test/test-stale-maintenance-node/cmdlist | 6 ++ .../datacenter.cfg| 5 + .../hardware_s

[pve-devel] [PATCH v2 ha-manager 2/2] manager: clear stale maintenance node caused by simultaneous cluster shutdown

already in the process of being shut down too. If a user ends up in this edge case, it would be rather surprising that the service would be automatically migrated back to the "maintenance node" which actually is not in maintenance mode anymore after a migration away from it. Signed-off

[pve-devel] [PATCH v2 storage] api: config: add/update storage: check for type mismatch first

This avoids confusing errors about other properties when the storage type doesn't match. By highlighting that the type doesn't match, users should know right away what the issue is. Signed-off-by: Fiona Ebner --- Changes in v2: * Avoid unshift, prepend type directly to loop list.

Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

Am 12.06.23 um 13:22 schrieb Fiona Ebner: > Am 09.05.23 um 10:46 schrieb Christoph Heiss: >> +my $err = ''; >> +$run_params{logfunc} = sub { $err .= "QEMU: $1\r\n"; }; > > Style nit: please use $run_params->{logfunc} Please ign

Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

Am 09.05.23 um 10:46 schrieb Christoph Heiss: > @@ -5922,13 +5916,19 @@ sub vm_start_nolock { > $tpmpid = start_swtpm($storecfg, $vmid, $tpm, $migratedfrom); > } > > + # '\r\n' needs to be used as a line separator here, as that is what > run_command() splits > +

[pve-devel] [PATCH widget-toolkit 2/2] apt repositories: avoid potential type error in classifyOrigin helper

with undefined (or otherwise falsy) argument. Signed-off-by: Fiona Ebner --- src/node/APTRepositories.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index 47c0a2c..016118e 100644 --- a/src/node/APTRepositories.js +++ b/src/node

[pve-devel] [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text

nd running apt update. Signed-off-by: Fiona Ebner --- Not too difficult to run into with external repos during upgrade preparation (when they are not yet bookworm-ready), so might also be worth it for the stable branch? src/node/APTRepositories.js | 2 +- 1 file changed, 1 insertion(+),

[pve-devel] [PATCH storage] api: config: add/update storage: check for type mismatch first

This avoids confusing errors about other properties when the storage type doesn't match. By highlighting that the type doesn't match, users should know right away what the issue is. Signed-off-by: Fiona Ebner --- src/PVE/API2/Storage/Config.pm | 2 +- 1 file changed, 1 insertion(+),

Re: [pve-devel] [PATCH stable proxmox-apt 1/1] repositories: also detect repository with next suite as configured

comment about "for next time" below. > > On Mon, Jun 05, 2023 at 05:43:08PM +0200, Fiona Ebner wrote: >> This avoids that no standard Proxmox repository can be detected during >> upgrade anymore. There is a 'ignore-pre-upgrade-warning' about the >> suit

[pve-devel] [PATCH manager] ui: qemu: show progress bar for resize task

The API call was changed to spawn a task now. Signed-off-by: Fiona Ebner --- Dependency bump for qemu-server needed. www/manager6/qemu/HDResize.js | 4 1 file changed, 4 insertions(+) diff --git a/www/manager6/qemu/HDResize.js b/www/manager6/qemu/HDResize.js index f9c7290d..97bec73b

[pve-devel] [PATCH qemu-server] qm: remote migration: improve error when storage cannot be found

It can also be a permission issue, so the current error can be a bit confusing. Reported in the community forum: https://forum.proxmox.com/threads/120619/post-562660 Signed-off-by: Fiona Ebner --- PVE/CLI/qm.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/qm.pm b

[pve-devel] [PATCH v2 guest-common] vzdump: config: improve description of ionice setting

then and does not inherit the ionice priority. Signed-off-by: Fiona Ebner --- No changes in v2. src/PVE/VZDump/Common.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index 64c4e4e..a6fe483 100644 --- a/src/PVE/VZDump

[pve-devel] [PATCH v2 manager 1/2] close #4513: ui: backup job: add performance tab

be added with appropriate notes if there is enough user demand. Signed-off-by: Fiona Ebner --- Changes in v2: * drop mistakenly copy-pased hint name 'pbs-hint' * use second column for description * align empty text right to match what bwlimit field does * use title case for

[pve-devel] [PATCH v2 docs] backup: update information about performance settings

Signed-off-by: Fiona Ebner --- No changes in v2. vzdump.adoc | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index f3eadcd..bd5bc58 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -214,11 +214,12 @@ the behaviour for catching up. By

[pve-devel] [PATCH v2 manager 2/2] ui: backup job: disable zstd thread count field when zstd isn't used

Also need to check for enable/disable of the compression selector, because with PBS the value zstd is set, but the thread count setting doesn't apply. Suggested-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- New in v2. www/manager6/dc/Backup.js | 18 ++

Re: [pve-devel] [PATCH v4 qemu-server 1/1] cpuconfig: add new x86-64-vX models

Am 07.06.23 um 12:57 schrieb DERUMIER, Alexandre: >> >> So again, sounds like the xsave feature is required for the osxsave >> feature to even make sense. >> > The problem is that xsaves is not supported on all intel/amd cpu,  > > older model don't seem to support xsaves too (intel only since > s

Re: [pve-devel] applied: [PATCH edk2-firmware] add patch to work around older guest kernel bug

Am 07.06.23 um 11:04 schrieb Fiona Ebner: > Am 06.06.23 um 16:26 schrieb Thomas Lamprecht: >> applied, but fixed line endings of patch, edk2 (sadly) uses Windows-Style >> \r\n, >> but the patch only got \n, so failed building a DSC: >> > > Hmm, it's correct

Re: [pve-devel] [RFC storage] content-dirs: check that all content dirs are pairwise inequal

Am 21.03.23 um 18:03 schrieb Friedrich Weber: > This prevents strange interactions in case the same content directory > is used for multiple content types. > Should we also check in the create/update API calls for syntactic duplicates and fail the call? E.g. I can successfully issue: pvesh set /s

Re: [pve-devel] applied: [PATCH edk2-firmware] add patch to work around older guest kernel bug

Am 06.06.23 um 16:26 schrieb Thomas Lamprecht: > > nit: a slightly more telling subject could have been something like: > > backport limiting the phys-bits to 46 for bug in old guest kernel Yes, sorry. My commit title was too generic. > Am 05/06/2023 um 09:43 schrieb Fio

Re: [pve-devel] [PATCH storage 2/2] rbd: volume resize: avoid passing floating point value to rbd

Am 06.06.23 um 19:37 schrieb Thomas Lamprecht: > Am 28/04/2023 um 14:32 schrieb Fiona Ebner: >> >> -my $cmd = $rbd_cmd->($scfg, $storeid, 'resize', '--size', >> ($size/1024/1024), $name); >> +my $cmd = $rbd_cmd->($scfg, $storeid,

Re: [pve-devel] [PATCH v4 qemu-server 1/1] cpuconfig: add new x86-64-vX models

Am 06.06.23 um 15:36 schrieb DERUMIER, Alexandre: > Le mardi 06 juin 2023 à 14:09 +0200, Fiona Ebner a écrit : >> Am 02.06.23 um 12:05 schrieb Alexandre Derumier: >>> >>> " >>> In 2020, AMD, Intel, Red Hat, and SUSE worked together to define >>

Re: [pve-devel] [PATCH v2 pve-manager 1/1] qemu: processor : set x86-64-v2-AES as default cputype for create wizard

Am 02.06.23 um 12:05 schrieb Alexandre Derumier: > --- Missing your Signed-off-by > www/manager6/qemu/OSDefaults.js| 1 + > www/manager6/qemu/ProcessorEdit.js | 13 + > 2 files changed, 14 insertions(+) > > diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefa

Re: [pve-devel] [PATCH v4 qemu-server 1/1] cpuconfig: add new x86-64-vX models

Am 02.06.23 um 12:05 schrieb Alexandre Derumier: > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg01592.html > " > In 2020, AMD, Intel, Red Hat, and SUSE worked together to define > three microarchitecture levels on top of the historical x86-64 > baseline: > > * x86-64:original x86

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

r upto first > boot to GUI login to installed system: > > > El 1/6/23 a las 18:00, Fiona Ebner escribió: >>> qm set -args '-cpu >>> kvm64,enforce,+kvm_pv_eoi,+kvm_pv_unhalt,+sep,+lahf_lm,+popcnt,+sse4.1,+sse4.2,+ssse3' > > This was good for all

[pve-devel] [PATCH qemu 1/2] update submodule and patches to QEMU 8.0.2

Signed-off-by: Fiona Ebner --- ...le-reentrancy-detection-for-script-R.patch | 4 +- ...39-fix-large_send_mss-divide-by-zero.patch | 72 ...en-getting-cursor-without-a-console.patch} | 2 +- ...-Fix-crash-when-executing-HMP-commit.patch | 48 --- ...our-channel-order-for-PNG

[pve-devel] [PATCH qemu 2/2] update reentrancy patches to version in upstream git

The previous version was picked from the mailing list and still had an object_dynamic_cast call in a hot path, which is avoided with the version that landed in git. Also adds a few more exceptions for devices that need reentrancy. Signed-off-by: Fiona Ebner --- ...-memory-prevent-dma-reentracy

Re: [pve-devel] [PATCH-SERIES guest-common/container/qemu-server/ha-manager] make HA manager not depend on internal configuration details

Am 28.02.23 um 11:54 schrieb Fiona Ebner: > by introducing a get_derived_property() method for the configuration > plugins. The derived properties are calculated by the plugins and will > stay the same regardless of changes to the configuration structure. > For example, this will a

Re: [pve-devel] [PATCH-SERIES qemu-server] adapt to QEMU 8.0 removed and deprecated features

Am 03.04.23 um 14:09 schrieb Fiona Ebner: > Fiona Ebner (4): > cfg2cmd: use actual backend names instead of removed tty and paraport > aliases > cfg2cmd: replace deprecated no-acpi option with acpi=off machine flag > cfg2cmd: replace deprecated no-hpet option with hpet=o

Re: [pve-devel] [PATCH-SERIES manager] backup permission improvements

Am 05.04.23 um 09:43 schrieb Fiona Ebner: > Am 16.11.22 um 15:04 schrieb Fiona Ebner: >> Currently, suffenciently privileged users may edit a backup job, but >> cannot run the very same job manually (via the vzdump API call). The >> first patch addresses this by removing the

Re: [pve-devel] [PATCH/RFC widget-toolkit 2/5] apt repositories: just ignore unknown info rather than throwing an error

Am 05.06.23 um 19:06 schrieb Thomas Lamprecht: > Am 05/06/2023 um 17:43 schrieb Fiona Ebner: >> This will avoid breaking older UI when extending the backend. >> >> Signed-off-by: Fiona Ebner >> --- >> src/node/APTRepositories.js | 2 -- >> 1 file changed

[pve-devel] [PATCH widget-toolkit 3/5] apt repositories: add classifyOrigin helper

to be used again to detect mixed repositories before upgrade. Needed to convert into an actual function for the 'this' usage. Signed-off-by: Fiona Ebner --- src/node/APTRepositories.js | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

[pve-devel] [PATCH/RFC widget-toolkit 2/5] apt repositories: just ignore unknown info rather than throwing an error

This will avoid breaking older UI when extending the backend. Signed-off-by: Fiona Ebner --- src/node/APTRepositories.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index cb08bb6..ed58e5b 100644 --- a/src/node/APTRepositories.js

[pve-devel] [PATCH stable proxmox-apt 1/1] repositories: also detect repository with next suite as configured

This avoids that no standard Proxmox repository can be detected during upgrade anymore. There is a 'ignore-pre-upgrade-warning' about the suite already, that the frontend can display when upgrading is not allowed yet. Signed-off-by: Fiona Ebner --- It's not ideal, for the time b

[pve-devel] [PATCH widget-toolkit 4/5] apt repositories: detect mixed suites before major upgrade

Usually, differing suites already produce warnings/errors, but before a major upgrade the current and the next suite are both valid. Mixing them is an issue though. Signed-off-by: Fiona Ebner --- src/node/APTRepositories.js | 35 +-- 1 file changed, 33 insertions

[pve-devel] [PATCH stable-bullseye widget-toolkit 5/5] apt repositoires: allow major upgrade

Currently, all this does is silence warnings when the suite after the current one is configured as well as enabling the check for mixed repositiories. Since there is no API call as mentioned in the comment yet, just set it manually. Signed-off-by: Fiona Ebner --- Intended only for the stable

[pve-devel] [PATCH-SERIES proxmox-apt/widget-toolkit] prepare for major upgrade

check for mixed repositories when upgrade is allowed. The final UI patch is intended for the stable branch only and makes sure that the warning handling expects a major upgrade to be allowed. proxmox-apt: Fiona Ebner (1): repositories: also detect repository with next suite as configured

[pve-devel] [PATCH widget-toolkit 1/5] apt repositories: actually ignore ignore-pre-upgrade-warning

when upgrading is possible rather than throwing an error by reaching the else branch. Signed-off-by: Fiona Ebner --- src/node/APTRepositories.js | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index 1fb627c

[pve-devel] [PATCH proxmox] apt: tests: remove output directories before running test

CARGO_TARGET_TMPDIR") and re-introduce the remove-before-test logic. Fixes: 9b7c533 ("apt: tests: create temporary test directories in CARGO_TARGET_TMPDIR") Signed-off-by: Fiona Ebner --- proxmox-apt/tests/repositories.rs | 10 ++ 1 file changed, 10 insertions

[pve-devel] [PATCH widget-toolkit] apt repositories: add production ready warnings for Ceph repositories

Could've been done for the test repository already, but now that there is a split between no-subscription and enterprise it becomes even more relevant. Reported-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- src/node/APTRepositories.js | 48 ++--- 1

[pve-devel] [PATCH edk2-firmware] add patch to work around older guest kernel bug

by limiting the phys-bits to 46 instead of 47. On Ubuntu 18.04 with kernel 4.15, using 47 leads to a strange issue where initialization of VirtIO devices would fail. Reported in the community forum: https://forum.proxmox.com/threads/127410/ Signed-off-by: Fiona Ebner --- ...latformInitLib

Re: [pve-devel] [PATCH v3 docs 7/7] storage: add hint to avoid storage aliasing

Am 01.06.23 um 15:53 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > I am happy for suggestions on how to improve the phrasing if it is not > clear enough. > > pvesm.adoc | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/pvesm.adoc b/pvesm.adoc > index 6ade1a4..7e91c50

Re: [pve-devel] [PATCH v3 container 5/7] migration: only migrate volumes used by the guest

::LXC::Config->foreach_volume($conf->{pending}, $test_mp); > +} > + Other than that, both container patches: Reviewed-by: Fiona Ebner ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v3 qemu-server 4/7] tests: add migration alias check

Am 01.06.23 um 15:53 schrieb Aaron Lauterer: > @@ -351,9 +387,9 @@ my $source_vdisks = { > { > 'ctime' => '1589277334', > 'format' => 'raw', > - 'size' => 108003328, > - 'vmid' => '111', > - 'volid' => 'local-zfs:vm-111-disk-0', > + 'size' =

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

Am 02.06.23 um 11:13 schrieb DERUMIER, Alexandre: >> >> "catastrophic performance collapses" doesn't sound very promising :/ >> > > I have found another thread here: > https://lore.kernel.org/all/0484ea3f-4ba7-4b93-e976-098c57171...@redhat.com/ > where paolo have done benchmark with only 3% differ

Re: [pve-devel] [PATCH v3 qemu-server 1/7] migration: only migrate disks used by the guest

Am 02.06.23 um 11:45 schrieb Fiona Ebner: > Am 01.06.23 um 15:53 schrieb Aaron Lauterer: >> When scanning all configured storages for disk images belonging to the >> VM, the migration could easily fail if a storage is not available, but >> enabled. That storage might not even

Re: [pve-devel] [PATCH v3 qemu-server 1/7] migration: only migrate disks used by the guest

Am 01.06.23 um 15:53 schrieb Aaron Lauterer: > When scanning all configured storages for disk images belonging to the > VM, the migration could easily fail if a storage is not available, but > enabled. That storage might not even be used by the VM at all. > > By not doing that and only looking at

[pve-devel] [PATCH v2 proxmox 5/5] apt: tests: add tests for Ceph Quincy repository detection on Bookworm

Signed-off-by: Fiona Ebner --- No changes in v2. proxmox-apt/tests/repositories.rs | 30 +++ .../ceph-quincy-bookworm.list | 6 .../ceph-quincy-nosub-bookworm.list | 2 ++ .../sources.list.d/ceph-quincy-bookworm.list | 4

[pve-devel] [PATCH v2 proxmox 4/5] apt: tests: code cleanup to avoid useless vector

Signed-off-by: Fiona Ebner --- No changes in v2. proxmox-apt/tests/repositories.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/proxmox-apt/tests/repositories.rs b/proxmox-apt/tests/repositories.rs index 6319a62..2fb7ac8 100644 --- a/proxmox-apt/tests/repositories.rs

[pve-devel] [PATCH v2 proxmox 1/5] apt: drop older Ceph standard repositories

On Proxmox VE 8, only Quincy and newer will be supported. Signed-off-by: Fiona Ebner --- No changes in v2. Changes for the series in v2: * create temporary test directories inside CARGO_TARGET_TMPDIR * mention that deprecated 'main' component maps to no-subscriptio

[pve-devel] [PATCH v2 proxmox 2/5] apt: split Ceph main repository into no-subscription and enterprise

d be needed here too. So overall, the above alternative just felt better. Signed-off-by: Fiona Ebner --- Changes in v2: * mention that 'main' component now maps to no-subscription proxmox-apt/src/repositories/mod.rs| 3 +- proxmox-apt/src/repositories/repository.r

[pve-devel] [PATCH v2 proxmox 3/5] apt: tests: create temporary test directories in CARGO_TARGET_TMPDIR

Signed-off-by: Fiona Ebner --- New in v2. proxmox-apt/tests/repositories.rs | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/proxmox-apt/tests/repositories.rs b/proxmox-apt/tests/repositories.rs index 4b3c9de..6319a62 100644 --- a/proxmox-apt/tests

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

Am 01.06.23 um 23:15 schrieb DERUMIER, Alexandre: > Hi, > I found an interesting thread on the forum about kvm_pv_unhalt > > https://forum.proxmox.com/threads/live-migration-between-intel-xeon-and-amd-epyc2-linux-guests.68663/ > > > Sounds good. Please also take a look at the default flag > "kvm

[pve-devel] [PATCH proxmox 4/4] apt: tests: add tests for Ceph Quincy repository detection on Bookworm

Signed-off-by: Fiona Ebner --- proxmox-apt/tests/repositories.rs | 30 +++ .../ceph-quincy-bookworm.list | 6 .../ceph-quincy-nosub-bookworm.list | 2 ++ .../sources.list.d/ceph-quincy-bookworm.list | 4 +++ .../ceph-quincy-nosub

[pve-devel] [PATCH proxmox 1/4] apt: drop older Ceph standard repositories

On Proxmox VE 8, only Quincy and newer will be supported. Signed-off-by: Fiona Ebner --- proxmox-apt/src/repositories/mod.rs | 4 -- proxmox-apt/src/repositories/standard.rs | 58 proxmox-apt/tests/repositories.rs| 4 -- 3 files changed, 66 deletions

[pve-devel] [PATCH proxmox 3/4] apt: tests: code cleanup to avoid useless vector

Signed-off-by: Fiona Ebner --- proxmox-apt/tests/repositories.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/proxmox-apt/tests/repositories.rs b/proxmox-apt/tests/repositories.rs index 4b3c9de..710e2f7 100644 --- a/proxmox-apt/tests/repositories.rs +++ b/proxmox-apt

[pve-devel] [PATCH proxmox 2/4] apt: split Ceph main repository into no-subscription and enterprise

d be needed here too. So overall, the above alternative just felt better. Signed-off-by: Fiona Ebner --- Hope the URLs are correct like this. proxmox-apt/src/repositories/mod.rs| 3 +- proxmox-apt/src/repositories/repository.rs | 10 ++- proxmox-apt/src/repositorie

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

Am 01.06.23 um 14:02 schrieb Eneko Lacunza: > Hi, > > We have Ryzen 1700, 2600X, 3700 and 5950X machines here, I can test on > them if that helps (please detail tests to perform). > > Thanks > Hi, thank you for the offer. It would be interesting to see if you have any issues with the following:

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

Am 01.06.23 um 15:53 schrieb DERUMIER, Alexandre: >>> >>> What AMD CPUs did you try it on? >>> >> epyc v2/v3 with last microcodes >> >> >> does it work with x86-64-v3 ?  (because the other patch of the series >> could autofind the best new model if it's working) > > Looking at linux kernel code, t

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

Am 22.05.23 um 12:25 schrieb Alexandre Derumier:> Nahelemn is a 2008 cpu, so I think it's ok, we are in 2013 ;) > (and user can disable aes flag in gui too) > > That mean than the minimum compatible cpu for v2 is Intel Westmere (2010) > and Amd Bulldozer (2011). > Unfortunately, it doesn't seem t

Re: [pve-devel] [PATCH v3 qemu-server 1/7] cpuconfig: add new x86-64-vX models

Am 31.05.23 um 17:08 schrieb DERUMIER, Alexandre: >>>   >>> +my $builtin_models = { >>> +    'x86-64-v1' => { >>> +   'reported-model' => 'Opteron_G1', >> >> It's unfortunate that we'll report this model and hence also AMD as >> vendor even on Intel hosts and vice versa for the other models. We

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

Am 31.05.23 um 16:34 schrieb DERUMIER, Alexandre: > Le mercredi 31 mai 2023 à 13:36 +0200, Fiona Ebner a écrit : >> Am 22.05.23 um 12:25 schrieb Alexandre Derumier: >>> In addition to theses model, I have enabled aes too. >>> I think it's really important, be

Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel

Am 22.05.23 um 12:25 schrieb Alexandre Derumier: > In addition to theses model, I have enabled aes too. > I think it's really important, because a lot of users use default values and > have > bad performance with ssl and other crypto stuffs. > So there is the answer to my aes question :) But sho

<    6   7   8   9   10   11   12   13   14   15   >