Re: [pve-devel] [PATCH qemu-server 1/1] fix #5365: drive: add drive_is_cloudinit check to get_scsi_devicetype

2024-04-10 Thread Hannes Dürr
On 4/10/24 11:34, Thomas Lamprecht wrote: This is not bug #5365 [0] (which is about a ceph device class UX improvement) but #5363 [0]. [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5365 [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=5363 Good catch, thank you ! I mostly noticed becaus

Re: [pve-devel] [PATCH pve-storage v4 2/2] fix #1611: implement import of base-images for LVM-thin Storage

2024-04-10 Thread Hannes Dürr
On 1/30/24 11:00, Fabian Grünbichler wrote: On December 19, 2023 3:03 pm, Hannes Duerr wrote: for base images we call the volume_import of the parent plugin and pass it as vm-image instead of base-image, then convert it back as base-image Signed-off-by: Hannes Duerr --- src/PVE/Storage/LvmT

Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

2024-03-06 Thread Hannes Dürr
On 3/6/24 15:04, Fiona Ebner wrote: Yes, but the question is what is worse: Needing to re-do the clone or having the VM config on the wrong node? To avoid that, I'd lean towards keeping the behavior of failing the task if deactivating $newvollist fails. After all, at least in case of LVM not

Re: [pve-devel] fix #5254: add separate Sys.AccessNetwork privilege

2024-02-20 Thread Hannes Dürr
Tested the patch by 1. * creating a role with 'Datastore.Audit,Datastore.AllocateTemplate,Sys.AccessNetwork' * creating a user with permission for specific {storage} and {node} * downloading the iso via gui 2. * creating a role with 'Datastore.AllocateTemplate,Sys.AccessNetwork' * creatin

Re: [pve-devel] [PATCH docs] ballooning example: improve wording

2024-01-16 Thread Hannes Dürr
I don't think this is an improvement of the wording, liked the previous version more. Are there people who have not understood the wording? On 1/16/24 14:11, Alexander Zeidler wrote: Signed-off-by: Alexander Zeidler --- qm.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-16 Thread Hannes Dürr
On 1/16/24 11:34, Thomas Lamprecht wrote: Am 15/01/2024 um 16:53 schrieb Hannes Dürr: Tested cluster creation with three new nodes on 8.1 and the patches Cluster creation and further ssh communication (eq. migration) worked flawless Tested-by: Hannes Duerr What about the reinstallation of

Re: [pve-devel] [PATCH cluster/manager/storage/docs 0/9] fix #4886: improve SSH handling

2024-01-15 Thread Hannes Dürr
Tested cluster creation with three new nodes on 8.1 and the patches Cluster creation and further ssh communication (eq. migration) worked flawless Tested-by: Hannes Duerr On 1/11/24 11:51, Fabian Grünbichler wrote: this series replaces the old mechanism that used a cluster-wide merged known

Re: [pve-devel] [PATCH v2 qemu-server] fix #4501: TCP migration: start vm: move port reservation and usage closer together

2023-12-27 Thread Hannes Dürr
I live-migrated 300 vms with: migration: insecure max_workers: 30 and 10 parallel workers (as described here https://forum.proxmox.com/threads/live-migration.127355/#post-557181) Had zero issues with the patch applied, without the patch i had ~30 errors Tested-by: Hannes Duerr On 12/20/23 13

Re: [pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage

2023-12-18 Thread Hannes Dürr
On 12/14/23 15:23, Fiona Ebner wrote: create_base() will tell you the actual name, you should not override it with the old one. We expect it to match, but then there's no need for the assignment. If it doesn't match, you'd be returning something wrong. Or what am I missing? If i am not mistaken

Re: [pve-devel] [PATCH pve-network] validation: add support for arrays to change tracking

2023-11-28 Thread Hannes Dürr
Tested-by: Hannes Duerr On 11/22/23 13:28, Stefan Hanreich wrote: This is needed so dhcp-ranges are properly displayed as changed in the web UI. Also took the chance to properly indent the encode_value function with our indentation scheme. Signed-off-by: Stefan Hanreich --- src/PVE/Network

Re: [pve-devel] [PATCH pve-manager] sdn: ipam: fix ipam grouping identical subnets in different vnets

2023-11-28 Thread Hannes Dürr
Tested-by: Hannes Duerr On 11/28/23 09:58, Stefan Hanreich wrote: When SDN is configured with the same subnet in two different VNets the IPAM tree would render them wrongly. Reported-By: Hannes Duerr Signed-off-by: Stefan Hanreich --- www/manager6/tree/DhcpTree.js | 10 +++--- 1 file

Re: [pve-devel] [PATCH v4 qemu-server 4/4] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-17 Thread Hannes Dürr
New Version can be found here: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060429.html On 11/17/23 12:53, Hannes Duerr wrote: adds vendor and product information for SCSI devices to the json schema and checks in the VM create/update API call if it is possible to add these to QEMU

Re: [pve-devel] [PATCH pve-storage] fix #1611: implement import of base-images for LVM-thin Storage

2023-11-13 Thread Hannes Dürr
On 11/3/23 11:39, Fiona Ebner wrote: [...] This essentially duplicates most of the same function in the parent plugin, i.e. LVMPlugin. What you can do to avoid it, is introduce new helper functions for the parts that are different, call those in LVMPlugin's implementation and overwrite the help

Re: [pve-devel] [PATCH v2 qemu-server] fix #4957: add vendor and product information passthrough for SCSI-Disks

2023-11-08 Thread Hannes Dürr
On 11/8/23 11:04, Fiona Ebner wrote: Am 08.11.23 um 09:51 schrieb Hannes Duerr: adds vendor and product information for SCSI devices to the json schema and checks in the VM create/update API call if it is possible to add these to QEMU as a device option Signed-off-by: Hannes Duerr --- chang