gettext is rather dumb and does not like multi-line strings or string
interpolation.
Reported-by: Maximiliano Sandoval
Signed-off-by: Lukas Wagner
---
src/panel/NotificationConfigView.js | 4 ++--
src/panel/SendmailEditPanel.js | 4 +---
2 files changed, 3 insertions(+), 5 deletions
gettext is rather dumb and does not like multi-line strings or string
interpolation.
Also removed some unneeded gettext calls (mail-to-root should not be
translated.)
Reported-by: Maximiliano Sandoval
Signed-off-by: Lukas Wagner
---
www/manager6/dc/NotificationEvents.js | 7 +++
1 file
On 8/28/23 11:30, Gabriel Goller wrote:
Already submitted the patch to `proxmox_sys::mail::sendmail` in the
other mailing list (pbs-devel) :)
Ah yes, I missed that. Nevermind then :)
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.c
erl impl, PBS and PVE use the Rust
impl).
Apart from that: From briefly skimming through the RFC the change makes
sense, so consider this:
Reviewed-by: Lukas Wagner
--
- Lukas
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
to render the whole template (leading
to no notification being sent).
Signed-off-by: Lukas Wagner
---
proxmox-notify/examples/render.rs| 2 +-
proxmox-notify/src/renderer/html.rs | 2 +-
proxmox-notify/src/renderer/mod.rs | 58 ++--
proxmox-notify/src
be a good idea to actually hunt down the places that produced
the string instead of an integer, but as a quick fix and as a
safeguard against similar lurking errors this approach is fine, IMO.
Signed-off-by: Lukas Wagner
---
Popped up in:
https://forum.proxmox.com/threads/keine-mails-mehr-nach
On 8/7/23 15:06, Lukas Wagner wrote:
This patch series adds support for a new notification endpoint type,
smtp. As the name suggests, this new endpoint allows PVE to talk
to SMTP server directly, without using the system's MTA (postfix).
A v2 will follow, I need to refactor a few thing
On 8/2/23 12:53, Dominik Csapak wrote:
this adds a 'tagview' to the web ui, organizing guests by their tags
(for details see the pve-manager patch)
Gave this a quick test on the respective latest master branches. Seems
to work as advertised. Consider this:
Tested-by: Lu
Thanks for the review! Comments inline.
On 8/22/23 12:08, Max Carrara wrote:
On 8/21/23 15:44, Lukas Wagner wrote:
For now, it contains a file-backed cache with expiration logic.
The cache should be safe to be accessed from multiple processes at
once.
This seems pretty neat! The cache
On 8/21/23 15:44, Lukas Wagner wrote:
+my $status_cache = PVE::RS::Cache->pvestatd_cache();
Urgh, just noticed that I seemingly have forgotten to commit a
refactoring step in `pve-storage`.
Should be `Proxmox::RS::SharedCache->new("/run/pvestatd-cache")`
Everything el
the cache
very frequently (due to the overhead of JSON de/serialization)
- Require arbitrary keys - right now, keys are limited by
SAFE_ID_REGEX
The cache was developed for the use in pvestatd, in order to cache
e.g. storage plugin status. There, these limitations do not really
pla
Signed-off-by: Lukas Wagner
---
proxmox-cache/debian/changelog | 5
proxmox-cache/debian/control | 47 ++
proxmox-cache/debian/copyright | 18
proxmox-cache/debian/debcargo.toml | 7 +
4 files changed, 77 insertions(+)
create
Cache storage plugin status so that pvestatd and API calls can use the
cached results, without having to query all storage plugins again.
Signed-off-by: Lukas Wagner
---
src/PVE/API2/Storage/Config.pm | 10 +
src/PVE/Storage.pm | 40 --
2
Under the hood, this function calls `mkdtemp` from libc. Unfortunatly
the nix crate did not provide bindings for this function, so we have
to call into libc directly.
Signed-off-by: Lukas Wagner
---
proxmox-sys/src/fs/dir.rs | 73 +--
1 file changed, 71
It seems like the mentioned clippy bug has since been fixed.
Signed-off-by: Lukas Wagner
---
proxmox-sys/src/fs/dir.rs | 4
proxmox-sys/src/fs/mod.rs | 2 --
2 files changed, 6 deletions(-)
diff --git a/proxmox-sys/src/fs/dir.rs b/proxmox-sys/src/fs/dir.rs
index 72bf1ad..0c1d151 100644
This ensures that test code is not compiled in regular builds
Signed-off-by: Lukas Wagner
---
proxmox-sys/src/fs/dir.rs | 29 +
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/proxmox-sys/src/fs/dir.rs b/proxmox-sys/src/fs/dir.rs
index bdef85e
there was not much thought behind that value.
The first three patches for `proxmox` are purely preparatory and cleanup.
proxmox:
Lukas Wagner (5):
sys: fs: move tests to a sub-module
sys: add make_tmp_dir
sys: fs: remove unnecessary clippy allow directive
cache: add new crate 'pr
Signed-off-by: Lukas Wagner
---
common/pkg/Makefile | 1 +
common/src/cache.rs | 59 +
common/src/mod.rs | 1 +
pve-rs/Cargo.toml | 5
pve-rs/src/lib.rs | 1 +
5 files changed, 67 insertions(+)
create mode 100644 common/src/cache.rs
or that is shared between sendmail and smtp
endpoints has been moved to a new `endpoints::common::mail` module.
Signed-off-by: Lukas Wagner
---
Cargo.toml | 1 +
proxmox-notify/Cargo.toml | 4 +-
proxmox-notify/src/config.rs
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/api/mod.rs | 48 +
proxmox-notify/src/api/smtp.rs | 373 +
2 files changed, 421 insertions(+)
create mode 100644 proxmox-notify/src/api/smtp.rs
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notify
tches require
v6 of the original notification patches [1] series to be applied
first. The patches for proxmox and proxmox-perl-rs are based of the
latest master branch.
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-August/058618.html
proxmox:
Lukas Wagner (4):
notify: add 'smtp
Signed-off-by: Lukas Wagner
---
proxmox-notify/debian/control | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/proxmox-notify/debian/control b/proxmox-notify/debian/control
index a5d6ea3..af936df 100644
--- a/proxmox-notify/debian/control
+++ b/proxmox
.
Signed-off-by: Lukas Wagner
---
src/Makefile | 2 +
src/Schema.js| 5 +
src/panel/EmailRecipientPanel.js | 93 +++
src/panel/SendmailEditPanel.js | 69 ++-
src/panel/SmtpEditPanel.js | 192 +++
5
code.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 337 ++
1 file changed, 337 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index ec666903..0f9d6432 100644
--- a/PVE/API2/Cluster/Notifications.pm
Signed-off-by: Lukas Wagner
---
proxmox-notify/src/lib.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs
index ceaca62..af88725 100644
--- a/proxmox-notify/src/lib.rs
+++ b/proxmox-notify/src/lib.rs
@@ -106,7 +106,7
Signed-off-by: Lukas Wagner
---
common/src/notify.rs | 110 +++
1 file changed, 110 insertions(+)
diff --git a/common/src/notify.rs b/common/src/notify.rs
index 9f44225..1d379fa 100644
--- a/common/src/notify.rs
+++ b/common/src/notify.rs
@@ -13,6 +13,10
Signed-off-by: Lukas Wagner
---
notifications.adoc | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/notifications.adoc b/notifications.adoc
index c4d2931..839ed41 100644
--- a/notifications.adoc
+++ b/notifications.adoc
@@ -72,9 +72,37
g
sendmail endpoints. The dialog is 'plugin-in' based, meaning that it
consists of a base window (EndpointEditBase) and a panel that holds
the actual fields for the endpoint type configuration. This will show
be beneficial once the GUI for other endpoint types is added.
Signed-off-by: Luka
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 255 ++
1
update API compat in the case that a notification shall be sent,
but without any configured notification target (which will then
default to 'mail-to-root').
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v5:
- Fix bug in permission check
PVE/API2
The GUI is based on the 'plugin-based' dialog window EndpointEditBase
that was introduced in an earlier commit.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v5:
- Extended commit message
Changes since v3:
- Use items/advancedItems instead of columns
Settings for notifications have been moved to their own view.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- New in v4
www/manager6/dc/OptionView.js | 20
1 file changed, 20 deletions(-)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc
This commit adds a new dialog window, containing all fields necessary
to configure notification filters.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v5:
- Extended commit message
Changes since v3:
- use items/advancedItems instead of columns
src/Makefile
This commit adds a new view that allows configuring notification
targets for all existing notification events (replication, updates,
fencing).
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v5:
- Fixed missing trailing commas
Changes since v4:
- No changes
Signed-off-by: Lukas Wagner
---
notifications.adoc | 159 +++
pve-admin-guide.adoc | 2 +
pve-gui.adoc | 2 +
vzdump.adoc | 5 ++
4 files changed, 168 insertions(+)
create mode 100644 notifications.adoc
diff --git a
This commit adds a new selector field for existing endpoint
configuration where one is able to select a notification filter.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v5:
- Extended commit message
src/Makefile| 1 +
src/form
end_notification`
- Breaking out some of the code into helper subs, hopefully
reducing the spaghetti factor a bit
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 10 +-
PVE/VZDump.pm | 335 +
test/mail_test.pl | 36 ++---
3 files c
Check notification targets configured in datacenter.cfg and jobs.cfg,
failing if the group/endpoint to be removed is still in use there.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 44 ++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff
The API call returns all entities that can be used as notification
targets (endpoints, groups). Only targets for which the user has
appropriate permissions are returned.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 81 +++
1 file changed, 81
This API call allows the user to test a notification target.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster/Notifications.pm | 40 +++
1 file changed, 40 insertions(+)
diff --git a/PVE/API2/Cluster/Notifications.pm
b/PVE/API2/Cluster/Notifications.pm
index
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 263 ++
1
... instead of using sendmail directly
If the new 'target-package-updates' is set, we send a notification to
this target. If not, we continue to send a mail to root@pam (if the
mail address is configured)
Signed-off-by: Lukas Wagner
---
PVE/API2/A
ls whether to send
a notification at all.
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 63 -
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm
index 89c5a802..d61518ba 100644
--- a/PVE/API2/
This commit adds a new Perl module, PVE::API2::Cluster::Notification.
The module will contain all API handlers for the new notification
subsystem.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster.pm | 7 +++
PVE/API2/Cluster/Makefile | 1 +
PVE/API2/Cluster
an 'anonymous' channel with a temporary
sendmail endpoint, sending mails to `root`
- Added new options for backup jobs
- Reworked git history
Versions of this patch series:
v5: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058467.html
v4: https://lists.proxmox.com/piper
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 305 ++
1
backup jobs. Some logic which automatically migrates from
'mailnotification' has been added.
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 4 +-
www/manager6/dc/Backup.js | 84 +--
www/manager6/form/Notifica
The GUI is based on the 'plugin-based' dialog window EndpointEditBase
that was introduced in an earlier commit.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v5:
- Extended commit message
Changes since v3:
- Use items/advancedItems instead of col
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 262 ++
1
In essence the same change as for backup jobs.
Signed-off-by: Lukas Wagner
---
www/manager6/window/Backup.js | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 4b21c746
Suggested-by: Dominik Csapak
Signed-off-by: Lukas Wagner
---
Notes:
In future, we could create a new API endpoint that returns all possible ACL
and then use a normal store for the perm path combobox?
Changes since v3:
- Removed API calls that fetch targets/filters
Virtual (or anonymous) endpoints/groups are used for sending
one-off notifications to a target that does not exist in the
config.
VZDump uses this to send out notification mails to those addresses
configured by the `mailto` parameter.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
Embed the new notification target configuration panel, implemented in
proxmox-widget-toolkit.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Config.js | 16
1 file changed, 16 insertions(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index aa025c8d
ACL paths for notification targets can become quite long, e.g.:
/mappings/notifications/
Signed-off-by: Lukas Wagner
---
www/manager6/form/PermPathSelector.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/form/PermPathSelector.js
b/www/manager6/form/PermPathSelector.js
index
Signed-off-by: Lukas Wagner
---
test/Makefile | 8
test/{mail_test.pl => vzdump_notification_test.pl} | 0
2 files changed, 4 insertions(+), 4 deletions(-)
rename test/{mail_test.pl => vzdump_notification_test.pl} (100%)
diff --git a/test/Ma
Adapt the backup job detail view so that it shows notification
targets.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/BackupJobDetail.js | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/BackupJobDetail.js
b/www/manager6/dc
#x27; paramter which controls if
notifications should be sent at all. If it is not set, we
default to the old behavior, which is to send.
Also add dependency to the `libpve-notify-perl` package to d/control.
Signed-off-by: Lukas Wagner
---
debian/control | 2 ++
src/PVE/HA/Env.pm|
Signed-off-by: Lukas Wagner
---
Notes:
Did not add version number since I do not know which it will be yet.
debian/control | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/control b/debian/control
index 3206b514..b807dbfe 100644
--- a/debian/control
+++ b/debian/control
On Wed Aug 2, 2023 at 10:02 AM CEST, Thomas Lamprecht wrote:
> FWIW, it might be also look slightly better, and save some space, if we'd
> move the add button inside the grid, i.e., at the right side below the last
> row. Would also shorten the way one has to move between adding a new tag input
> a
On Thu Jul 27, 2023 at 3:33 PM CEST, Christoph Heiss wrote:
> The checkbox is enabled by default for new realms, setting the new
> `check-connection` parameter.
>
> Won't effect existing configurations, i.e. being opt-in for them, to not
> break existing setups.
As mentioned in my other reply, I th
On Thu Jul 27, 2023 at 3:33 PM CEST, Christoph Heiss wrote:
> Removes the dreaded DN regex, instead introducing a connect/bind check
> on creation/update, aligning it with the way PBS does it. This is
> enabled by default for new realms, but opt-in for existing, to not break
> backwards-compatibili
Before, there was zero space between the the grid border line and the
button, making it look a bit odd.
The ListField form component is currently used in the
'User Tag Access' and 'Registered Tags' dialog windows in datacenter
option view.
Signed-off-by: Lukas Wagner
--
On 7/24/23 11:03, Christoph Heiss wrote:
tl;dr implements the result of the discussion in [0].
First, this removes the dreaded LDAP DN regex, replacing it instead with
a proper schema format, which does validation using
Net::LDAP::Util::canonical_dn().
Already discussed off-list, but for the s
ameter.
The modified AuthEdit{LDAP,AD} panel will now automatically migrate
to the new paramter by hooking into onGetValues/onSetValues.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/AuthEditAD.js | 43 +++--
www/manager6/dc/AuthEditLDAP.js | 42 +++
Signed-off-by: Lukas Wagner
---
www/manager6/dc/AuthEditAD.js | 2 +-
www/manager6/dc/AuthEditLDAP.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/dc/AuthEditAD.js b/www/manager6/dc/AuthEditAD.js
index bd46faaa..41390a47 100644
--- a/www/manager6/dc
Although 'SSL' is used colloquially, the proper term is 'TLS'.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/AuthEditAD.js | 2 +-
www/manager6/dc/AuthEditLDAP.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/dc/AuthEditAD.
Also improve API documentation in terms of which HttpError is
returned when.
Signed-off-by: Lukas Wagner
---
Notes:
Assumes that the following two patches have been applied before,
otherwise there will be a conflict (which is trivial to resolve,
though)
1: "notify
Use `proxmox-http-error::HttpError` instead of
`proxmox-notify::api::ApiError`.
Also factoring out the digest decoding into a small helper.
Signed-off-by: Lukas Wagner
---
common/src/notify.rs | 77 +++-
pve-rs/Cargo.toml| 1 +
2 files changed, 42
age.
Also add some smoke-tests to make sure that the `http_bail` and
`http_err` macros actually produce valid code.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
---
Cargo.toml| 2 +
proxmox-http-error/Cargo.toml | 16 +++
proxmox-http-error/src/l
.
- Drop unused 'derive' features for the serde dependency
proxmox:
Lukas Wagner (3):
http-error: add new http-error crate
router: re-export `HttpError` from `proxmox-http-error`
notify: use HttpError from proxmox-http-error
Cargo.toml | 2 +
proxmox-
Signed-off-by: Lukas Wagner
---
proxmox-router/Cargo.toml | 1 +
proxmox-router/src/error.rs | 42 +
proxmox-router/src/lib.rs | 2 +-
3 files changed, 3 insertions(+), 42 deletions(-)
diff --git a/proxmox-router/Cargo.toml b/proxmox-router/Cargo.toml
On 7/26/23 15:41, Wolfgang Bumiller wrote:
I'd like `proxmox-router` to keep re-exporting both the `http_bail/err`
macros and the `HttpError` type. This would require much fewer changes
at all the call sites, and we don't need to explicitly depend on the new
crate everywhere. Its point is mostly
hough, since we do not know if
the token has separated privileges enable or not.
Signed-off-by: Lukas Wagner
---
www/manager6/dc/ACLView.js | 14 ++
1 file changed, 14 insertions(+)
diff --git a/www/manager6/dc/ACLView.js b/www/manager6/dc/ACLView.js
index 79f900cd..ec81a487 100644
--
The `HttpError` type from `proxmox-router` has been moved into its
own crate.
Signed-off-by: Lukas Wagner
---
Cargo.toml | 3 +++
src/api2/access/openid.rs | 5 ++---
src/api2/access/tfa.rs | 3 ++-
src/api2/admin/datastore.rs
Use `proxmox-http-error::HttpError` instead of
`proxmox-notify::api::ApiError`.
Signed-off-by: Lukas Wagner
---
common/src/notify.rs | 77 +++-
pve-rs/Cargo.toml| 1 +
2 files changed, 42 insertions(+), 36 deletions(-)
diff --git a/common/src
Signed-off-by: Lukas Wagner
---
proxmox-auth-api/Cargo.toml | 2 ++
proxmox-auth-api/src/api/access.rs | 3 +-
proxmox-rest-server/Cargo.toml | 1 +
proxmox-rest-server/src/h2service.rs | 2 +-
proxmox-rest-server/src/rest.rs | 2 +-
proxmox-router/Cargo.toml
Also improve API documentation in terms of which HttpError is
returned when.
Signed-off-by: Lukas Wagner
---
Notes:
Assumes that the following two patches have been applied before,
otherwise there will be a conflict (which is trivial to resolve,
though)
1: "notify
previously used it's own error type, is now also using
the new crate.
proxmox:
Lukas Wagner (3):
http-error: add new http-error crate
router: rest-server: auth-api: use new http-error crate
notify: use HttpError from proxmox-http-error
Cargo.toml | 2 +
pr
age.
Also add some smoke-tests to make sure that the `http_bail` and
`http_err` macros actually produce valid code.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
---
Cargo.toml| 2 +
proxmox-http-error/Cargo.toml | 16 +++
proxmox-http-error/src/l
Note, this commit has now been included in v5 of the original patch series.
On 7/24/23 13:26, Lukas Wagner wrote:
Virtual (or anonymous) endpoints/groups are used for sending
one-off notifications to a target that does not exist in the
config.
VZDump uses this to send out notification mails
Signed-off-by: Lukas Wagner
---
notifications.adoc | 159 +++
pve-admin-guide.adoc | 2 +
pve-gui.adoc | 2 +
vzdump.adoc | 5 ++
4 files changed, 168 insertions(+)
create mode 100644 notifications.adoc
diff --git a
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Show warnings only if 'never' is selected
- Also show a warning for disabled package update notifications
- Some code style touch ups
- Added some comments
www/manager6/Makefile |
backup jobs. Some logic which automatically migrates from
'mailnotification' has been added.
Signed-off-by: Lukas Wagner
---
www/manager6/Makefile | 4 +-
www/manager6/dc/Backup.js | 84 +--
www/manager6/form/Notifica
end_notification`
- Breaking out some of the code into helper subs, hopefully
reducing the spaghetti factor a bit
Signed-off-by: Lukas Wagner
---
PVE/API2/VZDump.pm | 10 +-
PVE/VZDump.pm | 335 +
test/mail_test.pl | 36 ++---
3 files c
update API
compat in the case that a notification shall be sent, but without
any configured notification target (which will then default to
'mail-to-root').
Signed-off-by: Lukas Wagner
---
Notes:
New in v5
PVE/API2/Cluster/Notifications.pm | 31 ++-
1 fil
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 262 ++
1
Virtual (or anonymous) endpoints/groups are used for sending
one-off notifications to a target that does not exist in the
config.
VZDump uses this to send out notification mails to those addresses
configured by the `mailto` parameter.
Suggested-by: Wolfgang Bumiller
Signed-off-by: Lukas Wagner
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Use items/advancedItems instead of columns
src/Makefile | 1 +
src/Schema.js| 5
src/panel/GotifyEditPanel.js | 44
3 files changed, 50 insertions
Signed-off-by: Lukas Wagner
---
www/manager6/dc/Config.js | 16
1 file changed, 16 insertions(+)
diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
index aa025c8d..9ba7b301 100644
--- a/www/manager6/dc/Config.js
+++ b/www/manager6/dc/Config.js
@@ -329,6 +329,22
Suggested-by: Dominik Csapak
Signed-off-by: Lukas Wagner
---
Notes:
In future, we could create a new API endpoint that returns all possible ACL
and then use a normal store for the perm path combobox?
Changes since v3:
- Removed API calls that fetch targets/filters
#x27; paramter which controls if
notifications should be sent at all. If it is not set, we
default to the old behavior, which is to send.
Also add dependency to the `libpve-notify-perl` package to d/control.
Signed-off-by: Lukas Wagner
---
debian/control | 2 ++
src/PVE/HA/Env.pm|
This commit adds a new Perl module, PVE::API2::Cluster::Notification.
The module will contain all API handlers for the new notification
subsystem.
Signed-off-by: Lukas Wagner
---
PVE/API2/Cluster.pm | 7 +++
PVE/API2/Cluster/Makefile | 1 +
PVE/API2/Cluster
ls whether
to send a notification at all.
Signed-off-by: Lukas Wagner
---
PVE/API2/Replication.pm | 63 -
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm
index 89c5a802..d61518ba 100644
--- a/PVE/API2/
Signed-off-by: Lukas Wagner
---
src/Makefile| 1 +
src/form/NotificationFilterSelector.js | 58 +
src/panel/GotifyEditPanel.js| 9
src/panel/NotificationConfigView.js | 4 ++
src/panel/NotificationGroupEditPanel.js | 9
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- extracted validator function
- use items/advancedItems instead of columns
src/Makefile | 4 +
src/Schema.js| 8 ++
src/data/model/NotificationConfig.js | 8 ++
src
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 305 ++
1
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- use items/advancedItems instead of columns
src/Makefile | 3 +-
src/data/model/NotificationConfig.js | 9 ++
src/panel/NotificationConfigView.js | 119 +++
src/window
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- Use items/advancedItems instead of columns
- Call initField in EndpointSelector
- Minor code style improvements
src/Makefile| 1 +
src/Schema.js | 5 +
src
code.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v4:
- Explain the changes a bit more in the commit message
- Factor out permission checks into a common helper
- Minor code style improvements
PVE/API2/Cluster/Notifications.pm | 255 ++
1
Settings for notifications have been moved to their own view.
Signed-off-by: Lukas Wagner
---
Notes:
Changes since v3:
- New in v4
www/manager6/dc/OptionView.js | 20
1 file changed, 20 deletions(-)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc
601 - 700 of 980 matches
Mail list logo
