[pve-devel] [PATCH docs] passthrough: viommu: replace host requirement with reference to pcie passthrough

2024-07-26 Thread Markus Frank
Enabling IOMMU on the host is not a requirement for vIOMMU. It is only a requirement for passthrough. Add a sentence to clarify the need for a configured PCI(e) passthrough on the host for passthrough to nested VMs. Suggested-by: Dominik Csapak Signed-off-by: Markus Frank --- This patch

Re: [pve-devel] [PATCH qemu-server/docs/manager v11 0/5] AMD SEV

2024-07-23 Thread Markus Frank
Ping. Patches still apply. On 2024-05-29 14:23, Markus Frank wrote: Patch series to enable AMD Secure Encrypted Virtualization (SEV) https://www.amd.com/en/developer/sev.html changes v11: * removed systemd service and added run_command in qemu-server instead * moved SEV related code

[pve-devel] [PATCH qemu-server v11 5/12] fix #1027: virtio-fs support

2024-07-08 Thread Markus Frank
Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 40 ++- PVE/QemuServer.pm | 22 +++- PVE/QemuServer/Makefile| 3 +- PVE/QemuServer/Memory.pm | 23 ++-- PVE/QemuServer/Virtiofs.

[pve-devel] [PATCH manager v11 09/12] ui: add edit window for dir mappings

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 230 ++ 2 files changed, 231 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile

[pve-devel] [PATCH manager v11 12/12] ui: add options to add virtio-fs to qemu config

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 + www/manager6/qemu/VirtiofsEdit.js | 137 ++ 4 files changed, 158 insertions(+) create mode 100644 www

[pve-devel] [PATCH docs v11 3/12] add doc section for the shared filesystem virtio-fs

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 97 +++-- 1 file changed, 95 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 42c26db..71c8d40 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1081,6 +1081,98 @@ recommended to always use

[pve-devel] [PATCH manager v11 11/12] ui: form: add selector for directory mappings

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DirMapSelector.js diff --git a/www/manager6/Makefile b/www/manager6

[pve-devel] [PATCH guest-common v11 2/12] add dir mapping section config

2024-07-08 Thread Markus Frank
ault settings for xattr & acl. example config: ``` some-dir-id map node=node1,path=/mnt/share/,submounts=1 map node=node2,path=/mnt/share/, xattr 1 acl 1 ``` Signed-off-by: Markus Frank --- src/Makefile | 1 + src/PVE/Mapping/Dir.

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v11 0/12] virtiofs

2024-07-08 Thread Markus Frank
::QemuServer::Virtiofs dependency removed in QemuServer/Memory.pm * Minor changes to function/variable names * Disable snapshots (with RAM) and hibernate due to incompatibility cluster: Markus Frank (1): add mapping/dir.cfg for resource mapping src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2

[pve-devel] [PATCH cluster v11 1/12] add mapping/dir.cfg for resource mapping

2024-07-08 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff

[pve-devel] [PATCH manager v11 08/12] api: add resource map api endpoints for directories

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 317 ++ PVE/API2/Cluster/Mapping/Makefile | 1 + 3 files changed, 325 insertions(+) create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm diff --git a/PVE

[pve-devel] [PATCH qemu-server v11 6/12] migration: check_local_resources for virtiofs

2024-07-08 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- PVE/QemuServer.pm| 10 +- test/MigrationTest/Shared.pm

[pve-devel] [PATCH manager v11 10/12] ui: add resource mapping view for directories

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 +++ www/manager6/dc/DirMapView.js | 50 +++ 3 files changed, 61 insertions(+) create mode 100644 www/manager6/dc/DirMapView.js diff --git a/www/manager6

[pve-devel] [PATCH qemu-server v11 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 6 ++ PVE/QemuServer.pm | 4 2 files changed, 10 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index f4982b0..854ad98 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -5246,6 +5246,12 @@ __PACKAGE__

[pve-devel] [PATCH qemu-server v11 4/12] control: add virtiofsd as runtime dependency for qemu-server

2024-07-08 Thread Markus Frank
Signed-off-by: Markus Frank --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 2b5c8e3..61d0cf3 100644 --- a/debian/control +++ b/debian/control @@ -55,6 +55,7 @@ Depends: dbus, socat, swtpm, swtpm-tools

[pve-devel] [PATCH docs v11 4/5] add AMD SEV documentation

2024-05-29 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- qm.adoc | 103 1 file changed, 103 insertions(+) diff --git a/qm.adoc b/qm.adoc index 42c26db..2001

[pve-devel] [PATCH qemu-server/docs/manager v11 0/5] AMD SEV

2024-05-29 Thread Markus Frank
to Options qemu-server: Markus Frank (3): add C program to get hardware capabilities from CPUID config: add AMD SEV support migration: add check_non_migratable_resources function Makefile | 1 + PVE/API2/Qemu.pm |

[pve-devel] [PATCH qemu-server v11 2/5] config: add AMD SEV support

2024-05-29 Thread Markus Frank
see coherent doc patch Signed-off-by: Markus Frank --- changes v11: * add run_command() for the query-machine-capabilities program * moved SEV related code to CPUConfig PVE/QemuServer.pm | 13 +- PVE/QemuServer/CPUConfig.pm | 83 - 2 files

[pve-devel] [PATCH manager v11 5/5] ui: add AMD SEV configuration to Options

2024-05-29 Thread Markus Frank
By adding a new input panel with an AMD SEV technology selection combo box and checkboxes for the optional parameters in an advanced section, the user can configure the amd_sev option via the WebUI's Options tab. Signed-off-by: Markus Frank --- changes v11: * instead of the no-debug and no-key

[pve-devel] [PATCH qemu-server v11 3/5] migration: add check_non_migratable_resources function

2024-05-29 Thread Markus Frank
The function checks for resources that cannot be migrated, snapshoted, or suspended. Signed-off-by: Markus Frank --- changes v11: * this patch is new to v11 PVE/API2/Qemu.pm | 5 - PVE/QemuMigrate.pm | 2 +- PVE/QemuServer.pm | 23 ++- 3 files changed, 27

[pve-devel] [PATCH qemu-server v11 1/5] add C program to get hardware capabilities from CPUID

2024-05-29 Thread Markus Frank
read and save other hardware information at boot time. Signed-off-by: Markus Frank Co-authored-by: Thomas Lamprecht Tested-by: Filip Schauer --- changes v11: * removed systemd service Makefile | 1 + query-machine-capabilities/Makefile | 18 + .../q

[pve-devel] [PATCH manager v10 08/11] ui: add edit window for dir mappings

2024-05-14 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/window/DirMapEdit.js | 222 ++ 2 files changed, 223 insertions(+) create mode 100644 www/manager6/window/DirMapEdit.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile

[pve-devel] [PATCH docs v10 3/11] add doc section for the shared filesystem virtio-fs

2024-05-14 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 94 +++-- 1 file changed, 92 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index 42c26db..755e20e 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1081,6 +1081,95 @@ recommended to always use

[pve-devel] [PATCH manager v10 09/11] ui: ResourceMapTree for DIR

2024-05-14 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/dc/Config.js | 10 +++ www/manager6/dc/DirMapView.js | 50 +++ 3 files changed, 61 insertions(+) create mode 100644 www/manager6/dc/DirMapView.js diff --git a/www/manager6

[pve-devel] [PATCH manager v10 10/11] ui: form: add DIRMapSelector

2024-05-14 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/form/DirMapSelector.js | 63 + 2 files changed, 64 insertions(+) create mode 100644 www/manager6/form/DirMapSelector.js diff --git a/www/manager6/Makefile b/www/manager6

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v10 0/11] virtiofs

2024-05-14 Thread Markus Frank
-server 5. manager I did not get virtiofsd to run with run_command without creating zombie processes after stutdown. So I replaced run_command with exec for now. Maybe someone can find out why this happens. changes v10: * rebase to master * added gui patches again cluster: Markus Frank (1): add

[pve-devel] [PATCH qemu-server v10 6/11] migration: check_local_resources for virtiofs

2024-05-14 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- PVE/QemuServer.pm| 10 +- test/MigrationTest/Shared.pm

[pve-devel] [PATCH manager v10 07/11] api: add resource map api endpoints for directories

2024-05-14 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 317 ++ PVE/API2/Cluster/Mapping/Makefile | 1 + 3 files changed, 325 insertions(+) create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm diff --git a/PVE

[pve-devel] [PATCH qemu-server v10 5/11] fix #1027: virtio-fs support

2024-05-14 Thread Markus Frank
Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 39 ++- PVE/QemuServer.pm | 19 +++- PVE/QemuServer/Makefile| 3 +- PVE/QemuServer/Memory.pm | 34 -- PVE/QemuServer/Virtiofs.

[pve-devel] [PATCH qemu-server v10 4/11] add virtiofsd as runtime dependency for qemu-server

2024-05-14 Thread Markus Frank
Signed-off-by: Markus Frank --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 1301a36..8e4ca7f 100644 --- a/debian/control +++ b/debian/control @@ -55,6 +55,7 @@ Depends: dbus, socat, swtpm, swtpm-tools

[pve-devel] [PATCH manager v10 11/11] ui: add options to add virtio-fs to qemu config

2024-05-14 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/Makefile | 1 + www/manager6/Utils.js | 1 + www/manager6/qemu/HardwareView.js | 19 + www/manager6/qemu/VirtiofsEdit.js | 137 ++ 4 files changed, 158 insertions(+) create mode 100644 www

[pve-devel] [PATCH guest-common v10 2/11] add dir mapping section config

2024-05-14 Thread Markus Frank
ault settings for xattr & acl. example config: ``` some-dir-id map node=node1,path=/mnt/share/,submounts=1 map node=node2,path=/mnt/share/, xattr 1 acl 1 ``` Signed-off-by: Markus Frank --- src/Makefile | 1 + src/PVE/Mapping/Dir.

[pve-devel] [PATCH cluster v10 1/11] add mapping/dir.cfg for resource mapping

2024-05-14 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff

[pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID

2024-05-10 Thread Markus Frank
also be used to read and save other hardware information at boot time. Signed-off-by: Markus Frank Co-authored-by: Thomas Lamprecht Tested-by: Filip Schauer --- changes v10: * removed include of sys/types.h Makefile | 1 + query-machine-capabilities/Make

[pve-devel] [PATCH qemu-server v10 2/4] config: add AMD SEV support

2024-05-10 Thread Markus Frank
nt doc patch Signed-off-by: Markus Frank --- changes v10: * also die if the BIOS is not set, since the default is SeaBIOS PVE/API2/Qemu.pm | 11 +++ PVE/QemuMigrate.pm | 4 +++ PVE/QemuServer.pm | 79 ++ 3 files changed, 94 insertions(+) diff

[pve-devel] [PATCH docs v10 3/4] add AMD SEV documentation

2024-05-10 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- changes v10: * none qm.adoc | 103 1 file changed, 103 insertions(+) diff --git a/qm.adoc b/qm.adoc ind

[pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV

2024-05-10 Thread Markus Frank
from CPUID 2. qemu-server: config: add AMD SEV support 3. pve-docs: add AMD SEV documentation 4. pve-manager: ui: add AMD SEV configuration to Options qemu-server: Markus Frank (2): add C program to get hardware capabilities from CPUID config: add AMD SEV support Makefile

[pve-devel] [PATCH manager v10 4/4] ui: add AMD SEV configuration to Options

2024-05-10 Thread Markus Frank
By adding a new input panel with an AMD SEV technology selection combo box and checkboxes for the optional parameters in an advanced section, the user can configure the amd_sev option via the WebUI's Options tab. Signed-off-by: Markus Frank --- changes v10: * this patch is new to v10 www

[pve-devel] [PATCH qemu-server v9 1/3] add C program to get hardware capabilities from CPUID

2024-04-26 Thread Markus Frank
also be used to read and save other hardware information at boot time. Signed-off-by: Markus Frank Co-authored-by: Thomas Lamprecht --- v9: * added directory existance check * print error messages v8: * renamed query-machine-params to query-machine-capabilities v7: * renamed amd-sev-support to q

[pve-devel] [PATCH docs v9 3/3] add AMD SEV documentation

2024-04-26 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: add AMD SEV support" patch. Signed-off-by: Markus Frank --- v8: * adjust changed parameter names in examples v5: * removed NodeConfig part v4: * added text that SEV-ES is experimental qm.

[pve-devel] [PATCH qemu-server v9 2/3] config: add AMD SEV support

2024-04-26 Thread Markus Frank
nt doc patch Signed-off-by: Markus Frank --- v8: * renamed "params" to "capabilities" or "caps" * renamed "nodbg" to "no-debug" and "noks" to "no-key-sharing" * untainted json_text as it prevented a SEV VM from starting via GUI

[pve-devel] [PATCH qemu-server v8 1/3] add C program to get hardware capabilities from CPUID

2024-04-25 Thread Markus Frank
also be used to read and save other hardware information at boot time. Signed-off-by: Markus Frank Co-authored-by: Thomas Lamprecht --- v8: * renamed query-machine-params to query-machine-capabilities v7: * renamed amd-sev-support to query-machine-params * mv /run/amd-sev-params to /run/qemu-serve

[pve-devel] [PATCH docs v8 3/3] add AMD SEV documentation

2024-04-25 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: add AMD SEV support" patch. Signed-off-by: Markus Frank --- v8: * adjust changed parameter names in examples v5: * removed NodeConfig part v4: * added text that SEV-ES is experimental qm.

[pve-devel] [PATCH qemu-server v8 2/3] config: add AMD SEV support

2024-04-25 Thread Markus Frank
nt doc patch Signed-off-by: Markus Frank --- v8: * renamed "params" to "capabilities" or "caps" * renamed "nodbg" to "no-debug" and "noks" to "no-key-sharing" * untainted json_text as it prevented a SEV VM from starting via GUI

[pve-devel] [PATCH qemu-server v7 2/3] config: QEMU AMD SEV enable

2024-04-22 Thread Markus Frank
mental since it could not be tested. see coherent doc patch Signed-off-by: Markus Frank --- v7: * adjustments for the changes made in the query-machine-params C program v6: * rebase on master * removed unused $sev_node_fmt object v5: * parse /run/amd-sev-params for hardware parameters * remove

[pve-devel] [PATCH docs v7 3/3] add AMD SEV documentation

2024-04-22 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- v5: * removed NodeConfig part v4: * added text that SEV-ES is experimental qm.adoc | 103 1 file changed, 103

[pve-devel] [PATCH qemu-server v7 1/3] add C program to get AMD SEV hardware parameters from CPUID

2024-04-22 Thread Markus Frank
also be used to read and save other hardware information at boot time. Signed-off-by: Markus Frank Co-authored-by: Thomas Lamprecht --- v7: * renamed amd-sev-support to query-machine-params * mv /run/amd-sev-params to /run/qemu-server/hw-params.json * add "mkdir /run/qemu-server&q

[pve-devel] [PATCH manager v17 2/2] ui: qemu: add clipboard ComboBox as a advanced option in DisplayEdit

2024-04-22 Thread Markus Frank
For SPICE and VNC, a different message is displayed. The backend code for the clipboard option can be found in the 'config: enable vnc clipboard parameter in vga_fmt'-commit in qemu-server. Signed-off-by: Markus Frank --- v17: * added "value: '__default__'" to clipboard ComboBox so

[pve-devel] [PATCH manager v17 1/2] ui: qemu: change logic to use ViewModel instead of listener function

2024-04-22 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- v17: * moved regex to inline match as it is only used once. www/manager6/qemu/DisplayEdit.js | 56 +++- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/www

[pve-devel] [PATCH qemu-server v6 1/3] add C program to get AMD SEV hardware parameters from CPUID

2024-04-19 Thread Markus Frank
Implement a systemd service that runs a C program that extracts AMD SEV hardware parameters such as reduced-phys-bios and cbitpos from CPUID at boot time, looks if SEV, SEV-ES & SEV-SNP are enabled, and outputs these details as JSON to /run/amd-sev-params. Signed-off-by: Markus F

[pve-devel] [PATCH qemu-server v6 2/3] config: QEMU AMD SEV enable

2024-04-19 Thread Markus Frank
ES is highly experimental since it could not be tested. see coherent doc patch Signed-off-by: Markus Frank --- v6: * rebase on master * removed unused $sev_node_fmt object v5: * parse /run/amd-sev-params for hardware parameters * removed NodeConfig dependency * only disallow live-migration a

[pve-devel] [PATCH docs v6 3/3] add AMD SEV documentation

2024-04-19 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- v5: * removed NodeConfig part v4: * added text that SEV-ES is experimental qm.adoc | 103 1 file changed, 103

[pve-devel] [PATCH docs v5 3/3] add AMD SEV documentation

2024-04-19 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- v5: * removed NodeConfig part v4: * added text that SEV-ES is experimental qm.adoc | 103 1 file changed, 103

[pve-devel] [PATCH qemu-server v5 1/3] add C program to get AMD SEV hardware parameters from CPUID

2024-04-19 Thread Markus Frank
Implement a systemd service that runs a C program that extracts AMD SEV hardware parameters such as reduced-phys-bios and cbitpos from CPUID at boot time, verifies that SEV, SEV-ES & SEV-SNP are enabled, and outputs these details as JSON to /run/amd-sev-params. Signed-off-by: Markus F

[pve-devel] [PATCH qemu-server v5 2/3] config: QEMU AMD SEV enable

2024-04-19 Thread Markus Frank
mental since it could not be tested. see coherent doc patch Signed-off-by: Markus Frank --- v5: * parse /run/amd-sev-params for hardware parameters * removed NodeConfig dependency * only disallow live-migration and snapshots with vmstate -> allow offline migration and snapshots without vmstate v4:

[pve-devel] [PATCH docs v4 2/2] add AMD SEV documentation

2024-04-18 Thread Markus Frank
add documentation for the "[PATCH qemu-server] config: QEMU AMD SEV enable" patch. Signed-off-by: Markus Frank --- v4: * added text that SEV-ES is experimental qm.adoc | 114 1 file changed, 114 insertions(+) diff --git a

[pve-devel] [PATCH qemu-server v4 1/2] config: QEMU AMD SEV enable

2024-04-18 Thread Markus Frank
mental since it could not be tested. see coherent doc patch Signed-off-by: Markus Frank --- v4: * reduced lines of code * added text that SEV-ES is experimental PVE/API2/Qemu.pm | 10 PVE/QemuServer.pm | 117 ++ 2 files changed, 127 insertions(+)

[pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings

2024-04-15 Thread Markus Frank
--- www/manager6/qemu/MachineEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/MachineEdit.js b/www/manager6/qemu/MachineEdit.js index 48c72c1d..ee2b2dac 100644 --- a/www/manager6/qemu/MachineEdit.js +++ b/www/manager6/qemu/MachineEdit.js @@ -1,6 +1,7 @@

[pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox

2024-04-15 Thread Markus Frank
efine machine schema as property-string" commit and the viommu option added in the qemu-server's "fix #3784: config: Parameter for guest vIOMMU + test-cases" commit. Signed-off-by: Markus Frank --- www/manager6/qemu/MachineEdit.js | 62 +++- 1 file ch

[pve-devel] [PATCH qemu-server/docs/manager v9 0/3] vIOMMU-Feature #3784

2024-04-11 Thread Markus Frank
patch series. qemu-server: v9: * rebase to master * changed if to elsif * changed vIOMMU description * renamed check_machine_config to assert_valid_machine_property * added 2 test-cases with i440fx Markus Frank (1): fix #3784: config: Parameter for guest vIOMMU + test-cases PVE/API2/Qemu.pm

[pve-devel] [PATCH qemu-server v9 1/3] fix #3784: config: Parameter for guest vIOMMU + test-cases

2024-04-11 Thread Markus Frank
Currently there are two vIOMMU implementation in QEMU to choose: intel or virtio Virtio-iommu is more recent but less used in production than intel-iommu. The assert_valid_machine_property function prevents using intel-iommu with i440fx. Signed-off-by: Markus Frank --- PVE/AP

[pve-devel] [PATCH manager v9 3/3] ui: machine: add viommu ComboBox

2024-04-11 Thread Markus Frank
Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM. If i440fx is selected, a hint tells that q35 is required for Intel vIOMMU. The UI also needs to parse the new machine parameter as PropertyString. Signed-off-by: Markus Frank --- www/manager6/qemu/MachineEdit.js | 45

[pve-devel] [PATCH docs v9 2/3] add vIOMMU documentation

2024-04-11 Thread Markus Frank
Signed-off-by: Markus Frank --- qm-pci-passthrough.adoc | 50 + qm.adoc | 1 + 2 files changed, 51 insertions(+) diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc index 3abeb50..bbd6b85 100644 --- a/qm-pci-passthrough.adoc

[pve-devel] [PATCH manager v16 1/2] ui: qemu: change DisplayEdit logic to use ViewModel instead of listener function

2024-04-08 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 57 ++-- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..17b02ee4 100644 --- a/www/manager6/qemu

[pve-devel] [PATCH manager v16 2/2] ui: qemu: add clipboard ComboBox as a advanced option in DisplayEdit

2024-04-08 Thread Markus Frank
For SPICE and VNC, a different message is displayed. The backend code for the clipboard option can be found in the 'config: enable vnc clipboard parameter in vga_fmt'-commit in qemu-server. Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 41

[pve-devel] [PATCH access-control] api: Prevent TFA from being set up for openid users

2024-03-13 Thread Markus Frank
Currently it is possible to set up TFA for an OpenID user (as root user), but it is never requested during the login process for that user. This patch prevents this and displays an error message with the instruction to set up TFA using the OpenId server. Signed-off-by: Markus Frank --- src/PVE

Re: [pve-devel] [PATCH manager v15 1/2] add clipboard comboBox to VM Options

2024-03-12 Thread Markus Frank
Ping, the patch still applies. On 2023-11-21 13:39, Markus Frank wrote: For SPICE and VNC, a different message is displayed. Save config in DisplayEdit so that the clipboard setting persist. Signed-off-by: Markus Frank Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- v15

[pve-devel] [PATCH qemu-server v9 5/7] fix #1027: virtio-fs support

2024-03-01 Thread Markus Frank
Also add a permission check for virtiofs directory access. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 39 ++- PVE/QemuServer.pm | 19 +++- PVE/QemuServer/Makefile| 3 +- PVE/QemuServer/Memory.pm | 34 -- PVE/QemuServer/Virtiofs.

[pve-devel] [PATCH manager v9 7/7] api: add resource map api endpoints for directories

2024-03-01 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 317 ++ PVE/API2/Cluster/Mapping/Makefile | 1 + 3 files changed, 325 insertions(+) create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm diff --git a/PVE

[pve-devel] [PATCH qemu-server v9 6/7] migration: check_local_resources for virtiofs

2024-03-01 Thread Markus Frank
add dir mapping checks to check_local_resources Since the VM needs to be powered off for migration, migration should work with a directory on shared storage with all caching settings. Signed-off-by: Markus Frank --- PVE/QemuServer.pm| 10 +- test/MigrationTest/Shared.pm

[pve-devel] [PATCH guest-common v9 2/7] add dir mapping section config

2024-03-01 Thread Markus Frank
ault settings for xattr & acl. example config: ``` some-dir-id map node=node1,path=/mnt/share/,submounts=1 map node=node2,path=/mnt/share/, xattr 1 acl 1 ``` Signed-off-by: Markus Frank --- src/Makefile | 1 + src/PVE/Mapping/Dir.

[pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v9 0/7] virtiofs

2024-03-01 Thread Markus Frank
-server 5. manager I did not get virtiofsd to run with run_command without creating zombie processes after stutdown. So I replaced run_command with exec for now. Maybe someone can find out why this happens. cluser: Markus Frank (1): add mapping/dir.cfg for resource mapping src/PVE/Cluster.pm

[pve-devel] [PATCH qemu-server v9 4/7] add virtiofsd as runtime dependency for qemu-server

2024-03-01 Thread Markus Frank
--- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 7d6f975..0fce1a8 100644 --- a/debian/control +++ b/debian/control @@ -55,6 +55,7 @@ Depends: dbus, socat, swtpm, swtpm-tools, + virtiofsd,

[pve-devel] [PATCH cluster v9 1/7] add mapping/dir.cfg for resource mapping

2024-03-01 Thread Markus Frank
Add it to both the perl side (PVE/Cluster.pm) and pmxcfs side (status.c). This dir.cfg is used to map directory IDs to paths on selected hosts. Signed-off-by: Markus Frank Reviewed-by: Fiona Ebner --- src/PVE/Cluster.pm | 1 + src/pmxcfs/status.c | 1 + 2 files changed, 2 insertions(+) diff

[pve-devel] [PATCH docs v9 3/7] add doc section for the shared filesystem virtio-fs

2024-03-01 Thread Markus Frank
Signed-off-by: Markus Frank --- qm.adoc | 94 +++-- 1 file changed, 92 insertions(+), 2 deletions(-) diff --git a/qm.adoc b/qm.adoc index fa6a772..fa1de72 100644 --- a/qm.adoc +++ b/qm.adoc @@ -1056,6 +1056,95 @@ recommended to always use

Re: [pve-devel] [PATCH qemu-server v8 6/7] check_local_resources: virtiofs

2024-02-22 Thread Markus Frank
On 2024-01-31 16:35, Fiona Ebner wrote: A 'migration: ' prefix would be nice for the commit title. Am 08.11.23 um 09:52 schrieb Markus Frank: add dir mapping checks to check_local_resources So, as long as there is a mapping for the target node, the migration check goes through. Should

Re: [pve-devel] [PATCH qemu-server v8 4/7] feature #1027: virtio-fs support

2024-02-13 Thread Markus Frank
Thanks, I already moved most of the code into a new PVE/QemuServer/Virtiofs.pm module. Just an clarification & question concerning the queue-size: On 2024-01-31 16:02, Fiona Ebner wrote: + push @$devices, '-chardev', "socket,id=virtfs$i,path=/var/run/virtiofsd/vm$vmid-fs$i"; +

Re: [pve-devel] [PATCH guest-common v8 2/7] add Dir mapping config

2024-01-31 Thread Markus Frank
On 2024-01-31 15:00, Fiona Ebner wrote: Am 31.01.24 um 14:53 schrieb Fiona Ebner: Am 31.01.24 um 14:42 schrieb Markus Frank: What could also be mentioned for xattr and acl: do the underlying file systems need to support these? What happens if they don't? ACLs and xattrs just get ignored

Re: [pve-devel] [PATCH guest-common v8 2/7] add Dir mapping config

2024-01-31 Thread Markus Frank
Thanks for the review, 2 answers inline. The rest is clear. On 2024-01-31 13:01, Fiona Ebner wrote: Am 08.11.23 um 09:52 schrieb Markus Frank: Adds a config file for directories by using a 'map' array propertystring for each node mapping. Next to node & path, there is the optional submo

Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v8 0/7] virtiofs

2024-01-30 Thread Markus Frank
ping, patches still apply. Only the cluster patch needs a 3-way merge to apply. On 2023-11-08 09:52, Markus Frank wrote: build-order: 1. cluster 2. guest-common 3. docs 4. qemu-server 5. manager I did not get virtiofsd to run with run_command without creating zombie processes after stutdown

[pve-devel] [PATCH qemu-server v8 1/4] machine as property-string

2024-01-24 Thread Markus Frank
Convert the machine parameter to a property-string and use the machine type as the default key for backward compatibility. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 9 +++-- PVE/QemuConfig.pm | 3 ++- PVE/QemuServer.pm | 16 ++- PVE/QemuServer

[pve-devel] [PATCH qemu-server v8 2/4] fix #3784: Parameter for guest vIOMMU + test-cases

2024-01-24 Thread Markus Frank
implementation in QEMU to choose: intel & virtio Virtio-iommu is more recent but less used in production than intel-iommu. The check_machine_config function prevents using intel-iommu with i440fx. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm| 2 ++ PVE/QemuServe

[pve-devel] [PATCH manager v8 4/4] ui: MachineEdit with viommu ComboBox

2024-01-24 Thread Markus Frank
Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM. If i440fx is selected, a hint tells that q35 is required for Intel vIOMMU. The UI also needs to parse the new machine parameter as PropertyString. Signed-off-by: Markus Frank --- www/manager6/qemu/MachineEdit.js | 45

[pve-devel] [PATCH qemu-server/docs/manager v8 0/4] vIOMMU-Feature #3784

2024-01-24 Thread Markus Frank
moved viommu-parameter inside of machine_fmt and added it the new parameter machine_properties new Config -> machine_properties: viommu=1,etc * check if kvm and q35 are set Markus Frank (2): machine as property-string fix #3784: Parameter for guest vIOMMU + test-cases PVE/API2/Qemu.pm

[pve-devel] [PATCH docs v8 3/4] added vIOMMU documentation

2024-01-24 Thread Markus Frank
Signed-off-by: Markus Frank --- qm-pci-passthrough.adoc | 51 + qm.adoc | 1 + 2 files changed, 52 insertions(+) diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc index 3abeb50..04a3bc2 100644 --- a/qm-pci-passthrough.adoc

[pve-devel] [qemu-server] fix: do not allow live-migration with clipboard=vnc

2023-11-24 Thread Markus Frank
a new 'die' prevents a live-migration if a running VMs has clipboard set to vnc. Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 5 + PVE/QemuMigrate.pm | 5 + 2 files changed, 10 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index f5bff53..f26adf5 100644 --- a/PVE/AP

[pve-devel] [PATCH manager v15 1/2] add clipboard comboBox to VM Options

2023-11-21 Thread Markus Frank
For SPICE and VNC, a different message is displayed. Save config in DisplayEdit so that the clipboard setting persist. Signed-off-by: Markus Frank Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- v15: * changed style of line break in vncHint field www/manager6/qemu/DisplayEdit.js

[pve-devel] [PATCH docs v15 2/2] add VNC clipboard documentation

2023-11-21 Thread Markus Frank
Signed-off-by: Markus Frank Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- qm.adoc | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qm.adoc b/qm.adoc index 55a4728..cd0d907 100644 --- a/qm.adoc +++ b/qm.adoc @@ -817,6 +817,24 @@ Selecting `serialX` as display

[pve-devel] [PATCH common] fix #5034 ldap attribute regex

2023-11-15 Thread Markus Frank
Change regex from "m/^[a-zA-Z0-9]+$/" to "m/^[a-zA-Z0-9\-]+$/" to allow hyphen in ldap attribute names for pve & pmg. Signed-off-by: Markus Frank --- There does not seem to be a regex for LDAP attributes in pbs. Should a regex be added for this? src/PVE/JSONSchema.pm |

[pve-devel] [PATCH manager v14 5/6] add clipboard checkbox to VM Options

2023-11-14 Thread Markus Frank
Signed-off-by: Markus Frank --- www/manager6/qemu/DisplayEdit.js | 8 www/manager6/qemu/Options.js | 82 2 files changed, 90 insertions(+) diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js index 9bb1763e..d7cd51a9 100644

[pve-devel] [PATCH docs v14 6/6] add VNC clipboard documentation

2023-11-14 Thread Markus Frank
Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak Signed-off-by: Markus Frank --- qm.adoc | 18 ++ 1 file changed, 18 insertions(+) diff --git a/qm.adoc b/qm.adoc index 55a4728..cd0d907 100644 --- a/qm.adoc +++ b/qm.adoc @@ -817,6 +817,24 @@ Selecting `serialX` as display

[pve-devel] [PATCH qemu-server v14 3/6] test cases for clipboard spice & std

2023-11-14 Thread Markus Frank
add one test case for a spice display and one for std Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak Signed-off-by: Markus Frank --- test/cfg2cmd/VNC-clipboard-spice.conf | 1 + test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 +++ test/cfg2cmd/VNC-clipboard

[pve-devel] [PATCH qemu-server v14 1/6] enable VNC clipboard parameter in vga_fmt

2023-11-14 Thread Markus Frank
on the guest. Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 7 + PVE/QemuServer.pm | 66 ++- 2 files changed, 55 insertions(+), 18 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm

[pve-devel] [PATCH novnc v14 4/6] add "show clipboard button" patch to series

2023-11-14 Thread Markus Frank
Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak Signed-off-by: Markus Frank --- .../patches/0019-show-clipboard-button.patch | 30 +++ debian/patches/series | 1 + 2 files changed, 31 insertions(+) create mode 100644 debian/patches/0019-show

[pve-devel] [PATCH qemu-server/novnc/manager/docs v14 0/6] Feature VNC-Clipboard

2023-11-14 Thread Markus Frank
io-serial-pci Markus Frank (3): enable VNC clipboard parameter in vga_fmt add clipboard variable to return at status/current test cases for clipboard spice & std PVE/API2/Qemu.pm | 15 ++ PVE/QemuServer.pm | 66 ---

[pve-devel] [PATCH qemu-server v14 2/6] add clipboard variable to return at status/current

2023-11-14 Thread Markus Frank
By that noVNC is able to check if clipboard is active. Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 8 1 file changed, 8 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 0177489..2bca07f 100644 --- a/PVE

[pve-devel] [PATCH manager v8 7/7] api: add resource map api endpoints for directories

2023-11-08 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Cluster/Mapping.pm | 7 + PVE/API2/Cluster/Mapping/Dir.pm | 309 ++ PVE/API2/Cluster/Mapping/Makefile | 3 +- 3 files changed, 318 insertions(+), 1 deletion(-) create mode 100644 PVE/API2/Cluster/Mapping/Dir.pm

[pve-devel] [PATCH guest-common v8 2/7] add Dir mapping config

2023-11-08 Thread Markus Frank
de=node1,path=/mnt/share/,submounts=1 map node=node2,path=/mnt/share/, xattr 1 acl 1 ``` Signed-off-by: Markus Frank --- src/Makefile | 1 + src/PVE/Mapping/Dir.pm | 177 + 2 files changed, 178 insertions(+) create mode 10

[pve-devel] [PATCH qemu-server v8 6/7] check_local_resources: virtiofs

2023-11-08 Thread Markus Frank
add dir mapping checks to check_local_resources Signed-off-by: Markus Frank --- PVE/QemuServer.pm| 10 +- test/MigrationTest/Shared.pm | 7 +++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f66f26e..b5c2c14

[pve-devel] [PATCH qemu-server v8 5/7] Permission check for virtiofs directory access

2023-11-08 Thread Markus Frank
Signed-off-by: Markus Frank --- PVE/API2/Qemu.pm | 39 ++- PVE/QemuServer.pm | 5 - 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c8a87f3..1c5eb4c 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2

  1   2   3   4   >