[pve-devel] [PATCH conntrack-tool 1/2] initial commit

2020-10-16 Thread Mira Limbeck
-tools' conntrack also exhibits the same behavior). They are still dumped. Expectation support, which is necessary for FTP and other protocols, is not yet implemented. Signed-off-by: Mira Limbeck --- Cargo.toml | 15 ++ src/main.rs| 473

Re: [pve-devel] [PATCH v2 qemu-server 2/2] fix clone_disk failing for nonexistent cloudinit disk

2020-10-06 Thread Mira Limbeck
On 10/6/20 10:56 AM, Mira Limbeck wrote: On 10/5/20 5:35 PM, Thomas Lamprecht wrote: On 28.09.20 10:36, Mira Limbeck wrote: After migration or a rollback the cloudinit disk might not be allocated, so volume_size_info() fails. As we override the value anyway for cloudinit and efi disks simply

Re: [pve-devel] [PATCH v2 qemu-server 2/2] fix clone_disk failing for nonexistent cloudinit disk

2020-10-06 Thread Mira Limbeck
On 10/5/20 5:35 PM, Thomas Lamprecht wrote: On 28.09.20 10:36, Mira Limbeck wrote: After migration or a rollback the cloudinit disk might not be allocated, so volume_size_info() fails. As we override the value anyway for cloudinit and efi disks simply move the volume_size_info() call

[pve-devel] [PATCH v2 qemu-server 1/2] fix VM clone from snapshot with cloudinit disk

2020-09-28 Thread Mira Limbeck
All volumes contained in $vollist are activated. In this case a snapshot of the volume. For cloudinit disks no snapshots are created so don't add it to the list of volumes to activate as it otherwise fails with no logical volume found. Signed-off-by: Mira Limbeck --- v2: unchanged PVE/API2

[pve-devel] [PATCH v2 qemu-server 2/2] fix clone_disk failing for nonexistent cloudinit disk

2020-09-28 Thread Mira Limbeck
After migration or a rollback the cloudinit disk might not be allocated, so volume_size_info() fails. As we override the value anyway for cloudinit and efi disks simply move the volume_size_info() call into the 'else' branch. Signed-off-by: Mira Limbeck --- v2: changed subject PVE

Re: [pve-devel] [PATCH qemu-server 2/2] fix volume_size_info failing for nonexistent cloudinit disk

2020-09-25 Thread Mira Limbeck
The subject should probably be 'fix clone_disk failing for nonexistent cloudinit disk'. Want me to send a v2? On 9/25/20 10:51 AM, Mira Limbeck wrote: After migration or a rollback the cloudinit disk might not be allocated, so volume_size_info() fails. As we override the value anyway

[pve-devel] [PATCH qemu-server 2/2] fix volume_size_info failing for nonexistent cloudinit disk

2020-09-25 Thread Mira Limbeck
After migration or a rollback the cloudinit disk might not be allocated, so volume_size_info() fails. As we override the value anyway for cloudinit and efi disks simply move the volume_size_info() call into the 'else' branch. Signed-off-by: Mira Limbeck --- PVE/QemuServer.pm | 4 +++- 1 file

[pve-devel] [PATCH qemu-server 1/2] fix VM clone from snapshot with cloudinit disk

2020-09-25 Thread Mira Limbeck
All volumes contained in $vollist are activated. In this case a snapshot of the volume. For cloudinit disks no snapshots are created so don't add it to the list of volumes to activate as it otherwise fails with no logical volume found. Signed-off-by: Mira Limbeck --- PVE/API2/Qemu.pm | 1 + 1

Re: [pve-devel] [PATCH qemu-server] api: cloud-init support for mtu and userdata

2020-09-09 Thread Mira Limbeck
Hi, On 9/4/20 5:21 PM, proxmox wrote: Hello I didn't know this patch mail got approved, so sorry for the (very) late response. My intention for not going with snippets was the fact that they could not be created via the API and one would have to manually create a file on the target

Re: [pve-devel] [PATCH] api: cloud-init support for mtu and userdata

2020-08-28 Thread Mira Limbeck
Thank you for the patch. Seems to be the exactly the same as the one you sent some time ago: https://lists.proxmox.com/pipermail/pve-devel/2020-July/044241.html Was this intentional? On 8/11/20 9:02 PM, Marius Schellenberger wrote: Extended the PVE API to configure cloud-init userdata and

Re: [pve-devel] [PATCH proxmox-backup 1/2] change * imports of proxmox_backup::client

2020-07-17 Thread Mira Limbeck
Sent it to the wrong mailing list by accident, please disregard. On 7/17/20 5:43 PM, Mira Limbeck wrote: Change the src/client.rs to make the modules public instead of publically using each member. This simplified the code and keeps the behaviour almost the same. Instead of using 'use

[pve-devel] [PATCH proxmox-backup 2/2] backup-client: change imports to not use '*'

2020-07-17 Thread Mira Limbeck
Import the required symbols directly instead of importing everything there is with '*'. This makes it clear which symbol is exported by which crate and module. Signed-off-by: Mira Limbeck --- Only proxmox_backup::client and proxmox_backup_client have been changed to import via the submodule

[pve-devel] [PATCH proxmox-backup 1/2] change * imports of proxmox_backup::client

2020-07-17 Thread Mira Limbeck
::') instead. This makes it clear where each symbol can be found. As the client module is used in some other files, we need to adapt them as well. Signed-off-by: Mira Limbeck --- It would be possible to keep the 'pub use ::*' lines so a proxmox_backup::client::* import still works. In my opinion this makes

Re: [pve-devel] [PATCH qemu-server] api: cloud-init support for mtu and userdata

2020-07-13 Thread Mira Limbeck
The MTU part of the patch looks good and works fine here. It would be great if you could send that as a separate patch when you send a v2 of the patch series. Any reason why snippets [0] are not enough for custom userdata? Also we don't want any further cloudinit options in the global

Re: [pve-devel] Extend cloud-init API with MTU and userdata

2020-07-13 Thread Mira Limbeck
Hi, Thank you for the patch series. I'm currently taking a look and will provide comments on the individual patches. On 7/2/20 6:08 PM, Marius Schellenberger wrote: To fully automate virtual machine creation and configuration via the Proxmox API, I added configuration support for MTU and

[pve-devel] [PATCH storage] fix #2460: use dm-uuid-mpath- as fallback for multipath

2020-07-07 Thread Mira Limbeck
/39b201160bbff39117fca46b2709ff3f74c53d80/os_brick/initiator/linuxscsi.py#L400) Also sort the output of readdir so 'scsi-' is always after 'dm-uuid-mpath-' so the output of pvesm list does not change for systems that worked before. Signed-off-by: Mira Limbeck --- PVE/Storage/ISCSIPlugin.pm | 4 ++-- 1 file changed, 2

<    1   2