[pve-devel] [PATCH proxmox-acme 1/2] plugin-caller: add _readdomainconf stub

2022-03-04 Thread Stoiko Ivanov
it's used by the dns_hetzner (and dns_nsd) plugins. reported in our community-forum (and tested there as well): https://forum.proxmox.com/threads/.105879/ Signed-off-by: Stoiko Ivanov --- src/proxmox-acme | 5 + 1 file changed, 5 insertions(+) diff --git a/src/proxmox-acme b/src/proxmox

[pve-devel] [PATCH proxmox-acme 2/2] add shellscript to find needed functions not provided by proxmox-acme

2022-03-04 Thread Stoiko Ivanov
based on the heuristic I used a while ago. Adapted to catch the functions missed the last time. Signed-off-by: Stoiko Ivanov --- check-missing-functions | 13 + 1 file changed, 13 insertions(+) create mode 100755 check-missing-functions diff --git a/check-missing-functions b/check

[pve-devel] [PATCH pve-kernel-meta v2 2/8] proxmox-boot: add reinit subcommand

2022-03-03 Thread Stoiko Ivanov
to iterate over all configured ESPs and refresh the boot-loader installations. the init function was changed to not run refresh directly - to prevent refresh from running once for each ESP currently reinit does not imply refresh Signed-off-by: Stoiko Ivanov --- unchanged bin/grub-install

[pve-devel] [PATCH pve-kernel-meta v2 6/8] proxmox-boot: init bootloaders based on esp contents

2022-03-03 Thread Stoiko Ivanov
in addition to installing the boot loader for the current bootmode (grub for legacy, systemd-boot for uefi) also install the bootloader if its config is already present on the ESP. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 26 -- 1 file changed, 24

[pve-devel] [PATCH pve-kernel-meta v2 8/8] proxmox-boot: fix #3729 add --graceful to bootctl invocation

2022-03-03 Thread Stoiko Ivanov
` command. see also: https://github.com/systemd/systemd/issues/13603 Signed-off-by: Stoiko Ivanov --- new in v2 - unrelated to the other changes bin/proxmox-boot-tool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index 23bbdc9

[pve-devel] [PATCH installer v2 1/2] remove /mnt/hostrun after install

2022-03-03 Thread Stoiko Ivanov
else the directory lingers around on fresh systems. follows 8d7ddbde84b3ebde29108b2080977b03853b2b69 Signed-off-by: Stoiko Ivanov --- unchanged proxinstall | 1 + 1 file changed, 1 insertion(+) diff --git a/proxinstall b/proxinstall index a39d405..bddcc5d 100755 --- a/proxinstall +++ b

[pve-devel] [PATCH pve-kernel-meta v2 5/8] proxmox-boot: remove now obsolete EFI/proxmoxdir if it exists

2022-03-03 Thread Stoiko Ivanov
this can be dropped in the next major version - so keeping it as separate commit. Signed-off-by: Stoiko Ivanov --- new in v2 proxmox-boot/zz-proxmox-boot | 6 ++ 1 file changed, 6 insertions(+) diff --git a/proxmox-boot/zz-proxmox-boot b/proxmox-boot/zz-proxmox-boot index fa0ea4a..39e3bea

[pve-devel] [PATCH pve-kernel-meta v2 1/8] rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels

2022-03-03 Thread Stoiko Ivanov
was forgotten during the general renaming of pve-efiboot -> proxmox-boot. follows commit 8c0a22adfe15dc00cf2194647bb254201d8d187b Signed-off-by: Stoiko Ivanov --- rebased on current master debian/pve-kernel-helper.postinst | 4 proxmox-boot/functions| 2 +- 2 files changed

[pve-devel] [PATCH pve-kernel-meta v2 4/8] proxmox-boot: refresh based on bootloader config instead of bootmode

2022-03-03 Thread Stoiko Ivanov
should be fine with it. Additionally adapt the output of `p-b-t status` to the new paths [0] https://systemd.io/BOOT_LOADER_SPECIFICATION/ [1] section 13.3.1.3 of https://uefi.org/sites/default/files/resources/UEFI_Spec_2_9_2021_03_18.pdf Signed-off-by: Stoiko Ivanov --- adapted to use the helpers

[pve-devel] [PATCH installer v2 2/2] use proxmox-boot-tool for all uefi installs

2022-03-03 Thread Stoiko Ivanov
grub by itself is only used for btrfs/ext4/xfs installs on legacy systems for zfs proxmox-boot-tool is used in legacy and uefi mode Signed-off-by: Stoiko Ivanov --- unchanged proxinstall | 80 ++--- 1 file changed, 14 insertions(+), 66 deletions

[pve-devel] [PATCH pve-kernel-meta/pve-installer v2] improve boot-mode switching

2022-03-03 Thread Stoiko Ivanov
com/pipermail/pve-devel/2022-February/051732.html pve-kernel-meta: Stoiko Ivanov (8): rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels proxmox-boot: add reinit subcommand proxmox-boot: add helpers to check for bootloader configs proxmox-boot: refresh based on bootloader con

[pve-devel] [PATCH pve-kernel-meta v2 7/8] proxmox-boot: allow to manually specify bootloader

2022-03-03 Thread Stoiko Ivanov
CD, chrooting and manually running the necessary p-b-t commands. Signed-off-by: Stoiko Ivanov --- added [--legacy|--uefi] to the reinit subcommand as well. bin/proxmox-boot-tool | 60 +++ 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/bin

[pve-devel] [PATCH pve-kernel-meta v2 3/8] proxmox-boot: add helpers to check for bootloader configs

2022-03-03 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- new in v2 - should reduce code copying in the future bin/proxmox-boot-tool| 4 ++-- proxmox-boot/functions | 16 proxmox-boot/zz-proxmox-boot | 4 ++-- 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/bin/proxmox

[pve-devel] [PATCH pve-kernel-meta 5/5] proxmox-boot: allow to manually specify bootloader

2022-02-14 Thread Stoiko Ivanov
and manually running the necessary p-b-t commands. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 47 --- 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index c697f64..68401ee 100755

[pve-devel] [PATCH installer 1/2] remove /mnt/hostrun after install

2022-02-14 Thread Stoiko Ivanov
else the directory lingers around on fresh systems. follows 8d7ddbde84b3ebde29108b2080977b03853b2b69 Signed-off-by: Stoiko Ivanov --- noticed in my last tests - not really related to the series proxinstall | 1 + 1 file changed, 1 insertion(+) diff --git a/proxinstall b/proxinstall index

[pve-devel] [PATCH pve-kernel-meta 1/5] rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels

2022-02-14 Thread Stoiko Ivanov
was forgotten during the general renaming of pve-efiboot -> proxmox-boot. follows commit 8c0a22adfe15dc00cf2194647bb254201d8d187b Signed-off-by: Stoiko Ivanov --- debian/pve-kernel-helper.postinst | 4 proxmox-boot/functions| 2 +- 2 files changed, 5 insertions(+), 1 delet

[pve-devel] [PATCH pve-kernel-meta 3/5] proxmox-boot: refresh based on bootloader config instead of bootmode

2022-02-14 Thread Stoiko Ivanov
should be fine with it. Additionally adapt the output of `p-b-t status` to the new paths [0] https://systemd.io/BOOT_LOADER_SPECIFICATION/ [1] section 13.3.1.3 of https://uefi.org/sites/default/files/resources/UEFI_Spec_2_9_2021_03_18.pdf Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool

[pve-devel] [PATCH installer 2/2] use proxmox-boot-tool for all uefi installs

2022-02-14 Thread Stoiko Ivanov
grub by itself is only used for btrfs/ext4/xfs installs on legacy systems for zfs proxmox-boot-tool is used in legacy and uefi mode Signed-off-by: Stoiko Ivanov --- proxinstall | 80 ++--- 1 file changed, 14 insertions(+), 66 deletions(-) diff

[pve-devel] [PATCH pve-kernel-meta 4/5] proxmox-boot: init bootloaders based on esp contents

2022-02-14 Thread Stoiko Ivanov
in addition to installing the boot loader for the current bootmode (grub for legacy, systemd-boot for uefi) also install the bootloader if its config is already present on the ESP. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 26 -- 1 file changed, 24

[pve-devel] [PATCH pve-kernel-meta 2/5] proxmox-boot: add reinit subcommand

2022-02-14 Thread Stoiko Ivanov
to iterate over all configured ESPs and refresh the boot-loader installations. the init function was changed to not run refresh directly - to prevent refresh from running once for each ESP currently reinit does not imply refresh Signed-off-by: Stoiko Ivanov --- bin/grub-install-wrapper | 19

[pve-devel] [PATCH pve-kernel-meta/pve-installer] improve boot-mode switching

2022-02-14 Thread Stoiko Ivanov
/2022-February/051732.html pve-kernel-meta: Stoiko Ivanov (5): rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels proxmox-boot: add reinit subcommand proxmox-boot: refresh based on bootloader config instead of bootmode proxmox-boot: init bootloaders based on esp contents

[pve-devel] [PATCH pve-kernel-meta v3 2/4] proxmox-boot: fix #3671 add pin/unpin for kernel-version

2022-02-11 Thread Stoiko Ivanov
ore robust Tested with a BIOS and an UEFI VM with / on ZFS. [0] https://systemd.io/BOOT_LOADER_SPECIFICATION/ Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool| 48 proxmox-boot/functions | 37 +++ proxmox-boot/zz-pr

[pve-devel] [PATCH pve-kernel-meta/proxmox-ve v3] proxmox-boot: add kernel pinning functionality (#3761)

2022-02-11 Thread Stoiko Ivanov
kernel-meta: Stoiko Ivanov (4): proxmox-boot: return empty if file does not exist in get_first_line proxmox-boot: fix #3671 add pin/unpin for kernel-version proxmox-boot: add --next-boot option kernel pin command proxmox-boot: add pin/unpin functionality for non-p-b-t systems bin/proxmo

[pve-devel] [PATCH proxmox-ve v3 2/3] apt-hook: verify that fd is numeric

2022-02-11 Thread Stoiko Ivanov
since we read it from the environment Co-authored-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 2053fef..8fa58c5 100755

[pve-devel] [PATCH pve-kernel-meta v3 1/4] proxmox-boot: return empty if file does not exist in get_first_line

2022-02-11 Thread Stoiko Ivanov
makes using this helper shorter in most cases Signed-off-by: Stoiko Ivanov --- proxmox-boot/functions | 5 + 1 file changed, 5 insertions(+) diff --git a/proxmox-boot/functions b/proxmox-boot/functions index 4515a2d..27da363 100755 --- a/proxmox-boot/functions +++ b/proxmox-boot/functions

[pve-devel] [PATCH proxmox-ve v3 3/3] apt-hook: add check preventing the removal of pinned kernels

2022-02-11 Thread Stoiko Ivanov
the $file_read_firstline helper code is copied from PVE::Tools, since we do not want to depend on pve-common being in good shape when the apt hook is executed Co-authored-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 28 1

[pve-devel] [PATCH pve-kernel-meta v3 3/4] proxmox-boot: add --next-boot option kernel pin command

2022-02-11 Thread Stoiko Ivanov
by setting the desired version in a dedicated file, which is used by the systemd service as condition for removing it and refreshing upon reboot. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 53 ++- debian/pve-kernel-helper.install

[pve-devel] [PATCH pve-kernel-meta v3 4/4] proxmox-boot: add pin/unpin functionality for non-p-b-t systems

2022-02-11 Thread Stoiko Ivanov
-b-t kernel pin --next-boot ; p-b-t kernel pin Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index 90c4f5d..178b6fb 100755 --- a/bin/proxmox-boot

[pve-devel] [PATCH proxmox-ve v3 1/3] apt-hook: fix perlcritic warnings

2022-02-11 Thread Stoiko Ivanov
Co-authored-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 1f77a1a..2053fef 100755 --- a/debian/apthook/pve-apt-hook

Re: [pve-devel] [PATCH proxmox-ve v2 2/2] apt-hook: add check preventing the removal of pinned kernels

2022-02-09 Thread Stoiko Ivanov
in some of our other products, which do not depend on pve-common (PBS for now). if the series is accepted as-is - feel free to update the commit message. else - I'll include it in the v3 sorry for the noise On Fri, 4 Feb 2022 19:45:38 +0100 Stoiko Ivanov wrote: > Signed-off-by: Stoiko Iva

[pve-devel] [PATCH pve-kernel-meta/proxmox-ve v2] proxmox-boot: add kernel pinning functionality (#3761)

2022-02-04 Thread Stoiko Ivanov
VMs installed from the 7.1 ISO (UEFI+ZFS, legacy+ZFS, UEFI+lvm-thin). proxmox-kernel-meta: Stoiko Ivanov (4): proxmox-boot: return empty if file does not exist in get_first_line proxmox-boot: fix #3671 add pin/unpin for kernel-version proxmox-boot: add kernel next-boot command proxmox-b

[pve-devel] [PATCH proxmox-ve v2 2/2] apt-hook: add check preventing the removal of pinned kernels

2022-02-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 28 1 file changed, 28 insertions(+) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 50e50d1..6de56c4 100755 --- a/debian/apthook/pve-apt-hook +++ b/debian/apthook/pve-apt

[pve-devel] [PATCH pve-kernel-meta v2 1/4] proxmox-boot: return empty if file does not exist in get_first_line

2022-02-04 Thread Stoiko Ivanov
makes using this helper shorter in most cases Signed-off-by: Stoiko Ivanov --- proxmox-boot/functions | 5 + 1 file changed, 5 insertions(+) diff --git a/proxmox-boot/functions b/proxmox-boot/functions index 4515a2d..27da363 100755 --- a/proxmox-boot/functions +++ b/proxmox-boot/functions

[pve-devel] [PATCH pve-kernel-meta v2 2/4] proxmox-boot: fix #3671 add pin/unpin for kernel-version

2022-02-04 Thread Stoiko Ivanov
ore robust Tested with a BIOS and an UEFI VM with / on ZFS. [0] https://systemd.io/BOOT_LOADER_SPECIFICATION/ Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool| 46 proxmox-boot/functions | 37 + proxmox-boot/

[pve-devel] [PATCH pve-kernel-meta v2 3/4] proxmox-boot: add kernel next-boot command

2022-02-04 Thread Stoiko Ivanov
by setting the desired version in a dedicated file, which is used by the systemd service as condition for removing it and refreshing upon reboot Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 34 +-- debian/pve-kernel-helper.install

[pve-devel] [PATCH pve-kernel-meta v2 4/4] proxmox-boot: add pin/unpin functionality for non-p-b-t systems

2022-02-04 Thread Stoiko Ivanov
While running `update-grub` directly in this case is a divergence from the semantics of the command when p-b-t handles booting it makes the cleanup in the `next-boot` case a bit tidier. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 22 +++--- 1 file changed, 19

[pve-devel] [PATCH proxmox-ve v2 1/2] apt-hook: fix perlcritic warnings

2022-02-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 1f77a1a..50e50d1 100755 --- a/debian/apthook/pve-apt-hook +++ b/debian/apthook/pve-apt-hook

Re: [pve-devel] [RFC pve-kernel-meta 0/5] unify boot-mode config

2022-02-02 Thread Stoiko Ivanov
On Wed, 2 Feb 2022 10:03:05 +0100 Thomas Lamprecht wrote: > On 01.02.22 23:03, Stoiko Ivanov wrote: > > patch 3 drops systemd-boot and uses grub for both boot-modes, hopefully > > unifying the boot-experience and causing less confusion (currently I suggest > > to look at the

[pve-devel] [RFC pve-kernel-meta 0/5] unify boot-mode config

2022-02-01 Thread Stoiko Ivanov
ESP to clean out systemd-boot) - both booted fine when changing their BIOS mode as is it's definitely missing: * a plan for transitioning current systems * cleanup of the code (the changes are minimal for a POC) * updated documentation * quite a bit more testing (especially on real hardware) Sto

[pve-devel] [RFC pve-kernel-meta 3/5] proxmox-boot: keep EFI and legacy bootloaders in sync

2022-02-01 Thread Stoiko Ivanov
/UEFI_Spec_2_9_2021_03_18.pdf Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool| 38 proxmox-boot/zz-proxmox-boot | 88 ++-- 2 files changed, 45 insertions(+), 81 deletions(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index

[pve-devel] [RFC pve-kernel-meta 4/5] proxmox-boot: use grub for UEFI boot

2022-02-01 Thread Stoiko Ivanov
handling non-uefi installations we can deal with grub installed on an ESP anyways. This changeset changes proxmox-boot-tool to use grub for both boot-modes, unifying the experience (e.g. not needing to check the boot mode in order to set kernel commandline arguments) Signed-off-by: Stoiko Ivanov

[pve-devel] [RFC pve-kernel-meta 1/5] rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels

2022-02-01 Thread Stoiko Ivanov
was forgotten during the general renaming of pve-efiboot -> proxmox-boot. follows commit 8c0a22adfe15dc00cf2194647bb254201d8d187b Signed-off-by: Stoiko Ivanov --- debian/pve-kernel-helper.postinst | 4 proxmox-boot/functions| 2 +- 2 files changed, 5 insertions(+), 1 delet

[pve-devel] [RFC pve-kernel-meta 2/5] proxmox-boot: add reinit subcommand

2022-02-01 Thread Stoiko Ivanov
to iterate over all configured ESPs and refresh the boot-loader installations. Signed-off-by: Stoiko Ivanov --- bin/grub-install-wrapper | 19 ++- bin/proxmox-boot-tool| 39 +++ 2 files changed, 37 insertions(+), 21 deletions(-) diff

[pve-devel] [RFC pve-kernel-meta 5/5] proxmox-boot: install grub in esp/EFI/BOOT/BOOTX64.EFI

2022-02-01 Thread Stoiko Ivanov
by passing the --removable option Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index d8caa6b..72f77ed 100755 --- a/bin/proxmox-boot-tool +++ b/bin/proxmox-boot-tool

[pve-devel] [PATCH pve-kernel-meta 5/5] proxmox-boot: add pin/unpin functionality for non-p-b-t systems

2022-01-31 Thread Stoiko Ivanov
While running `update-grub` directly in this case is a divergence from the semantics of the command when p-b-t handles booting it makes the cleanup in the `next-boot` case a bit tidier. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 17 +++-- 1 file changed, 15 insertions

[pve-devel] [PATCH pve-kernel-meta 1/5] proxmox-boot: drop unused potential_esps function

2022-01-31 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- proxmox-boot/zz-proxmox-boot | 5 - 1 file changed, 5 deletions(-) diff --git a/proxmox-boot/zz-proxmox-boot b/proxmox-boot/zz-proxmox-boot index e516b61..90d4aa9 100755 --- a/proxmox-boot/zz-proxmox-boot +++ b/proxmox-boot/zz-proxmox-boot @@ -39,11 +39,6

[pve-devel] [PATCH pve-kernel-meta 3/5] proxmox-boot: fix #3671 add pin/unpin for kernel-version

2022-01-31 Thread Stoiko Ivanov
st Tested with a BIOS and an UEFI VM with / on ZFS. [0] https://systemd.io/BOOT_LOADER_SPECIFICATION/ Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool| 47 +--- proxmox-boot/functions | 37 proxmox-boot/zz-proxmox-boot |

[pve-devel] [PATCH pve-kernel-meta 2/5] proxmox-boot: add get_first_line_from_file helper and use it

2022-01-31 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- proxmox-boot/functions | 8 proxmox-boot/zz-proxmox-boot | 4 +--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/proxmox-boot/functions b/proxmox-boot/functions index 6e19c20..4515a2d 100755 --- a/proxmox-boot/functions +++ b

[pve-devel] [PATCH pve-kernel-meta 4/5] proxmox-boot: add kernel next-boot command

2022-01-31 Thread Stoiko Ivanov
by pinning the desired version and touching a flag file, which is used by the systemd service as condition for unpinning and refreshing upon reboot Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 9 +++-- debian/pve-kernel-helper.install | 1 + debian

[pve-devel] [PATCH pve-kernel-meta 0/5] proxmox-boot: add kernel pinning functionality (#3761)

2022-01-31 Thread Stoiko Ivanov
from the 7.1 ISO (UEFI+ZFS, legacy+ZFS, UEFI+lvm-thin). Stoiko Ivanov (5): proxmox-boot: drop unused potential_esps function proxmox-boot: add get_first_line_from_file helper and use it proxmox-boot: fix #3671 add pin/unpin for kernel-version proxmox-boot: add kernel next-boot command

[pve-devel] [PATCH installer] get_device_desc: display disk size with 2 decimal places

2022-01-25 Thread Stoiko Ivanov
Addtionally added the explicit return ath the end of the if branch, instead of relying on the last statement not moving. Signed-off-by: Stoiko Ivanov --- Alternatively we could also use sprintf without decimal places for rounding (Math::Round is a debian package of it's own) - if people consider

[pve-devel] [PATCH zfsonlinux] cherry-pick lock-inversion patch for zvol_open

2022-01-11 Thread Stoiko Ivanov
off-by: Stoiko Ivanov --- did not reproduce the dead-lock myself (in my very limited tests) but given that our 2.1.2 packages (and kernel modules) have not seen too much testing in public yet - thought it makes sense to proactively pull this in quickly tested a kernel+userspace with this pa

[pve-devel] [PATCH zfsonlinux/stable-6 2/2] d/rules: allow abigail to fail

2022-01-11 Thread Stoiko Ivanov
From: Aron Xu (cherry picked from debian upstream [0] commit 5ae98b5499022c2c127d546a7b5aeb906f6f2a6b) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian

[pve-devel] [PATCH zfsonlinux/stable-6 1/2] update submodule and patches to ZFS 2.0.7

2022-01-11 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/patches/0005-Enable-zed-emails.patch | 2 +- debian/patches/0007-Use-installed-python3.patch | 6 +++--- upstream| 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/debian/patches/0005-Enable

[pve-devel] [PATCH zfsonlinux/stable-6 0/2] update zfs to 2.0.7

2022-01-11 Thread Stoiko Ivanov
are-testhosts Aron Xu (1): d/rules: allow abigail to fail Stoiko Ivanov (1): update submodule and patches to ZFS 2.0.7 debian/patches/0005-Enable-zed-emails.patch | 2 +- debian/patches/0007-Use-installed-python3.patch | 6 +++--- debian/rules| 2 +- upstr

[pve-devel] [PATCH pve-kernel 2/2] drop -ERESTARTSYS handling in blkdev_get_by_dev patch

2021-12-23 Thread Stoiko Ivanov
ZFS 2.1.2 handles this internally (commit 16da688f2518526389e6bff8370684a1a2a1469c) Signed-off-by: Stoiko Ivanov --- ...onfig-disable-module-BTF-debug-info.patch} | 0 ...ove-the-ERESTARTSYS-handling-in-blkd.patch | 40 --- 2 files changed, 40 deletions(-) rename patches

[pve-devel] [PATCH zfsonlinux 2/2] d/rules: allow abigail to fail

2021-12-23 Thread Stoiko Ivanov
From: Aron Xu (cherry picked from debian upstream [0] commit 5ae98b5499022c2c127d546a7b5aeb906f6f2a6b) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian

[pve-devel] [PATCH zfsonlinux/kernel] update ZFS to 2.1.2

2021-12-23 Thread Stoiko Ivanov
- the zvol ERSTARTSYS issue is still fixed - tested with: ` parallel -j1000% nice -n19 dd if=\{\} of=/dev/null status=none bs=4K count=1 ::: /dev/zd*` zfsonlinux: Aron Xu (1): d/rules: allow abigail to fail Stoiko Ivanov (1): update submodule and patches to ZFS 2.1.2 debian/patches/0005-

[pve-devel] [PATCH pve-kernel 1/2] patches: add Author information to disable-split-btf.patch

2021-12-23 Thread Stoiko Ivanov
else it is not easily applied with git am (as used by debian/scripts/import-patchqueue) Signed-off-by: Stoiko Ivanov --- ...Config-disable-module-BTF-debug-info.patch | 23 +++ patches/kernel/0009-disable-split-btf.patch | 13 --- 2 files changed, 23 insertions(+), 13

[pve-devel] [PATCH zfsonlinux 1/2] update submodule and patches to ZFS 2.1.2

2021-12-23 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/patches/0005-Enable-zed-emails.patch | 2 +- debian/patches/0007-Use-installed-python3.patch | 6 +++--- upstream| 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/debian/patches/0005-Enable

Re: [pve-devel] [PATCH http-server/manager/pmg-api/docs 0/10] expose more TLS knobs

2021-12-20 Thread Stoiko Ivanov
Thanks for the series! tried each of the option (and verified with `sslscan localhost:8006`) 2 minor cosmetic nits (mentioned as replies to the individual patches) with and without them LGTM: Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov On Fri, 17 Dec 2021 13:57:26 +0100 Fabian

Re: [pve-devel] [PATCH docs] pveproxy: document newly added options

2021-12-20 Thread Stoiko Ivanov
tiny nit inline: On Fri, 17 Dec 2021 13:57:33 +0100 Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > pveproxy.adoc | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/pveproxy.adoc b/pveproxy.adoc > index

Re: [pve-devel] [PATCH http-server 1/3] fix #3790: allow setting TLS 1.3 cipher suites

2021-12-20 Thread Stoiko Ivanov
Thanks for tackling this! gave it a spin - works as advertised one thing I think could be improved - is that currently nothing is logged when CIPHERSUITES is set to an invalid setting. (tested with "garbage TLS_CHACHA20_POLY1305_SHA256") with TLS1.2 CIPHERS the log gets filled with: 'garbage'

[pve-devel] [PATCH pve-kernel 1/1] d/control.in: Provide versioned linux-image/linux-headers

2021-12-13 Thread Stoiko Ivanov
for third-party kernel-drivers on plain debian. Signed-off-by: Stoiko Ivanov --- debian/control.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/control.in b/debian/control.in index ee91978..df6ff3d 100644 --- a/debian/control.in +++ b/debian/control.in @@ -50,7

[pve-devel] [PATCH pve-kernel-meta 2/2] fix #3781: add Provides: wireguard-modules to control.in

2021-12-13 Thread Stoiko Ivanov
-image-amd64), so following this add it to pve-kernel-$MAJ.$MIN versioned dependency added since wireguard has a versioned dependency on wireguard-modules. [0] https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/templates/control.image.meta.in Signed-off-by: Stoiko Ivanov --- debian

[pve-devel] [PATCH pve-kernel-meta 1/2] d/control.in: Provide linux-image/linux-headers

2021-12-13 Thread Stoiko Ivanov
on linux-headers-amd64. Signed-off-by: Stoiko Ivanov --- debian/control.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control.in b/debian/control.in index 3a7d32b..ce9f19a 100644 --- a/debian/control.in +++ b/debian/control.in @@ -9,6 +9,7 @@ Maintainer: Proxmox Support Team Package

[pve-devel] [PATCH pve-kernel-meta/pve-kernel] add Provides for plain debian packages

2021-12-13 Thread Stoiko Ivanov
works smootly * afterwards install `wireguard` * running `apt install linux-headers-$(uname -r)-amd64` pve-kernel-meta: Stoiko Ivanov (2): d/control.in: Provide linux-image/linux-headers fix #3781: add Provides: wireguard-modules to control.in debian/control.in | 2 ++ 1 file changed, 2

Re: [pve-devel] [PATCH pve-kernel] fix #3781: add Provides: wireguard-modules to control.in

2021-12-10 Thread Stoiko Ivanov
On Fri, 10 Dec 2021 18:27:39 +0100 Thomas Lamprecht wrote: > On 10.12.21 17:49, Stoiko Ivanov wrote: > > without this line `apt install wireguard` pulls in Debian's kernel + > > firmware which confilcts with pve-firmware - forcing users to install > > via `apt install --

[pve-devel] [PATCH pve-kernel] fix #3781: add Provides: wireguard-modules to control.in

2021-12-10 Thread Stoiko Ivanov
/control.image.meta.in Signed-off-by: Stoiko Ivanov --- * quickly tested by building a kernel with this patch - installing it in a VM and running `apt install wireguard` afterwards debian/control.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/control.in b/debian

[pve-devel] [PATCH installer] proxmox-boot-preparation: add newline to /etc/kernel/cmdline

2021-11-30 Thread Stoiko Ivanov
for better readability - and more robust handling in proxmox-boot-tool quickly tested with the latest PMG-ISO and the debug mode. Signed-off-by: Stoiko Ivanov --- proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index ddb4523..ae0e235

Re: [pve-devel] [PATCH manager 1/1] api: journal: stream the journal data to the client

2021-11-24 Thread Stoiko Ivanov
On Wed, 24 Nov 2021 18:46:04 +0100 Thomas Lamprecht wrote: > On 24.11.21 18:32, Stoiko Ivanov wrote: > > Huge thanks for addressing this so quickly and elegantly! > > > > One question/nit: > > > > On Wed, 24 Nov 2021 15:47:48 +0100 > > Dominik Csapak wro

Re: [pve-devel] [PATCH manager 1/1] api: journal: stream the journal data to the client

2021-11-24 Thread Stoiko Ivanov
Huge thanks for addressing this so quickly and elegantly! One question/nit: On Wed, 24 Nov 2021 15:47:48 +0100 Dominik Csapak wrote: > instead of accumulating the whole output of 'mini-journalreader' in > the api call (this can be quite big), use the download mechanic of the > http-server to

[pve-devel] [PATCH http-server] fix #3724: disable TLS renegotiation

2021-11-15 Thread Stoiko Ivanov
in openssl API over the years) Signed-off-by: Stoiko Ivanov --- src/PVE/APIServer/AnyEvent.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index 86d0e2e..e3633f7 100644 --- a/src/PVE/APIServer/AnyEvent.pm +++ b/src

[pve-devel] [PATCH zfsonlinux] arcstat/arc_summary: workaround for stats only present with cache device

2021-11-11 Thread Stoiko Ivanov
This commit updates Thomas' patch to deal with a 2.0 kernel module with 2.1 arc_summary/arcstat Tested by adding a cache-device to a zpool and running both commands to verify no KeyError exception is thrown. Signed-off-by: Stoiko Ivanov --- I hope the fixup in the patch and commit-log above my

[pve-devel] [PATCH cluster] sysctl snippet: move to /usr/lib and prefix with 10-

2021-11-11 Thread Stoiko Ivanov
. systemd - 50-) Tested on 2 VMs (one with modifications, the other without) - worked as advertised (the modified file was kept as /etc/sysctl.d/pve.conf.dpkg-old and the upgrade notified me of the change) Signed-off-by: Stoiko Ivanov --- debian/conffiles | 1 + debian/pve

[pve-devel] [PATCH pve-kernel-meta v2] proxmox-boot: read only first line of /etc/kernel/cmdline

2021-11-10 Thread Stoiko Ivanov
in the beginning, which again rendered it unbootable. quickly tested on a VM. [0]: https://forum.proxmox.com/threads/problem-with-proxmox-boot-tool.99043/ Signed-off-by: Stoiko Ivanov --- v1->v2: * incorporated Dominik and Thomas' feedback (huge thanks for catching my glitches!) proxmox-boot/zz-prox

Re: [pve-devel] [PATCH kernel-meta] boot-tool: fix whitespace in generated loader configuration

2021-11-10 Thread Stoiko Ivanov
my test-system unbootable was adding empty lines to /etc/kernel/cmdline (and running p-b-t refresh) - I sent a short follow-up for this. In any case - your patch works as advertised: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Wed, 10 Nov 2021 14:07:46 +0100 Oguz Bektas wrote

[pve-devel] [PATCH pve-kernel-meta] proxmox-boot: trim /etc/kernel/cmdline before appending

2021-11-10 Thread Stoiko Ivanov
this - systemd-boot booted quite happily even with the indentation. quickly tested on a VM. [0]: https://forum.proxmox.com/threads/problem-with-proxmox-boot-tool.99043/ Signed-off-by: Stoiko Ivanov --- proxmox-boot/zz-proxmox-boot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pve-devel] [PATCH proxmox-acme 2/2] dns-challenge: add 'use-proxy' property

2021-11-09 Thread Stoiko Ivanov
, direct traffic to the pdns server being dropped, and a configured squid proxy Signed-off-by: Stoiko Ivanov --- src/PVE/ACME/DNSChallenge.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/PVE/ACME/DNSChallenge.pm b/src/PVE/ACME/DNSChallenge.pm index 9b28970

[pve-devel] [PATCH widget-toolkit 1/1] acmeplugin: add use-proxy checkbox

2021-11-09 Thread Stoiko Ivanov
if set the plugin will use the http_proxy configured on the node/datacenter. Signed-off-by: Stoiko Ivanov --- src/window/ACMEPluginEdit.js | 8 1 file changed, 8 insertions(+) diff --git a/src/window/ACMEPluginEdit.js b/src/window/ACMEPluginEdit.js index 237b362..406f14e 100644

[pve-devel] [PATCH manager/proxmox-acme/pwt 0/3] fix #3536 add http proxy support for acme

2021-11-09 Thread Stoiko Ivanov
with a publicly exposed powerdns-plugin and let's encrypt (mostly staging) proxmox-acme: Stoiko Ivanov (2): add support for proxies dns-challenge: add 'use-proxy' property src/PVE/ACME.pm | 6 ++ src/PVE/ACME/DNSChallenge.pm | 10 +- 2 files changed, 15 insertions(+), 1

[pve-devel] [PATCH manager 3/3] gui: use acme plugin editor from proxmox-widget-toolkit

2021-11-09 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- www/manager6/Makefile | 1 - www/manager6/dc/ACMEClusterView.js | 13 +- www/manager6/dc/ACMEPluginEdit.js | 223 - 3 files changed, 10 insertions(+), 227 deletions(-) delete mode 100644 www/manager6/dc

[pve-devel] [PATCH manager 2/3] api: acme: dns-plugin: conditionally pass proxy to acme.sh wrapper

2021-11-09 Thread Stoiko Ivanov
) and communication with them must not pass through the proxy. The implementation follows the one in PMG Signed-off-by: Stoiko Ivanov --- PVE/API2/ACME.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/PVE/API2/ACME.pm b/PVE/API2/ACME.pm index 6e6f44f6..de6068bf 100644 --- a/PVE/API2/ACME.pm +++ b/PVE

[pve-devel] [PATCH proxmox-acme 1/2] add support for proxies

2021-11-09 Thread Stoiko Ivanov
by setting the proxy for the LWP::UserAgent Signed-off-by: Stoiko Ivanov --- src/PVE/ACME.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm index 57578d7..3f66182 100644 --- a/src/PVE/ACME.pm +++ b/src/PVE/ACME.pm @@ -113,6 +113,12 @@ sub new

[pve-devel] [PATCH manager 1/3] api: acme: set http_proxy if configured in datacenter.cfg

2021-11-09 Thread Stoiko Ivanov
partially fixes #3536 If a http_proxy is set in the datacenter config, use it for communicating with the (usually public) Acme provider. Signed-off-by: Stoiko Ivanov --- PVE/API2/ACME.pm| 13 + PVE/API2/ACMEAccount.pm | 17 + 2 files changed, 30 insertions

Re: [pve-devel] [PATCH v2 proxmox-acme] support downloading alternate chains

2021-10-08 Thread Stoiko Ivanov
Tested again against LE production endpoint - LGTM :) Thanks! Reviewed-By: Stoiko Ivanov Tested-By: Stoiko Ivanov On Fri, 8 Oct 2021 10:18:21 +0200 Fabian Grünbichler wrote: > the current default chains end with an expired root certificate for > maximum compatibility with old A

Re: [pve-devel] [PATCH proxmox-acme] support downloading alternate chains

2021-10-07 Thread Stoiko Ivanov
Huge Thanks for addressing this so fast! quickly tested it on a (publicly accessible) system of mine against Let's Encrypt official API (boulder) It works as advertised and fetches the (shorter) certificate chain without the signed ISRG X1 as intermediate (signed by DST Root CA X3) So this

[pve-devel] [PATCH pve-kernel-meta/pve-kernel-5.4] boot-tool: prefer PVE for systemd-boot loader title

2021-09-28 Thread Stoiko Ivanov
From: Fabian Grünbichler like for Grub where this is handled via snippets with PVE > PMG > PBS. Reported-by: Oguz Bektas Signed-off-by: Fabian Grünbichler (cherry picked from commit 40d8d36eef7935ee386edbdf5328f3b6421ff899) Signed-off-by: Stoiko Ivanov --- this patch is the only releva

[pve-devel] [PATCH zfsonlinux 3/3] bump libzpool soname

2021-09-27 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- Makefile | 2 +- debian/control| 8 debian/{libzpool4linux.docs => libzpool5linux.docs} | 0 ...ibzpool4linux.install.in => libzpool5linux.install.i

[pve-devel] [PATCH zfsonlinux 2/3] buildsys: adapt install paths for zfs 2.1.1

2021-09-27 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install index 4f93aa70..b7501b30 100644 --- a/debian/zfsutils-linux.install +++ b/debian

[pve-devel] [PATCH zfsonlinux 1/3] update submodule and patches to ZFS 2.1.1-staging

2021-09-27 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...ith-d-dev-disk-by-id-in-scan-service.patch | 6 +- .../0006-dont-symlink-zed-scripts.patch | 5 +- .../patches/0007-Use-installed-python3.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 61 +-- upstream

[pve-devel] [PATCH zfsonlinux 0/3] update to 2.1.1

2021-09-27 Thread Stoiko Ivanov
replication for one VM (snapshotting, migrating, upgrading the zpool, migrating back) - all seemed ok. Stoiko Ivanov (3): update submodule and patches to ZFS 2.1.1-staging buildsys: adapt install paths for zfs 2.1.1 bump libzpool soname Makefile | 2

[pve-devel] [PATCH pve-kernel-meta] proxmox-boot: fix #3632 copy kernel+initrd unconditionally

2021-09-23 Thread Stoiko Ivanov
with the pve-no-subscription repo) and verified this patch fixes it. Signed-off-by: Stoiko Ivanov --- Initially considered using the output of `stat --format=%s:%Y` of both files as 'fingerprint' for comparison proxmox-boot/zz-proxmox-boot | 12 ++-- 1 file changed, 6 insertions(+), 6

[pve-devel] [PATCH zfsonlinux/stable-6] cherry-pick fix for assertion from 2.0.6-staging

2021-09-08 Thread Stoiko Ivanov
The panic described in the issues closed by this commit were observed by some users. Since the revert is already included in upstreams master and 2.1 branches, and the proposed port to the 2.0 branches is already accepted the limit for regression should be small. Signed-off-by: Stoiko Ivanov

[pve-devel] [RFC zfsonlinux 5/5] bump libzpool soname

2021-09-07 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- Makefile | 2 +- debian/control | 12 ++-- debian/{libzpool4linux.docs => libzpool5linux.docs} | 0 ...ol4linux.install.in => libzpool5linux.install.in

[pve-devel] [RFC zfsonlinux 3/5] port changes to abi tracking from master

2021-09-07 Thread Stoiko Ivanov
mit will break building zfs on buster. Signed-off-by: Stoiko Ivanov --- debian/control| 2 +- .../0010-Check-for-libabigail-version.patch | 45 +++ ...c-storabi-abidw-invocation-with-mast.patch | 33 ++ debian/patches/ser

[pve-devel] [RFC zfsonlinux 1/5] update submodule and patches to ZFS 2.1.1-staging

2021-09-07 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...ith-d-dev-disk-by-id-in-scan-service.patch | 6 +- .../0006-dont-symlink-zed-scripts.patch | 5 +- .../patches/0007-Use-installed-python3.patch | 4 +- ...-move-manpage-arcstat-1-to-arcstat-8.patch | 61 +-- upstream

[pve-devel] [RFC zfsonlinux 2/5] buildsys: adapt install paths for zfs 2.1.0

2021-09-07 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install index 4f93aa70..b7501b30 100644 --- a/debian/zfsutils-linux.install +++ b/debian

[pve-devel] [RFC zfsonlinux 4/5] update abi definitions for 2.1.1

2021-09-07 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...itions-with-abigail-tools-1.8-and-ne.patch | 25768 debian/patches/series | 1 + 2 files changed, 25769 insertions(+) create mode 100644 debian/patches/0012-update-abi-definitions-with-abigail-tools-1.8

[pve-devel] [RFC zfsonlinux 0/5] update to 2.1.1

2021-09-07 Thread Stoiko Ivanov
- which still leaves the soname at libzfs.so.4 when building on my machine. Did some minimal tests in a virtual 2-node test-cluster of mine with storage replication for one VM (snapshotting, migrating, upgrading the zpool, migrating back) - all seemed ok. Stoiko Ivanov (5): update submodule

<    1   2   3   4   5   6   >