Re: [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Friedrich Weber
Tested-by: Friedrich Weber Tested the following: * PVE 7.3: setup LDAP realms realm #1 with `base_dn ou=Foo- und Bar,dc=example,dc=com` realm #2 with `base_dn ou=Users,dc=example,dc=com` both work, i.e., sync is possible and users can log in * Update to 7.4: realm #1: users cannot login

Re: [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Thomas Lamprecht
Am 23/03/2023 um 14:14 schrieb Dominik Csapak: > we previously added support for ',' in the dns attribute by allowing a > quoted format. the regex was sadly too restrictive: > > in a quoted attribute we'd only allow \w (alphanumeric + _) and the > restricted characters. this patch now changes that

[pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config

2023-03-23 Thread Dominik Csapak
we previously added support for ',' in the dns attribute by allowing a quoted format. the regex was sadly too restrictive: in a quoted attribute we'd only allow \w (alphanumeric + _) and the restricted characters. this patch now changes that to everything except " (nearer to the original regex whi