Am 15/03/2023 um 12:41 schrieb Dominik Csapak:
> if my example and all that could have been configured but
> would now be invalid are not valid ldap syntax anyway, i think
> we can get more strict and "break" someones config
> (as you said, shouldn't have worked anyway)
> or how do you see that
Comment inline.
On Wed, Mar 15, 2023 at 12:41:39PM +0100, Dominik Csapak wrote:
> On 3/15/23 12:17, Christoph Heiss wrote:
> > Thanks for the review!
> >
> > [..]
> > > >
> > > > diff --git a/src/PVE/Auth/LDAP.pm b/src/PVE/Auth/LDAP.pm
> > > > index 4792586..4d771e7 100755
> > > > ---
On 3/15/23 12:17, Christoph Heiss wrote:
Thanks for the review!
On Wed, Mar 15, 2023 at 10:54:38AM +0100, Dominik Csapak wrote:
hi,
so high level comment:
i'd write most of what you wrote in the cover letter here in the commit message,
makes it much more convenient to find it only via git ;)
Thanks for the review!
On Wed, Mar 15, 2023 at 10:54:38AM +0100, Dominik Csapak wrote:
> hi,
>
> so high level comment:
> i'd write most of what you wrote in the cover letter here in the commit
> message,
> makes it much more convenient to find it only via git ;)
Good point, I'll do that if/when
hi,
so high level comment:
i'd write most of what you wrote in the cover letter here in the commit message,
makes it much more convenient to find it only via git ;)
also i'm missing a bit the rationale for how the regex was chosen, besides
that it works in some conditions
further comment
Signed-off-by: Christoph Heiss
---
src/PVE/Auth/LDAP.pm | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Auth/LDAP.pm b/src/PVE/Auth/LDAP.pm
index 4792586..4d771e7 100755
--- a/src/PVE/Auth/LDAP.pm
+++ b/src/PVE/Auth/LDAP.pm
@@ -10,6 +10,8 @@ use PVE::Tools;
