Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-27 Thread Christoph Heiss
On Wed, Oct 25, 2023 at 07:09:00PM +0200, Thomas Lamprecht wrote: > > Am 25/10/2023 um 10:28 schrieb Christoph Heiss: > > On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel > > wrote: > > > > Currently, this isn't planned, although - since that setting is exposed > > afte

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-25 Thread Thomas Lamprecht
devel] [PATCH installer v2 1/6] fix #4829: install: add >> new ZFS `arc_max` setup option >> >> >> Hi there. >> Now, that's a good option in the installer. >> I wonder if this option will be available post-intall, like some box in the >> ZFS manager

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-25 Thread Christoph Heiss
On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel wrote: > Date: Tue, 24 Oct 2023 08:59:36 -0300 > From: Gilberto Ferreira > To: Proxmox VE development discussion > Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add > new ZFS

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-25 Thread Christoph Heiss
Thanks for the review! I will refactor all the points mentioned and send a v2 soon. On Tue, Oct 24, 2023 at 05:05:15PM +0200, Thomas Lamprecht wrote: > > Am 24/10/2023 um 13:55 schrieb Christoph Heiss: > > Signed-off-by: Christoph Heiss > > --- > > Changes v1 -> v2: > > * No changes > > > >

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-24 Thread Thomas Lamprecht
Am 24/10/2023 um 13:55 schrieb Christoph Heiss: > Signed-off-by: Christoph Heiss > --- > Changes v1 -> v2: > * No changes > > Proxmox/Install.pm| 4 > Proxmox/Install/Config.pm | 1 + > Proxmox/Install/RunEnv.pm | 38 ++ > 3 files changed, 43

Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-24 Thread Gilberto Ferreira via pve-devel
--- Begin Message --- Hi there. Now, that's a good option in the installer. I wonder if this option will be available post-intall, like some box in the ZFS manager from WEB GUI! That's would be nice. Em ter., 24 de out. de 2023 às 08:55, Christoph Heiss escreveu: > Signed-off-by: Christoph

[pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option

2023-10-24 Thread Christoph Heiss
Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * No changes Proxmox/Install.pm| 4 Proxmox/Install/Config.pm | 1 + Proxmox/Install/RunEnv.pm | 38 ++ 3 files changed, 43 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.p