Re: [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool

2024-07-16 Thread Christoph Heiss
v4 out: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064675.html On Thu, Jul 11, 2024 at 01:57:52PM GMT, Christoph Heiss wrote: > Pretty straight forward overall, implements a check for an existing > `rpool` on the system and ask the user whether they would like to rename > it, much in

Re: [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool

2024-07-15 Thread Christoph Heiss
Thanks again! On Fri, Jul 12, 2024 at 11:42:58AM GMT, Aaron Lauterer wrote: > tested this series more thoroughly and checked with an existing root pool > all 3 install options: > > * TUI > * GUI > * auto > > Worked well in 3 cases to rename. > > One oddity seems to be if we cancel the rename in th

Re: [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool

2024-07-12 Thread Aaron Lauterer
tested this series more thoroughly and checked with an existing root pool all 3 install options: * TUI * GUI * auto Worked well in 3 cases to rename. One oddity seems to be if we cancel the rename in the TUI installer. it jumps to 100% and stays there and I then need to manually abort. Jumpin

[pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool

2024-07-11 Thread Christoph Heiss
Pretty straight forward overall, implements a check for an existing `rpool` on the system and ask the user whether they would like to rename it, much in the same way as it works for VGs already. Without this, the installer would silently create a second (and thus conflicting) `rpool` and cause a b