Re: [pve-devel] [PATCH manager] fix #3182 #3183: change backup retention mask logic

2020-12-02 Thread Thomas Lamprecht
On 02.12.20 14:19, Dominik Csapak wrote: > On 12/2/20 2:11 PM, Thomas Lamprecht wrote: >> On 02.12.20 13:56, Dominik Csapak wrote: >>> instead of relying on the contentTypeField (which does not need to >>> exists, e.g. for iscsi), explicitely write it into the panel/icon >>> mapping and check that

Re: [pve-devel] [PATCH manager] fix #3182 #3183: change backup retention mask logic

2020-12-02 Thread Dominik Csapak
On 12/2/20 2:11 PM, Thomas Lamprecht wrote: On 02.12.20 13:56, Dominik Csapak wrote: instead of relying on the contentTypeField (which does not need to exists, e.g. for iscsi), explicitely write it into the panel/icon mapping and check that why not return it for iSCIS? > i don't understand w

Re: [pve-devel] [PATCH manager] fix #3182 #3183: change backup retention mask logic

2020-12-02 Thread Thomas Lamprecht
On 02.12.20 13:56, Dominik Csapak wrote: > instead of relying on the contentTypeField (which does not need to > exists, e.g. for iscsi), explicitely write it into the panel/icon > mapping and check that why not return it for iSCIS? > > better would be if we query the backend about storage capabi

[pve-devel] [PATCH manager] fix #3182 #3183: change backup retention mask logic

2020-12-02 Thread Dominik Csapak
instead of relying on the contentTypeField (which does not need to exists, e.g. for iscsi), explicitely write it into the panel/icon mapping and check that better would be if we query the backend about storage capabilities, but such an api call does not exist yet, so this should be ok for now Sig