Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-30 Thread Thomas Lamprecht
Am 28/12/2022 um 15:18 schrieb Stefan Sterz: > maybe somewhat off-topic for the patch at hand, but it might be nice to > modularize the pve report. so that `pvereport` gives you a default set > of information, but you could also use `pvereport ha` to give you more > information specifically about

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-28 Thread Stefan Sterz
On 12/16/22 13:15, Fiona Ebner wrote: > Am 15.12.22 um 17:57 schrieb Mira Limbeck: >> diff --git a/PVE/Report.pm b/PVE/Report.pm >> index 90b7cb1c..7ebe98f7 100644 >> --- a/PVE/Report.pm >> +++ b/PVE/Report.pm >> @@ -5,16 +5,34 @@ use warnings; >> >> use PVE::Tools; >> >> +my sub file2text {

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Fiona Ebner
Am 15.12.22 um 17:57 schrieb Mira Limbeck: > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 90b7cb1c..7ebe98f7 100644 > --- a/PVE/Report.pm > +++ b/PVE/Report.pm > @@ -5,16 +5,34 @@ use warnings; > > use PVE::Tools; > > +my sub file2text { > +my ($file, $filter) = @_; > +my $text

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Mira Limbeck
On 12/16/22 11:31, Thomas Lamprecht wrote: On 15/12/2022 17:57, Mira Limbeck wrote: Since some users keep their passwords in the VM/CT configs as comments and those are most of the time unnecessary when looking through the report, filter those. I'd rather have this optional, opt-out is fine,

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Thomas Lamprecht
On 15/12/2022 17:57, Mira Limbeck wrote: > Since some users keep their passwords in the VM/CT configs as comments > and those are most of the time unnecessary when looking through the > report, filter those. I'd rather have this optional, opt-out is fine, where the CLI gets a switch and the web

Re: [pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-16 Thread Stefan Sterz
On 12/15/22 17:57, Mira Limbeck wrote: > Since some users keep their passwords in the VM/CT configs as comments > and those are most of the time unnecessary when looking through the > report, filter those. > > In addition to the comments, also filter the `cipassword` option > since it contains

[pve-devel] [PATCH manager] report: filter comments in VM/CT configs

2022-12-15 Thread Mira Limbeck
Since some users keep their passwords in the VM/CT configs as comments and those are most of the time unnecessary when looking through the report, filter those. In addition to the comments, also filter the `cipassword` option since it contains the hash of the password. To facilitate the