Re: [pve-devel] [PATCH proxmox 1/2] notify: api: allow resetting built-in targets when they are referenced

2024-01-10 Thread Lukas Wagner
On 1/9/24 14:18, Wolfgang Bumiller wrote: On Thu, Dec 14, 2023 at 01:42:07PM +0100, Lukas Wagner wrote: by a matcher. ^ this line should be part of the subject In the 'delete'-handler targets, we check if a target is still referenced by a matcher - if it is, we return an error. For built

Re: [pve-devel] [PATCH proxmox 1/2] notify: api: allow resetting built-in targets when they are referenced

2024-01-09 Thread Wolfgang Bumiller
On Thu, Dec 14, 2023 at 01:42:07PM +0100, Lukas Wagner wrote: > by a matcher. ^ this line should be part of the subject > > In the 'delete'-handler targets, we check if a > target is still referenced by a matcher - if it is, we return an > error. For built-in targets, this is actually not necess

Re: [pve-devel] [PATCH proxmox 1/2] notify: api: allow resetting built-in targets when they are referenced

2024-01-08 Thread Lukas Wagner
ping On 12/14/23 13:42, Lukas Wagner wrote: by a matcher. In the 'delete'-handler targets, we check if a target is still referenced by a matcher - if it is, we return an error. For built-in targets, this is actually not necessary, since 'deleting' a built-in only resets it to its default settin

[pve-devel] [PATCH proxmox 1/2] notify: api: allow resetting built-in targets when they are referenced

2023-12-14 Thread Lukas Wagner
by a matcher. In the 'delete'-handler targets, we check if a target is still referenced by a matcher - if it is, we return an error. For built-in targets, this is actually not necessary, since 'deleting' a built-in only resets it to its default settings - it will continue to exist after that. The