Re: [pve-devel] [PATCH qemu-server] cloud-init: don't regenerate ssh hosts key on config change when vm is running

2021-01-15 Thread aderumier
I have sent another patch, with a config option (Like this, user can define behaviour) Le jeudi 14 janvier 2021 à 16:20 +0100, aderum...@odiso.com a écrit : > > > We could add vendor data and put the ssh keys there: > > > > > > > >

Re: [pve-devel] [PATCH qemu-server] cloud-init: don't regenerate ssh hosts key on config change when vm is running

2021-01-14 Thread aderumier
>>We could add vendor data and put the ssh keys there: >>> >>> https://cloudinit.readthedocs.io/en/latest/topics/vendordata.html >>> technically, it's possible to add host ssh keys with ssh_keys: rsa_private: | -BEGIN RSA PRIVATE KEY-

Re: [pve-devel] [PATCH qemu-server] cloud-init: don't regenerate ssh hosts key on config change when vm is running

2021-01-14 Thread aderumier
> Hi, > > There is something indeed annoying with that module, as I always end > up > adding ssh_deletekeys: false in a provisionned server, but I like > that > it does it the first time indeed… > > Maybe we could let it be configurable though! Yes, I don't known too much how to handle it at

Re: [pve-devel] [PATCH qemu-server] cloud-init: don't regenerate ssh hosts key on config change when vm is running

2021-01-13 Thread Gilles Pietri
Le 13/01/2021 à 10:01, Alexandre Derumier a écrit : > Currently, we always regenerate sshkeys on any config change. > > It should be done only before the first vm start, but currently can't known > that. > > So, this patch only do it when vm is running. Hi, There is something indeed annoying

Re: [pve-devel] [PATCH qemu-server] cloud-init: don't regenerate ssh hosts key on config change when vm is running

2021-01-13 Thread Mira Limbeck
We could add vendor data and put the ssh keys there: https://cloudinit.readthedocs.io/en/latest/topics/vendordata.html On 1/13/21 10:01 AM, Alexandre Derumier wrote: Currently, we always regenerate sshkeys on any config change. It should be done only before the first vm start, but currently

[pve-devel] [PATCH qemu-server] cloud-init: don't regenerate ssh hosts key on config change when vm is running

2021-01-13 Thread Alexandre Derumier
Currently, we always regenerate sshkeys on any config change. It should be done only before the first vm start, but currently can't known that. So, this patch only do it when vm is running. Signed-off-by: Alexandre Derumier --- PVE/QemuServer/Cloudinit.pm | 2 ++ 1 file changed, 2