Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-04-04 Thread alexandre derumier
Hi, if you really want to keep the current pending behaviour, I think the only way is add new pending values, like "hostname" example , and for ipconfig, add the mac attribute. so, this should give something like: name change:  name(pending

Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-04-02 Thread aderumier
Maybe, another way, instead writing [cloudnit:special] section, we could write this config section inside the drive image directly when we generate it (to avoid to reparse format generate config) so we could read the drive to display the diff in the gui (we already have an cloudinit dump api,

Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-04-01 Thread aderumier
Le jeudi 01 avril 2021 à 10:54 +0200, Thomas Lamprecht a écrit : > > actually, why isn't the pending section enough for this? > > If stuff can be hot plugged then we can do so and if only that > changed we > can just remove it from pending, as normally? Well, for example, if you change the vm

Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-04-01 Thread Thomas Lamprecht
On 28.03.21 17:11, Alexandre Derumier wrote: > Instead using vm pending options for pending cloudinit generated config, > > write current generated cloudinit config in a new [special:cloudinit] SECTION. > > Currently, some options like vm name, nic mac address can be hotplugged, > so they are

Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-03-31 Thread Mira Limbeck
Thank you for the patch series and the GUI patches. Some comments inline. On 3/28/21 5:11 PM, Alexandre Derumier wrote: Instead using vm pending options for pending cloudinit generated config, write current generated cloudinit config in a new [special:cloudinit] SECTION. Currently, some

[pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config.

2021-03-28 Thread Alexandre Derumier
Instead using vm pending options for pending cloudinit generated config, write current generated cloudinit config in a new [special:cloudinit] SECTION. Currently, some options like vm name, nic mac address can be hotplugged, so they are not way to know if the cloud-init disk is already updated.