Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2023-06-14 Thread Aaron Lauterer
On 6/14/23 14:13, Fiona Ebner wrote: Am 14.06.23 um 13:44 schrieb Aaron Lauterer: On 6/14/23 13:38, Thomas Lamprecht wrote: Am 14/06/2023 um 13:28 schrieb Aaron Lauterer: This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. The bug should be fixed by now [0]. The reproducer doesn'

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2023-06-14 Thread Fiona Ebner
Am 14.06.23 um 13:44 schrieb Aaron Lauterer: > On 6/14/23 13:38, Thomas Lamprecht wrote: >> Am 14/06/2023 um 13:28 schrieb Aaron Lauterer: >>> This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. >>> >>> The bug should be fixed by now [0]. The reproducer doesn't cause any >>> issues in my

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2023-06-14 Thread Aaron Lauterer
On 6/14/23 13:38, Thomas Lamprecht wrote: Am 14/06/2023 um 13:28 schrieb Aaron Lauterer: This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. The bug should be fixed by now [0]. The reproducer doesn't cause any issues in my tests. [0] https://github.com/openzfs/zfs/issues/8541 hm

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2023-06-14 Thread Thomas Lamprecht
Am 14/06/2023 um 13:28 schrieb Aaron Lauterer: > This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. > > The bug should be fixed by now [0]. The reproducer doesn't cause any > issues in my tests. > > [0] https://github.com/openzfs/zfs/issues/8541 hmm, torn on this one; 1 MB aligned ima

[pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2023-06-14 Thread Aaron Lauterer
This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15. The bug should be fixed by now [0]. The reproducer doesn't cause any issues in my tests. [0] https://github.com/openzfs/zfs/issues/8541 Signed-off-by: Aaron Lauterer --- AFAICT this has an affect on EFI disks which after this revert

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2021-06-11 Thread Thomas Lamprecht
On 09.06.21 15:54, Aaron Lauterer wrote: > https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of > openzfs 2.0 with [0]. Since we ship only ZFS 2.0 with PVE 7 we should be > okay to remove our workaround > > [0] > https://github.com/openzfs/zfs/commit/47c9299fcc9e5fb91d0b1636bfacc03

Re: [pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2021-06-10 Thread Fabian Ebner
Works for me. A tiny issue is that the disk size in the VM config does not show the actual value afterwards, but that is nothing new. Tested-by: Fabian Ebner Am 09.06.21 um 15:54 schrieb Aaron Lauterer: https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of openzfs 2.0 with [0].

[pve-devel] [PATCH storage] Revert "workaround zfs create -V error for unaligned sizes"

2021-06-09 Thread Aaron Lauterer
https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of openzfs 2.0 with [0]. Since we ship only ZFS 2.0 with PVE 7 we should be okay to remove our workaround [0] https://github.com/openzfs/zfs/commit/47c9299fcc9e5fb91d0b1636bfacc03bd3e98439 This reverts commit cdef3abb25984c36957162