Re: [pve-devel] [PATCH storage] fix #3203: report smart status correctly

2021-03-02 Thread Oguz Bektas
hi, On Tue, Mar 02, 2021 at 09:34:41AM +0100, Dominik Csapak wrote: > On 3/1/21 14:56, Oguz Bektas wrote: > > if the -a option isn't passed, -H might report a failing disk as > > 'PASSED' even when the disk might be in a corrupted state. > > > > Signed-off-by: Oguz Bektas > > --- > > PVE/Diskm

Re: [pve-devel] [PATCH storage] fix #3203: report smart status correctly

2021-03-02 Thread Dominik Csapak
On 3/1/21 14:56, Oguz Bektas wrote: if the -a option isn't passed, -H might report a failing disk as 'PASSED' even when the disk might be in a corrupted state. Signed-off-by: Oguz Bektas --- PVE/Diskmanage.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/Diskma

Re: [pve-devel] [PATCH storage] fix #3203: report smart status correctly

2021-03-01 Thread Dietmar Maurer
This code is quite strange. Please can you use a normal: if .. then .. else .. > +push @$cmd, '-H' if $healthonly; > +push @$cmd, '-a', '-A', '-f', 'brief' if !$healthonly; ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.pr

[pve-devel] [PATCH storage] fix #3203: report smart status correctly

2021-03-01 Thread Oguz Bektas
if the -a option isn't passed, -H might report a failing disk as 'PASSED' even when the disk might be in a corrupted state. Signed-off-by: Oguz Bektas --- PVE/Diskmanage.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 64bb81