Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

On 11/15/23 11:09, Thomas Lamprecht wrote: > Am 15/11/2023 um 11:05 schrieb Philipp Hufnagl: >> >> >> On 11/15/23 10:52, Thomas Lamprecht wrote: >>> Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl: On 11/15/23 09:31, Fiona Ebner wrote: > Am 14.11.23 um 15:27 schrieb Philipp Hufnagl:

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

Am 15/11/2023 um 11:05 schrieb Philipp Hufnagl: > > > On 11/15/23 10:52, Thomas Lamprecht wrote: >> Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl: >>> On 11/15/23 09:31, Fiona Ebner wrote: Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: > diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PV

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

On 11/15/23 10:52, Thomas Lamprecht wrote: > Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl: >> On 11/15/23 09:31, Fiona Ebner wrote: >>> Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 4320974..aceb2c4 100644

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

Am 15.11.23 um 10:37 schrieb Philipp Hufnagl: > > > On 11/15/23 09:31, Fiona Ebner wrote: >> Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: >>> @@ -826,10 +837,18 @@ sub activate_storage { >>> die "$storeid: $@" if $@; >>> >>> my $datastore = $scfg->{datastore}; >>> +my $namespace

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl: > On 11/15/23 09:31, Fiona Ebner wrote: >> Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: >>> diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm >>> index 4320974..aceb2c4 100644 >>> --- a/src/PVE/Storage/PBSPlugin.pm >>> +++ b/sr

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

On 11/15/23 09:31, Fiona Ebner wrote: > Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: >> Currently, when adding a PBS storage with a namespace that does not >> exist, the storage gets added normally, but browsing/using it only >> returns a cryptic error message. >> >> This change checks if the n

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: > Currently, when adding a PBS storage with a namespace that does not > exist, the storage gets added normally, but browsing/using it only > returns a cryptic error message. > > This change checks if the namespace entered when adding is valid and > pro

[pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

Currently, when adding a PBS storage with a namespace that does not exist, the storage gets added normally, but browsing/using it only returns a cryptic error message. This change checks if the namespace entered when adding is valid and prompts an error if it is not. If no namespace is provided, t