Re: [pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin

2024-04-18 Thread Thomas Lamprecht
Am 18/04/2024 um 09:38 schrieb Fiona Ebner: > I was thinking, users might stumble upon this e.g. with "man pvesm", and > then try it for storages like NFS and wonder why it doesn't work. With > the "options" option we also explicitly mention NFS/CIFS. I'll send a v2 > without mentioning PBS/ESXi if

Re: [pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin

2024-04-18 Thread Fiona Ebner
Am 17.04.24 um 16:55 schrieb Thomas Lamprecht: > Am 15/04/2024 um 14:48 schrieb Fiona Ebner: >> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm >> index 22a9729..5f49830 100644 >> --- a/src/PVE/Storage/Plugin.pm >> +++ b/src/PVE/Storage/Plugin.pm >> @@ -205,6 +205,14 @@ my $defau

Re: [pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin

2024-04-17 Thread Thomas Lamprecht
Am 15/04/2024 um 14:48 schrieb Fiona Ebner: > Commit 7020491 ("esxi: add 'port' config parameter") started using > the 'port' option in a second plugin, but the definition stayed in the > PBS plugin. Avoid the hidden dependency and move the definition to the > base plugin instead. > > It is necess

[pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin

2024-04-15 Thread Fiona Ebner
Commit 7020491 ("esxi: add 'port' config parameter") started using the 'port' option in a second plugin, but the definition stayed in the PBS plugin. Avoid the hidden dependency and move the definition to the base plugin instead. It is necessary to mark it as optional or it would be required alway