[pve-devel] [PATCH v2 manager] ui: lxc: add edit window for device passthrough

2023-11-21 Thread Filip Schauer
Signed-off-by: Filip Schauer --- Changes since v1: * Remove usb mapping * Add mode, uid and gid fields To get this to build on top of the current master cd731902b7a7, comment out the call to $notification_config->add_matcher in PVE/VZDump.pm for now. www/manager6/Makefile | 1 + www/

Re: [pve-devel] [PATCH v2 manager] ui: lxc: add edit window for device passthrough

2024-01-26 Thread Fiona Ebner
Am 21.11.23 um 11:21 schrieb Filip Schauer: > Signed-off-by: Filip Schauer High-level comment: - would be nice to have the default values as emptyText for UID/GID/Acces Mode and maybe also have an example text /dev/XYZ for the path - if I add /dev/doesnotexist I'll get an error but it'll still be

Re: [pve-devel] [PATCH v2 manager] ui: lxc: add edit window for device passthrough

2024-01-29 Thread Filip Schauer
This is a bug in pve-container. I sent a patch for it: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061513.html On 26/01/2024 16:23, Fiona Ebner wrote: - if I add /dev/doesnotexist I'll get an error but it'll still be added to the configuration

Re: [pve-devel] [PATCH v2 manager] ui: lxc: add edit window for device passthrough

2024-01-31 Thread Filip Schauer
On 26/01/2024 16:23, Fiona Ebner wrote: I might be missing something, but isn't this a normal ExtJS text field? Does this cbind have any actual consequences? Same for the others. This cbind is indeed not needed here. A patch v3 that incorporates your feedback is available: https://lists.proxm