Re: [pve-devel] [PATCH widget-toolkit] fix: gui: up/down arrow keys increment/decrement twice in Number field

2022-07-13 Thread Dominik Csapak
man, extjs overrides are weird. i was convinced that even the onRender gets 'overridden' and not simply called from a subclass? anyway in that case the fix looks ok, but i think we can even go further. since the original code will evidently be called, how about we remove the original 'onMouseWh

[pve-devel] [PATCH widget-toolkit] fix: gui: up/down arrow keys increment/decrement twice in Number field

2022-07-07 Thread Daniel Tschlatscher
When the up or down arrow key on the keyboard was pressed while a number text field (or any one descending from Ext.form.field.Spinner) was selected, the up and down callbacks for that text fields KeyNav were called twice. Therefore, the value in the text field would always incorrectly increment/de