Note that this does not only allow partitions to be used, but for DB and WAL disks, one more type of disk, that wasn't allowed before. Namely, GPT-partitioned disks with any partitions detected as used. The reason is get_disks' behavior: * Without $include_partitions=1, the disk will have the same usage as it's first used partition, and thus wasn't allowed. (Except in the case that usage was LVM, where the check was bypassed, but luckily OSD creation just failed later because no Ceph volume group would be detected). * With $include_partitions=1, the disk will have usage 'partitions' and thus be allowed.
Signed-off-by: Fabian Ebner <f.eb...@proxmox.com> --- RFC, because of the weird situation with the DB/WAL disks... Dependency bump for pve-storage is needed to actually make it work, because previously it wasn't supported to pass along partitions as elements of the first argument. PVE/API2/Ceph/OSD.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index 028b37d0..c511f315 100644 --- a/PVE/API2/Ceph/OSD.pm +++ b/PVE/API2/Ceph/OSD.pm @@ -346,7 +346,7 @@ __PACKAGE__->register_method ({ # test disk requirements early my $devlist = [ map { $_->{name} } values %$devs ]; - my $disklist = PVE::Diskmanage::get_disks($devlist, 1); + my $disklist = PVE::Diskmanage::get_disks($devlist, 1, 1); $test_disk_requirements->($disklist); # get necessary ceph infos @@ -451,7 +451,7 @@ __PACKAGE__->register_method ({ PVE::Diskmanage::locked_disk_action(sub { # update disklist and re-test requirements - $disklist = PVE::Diskmanage::get_disks($devlist, 1); + $disklist = PVE::Diskmanage::get_disks($devlist, 1, 1); $test_disk_requirements->($disklist); my $dev_class = $param->{'crush-device-class'}; -- 2.30.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel