Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > if the preparing of pci devices or the start of the vm fails, we need > to cleanup the pci devices (reservations *and* mdevs), or else > it might happen that there are leftovers which must be manually removed. > > to include also mdevs now, refactor the cleanup code from 'vm_stop_cleanup' > into it's own function, and call that instead of only 'remove_pci_reservation' > > also simplifies the code, such that it now removes all pci ids reserved > for that vmid, since we cannot have multiple vms with the same vmid > anyway > > Signed-off-by: Dominik Csapak <d.csa...@proxmox.com> > --- > PVE/QemuServer.pm | 34 ++++++++++++++++++---------------- > PVE/QemuServer/PCI.pm | 12 +++++++----- > 2 files changed, 25 insertions(+), 21 deletions(-) > >
I find it almost a bit odd though that we bothered to use a set of $dropped_ids in the first place anyhow, applied thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
