Re: [pve-devel] pve-storage : retrieve parent of a clone

2012-11-21 Thread Dietmar Maurer
applied, thanks. > -Original Message- > From: pve-devel-boun...@pve.proxmox.com [mailto:pve-devel- > boun...@pve.proxmox.com] On Behalf Of Alexandre Derumier > Sent: Mittwoch, 21. November 2012 18:12 > To: pve-devel@pve.proxmox.com > Subject: [pve-devel] pve-storage : retrieve parent of a

Re: [pve-devel] [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Peter Maydell
On 21 November 2012 17:03, Stefan Weil wrote: > Why do you use int64_t instead of off_t? > If the value is related to file sizes, off_t would be a good choice. Looking at the librbd API (which is what the size and ret values come from), it uses size_t and ssize_t for these. So I think probably ss

Re: [pve-devel] [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Priebe - Profihost AG
Not sure about off_t. What is min and max size? Stefan Am 21.11.2012 um 18:03 schrieb Stefan Weil : > Am 20.11.2012 13:44, schrieb Stefan Priebe: >> rbd / rados tends to return pretty often length of writes >> or discarded blocks. These values might be bigger than int. >> >> Signed-off-by: Stef

Re: [pve-devel] [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Weil
Am 20.11.2012 13:44, schrieb Stefan Priebe: rbd / rados tends to return pretty often length of writes or discarded blocks. These values might be bigger than int. Signed-off-by: Stefan Priebe --- block/rbd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/rbd.

[pve-devel] [PATCH 2/4] nexenta: retrieve parent of a clone

2012-11-21 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Storage/NexentaPlugin.pm | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/NexentaPlugin.pm b/PVE/Storage/NexentaPlugin.pm index a5b6fe2..386656f 100644 --- a/PVE/Storage/NexentaPlugin.pm +++ b/PVE/Storage/Nex

[pve-devel] [PATCH 3/4] rbd: retrieve parent of a clone

2012-11-21 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Storage/RBDPlugin.pm | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index cb7a823..60bd4e8 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@

[pve-devel] [PATCH 4/4] sheepdog : retrieve parent of a clone

2012-11-21 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Storage/SheepdogPlugin.pm | 40 +++- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/PVE/Storage/SheepdogPlugin.pm b/PVE/Storage/SheepdogPlugin.pm index 5aff893..3e5839e 100644 --- a/PVE/Storage/Sheepd

[pve-devel] [PATCH 1/4] files: retrieve parent of a clone

2012-11-21 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Storage/Plugin.pm |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 800639c..c7c17e1 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -458,6 +458,7 @@ sub

[pve-devel] pve-storage : retrieve parent of a clone

2012-11-21 Thread Alexandre Derumier
These patches retrieve parent volume name of a clone in list_images. It'll be usefull when we'll implemente clone feature. So we don't need to track parent->child relation in vm config files. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://p

Re: [pve-devel] qcow2 options

2012-11-21 Thread Alexandre DERUMIER
AFAIK, it's improving performance in writethrough mode. (But we need to make a kind of fsck on qcow2 file if something goes wrong) Don't have tested it yet. - Mail original - De: "Dietmar Maurer" À: pve-devel@pve.proxmox.com Envoyé: Mercredi 21 Novembre 2012 14:36:21 Objet: [pve

[pve-devel] qcow2 options

2012-11-21 Thread Dietmar Maurer
Should we use lazy refcounts? Somebody already tested that? https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg02168.html ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] updates for qemu 1.3

2012-11-21 Thread Alexandre DERUMIER
>>Any idea what we should do with this patch: >> >>update-cpus-x86_64.conf-to-rhel6.2-version.patch Put it to trash ? ;) cpudef are now defined in qemu code (no more external cpudef file). Good values are now in qemu, I have seen a lot a corrections for redhat devel pushed upstream. now, for

[pve-devel] backup patches

2012-11-21 Thread Dietmar Maurer
I just posted the backup patches to the qemu-devel list. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] updates for qemu 1.3

2012-11-21 Thread Dietmar Maurer
Any idea what we should do with this patch: update-cpus-x86_64.conf-to-rhel6.2-version.patch ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 09:49, schrieb Dietmar Maurer: mhm correct. But only -qmp without a parameter does not work. And i haven't found another useful parameter. With -qmp stdio it just works fine. So this was more a try and error ;-) We already use qmp - so what is wrong with the current code? I had

Re: [pve-devel] [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 09:33:08AM +0100, Stefan Priebe - Profihost AG wrote: > Am 21.11.2012 09:26, schrieb Stefan Hajnoczi: > >On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: > >>Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: > >QEMU is currently in hard freeze and on

Re: [pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Alexandre DERUMIER
>>But only -qmp without a parameter does not work That's strange, I can use monitor in proxmox gui without -qmp stdio ... - Mail original - De: "Stefan Priebe - Profihost AG" À: "Dietmar Maurer" Cc: pve-devel@pve.proxmox.com Envoyé: Mercredi 21 Novembre 2012 09:43:12 Objet: Re: [p

Re: [pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Dietmar Maurer
> mhm correct. But only -qmp without a parameter does not work. And i > haven't found another useful parameter. With -qmp stdio it just works fine. > So this was more a try and error ;-) We already use qmp - so what is wrong with the current code? ___ p

Re: [pve-devel] qemu 1.3 vs qemu-kvm 1.3 differences ?

2012-11-21 Thread Stefan Priebe - Profihost AG
Hi Alexandre, thanks for forwarding this. So pve HAS to switch to qemu and we can looking forward to backport and fix all stuff. Stefan Am 21.11.2012 09:42, schrieb Alexandre DERUMIER: De: "Jan Kiszka" À: "Alexandre DERUMIER" Cc: "qemu-devel" Envoyé: Mercredi 21 Novembre 2012 09:28:20 Ob

Re: [pve-devel] qemu 1.3 vs qemu-kvm 1.3 differences ?

2012-11-21 Thread Alexandre DERUMIER
De: "Jan Kiszka" À: "Alexandre DERUMIER" Cc: "qemu-devel" Envoyé: Mercredi 21 Novembre 2012 09:28:20 Objet: Re: qemu 1.3 vs qemu-kvm 1.3 differences ? On 2012-11-20 15:37, Alexandre DERUMIER wrote: > Hi List, > > I would like to known what are the remaining differences between qemu 1.3

Re: [pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 09:40, schrieb Dietmar Maurer: Am 21.11.2012 09:15, schrieb Dietmar Maurer: +push @$cmd, '-qmp', "stdio"; + What is this? http://wiki.qemu.org/QMP Without this the monitor does not work at all and -monitor stdio is only a read only monitor where you can't change settings.

Re: [pve-devel] [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: > Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: > >On Tue, Nov 20, 2012 at 8:16 PM, Stefan Priebe wrote: > >>Hi Stefan, > >> > >>Am 20.11.2012 17:29, schrieb Stefan Hajnoczi: > >> > >>>On Tue, Nov 20, 2012 at 01:44:55PM

Re: [pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Dietmar Maurer
> Am 21.11.2012 09:15, schrieb Dietmar Maurer: > >> +push @$cmd, '-qmp', "stdio"; > >> + > > > > What is this? > > http://wiki.qemu.org/QMP > > Without this the monitor does not work at all and -monitor stdio is only a > read only monitor where you can't change settings. But stdio is redirec

Re: [pve-devel] [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-21 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 09:26, schrieb Stefan Hajnoczi: On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: We're going in circles here. I know the types are wrong in the code and your patch fixes it, that's why I said it looks good

Re: [pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 09:15, schrieb Dietmar Maurer: +push @$cmd, '-qmp', "stdio"; + What is this? http://wiki.qemu.org/QMP Without this the monitor does not work at all and -monitor stdio is only a read only monitor where you can't change settings. Stefan ___

Re: [pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Dietmar Maurer
> +push @$cmd, '-qmp', "stdio"; > + What is this? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] qemu.git / 1.3

2012-11-21 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 08:58, schrieb Dietmar Maurer: For qemu.git we need some more patches i've already done: 1.) version kvm_user_version parsing does not work for qemu.git as they have a , in their version output. 2.) we need to change the start commands for kvm and add: -enable-kvm -qmp stdio Shoul

[pve-devel] [PATCH 2/2] add enable-kvm and qmp stdio to kvm cmd for qemu.git 1.3

2012-11-21 Thread Stefan Priebe
--- PVE/QemuServer.pm |4 1 file changed, 4 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 7a11e82..7d4a1a1 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2155,6 +2155,10 @@ sub config_to_command { push @$cmd, '-daemonize'; +push @$cmd, '-

[pve-devel] [PATCH 1/2] make kvm user version detection compatible to qemu

2012-11-21 Thread Stefan Priebe
--- PVE/QemuServer.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b67d259..7a11e82 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -648,7 +648,7 @@ sub kvm_user_version { my $tmp = `kvm -help 2>/dev/null`; -