[pve-devel] [PATCH] add noVNC_resize

2015-06-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/NoVncIndex.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/NoVncIndex.pm b/PVE/NoVncIndex.pm index b028680..bceab52 100644 --- a/PVE/NoVncIndex.pm +++ b/PVE/NoVncIndex.pm @@ -128,6 +128,7 @@ INCLUDE_URI='/novnc/include/'; Path

Re: [pve-devel] novnc : local resize v2

2015-06-24 Thread Alexandre DERUMIER
I have uploaded a clean rebase (mail is blocked because too big 100k) - Mail original - De: "aderumier" À: "dietmar" Cc: "pve-devel" Envoyé: Mercredi 24 Juin 2015 06:11:57 Objet: Re: [pve-devel] novnc : local resize v2 >>Yes, that would be great. I'll try tomorrow - Mail orig

[pve-devel] [PATCH] novnc: update to 0.5.1 (commit 205d1a11ce71744f1e95c6849f9652b65487a652)

2015-06-24 Thread Alexandre Derumier
full rebased on this commit (windows resize scaling) https://github.com/kanaka/noVNC/commit/205d1a11ce71744f1e95c6849f9652b65487a652 Signed-off-by: Alexandre Derumier --- Makefile |2 +- debian/patches/series |1 - debian/rules |4 +- pveui.js | 317

[pve-devel] [PATCH] firewall_module_duplicate

2015-06-24 Thread Alen Grizonic
removed duplicated line of Data::Dumper use Signed-off-by: Alen Grizonic --- src/PVE/Firewall.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index f0c105e..0049403 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -113,8 +113,6 @@ ev

[pve-devel] [PATCH 07/16] write_etc_network_interfaces: updated header comment

2015-06-24 Thread Wolfgang Bumiller
The header now mentions that the file is auto-generated and should not be tempered with directly. It now recommends to add custom network configurations via source/source-directory lines. --- src/PVE/INotify.pm | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/

[pve-devel] [PATCH 04/16] read_etc_network_interfaces: improved parsing

2015-06-24 Thread Wolfgang Bumiller
* parsing ipv6 blocks * parsing extra lines like source/source-directory/... The returned config hash is not just the interface hash anymore. Interfaces are now in its 'ifaces' member hash. All unknown options (including mappings) end up in its 'options' hash. Added a comment describing the confi

[pve-devel] [PATCH 12/16] /etc/network/interfaces: deal with OVS allow- lines

2015-06-24 Thread Wolfgang Bumiller
* __read_etc_interfaces: Delete OVS ports from "allow-$OVS_BRIDGE" option lines in order to prevent them from being duplicated or kept after removing the port from the bridge. * __write_etc_interfaces: Deleting unused OVSPorts has the side effect of them not being written out at all. If, however,

[pve-devel] [PATCH 10/16] write_etc_interfaces: fix: don't write ref of options6

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 846eb2f..57d7e6f 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -773,7 +773,7 @@ my $extract_ovs_option = sub { # , # like bridge_ports,

[pve-devel] [PATCH 15/16] write_network_interfaces: improved sorting

2015-06-24 Thread Wolfgang Bumiller
This way option line positions between interfaces can be preserved. --- src/PVE/INotify.pm | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 8b89488..be69510 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.p

[pve-devel] [PATCH 14/16] PVE::INotify::write_network_interfaces: readability

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 13c55bc..8b89488 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -1309,12 +1309,10 @@ NETWORKDOC return $p1 <=> $p2 if $p1 != $p2;

[pve-devel] [PATCH 05/16] merge bridge_port declarations

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 5bae210..4dde7b0 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -854,7 +854,11 @@ sub read_etc_network_interfaces {

[pve-devel] [PATCH 08/16] PVE::INotify: testable interface parser

2015-06-24 Thread Wolfgang Bumiller
read_etc_network_interfaces now opens all /proc files and passes them as filehandles to the actual implementation which is now is __read_etc_network_interfaces. Similarly write_etc_network_interfaces now prints the content string returned by the implementation now named __write_etc_network_interfa

[pve-devel] [PATCH 16/16] tests: list/create/update network interfaces

2015-06-24 Thread Wolfgang Bumiller
--- test/etc_network_interfaces/brbase | 26 + test/etc_network_interfaces/t.create_network.pl | 91 ++ test/etc_network_interfaces/t.list-interfaces.pl | 109 + test/etc_network_interfaces/t.update_network.pl | 116 +++

[pve-devel] [PATCH 03/16] removed write-only $gateway variable

2015-06-24 Thread Wolfgang Bumiller
--- src/PVE/INotify.pm | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 351e325..077975b 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -764,8 +764,6 @@ sub read_etc_network_interfaces { # we try to keep order

[pve-devel] [PATCH 13/16] importing etc_network_interfaces tests

2015-06-24 Thread Wolfgang Bumiller
--- Makefile | 3 + test/Makefile | 12 ++ test/etc_network_interfaces/Makefile | 7 + test/etc_network_interfaces/base | 16 ++ test/etc_network_interfaces/loopback |

[pve-devel] [PATCH 06/16] write_etc_network_interfaces: write options only once

2015-06-24 Thread Wolfgang Bumiller
Options such as bridge ports or ovs_* will now be written out only for the first interface. If multiple protocol families of a bridge contain bridge_ports lines they will be merged into the first interface. --- src/PVE/INotify.pm | 51 --- 1 file cha

[pve-devel] [PATCH 00/16] [common] network interfaces internal API change

2015-06-24 Thread Wolfgang Bumiller
Changes since the [RFC PATCH]: * network parsing tests added (+ 'make check' target) * read/write_etc_network_interfaces implementation separated from file load/saving. Logic is now in functions named __read/write_etc_network_interfaces in order to be able to test them directly from the

[pve-devel] [PATCH 09/16] write_network_interfaces: better newline consistency

2015-06-24 Thread Wolfgang Bumiller
Don't write extra newlines between sections where no options are printed when options exist. --- src/PVE/INotify.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 3277fae..846eb2f 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE

[pve-devel] [PATCH 02/16] read_etc_network_interfaces: less strict parsing

2015-06-24 Thread Wolfgang Bumiller
*) Don't require indented lines, instead know when to end a section. *) Don't require empty lines between sections. And turned (.*)\s* into just (.*) as .* eats the whitespace too. --- src/PVE/INotify.pm | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git

[pve-devel] [PATCH 11/16] read_etc_interfaces: missing iface initialization

2015-06-24 Thread Wolfgang Bumiller
If no 'auto' line was read the interface hash has to be initialized. --- src/PVE/INotify.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index 57d7e6f..0675538 100644 --- a/src/PVE/INotify.pm +++ b/src/PVE/INotify.pm @@ -827,7 +827,7 @

[pve-devel] [PATCH 01/16] JSONSchema: ipv6prefix and ipsubnet

2015-06-24 Thread Wolfgang Bumiller
ipv6prefix matches an ipv6 prefix length (0..128) ipsubnet matches an ipv4mask or an ipv6prefix --- src/PVE/JSONSchema.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 36a2de9..8fa5651 100644 --- a/src/PVE/JSONSchema

[pve-devel] [PATCH 0/3] [manager] network interfaces internal API change

2015-06-24 Thread Wolfgang Bumiller
Changes since the [RFC PATCH]: * made network UI consistent: IPv6 addresses now show up in the same column as IPv4 addresses the same way they do in the LXC configuration. * renamed ipv6 subnet length to ipv6 prefix length Wolfgang Bumiller (3): PVE::API2::Ceph: network_interfaces update +

[pve-devel] [PATCH 1/3] PVE::API2::Ceph: network_interfaces update + ipv6

2015-06-24 Thread Wolfgang Bumiller
--- PVE/API2/Ceph.pm | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 217b8ce..b7eea84 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -765,16 +765,18 @@ __PACKAGE__->register_method ({ my $find_node_ip = sub {

[pve-devel] [PATCH 2/3] PVE::API2::Network: network_interfaces update + ipv6

2015-06-24 Thread Wolfgang Bumiller
--- PVE/API2/Network.pm | 142 ++-- 1 file changed, 116 insertions(+), 26 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index dedf9e6..83e203f 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -45,6 +45,11 @@ my $co

[pve-devel] [PATCH 3/3] www/network: ipv6 related columns and edit fields

2015-06-24 Thread Wolfgang Bumiller
IPv6 address shown in cidr notation in the IP address column, the subnet column only includes the ipv4 subnet mask, the gateway includes both. --- www/manager/Toolkit.js | 6 ++ www/manager/Utils.js| 1 + www/manager/node/NetworkEdit.js | 39 +

[pve-devel] novnc - bump to 0.5.1 master branch

2015-06-24 Thread Alexandre Derumier
Hi, I finally got novnc working on very last master commit. I have make a patch to create the pveui.js from include/ui.js, I'll be easy to upgrade now with new novnc releases This patch apply on top of current pve-novnc git and novnc last master commit _

[pve-devel] novnc-pve : bump to 0.5.1 master branch

2015-06-24 Thread Alexandre Derumier
Hi, I finally get it working with very last novnc master commit. I have make a patch to create pveui.js from include/ui.js, so it'll be easy to update with next novnc releases. This patch apply on current proxmox novnc master git, and current novnc master git ___

[pve-devel] [PATCH] bump to 0.5.1 master branch

2015-06-24 Thread Alexandre Derumier
generate pveui.js from include/ui.js with a patch Signed-off-by: Alexandre Derumier --- Makefile |3 +- debian/patches/pveui.patch | 836 +++ debian/patches/series |2 +- debian/rules |7 - pveui.js | 1620 --

[pve-devel] [PATCH 1/2] add veth_create

2015-06-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network.pm | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index 00639f6..a0f658b 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -142,27 +142,3

[pve-devel] [PATCH 1/3] add net hot-unplug

2015-06-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/LXC.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 2ddee60..5acb3c2 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -13,6 +13,7 @@ use PVE::SafeSyslog; use PVE::INotify; us

[pve-devel] lxc network hotplug

2015-06-24 Thread Alexandre Derumier
Hi, theses patches (pve-common, pve-containers) add hotplug|unplug network to lxc. ip configuration patch need improvement (see commit) ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 3/3] add hotplug ip configuration

2015-06-24 Thread Alexandre Derumier
fixme: -ip removal -ipv6 support -permanent guest file write config ? Signed-off-by: Alexandre Derumier --- src/PVE/LXC.pm | 20 1 file changed, 20 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 8d24adb..c40b09c 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/L

[pve-devel] [PATCH 2/2] add veth_delete

2015-06-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/Network.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index a0f658b..23206c1 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -161,6 +161,14 @@ sub veth_create {

[pve-devel] [PATCH 2/3] add net hotplug

2015-06-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- src/PVE/LXC.pm | 73 +++--- 1 file changed, 70 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 5acb3c2..8d24adb 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -803,7 +8

Re: [pve-devel] [PATCH] bump to 0.5.1 master branch

2015-06-24 Thread Dietmar Maurer
That does not work for me, because I get an runtime error inside pveui.js: getSetting: function(name) { var ctrl = $D('noVNC_' + name); var val = WebUtil.readSetting(name); if (typeof val !== 'undefined' && val !== null && ctrl.type === 'checkbox') { see

Re: [pve-devel] [PATCH] bump to 0.5.1 master branch

2015-06-24 Thread Dietmar Maurer
> That does not work for me, because I get an runtime error inside pveui.js: > >getSetting: function(name) { > var ctrl = $D('noVNC_' + name); > var val = WebUtil.readSetting(name); > if (typeof val !== 'undefined' && val !== null && ctrl.type === > 'che

Re: [pve-devel] [PATCH] bump to 0.5.1 master branch

2015-06-24 Thread Dietmar Maurer
> > That does not work for me, because I get an runtime error inside pveui.js: > > > >getSetting: function(name) { > > var ctrl = $D('noVNC_' + name); > > var val = WebUtil.readSetting(name); > > if (typeof val !== 'undefined' && val !== null && ctrl.typ

Re: [pve-devel] [PATCH] bump to 0.5.1 master branch

2015-06-24 Thread Alexandre DERUMIER
>>After more testing, I also get the same error on master branch?? you need my another patch on vncindex.pm which define "resize" - Mail original - De: "dietmar" À: "aderumier" , "pve-devel" Envoyé: Jeudi 25 Juin 2015 08:25:57 Objet: Re: [pve-devel] [PATCH] bump to 0.5.1 master bra

[pve-devel] [PATCH] add noVNC_resize

2015-06-24 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/NoVncIndex.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/NoVncIndex.pm b/PVE/NoVncIndex.pm index b028680..bceab52 100644 --- a/PVE/NoVncIndex.pm +++ b/PVE/NoVncIndex.pm @@ -128,6 +128,7 @@ INCLUDE_URI='/novnc/include/'; Path

Re: [pve-devel] [PATCH] bump to 0.5.1 master branch

2015-06-24 Thread Alexandre DERUMIER
>>you need my another patch on vncindex.pm which define "resize" I have resent it in case if it was lost; - Mail original - De: "aderumier" À: "dietmar" Cc: "pve-devel" Envoyé: Jeudi 25 Juin 2015 08:44:27 Objet: Re: [pve-devel] [PATCH] bump to 0.5.1 master branch >>After more testin