Re: [pve-devel] firewall remove config file

2015-08-26 Thread Stefan Priebe - Profihost AG
Am 26.08.2015 um 09:01 schrieb Alen Grizonic: Hi Stefan. The remove function was applied to PVE 4. Yes but it's fix also needed for 3.4. Stefan On 08/26/2015 08:58 AM, Stefan Priebe - Profihost AG wrote: Hi, the firewall config isn't removed in PVE 3.4 at VM delete. Not sure if

Re: [pve-devel] firewall remove config file

2015-08-26 Thread Alen Grizonic
Hi Stefan. The remove function was applied to PVE 4. On 08/26/2015 08:58 AM, Stefan Priebe - Profihost AG wrote: Hi, the firewall config isn't removed in PVE 3.4 at VM delete. Not sure if this one is enough:

[pve-devel] firewall remove config file

2015-08-26 Thread Stefan Priebe - Profihost AG
Hi, the firewall config isn't removed in PVE 3.4 at VM delete. Not sure if this one is enough: https://git.proxmox.com/?p=pve-firewall.git;a=commit;h=edee90358fe82c7c3d91221c4a7944cdfc68f181 As i don't see the code where it is called. -- Stefan ___

Re: [pve-devel] pve-container : mountpoint : add support to pass directory path

2015-08-26 Thread Alexandre DERUMIER
any comment for this patches serie ? - Mail original - De: aderumier aderum...@odiso.com À: pve-devel pve-devel@pve.proxmox.com Envoyé: Lundi 24 Août 2015 10:13:17 Objet: [pve-devel] pve-container : mountpoint : add support to pass directory path This allow to pass a directory path

Re: [pve-devel] pve-container : mountpoint : add support to pass directory path

2015-08-26 Thread Dietmar Maurer
any comment for this patches serie ? I need more time (sorry) ... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] firewall remove config file

2015-08-26 Thread Alen Grizonic
Hi Stefan. Since we are adding a lot of new functionality and covering numerous older bugs like this in the new version, we were not planning to backport them in this very moment. On 08/26/2015 09:01 AM, Stefan Priebe - Profihost AG wrote: Am 26.08.2015 um 09:01 schrieb Alen Grizonic: Hi

[pve-devel] [PATCH v3 pve-common 1/2] Tools::run_with_timeout improvement + hires alarm

2015-08-26 Thread Wolfgang Bumiller
The following situations could lead to the 'unknown error': 1) As commented, when the alarm triggered after the first signal handler was installed and before the new alarm was installed. In this case the $signalcount was increased, and worse: the original signal handler was never called. 2) When

[pve-devel] [PATCH v3 pve-common 0/2] run_with_timeout and tcp_ping

2015-08-26 Thread Wolfgang Bumiller
A few more changes to tcp_ping: After checking perl's Net::Ping implementation I realized that Ping-port_number always overwrites Ping-service_check. Basically tcp-pinging without a port pings to the echo port and assumes that ECONNREFUSED means the machine is reachable, while setting a port

[pve-devel] [PATCH v3 pve-common 2/2] Added PVE::Network::tcp_ping to replace Net::Ping

2015-08-26 Thread Wolfgang Bumiller
We use Net::Ping twice in pve-storage (once for ISCSIPlugin and once in GlusterfsPlugin, both with the 'tcp' variant.), but Net::Ping doesn't support IPv6. --- src/PVE/Network.pm | 29 + 1 file changed, 29 insertions(+) diff --git a/src/PVE/Network.pm

Re: [pve-devel] [PATCH v3 pve-common 2/2] Added PVE::Network::tcp_ping to replace Net::Ping

2015-08-26 Thread Wolfgang Bumiller
Naturally, after copying from my temporary test.pl file I had to forget to include the +use POSIX qw(ECONNREFUSED); sorry about that... -_- On August 26, 2015 at 10:38 AM Wolfgang Bumiller w.bumil...@proxmox.com wrote: We use Net::Ping twice in pve-storage (once for ISCSIPlugin and once

Re: [pve-devel] pve-container : mountpoint : add support to pass directory path

2015-08-26 Thread Alexandre DERUMIER
I need more time (sorry) ... Ok, no problem, I just want to be sure that it was not lost in the flood of recents emails :) - Mail original - De: dietmar diet...@proxmox.com À: aderumier aderum...@odiso.com, pve-devel pve-devel@pve.proxmox.com Envoyé: Mercredi 26 Août 2015 10:53:16

Re: [pve-devel] [PATCH pve-container] allow to load configs from CTs located on other nodes

2015-08-26 Thread Dietmar Maurer
On 08/26/2015 03:54 PM, Thomas Lamprecht wrote: On 08/26/2015 03:36 PM, Thomas Lamprecht wrote: sub load_config { -my ($vmid) = @_; +my ($vmid, $node) = @_; -my $cfspath = cfs_config_path($vmid); +$node = $nodename if !$node; +my $cfspath = cfs_config_path($vmid,

Re: [pve-devel] [PATCH 5/5] make create_rootfs sub generic

2015-08-26 Thread Dietmar Maurer
On 08/21/2015 05:10 PM, Alexandre Derumier wrote: Signed-off-by: Alexandre Derumier aderum...@odiso.com --- src/PVE/LXC/Create.pm | 131 +++--- 1 file changed, 29 insertions(+), 102 deletions(-) @@ -279,30 +199,37 @@ sub create_rootfs {

Re: [pve-devel] novnc update

2015-08-26 Thread Dietmar Maurer
Why do we add the button if it does not work (confused)? On 08/25/2015 06:59 AM, Alexandre Derumier wrote: Currently in proxmox, the fullscreen button don't work in embedded console. For the popup console, it should work, but because of current proxmox resize windows code, it's not working

Re: [pve-devel] [PATCH pve-container] Correct package name in sub update_ipconfig()

2015-08-26 Thread Dietmar Maurer
applied, thanks! On 08/26/2015 04:12 PM, Emmanuel Kasper wrote: --- src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 5e21df6..e59a4ce 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1381,7 +1381,7 @@ sub hotplug_net

Re: [pve-devel] [PATCH pve-container] Add handling for arch and ostype options in update_pct_config()

2015-08-26 Thread Emmanuel Kasper
On 08/26/2015 03:30 PM, Dietmar Maurer wrote: Both values are auto-detected, so we should consider them read-only for now. I guess there is another way to solve the problem (do not call update_pct_config with those options)? OK I will try to look at that (do not call update_pct_config with

Re: [pve-devel] [PATCH pve-container] Add handling for arch and ostype options in update_pct_config()

2015-08-26 Thread Dietmar Maurer
Both values are auto-detected, so we should consider them read-only for now. I guess there is another way to solve the problem (do not call update_pct_config with those options)? On August 25, 2015 at 2:55 PM Emmanuel Kasper e.kas...@proxmox.com wrote: Without this patch, restoring a vzdump

[pve-devel] [PATCH pve-container] Correct package name in sub update_ipconfig()

2015-08-26 Thread Emmanuel Kasper
--- src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 5e21df6..e59a4ce 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1381,7 +1381,7 @@ sub hotplug_net { sub update_ipconfig { my ($vmid, $conf, $opt, $eth, $newnet,

[pve-devel] [PATCH pve-container] allow to load configs from CTs located on other nodes

2015-08-26 Thread Thomas Lamprecht
This allows load_config to load also configs from LXC container which arent't located on the same node. This is needed to fix the bug that doesn't let view the noVNC console from an CT located on another node, whereas viewing it on the same node as the container is located works fine.

Re: [pve-devel] [PATCH pve-container] allow to load configs from CTs located on other nodes

2015-08-26 Thread Thomas Lamprecht
On 08/26/2015 03:36 PM, Thomas Lamprecht wrote: This allows load_config to load also configs from LXC container which arent't located on the same node. This is needed to fix the bug that doesn't let view the noVNC console from an CT located on another node, whereas viewing it on the same node

Re: [pve-devel] pve-container : mountpoint : add support to pass directory path

2015-08-26 Thread Dietmar Maurer
applied, thanks! On 08/24/2015 10:13 AM, Alexandre Derumier wrote: This allow to pass a directory path to mountpoint. Can be use to share directories of a host nfs mount, as requested on the forum: http://forum.proxmox.com/threads/23370-NFS-Mount-in-LXC-v4-0-beta

Re: [pve-devel] [PATCH] Add possibillity to distinguish container and vm on RBD Storage.

2015-08-26 Thread Dietmar Maurer
applied On 08/25/2015 09:47 AM, Wolfgang Link wrote: this is necessary because we use image files for both. --- www/manager/lxc/CreateWizard.js | 2 +- www/manager/storage/RBDEdit.js | 14 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git

Re: [pve-devel] novnc update

2015-08-26 Thread Alexandre DERUMIER
Why do we add the button if it does not work (confused)? I've got it working in embedded console now. (see my other patch for pve-manager). For popup console, i'm still working on it. (It's going fullscreen, but proxmox windows resize code shrink them just after. I'm trying to disable proxmox

Re: [pve-devel] [PATCH 5/5] make create_rootfs sub generic

2015-08-26 Thread Alexandre DERUMIER
I wonder if that unmount everything (mountpoints below /)? Currently not, because anyway, I'm still only manage rootfs. (I'm waiting to have this patch serie commited before continue) But I'm looking to mount/unmount all mountpoints before/after restore_and_configure; - Mail original