Re: [pve-devel] Snapshot questions

2015-09-07 Thread Dietmar Maurer
> On September 7, 2015 at 10:58 AM Philipp Marek > wrote: > > > > > > Above container management toolkit 'pct' already supports drbd, and it > > > > would > > > > be really cool to have snapshots, so that we can make snapshot and > > > > snapshot backups ;-) > > >

Re: [pve-devel] Snapshot questions

2015-09-07 Thread Philipp Marek
> > > Above container management toolkit 'pct' already supports drbd, and it > > > would > > > be really cool to have snapshots, so that we can make snapshot and > > > snapshot backups ;-) > > The same should be easily possible for KVM, too. > > Yes, but we do not need that for KVM backup

[pve-devel] [PATCH pve-manager] Fix package path to startup and shutdown subroutines

2015-09-07 Thread Emmanuel Kasper
--- PVE/API2/Nodes.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 268ae01..1528fc6 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1240,7 +1240,7 @@ __PACKAGE__->register_method ({ if

Re: [pve-devel] Snapshot questions

2015-09-07 Thread Philipp Marek
Hi Dietmar, thanks for the answer. > > *) The first question is - how would these get called? "pvesm" shows no > > matching arguments, and the GUI has no "snapshot" buttons either. > I guess it is best to test that with Qemu VMs. You can use the GUI ... > There is currently no snapshot support

Re: [pve-devel] Snapshot questions

2015-09-07 Thread Dietmar Maurer
> > we > > want to use it with LXC containers: > > > > https://git.proxmox.com/?p=pve-container.git;a=summary > > > > Above container management toolkit 'pct' already supports drbd, and it would > > be really cool to have snapshots, so that we can make snapshot and > > snapshot backups ;-) >

[pve-devel] [RFC pve-container 1/4] get rid of most of the loop-devices code

2015-09-07 Thread Wolfgang Bumiller
-) loop devices are now attached in mountpoint_mount, and immediately detached in order to set the auto-clear flag Keeping track of loop-devices is otherweise next to impossible and a security concern. We mount the filesystems for the container. We do not support full loop device access for

[pve-devel] [RFC pve-container 4/4] vzdump: refactor LXC backup

2015-09-07 Thread Wolfgang Bumiller
*) Use the new Tools::command_pipe instead of building a shell command string. *) Ditch 'find' and utilize the --one-file-system switch instead. *) Added mountpoint handling *) Added support for 'backup=yes|no' on mountpoints *) sanitizing mountpoint paths --- src/PVE/VZDump/LXC.pm | 195

[pve-devel] [RFC pve-container 3/4] support resizing of owned container disks

2015-09-07 Thread Wolfgang Bumiller
--- src/PVE/API2/LXC/Config.pm | 159 + src/PVE/CLI/pct.pm | 2 + 2 files changed, 161 insertions(+) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index 95eafaa..476e07c 100644 --- a/src/PVE/API2/LXC/Config.pm +++

[pve-devel] [RFC pve-container 2/4] do not allow full access to loop devices via cgroups

2015-09-07 Thread Wolfgang Bumiller
and improve the device path listing --- src/PVE/LXC.pm | 2 +- src/lxc-pve-mount-hook | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 216c3cf..7ee887d 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1824,7 +1824,7 @@ sub

[pve-devel] [RFC v2 pve-container 1/4] get rid of most of the loop-devices code

2015-09-07 Thread Wolfgang Bumiller
-) loop devices are now attached in mountpoint_mount, and immediately detached in order to set the auto-clear flag Keeping track of loop-devices is otherweise next to impossible and a security concern. We mount the filesystems for the container. We do not support full loop device access for

[pve-devel] [RFC v2 pve-container 0/4] container loop/bdev/backup changes v2

2015-09-07 Thread Wolfgang Bumiller
I now replaced the blockdevices_list code altogether and use stat() on the device files instead. Remember the backup patches in the end need the pve-manager find-patch applied... Wolfgang Bumiller (4): get rid of most of the loop-devices code fix block device access support resizing of

[pve-devel] [RFC v2 pve-container 4/4] vzdump: refactor LXC backup

2015-09-07 Thread Wolfgang Bumiller
*) Use the new Tools::command_pipe instead of building a shell command string. *) Ditch 'find' and utilize the --one-file-system switch instead. *) Added mountpoint handling *) Added support for 'backup=yes|no' on mountpoints *) sanitizing mountpoint paths --- src/PVE/VZDump/LXC.pm | 195

[pve-devel] [RFC v2 pve-container 2/4] fix block device access

2015-09-07 Thread Wolfgang Bumiller
-) The condition was apparently to ignore /dev/ paths while that's actually what it was supposed to handle... (other paths aren't devices...). -) Get rid of the blockdevices_list heuristics, it doesn't work reliably for all types of devices. -) Check whether a device is a block device via

[pve-devel] [RFC v2 pve-container 3/4] support resizing of owned container disks

2015-09-07 Thread Wolfgang Bumiller
--- src/PVE/API2/LXC/Config.pm | 159 + src/PVE/CLI/pct.pm | 2 + 2 files changed, 161 insertions(+) diff --git a/src/PVE/API2/LXC/Config.pm b/src/PVE/API2/LXC/Config.pm index 95eafaa..476e07c 100644 --- a/src/PVE/API2/LXC/Config.pm +++

[pve-devel] [PATCH pve-ha-manager] limit service start tries

2015-09-07 Thread Thomas Lamprecht
Previously we tried to start an service indefinitely often, now we limit it to 3 start tries. After that the service goes in the error state and needs to be disabled manually. Signed-off-by: Thomas Lamprecht --- src/PVE/HA/Env/PVE2.pm | 2 -- src/PVE/HA/Manager.pm |

[pve-devel] [PATCH] fix output percent_used in rbd pools

2015-09-07 Thread Wolfgang Link
This fix is essential of cause json field changes in the ceph api. They change the field size in pool to max_avail and the field total_size in stats to total_max_avail --- PVE/API2/Ceph.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Ceph.pm

Re: [pve-devel] container block device access

2015-09-07 Thread Alexandre DERUMIER
>>@Alexandre: what's the reason for the cgroup devices.allow listing? This >>is the part that concerns me. It's fine for non-loop devices, but with >>loop devices this is a problem. >>IIRC it was something about resizing, but I'm going to handle this from >>the outside via an API call, so the

Re: [pve-devel] [PATCH_V2 1/2] fix unlock handling after migration.

2015-09-07 Thread Dietmar Maurer
applied, thanks. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] container block device access

2015-09-07 Thread Wolfgang Bumiller
I'm currently cleaning up the loop-devices code and am getting rid of pretty much all of it for security reasons and ease of handling. For one, losetup's listed paths aren't always accurate when mount-namespaces are involved (you get a path relative to the root of the filesystem the file resides

[pve-devel] Feature request: LDAP non-anonymous bind

2015-09-07 Thread Sten Aus
Hi I would like to propse a feature: LDAP non-anonymous bind. As it has been discussed already in forums I will link it here as well: http://forum.proxmox.com/threads/14649-LDAP-authentication-with-non-anonymous-bind As a proposed patch is working I would suggest it to add to Proxmox. A

[pve-devel] [PATCH pve-manager] Add missing install target dependencies

2015-09-07 Thread Thomas Lamprecht
These added dependencies let you execute `make install` repeatedly, whitout using `make clean` in between. Without it make autodeleted the %.1.pod and %.8.pod files as the install target doesn't declare a dependency although it needs them. Signed-off-by: Thomas Lamprecht

Re: [pve-devel] [RFC v2 pve-container 4/4] vzdump: refactor LXC backup

2015-09-07 Thread Dietmar Maurer
This is really too much for a single commit. You do - function signature changes (without obvious reason). - code cleanups (white space removals) - use new features like command_pipe() - add optimizations (rsync parameters) - change current behavior (use tar exclusions) ... I would like to have

[pve-devel] [PATCH pve-common] is_mounted: use realpath on the mountpoint

2015-09-07 Thread Wolfgang Bumiller
This will avoid problmes with symlinks as well as paths containing ./, ../ or trailing slashes. --- src/PVE/ProcFSTools.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/ProcFSTools.pm b/src/PVE/ProcFSTools.pm index 4670694..368ae73 100644 --- a/src/PVE/ProcFSTools.pm +++

[pve-devel] [PATCH pve-manager] Update vzdump man page for use with LXC containers

2015-09-07 Thread Emmanuel Kasper
--- PVE/CLI/vzdump.pm | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/PVE/CLI/vzdump.pm b/PVE/CLI/vzdump.pm index f812815..e3b02a6 100755 --- a/PVE/CLI/vzdump.pm +++ b/PVE/CLI/vzdump.pm @@ -33,7 +33,7 @@ vzdump - backup utility for virtual machine