Re: [pve-devel] [PATCH manager] fix #871: netstat: include veth devices

> 在 2016年1月19日，下午4:45，Wolfgang Bumiller 写道： > > Include container's veth devices in /nodes/{node}/netstat Great! thanks!___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH manager] fix #871: netstat: include veth devices

Include container's veth devices in /nodes/{node}/netstat --- @Stefan Priebe: As the implementation came from you with commit 72eb5b9f and I don't see other references to this netstat function in the code I'd like to ask if you agree with this change? PVE/API2/Nodes.pm | 2 +- 1 file

Re: [pve-devel] [PATCH manager] fix #871: netstat: include veth devices

Am 19.01.2016 um 09:45 schrieb Wolfgang Bumiller: > Include container's veth devices in /nodes/{node}/netstat > --- > > @Stefan Priebe: > As the implementation came from you with commit 72eb5b9f and I don't > see other references to this netstat function in the code I'd like > to ask if you

[pve-devel] [PATCH container 1/2] Use lock_container when checking locks

This should prevent race conditions by preventing config file changes inbetween checking locks and actually doing the start/stop/.. operation. Signed-off-by: Fabian Grünbichler --- src/PVE/API2/LXC/Status.pm | 83 -- 1 file

[pve-devel] [PATCH container 2/2] Don't hold flock for whole backup operation

Instead release at the end of prepare(), and use lock_container() to remove a potential 'backup' lock from the config file when the backup is finished. Signed-off-by: Fabian Grünbichler --- src/PVE/VZDump/LXC.pm | 10 +- 1 file changed, 5 insertions(+), 5

Re: [pve-devel] [PATCH container 2/2] Don't hold flock for whole backup operation

> Fabian Grünbichler hat am 19. Januar 2016 um > 11:20 geschrieben: > > @@ -192,16 +196,12 @@ sub prepare { > > sub lock_vm { > my ($self, $vmid) = @_; > - > PVE::LXC::lock_aquire($vmid); > } > > sub unlock_vm { > my ($self, $vmid) = @_; > - > -

Re: [pve-devel] [PATCH manager] fix #871: netstat: include veth devices

> On January 19, 2016 at 10:21 AM Stefan Priebe - Profihost AG > wrote: > > > Am 19.01.2016 um 09:45 schrieb Wolfgang Bumiller: > > Include container's veth devices in /nodes/{node}/netstat > > --- > > > > @Stefan Priebe: > > As the implementation came from you with

[pve-devel] [PATCH container 2/2] Fix typo in lxc-checkpoint dump directory

Signed-off-by: Fabian Grünbichler --- src/PVE/API2/LXC/Status.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index 8d59436..ec29fe8 100644 --- a/src/PVE/API2/LXC/Status.pm +++

[pve-devel] [PATCH container 1/2] Fix typos in comments, descriptions and messages

Signed-off-by: Fabian Grünbichler --- src/PVE/LXC.pm| 24 src/PVE/VZDump/LXC.pm | 15 --- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 035b3ab..2899fa9 100644 ---

[pve-devel] [PATCH v2 container 0/2] Fix various typos (rebased on master)

The first patch only fixes typos in comments, API descriptions, log and other messages. The second patch fixes a typo in the path given to lxc-checkpoint for container suspend and resume operations. Rebased on master. Fabian Grünbichler (2): Fix typos in comments, descriptions and

[pve-devel] [PATCH v2 container 2/2] Fix typo in lxc-checkpoint dump directory

Signed-off-by: Fabian Grünbichler --- src/PVE/API2/LXC/Status.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index e119211..6b468cf 100644 --- a/src/PVE/API2/LXC/Status.pm +++

[pve-devel] [PATCH v2 container 1/2] Fix typos in comments, descriptions and messages

Signed-off-by: Fabian Grünbichler --- src/PVE/LXC.pm| 24 src/PVE/VZDump/LXC.pm | 14 +++--- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 035b3ab..2899fa9 100644 ---

[pve-devel] VETH and manipulation of ip in container (big risk possible)

Dear, In moment I test on proxmox 3.4 the bridging via ovh vrack 1.5! The old way I used before RIPE-RIRs container 100 (via venet) RIPE-RIRS -> eth0 ---> venet ---> container 101 (via venet) RIPE-RIES Icontainer 102 (via

Re: [pve-devel] DAB and Ubuntu minimal

> # git clone git://git.proxmox.com/git/dab-pve-appliances.git > # cd dab-pve-appliances/ubuntu-trusty-standard-64/ > # nano Makefile # added '--minimal' to 'dab bootstrap' > # make Just tested that, and it works without any problems here. Maybe you are using an old dab version (try 2.0-3)?

[pve-devel] [PATCH v2 container 0/2] more locking fixes

Use lock_container / flock to prevent a race condition in start/stop/... and don't hold flock unnecessarily long. Changes compared to v1: lock_container now also wraps calls to RPC workers rebased on current master Fabian Grünbichler (2): Use lock_container when checking locks Don't hold

[pve-devel] [PATCH v2 container 1/2] Use lock_container when checking locks

This should prevent race conditions by preventing config file changes inbetween checking locks and actually doing the start/stop/.. operation. Signed-off-by: Fabian Grünbichler --- src/PVE/API2/LXC/Status.pm | 130 + 1 file

Re: [pve-devel] [PATCH v2 container 0/2] more locking fixes

applied both patches, thanks. I am still thinking about adding a new lock type for snapshot backups, maybe 'snapshot-backup' instead of 'backup'. What do you think? ___ pve-devel mailing list pve-devel@pve.proxmox.com