[pve-devel] [PATCH manager] Fix 895: don't drop the other processor values on load()

2016-02-17 Thread Wolfgang Bumiller
(Introduced in a5d21db: preserve extra cpu options) --- www/manager/qemu/ProcessorEdit.js | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/www/manager/qemu/ProcessorEdit.js b/www/manager/qemu/ProcessorEdit.js index e65c535..e2bad11 100644 --- a/www/manager/qemu/Pr

[pve-devel] [PATCH 1/2] passthrough : reenable hyperv and add hv_vendor_id for windows

2016-02-17 Thread Alexandre Derumier
qemu 2.5 support a new hyper-v feature: hv_vendor_id This allow nvidia drivers to install on windows with hyper-v feature on. Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/Qe

[pve-devel] [PATCH 2/2] disable vnc server and add -nographic is no vga card is present

2016-02-17 Thread Alexandre Derumier
For passthrough, we need to be sure that card is primary, so we need to disable vnc server Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 70232bf..d1cfb1d 100644 ---

Re: [pve-devel] [PATCH] Fix problems with turnkey repository PVE Version 3.4.

2016-02-17 Thread Dietmar Maurer
this does not work for me (on 3.4)??? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Add boot_offset parameter to syslog API call

2016-02-17 Thread Thomas Lamprecht
I have a better idea for that, with since/until for the web GUI as an nicer option. This solves also the really big log (=>timeout) problem for long running production systems. Will resend both patches with an added GIU patch... No need to apply these. On 02/16/2016 03:15 PM, Thomas Lamprecht wro

[pve-devel] [PATCH ha-manager v2] fix possible out of sync state on migrations

2016-02-17 Thread Thomas Lamprecht
Description of the problem, imagine the following: We get the CRM command to migrate 'vm:100' from A to B. Now when the migration fails, we would normally get placed in the started state on the source node A trough the CRM when it processes our result. But if the CRM didn't processed our result bef

Re: [pve-devel] [PATCH qemu-server 2/4] add function returning virtual size of disk image

2016-02-17 Thread Timo Grodzinski
Hi Wolfgang, Thanks for your annotations! Am 17.02.2016 um 15:01 schrieb Wolfgang Bumiller: > Please keep our coding style in mind. > There should be no spaces after opening and before closing parenthesis. Do you have a perltidyrc config for your coding style? > (Another one inline) > > On Mon

Re: [pve-devel] [PATCH] Fix problems with turnkey repository PVE Version 3.4.

2016-02-17 Thread Dietmar Maurer
comments inline: > To prevent that one time Net:SSL and an outer time IO::Socket::SSL is loaded, outer? > ensure that always use the same socket class. > > We load the the Net:SSL in AccessControl.pm where exactly? > if we call pveupdate, > but if we call pveam update this module is not load

Re: [pve-devel] [PATCH pve-manager 1/4] Fix initial loading of Node tabpanel:

2016-02-17 Thread Dietmar Maurer
applied all 4 patches, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server 3/4] add function importing disk image to existing vm

2016-02-17 Thread Wolfgang Bumiller
Forgot something in my previous answer (see inline): On Mon, Feb 15, 2016 at 02:33:48PM +0100, Timo Grodzinski wrote: > Signed-off-by: Timo Grodzinski > --- > PVE/QemuServer.pm | 61 > ++- > 1 file changed, 60 insertions(+), 1 deletion(-) > >

Re: [pve-devel] [PATCH qemu-server 4/4] add API2 handler for uploading disk images

2016-02-17 Thread Wolfgang Bumiller
So you moved this from pve-storage (in your previous [WIP] patch) to the qemu package. But I'm still wondering if the common parts can be factored out into public functions in the pve-storage package. I also see you didn't copy over the ssh code, so you won't be able to upload disks to VMs on diffe

Re: [pve-devel] [PATCH v3 container] Add to unused volumes only if really unused

2016-02-17 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH lxcfs 2/2] Don't install libpam-cgfs

2016-02-17 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH lxcfs 1/2] Make lxcfs.service reloadable, reload in postinst

2016-02-17 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server 3/4] add function importing disk image to existing vm

2016-02-17 Thread Wolfgang Bumiller
On Mon, Feb 15, 2016 at 02:33:48PM +0100, Timo Grodzinski wrote: > Signed-off-by: Timo Grodzinski > --- > PVE/QemuServer.pm | 61 > ++- > 1 file changed, 60 insertions(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >

Re: [pve-devel] [PATCH qemu-server 2/4] add function returning virtual size of disk image

2016-02-17 Thread Wolfgang Bumiller
Please keep our coding style in mind. There should be no spaces after opening and before closing parenthesis. (Another one inline) On Mon, Feb 15, 2016 at 02:33:47PM +0100, Timo Grodzinski wrote: > Signed-off-by: Timo Grodzinski > --- > PVE/QemuServer.pm | 20 > 1 file chang

Re: [pve-devel] [PATCH qemu-server 1/4] add switch to skip creation of target image for qemu-img

2016-02-17 Thread Wolfgang Bumiller
Looks like the 3rd patch's first hunk should be part of this patch. On Mon, Feb 15, 2016 at 02:33:46PM +0100, Timo Grodzinski wrote: > Signed-off-by: Timo Grodzinski > --- > PVE/QemuServer.pm | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/PVE/QemuServer.pm b

[pve-devel] [PATCH pve-manager 1/4] Fix initial loading of Node tabpanel:

2016-02-17 Thread Emmanuel Kasper
* push initial components individually * replace ifor the momment pvepanels with basic panels so we can at least load the first tabs * group ceph component with previous push call as they require the same capabilities --- www/manager6/node/Config.js | 65 ++---

[pve-devel] [PATCH pve-manager 2/4] remove redundant model definition

2016-02-17 Thread Emmanuel Kasper
pve-services is already declared in ServiceView.js provoking a namespace clash --- www/manager6/node/Subscription.js | 8 1 file changed, 8 deletions(-) diff --git a/www/manager6/node/Subscription.js b/www/manager6/node/Subscription.js index 8101d1b..c4e9979 100644 --- a/www/manager6/no

[pve-devel] [PATCH pve-manager 4/4] rename 'autoscroll' parameter to 'scrollable' following framework changes

2016-02-17 Thread Emmanuel Kasper
also move static parameters out of initComponent() for proper panel initialization --- www/manager6/node/Summary.js | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js index 6d44869..b01f848 100644 --- a/www/

[pve-devel] [PATCH pve-manager 3/4] temporary disable accessibility warnings

2016-02-17 Thread Emmanuel Kasper
ExtJS6 adds accessibility (aria) support to the framework, which means special handling of space/enter key and panels title, and a lot of warnings / errors in the browser console Aria support will be reenabled after all the components are migrated to ExtJS6 --- www/manager6/Utils.js | 7 +++

[pve-devel] [PATCH v3 container] Add to unused volumes only if really unused

2016-02-17 Thread Fabian Grünbichler
Add unused volumes for changed mpX and rootfs, not only for deleted mpX. Add check before adding to unused volumes in order to prevent false entries (which could lead to deletion of still used volumes!) --- Changes to v3: name sub like in QemuServer.pm, thanks Wolfgang! src/PVE/LXC.pm | 37 ++

[pve-devel] [PATCH v2 container] Add to unused volumes only if really unused

2016-02-17 Thread Fabian Grünbichler
- add unused volumes for changed mpX and rootfs, not only for deleted mpX. - add check before adding to unused volumes in order to prevent duplicate or false entries (which could lead to deletion of still used volumes!). --- src/PVE/LXC.pm | 37 + 1 file changed

[pve-devel] [PATCH manager] firewall: add disable_ndp option

2016-02-17 Thread Wolfgang Bumiller
--- www/manager/grid/FirewallOptions.js | 1 + www/manager6/grid/FirewallOptions.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager/grid/FirewallOptions.js b/www/manager/grid/FirewallOptions.js index f94be6c..ce2008b 100644 --- a/www/manager/grid/FirewallOptions.js +++ b/www/ma

[pve-devel] [PATCH firewall] Add disable_ndp option and default to NDP enabled

2016-02-17 Thread Wolfgang Bumiller
--- src/PVE/API2/Firewall/Host.pm | 7 ++- src/PVE/Firewall.pm | 14 +- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Firewall/Host.pm b/src/PVE/API2/Firewall/Host.pm index 37a63b7..ee0de8e 100644 --- a/src/PVE/API2/Firewall/Host.pm +++ b/s

[pve-devel] [PATCH lxcfs 2/2] Don't install libpam-cgfs

2016-02-17 Thread Fabian Grünbichler
--- There might be a better way to do this? Configuring lxcfs with "--with-pamdir=none" does not actually disable building the PAM module, despite the comment in configure.ac. debian/rules | 5 + 1 file changed, 5 insertions(+) diff --git a/debian/rules b/debian/rules index 6911ba9..584392c

[pve-devel] [PATCH lxcfs 1/2] Make lxcfs.service reloadable, reload in postinst

2016-02-17 Thread Fabian Grünbichler
Also don't restart on upgrades --- debian/lxcfs.postinst | 20 debian/lxcfs.service | 5 +++-- debian/rules | 6 ++ 3 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 debian/lxcfs.postinst diff --git a/debian/lxcfs.postinst b/debian/lxcfs.po

Re: [pve-devel] [PATCH lxcfs] Update to latest upstream 2.0.0.beta1

2016-02-17 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager 1/2] use 'refresh' event to reload the grid after filtering the store

2016-02-17 Thread Dietmar Maurer
applied both patches ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Minor patches for ext6 migration

2016-02-17 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [stable-3 kvm] Fix CVE-2016-2391 and CVE-2016-2392

2016-02-17 Thread Wolfgang Bumiller
CVE-2016-2391: usb: ohci avoid multiple eof timers CVE-2016-2392: usb: check USB configuration descriptor object --- ...6-2391-usb-ohci-avoid-multiple-eof-timers.patch | 40 ++ ...check-USB-configuration-descriptor-object.patch | 33 ++ debian/patches/series

[pve-devel] [PATCH kvm] Fix CVE-2016-2392

2016-02-17 Thread Wolfgang Bumiller
usb: check USB configuration descriptor object --- ...check-USB-configuration-descriptor-object.patch | 33 ++ debian/patches/series | 1 + 2 files changed, 34 insertions(+) create mode 100644 debian/patches/extra/CVE-2016-2392-check-USB-configur

[pve-devel] [PATCH lxcfs] Update to latest upstream 2.0.0.beta1

2016-02-17 Thread Fabian Grünbichler
Commit 551c58dd1a7fbaebe92dd0f1f80f1789faa3a2eb Drop patches applied upstream: - 0001-fix-missing-dereferencing-in-must_strcat_pid.patch - 0001-uptime-fix-pid1-and-reaper_busy-times.patch - 0003-fix-leak-in-realloc-loop-in-must_strcat_pid.patch - 0004-cgfs-fix-dorealloc-s-batch-allocation.patch U

Re: [pve-devel] [PATCH container] Add unused volume when mp is modified

2016-02-17 Thread Dietmar Maurer
comments inline > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index a737fc0..84aba83 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1352,6 +1352,12 @@ sub update_pct_config { > } elsif ($opt =~ m/^mp(\d+)$/) { > next if $hotplug_error->($opt); > check_pr

Re: [pve-devel] [PATCH lxcfs] Add quilt, libpam0g-dev to Build-Depends

2016-02-17 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] Fix problems with turnkey repository.

2016-02-17 Thread Wolfgang Link
To prevent that one time Net:SSL and an outer time IO::Socket::SSL is loaded, ensure that always use the same socket class. We load the the Net:SSL in AccessControl.pm if we call pveupdate, but if we call pveam update this module is not loaded an so the default is used (IO::Socket::SSL). --- PVE

[pve-devel] [PATCH] Fix problems with turnkey repository PVE Version 3.4.

2016-02-17 Thread Wolfgang Link
To prevent that one time Net:SSL and an outer time IO::Socket::SSL is loaded, ensure that always use the same socket class. We load the the Net:SSL in AccessControl.pm if we call pveupdate, but if we call pveam update this module is not loaded an so the default is used (IO::Socket::SSL). --- PVE