Re: [pve-devel] [RFC PATCH container] 'feature' config option

2016-03-14 Thread Dietmar Maurer
> diff --git a/src/PVE/API2/LXC/Makefile b/src/PVE/API2/LXC/Makefile > index f372d95..dd1b214 100644 > --- a/src/PVE/API2/LXC/Makefile > +++ b/src/PVE/API2/LXC/Makefile > @@ -1,8 +1,12 @@ > -SOURCES=Config.pm Status.pm Snapshot.pm > +SOURCES=Config.pm Status.pm Snapshot.pm Features.pm > + > +LXCPRO

Re: [pve-devel] [PATCH storage] lvmthin: activate base volumes

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH common] net: don't die in get_active_interfaces() and try both address families

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH ha-manager] add Fence class for external fence devices

2016-03-14 Thread Thomas Lamprecht
This class provides methods for starting and checking the current status of a fence job. When a fence job is started we execute a fence agent command. If we can fork this happens in forked worker, which can be multiple processes also, when parallel devices are configured. When a device fails to s

[pve-devel] [PATCH ha-manager v3 6/6] Add to README

2016-03-14 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- README | 111 + 1 file changed, 111 insertions(+) diff --git a/README b/README index 1c5177f..6cd523d 100644 --- a/README +++ b/README @@ -72,6 +72,117 @@ works using reliable HW fence devices.

[pve-devel] [PATCH ha-manager v3 5/6] allow use of external fencing devices

2016-03-14 Thread Thomas Lamprecht
A node now can be fenced with the use of external hardware fence devices. Those device can be configured at /etc/pve/ha/fence.cfg also the fencing option in the datacenter configuration file must be set to either 'hardware' or 'both', else configured devices will *not* be used. If hardware is sele

[pve-devel] [PATCH ha-manager v3 1/6] add FenceConfig class for external fencing devices

2016-03-14 Thread Thomas Lamprecht
Add a FenceConfig class which includes methods to parse a config file for fence devices in the format specified by dlm.conf, see the Fencing section in the dlm.conf manpage for more details regarding this format. With this we can generate commands for fencing a node from the parsed config file. W

[pve-devel] [PATCH ha-manager v3 2/6] Env, HW: add HW fencing related functions

2016-03-14 Thread Thomas Lamprecht
This adds three to hardware fencing related functions: * read_fence_config * fencing_mode * exec_fence_agent 'read_fence_config' allows to create a common code base between the real world and the test/sim world regarding fencing a bit easier. In PVE2 it parses the config from /etc/pve/ha/fence.cfg

[pve-devel] [PATCH ha-manager v3 3/6] add Fence class for external fence devices

2016-03-14 Thread Thomas Lamprecht
This class provides methods for starting and checking the current status of a fence job. When a fence job is started we execute a fence agent command. If we can fork this happens in forked worker, which can be multiple processes also, when parallel devices are configured. When a device fails to s

[pve-devel] [PATCH ha-manager v3 0/6] implement HW fencing for the ha-manager

2016-03-14 Thread Thomas Lamprecht
Third iteration of the hardware fencing. changes from v2: * throw away the hardware class for the PVE2 env, use an Env method instead * reworked 'allow hardware fencing' patch (nr. 5) a bit * fixed small error in config parser and writer (thanks wolfgang) What still needs to be done: * API integr

[pve-devel] [PATCH ha-manager v3 4/6] allow LRM lock stealing for fenced nodes

2016-03-14 Thread Thomas Lamprecht
We are only allowed to recover (=steal) a service when we have its LRMs lock, as this guarantees us that even if said LRM comes up again during the steal operation the LRM cannot start the services when the service config still belongs to it for a short time. This is important, else we have a poss

Re: [pve-devel] [PATCH manager] lxc: disable ACL settings for bind mounts

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/4] ext6migrate: fix double loadMask

2016-03-14 Thread Dietmar Maurer
applied all 4 patches, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 2/2] ext6migrate: fix framework caching issue

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 1/2] ext6migrate: fix store load race condition

2016-03-14 Thread Dietmar Maurer
applied, but this patch has some coding style errors - see comments > www/manager6/dc/Summary.js | 2 +- > www/manager6/form/ComboGrid.js | 4 ++-- > www/manager6/lxc/Config.js | 2 +- > www/manager6/node/Config.js | 2 +- > www/manager6/panel/LogView.js | 4 +

Re: [pve-devel] [PATCH pve-manager 3/3] Fix LXC summary view:

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager 2/3] Enable last remaining lxc panels

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager 1/3] css improvements for crisp theme

2016-03-14 Thread Dietmar Maurer
> * usability improvement for enabled buttons: I am unable to see any effect (please show me tomorrow). ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager v2] update leaf nodes instead of removing / readding them

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC ha-manager v2 5/7] allow LRM lock stealing for fenced nodes

2016-03-14 Thread Thomas Lamprecht
On 03/14/2016 04:33 PM, Dietmar Maurer wrote: >> To summarize the possible states: >> * the node is fenced and stays until someone comes and checks it >> (through switch, power, ... - fencing) - here we can do everything with >> the lock we want >> * the node comes back immediately (reset) becaus

Re: [pve-devel] [RFC ha-manager v2 5/7] allow LRM lock stealing for fenced nodes

2016-03-14 Thread Dietmar Maurer
> To summarize the possible states: > * the node is fenced and stays until someone comes and checks it > (through switch, power, ... - fencing) - here we can do everything with > the lock we want > * the node comes back immediately (reset) because someone thought this > was a good way to setup the

[pve-devel] [PATCH manager 4/4] ext6migrate: fix trailing whitespaces

2016-03-14 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Toolkit.js | 4 ++-- www/manager6/grid/PoolMembers.js| 6 +++--- www/manager6/storage/ContentView.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/Toolkit.js b/www/manager6/Toolkit.js index 0976fb

[pve-devel] [PATCH manager 2/4] ext6migrate: remove unecessary hacks

2016-03-14 Thread Dominik Csapak
this removes the two overrides for extjs4 Signed-off-by: Dominik Csapak --- i tested much, but did not find any case where these two hacks are necessary anymore, but if somebody finds something that does not work anymore, please send a message, and we should check if we can avoid these hacks, oth

[pve-devel] [PATCH manager 3/4] ext6migrate: fix pool member view

2016-03-14 Thread Dominik Csapak
change show event to activate Signed-off-by: Dominik Csapak --- www/manager6/grid/PoolMembers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js index 932f475..ee50933 100644 --- a/www/manager6/grid/PoolMembe

[pve-devel] [PATCH manager 1/4] ext6migrate: fix double loadMask

2016-03-14 Thread Dominik Csapak
fix the double loadMask, (it exists, because extjs has a default loadmask for gridpanels) also move static configuration to class definition Signed-off-by: Dominik Csapak --- www/manager6/storage/ContentView.js | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/www/man

[pve-devel] [PATCH storage] lvmthin: activate base volumes

2016-03-14 Thread Wolfgang Bumiller
create_base() uses '-ky' to prevent base images from being activated by default, similar to snapshots. This means we need to activate them like snapshots with the '-K' option. --- Without this you cannot clone template VMs with disks on LVM-thin. On a related note: We need to special-case the clon

Re: [pve-devel] [RFC ha-manager v2 5/7] allow LRM lock stealing for fenced nodes

2016-03-14 Thread Thomas Lamprecht
On 03/12/2016 01:39 PM, Dietmar Maurer wrote: >> We are only allowed to recover (=steal) a service when we have its >> LRMs lock, as this guarantees us that even if said LRM comes up >> again during the steal operation the LRM cannot start the services >> when the service config still belongs to

[pve-devel] [RFC PATCH container] 'feature' config option

2016-03-14 Thread Wolfgang Bumiller
This introduces a 'features' option which currently contains 3 AppArmor related options: netmount, blockmount and nesting. These change the container's AppArmor profile and are thus incompatible with a custom 'lxc.aa_profile' option, and are used to allow mounting of network or block devices as wel

[pve-devel] [PATCH manager] lxc: disable ACL settings for bind mounts

2016-03-14 Thread Wolfgang Bumiller
--- We already disable the quota element, but bind mounts also can't get their own ACL setting... www/manager/lxc/ResourceEdit.js | 21 + www/manager6/lxc/ResourceEdit.js | 21 + 2 files changed, 26 insertions(+), 16 deletions(-) diff --git a/www/manager/l

[pve-devel] [RFC ha-manager v2 2/2] status: show added but not yet active services

2016-03-14 Thread Thomas Lamprecht
If the CRM is dead or not active yet and we add a new service, we do not see it in the HA status. This can be confusing for the user as it is queued for adding but does not shows up, so lets show those services also. Signed-off-by: Thomas Lamprecht --- src/PVE/API2/HA/Status.pm | 12 ++--

[pve-devel] [PATCH ha-manager v2 1/2] status: mark CRM as idle if no service is configured

2016-03-14 Thread Thomas Lamprecht
This should avoid confusion if we remove all service from the CRM, as else we would always see "old timestamp -dead?" in the status. Signed-off-by: Thomas Lamprecht --- Also some whitespace cleanup in the diff context. src/PVE/API2/HA/Status.pm | 23 +++ 1 file changed, 15

[pve-devel] [PATCH manager v2 1/2] ext6migrate: fix store load race condition

2016-03-14 Thread Dominik Csapak
when we click on a node/container/vm and quickly click on something else, there might be a race condition, where the store finished loading and we try to change dom elements, which are not there anymore so we change the store.on to me.mon, which deletes the handler when the component is gone in t

[pve-devel] [PATCH manager v2 2/2] ext6migrate: fix framework caching issue

2016-03-14 Thread Dominik Csapak
in extjs 5/6 there is a caching issue, where they save dom elements for reuse, but the garbage collector can set them to null when the framework now reuses the "cached" element it is null, and any action on it produces an error, which breaks the site for details see the forum link in the comment

[pve-devel] [PATCH pve-manager 2/3] Enable last remaining lxc panels

2016-03-14 Thread Emmanuel Kasper
--- www/manager6/lxc/Config.js | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 8902c86..491a5f8 100644 --- a/www/manager6/lxc/Config.js +++ b/www/manager6/lxc/Config.js @@ -121,

[pve-devel] [PATCH pve-manager 1/3] css improvements for crisp theme

2016-03-14 Thread Emmanuel Kasper
* usability improvement for enabled buttons: in the default theme, ExtJS uses two different nuances of grey to distinguish enabled or disabled buttons the problem is that compared to the full black of the panels titles, it gives the impression that everything is disabled (the contrast is not strong

[pve-devel] [PATCH pve-manager 3/3] Fix LXC summary view:

2016-03-14 Thread Emmanuel Kasper
* replace scrollable with autoScroll and move to prototype body * use 'activate' to load store on F5 * do not set a height on the StatusView component: it hides some rows, and the framework sets a good working default height --- www/manager6/lxc/StatusView.js | 1 - www/manager6/lxc/Summary.js

[pve-devel] [PATCH v2 2/3] Skip templates when using the start all VMs button

2016-03-14 Thread Caspar Smit
Refactored and now using PVE::QemuConfig and PVE::LXC::Config Moved the next if.. statements into the corresponding branches Signed-off-by: Caspar Smit --- PVE/API2/Nodes.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 68496d7..f1f

[pve-devel] [PATCH v2 3/3] Allow migrate-all button on HA enabled VMs

2016-03-14 Thread Caspar Smit
Signed-off-by: Caspar Smit --- PVE/API2/Nodes.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index f1fb392..b2de907 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1208,9 +1208,6 @@ my $get_start_stop_list = sub {

Re: [pve-devel] [PATCH access-control 1/2] fix #916: allow HTTPS to access custom yubico url

2016-03-14 Thread Dietmar Maurer
applied both patches ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH access-control 1/2] fix #916: allow HTTPS to access custom yubico url

2016-03-14 Thread Fabian Grünbichler
remove the limit to HTTP only, since it would only apply for custom yubico validation server urls anyway. --- if there is a problem with certificate validation or proxies without https support, the user can simply change the url to an http one. PVE/AccessControl.pm | 6 ++ 1 file changed, 2 i

[pve-devel] [PATCH access-control 2/2] fix typos and grammar

2016-03-14 Thread Fabian Grünbichler
--- Note: the last hunk needs the other yubico patch to apply cleanly PVE/AccessControl.pm | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index 550fa87..6023285 100644 --- a/PVE/AccessControl.pm +++

[pve-devel] [PATCH ha-manager] mark CRM as idle if no service is configured

2016-03-14 Thread Thomas Lamprecht
This should avoid confusion if we remove all service from the CRM, as else we would always see "old timestamp -dead?" in the status. Signed-off-by: Thomas Lamprecht --- Also made a whitespace cleanup in the diff context. src/PVE/API2/HA/Status.pm | 6 -- 1 file changed, 4 insertions(+), 2

[pve-devel] [PATCH pve-manager v2] update leaf nodes instead of removing / readding them

2016-03-14 Thread Emmanuel Kasper
if the selected node has its status changed between stop & running, the node was removed and then readded during the remove / add process the 'selected' status of the node was lost if it has one instead of deleting / readding the node, we update now its content this was the default behaviour for s

Re: [pve-devel] [PATCH 3/3] Allow migrate-all button on HA enabled VMs

2016-03-14 Thread Thomas Lamprecht
This patch builds upon the previous patch, so please rebase it also when you update the other one else it won't apply, else it looks good. On 03/11/2016 12:59 PM, Caspar Smit wrote: > When using the migrate all button, HA enabled VMs and Containers are now also > migrated. The start/stop all butt

Re: [pve-devel] [PATCH 2/3] Skip templates when using the start all VMs button

2016-03-14 Thread Thomas Lamprecht
The idea of this patch looks good, please address the issues mentioned by Fabian (respin it on current master & move the "next if .." parts in the respective branch above) and sign the CLA (as mentioned in my other reply to your first patch) and then this should be good to go. Thanks for your con

Re: [pve-devel] [PATCH 1/3] Allow non-root to use start/stop/migrate all buttons

2016-03-14 Thread Thomas Lamprecht
Hi, first thanks for your contribution! We use the Harmony CLA for contributions: http://www.harmonyagreements.org/ See: https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright for more information. Please send a signed CLA to off...@proxmox.com (or per Mail/Fax if p

[pve-devel] [PATCH v3 cluster] Add warning for pvecm commands if not part of cluster

2016-03-14 Thread Fabian Grünbichler
If the cluster config file is missing, pvecm status, nodes and expected will probably not work. Add a helpful warning because the corosync-quorumtool error message is not very descriptive here. Add a helper sub in Cluster.pm to actually do the check. --- Changes compared to v2: - hardcode msg in h

Re: [pve-devel] [PATCH qemu-server] Use has_lock to check for specific lock

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 container 1/2] Use set_lock and remove_lock

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 container 2/2] Prevent race conditions in snapshot mode backup

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH cluster] fix #904: wrap openssl with faketime

2016-03-14 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] use ext4 discard option for containers?

2016-03-14 Thread Alexandre DERUMIER
fstrim is still better. discard mount option has too much overhead - Mail original - De: "dietmar" À: "pve-devel" Envoyé: Dimanche 13 Mars 2016 16:59:06 Objet: [pve-devel] use ext4 discard option for containers? Hi all, I wonder if we can/should use the ext4 "discard" option for con